summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2018-07-29replace double checked locking patternsJochen Nitschke
with thread safe static initialization Change-Id: I7b102e8a6aec64b0795f5fa915276ffc1f568d0a Reviewed-on: https://gerrit.libreoffice.org/58288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-29Merge identical conditional branches in OContentHelperMuhammet Kara
Change-Id: Ifaf72d1151f32dc99dbe76838f88090ee2fd7b15 Reviewed-on: https://gerrit.libreoffice.org/58269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-29Remove unused local variable aErrorMuhammet Kara
Leftover from 529e7619c5258aec91c33dd57b9fa12c3e85cfeb Change-Id: Ifdfe0f0c75d4d0d2ce90310dcb9c3fbfff5775e1 Reviewed-on: https://gerrit.libreoffice.org/58253 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-28loplugin:stringloop cui,dbaccessNoel Grandin
Change-Id: I32b63d2435d36b869823ea022ebd7f8347a46ea0 Reviewed-on: https://gerrit.libreoffice.org/58211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27Remove unused local variable aImageProviderMuhammet Kara
It is no longer needed for the cases where oly the static methods are called Change-Id: I869b824c53ef1a8db07f4ca7f0aa9e678e16a7ac Reviewed-on: https://gerrit.libreoffice.org/58162 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26dbaccess: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by removing explicitly user-provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non-deleted in the future. (Even if such a user-provided function was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already inline, so why bother with non-inline functions.) Change-Id: Ie8dfa12a144b0d21c99803bf6810cc573b4880ac Reviewed-on: https://gerrit.libreoffice.org/58075 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-26dbaccess: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. Change-Id: Ic07bf2a39ee18368d2d56b5bc6e666758367b7d7 Reviewed-on: https://gerrit.libreoffice.org/58074 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-24Fix typosAndrea Gelmini
Change-Id: I07cf04cd2acc5b50d64224edb9f2c2de2c61e356 Reviewed-on: https://gerrit.libreoffice.org/57884 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: I9671ad7c9e75b9e10abf46bc6b53fcd760acecbf Reviewed-on: https://gerrit.libreoffice.org/57599 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-22Fix typos in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I5140beaf2115005c197c1e47f4d2df073a761ed4 Reviewed-on: https://gerrit.libreoffice.org/57773 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-21Fix typosAndrea Gelmini
Change-Id: Ifc804e33afa160943d7b5634f8ccf4e3af4d26e5 Reviewed-on: https://gerrit.libreoffice.org/57806 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-13merge IUndoManager into SfxUndoManagerNoel Grandin
SfxUndoManager is the only implementation of the IUnderManager "interface", and it lives in the same header. Plus this way we can get rid of some covariant parameters, which will make using std::unique_ptr easier. Change-Id: I6661b9876b18da830bead78794d237886cd3c5c9 Reviewed-on: https://gerrit.libreoffice.org/57317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-10tdf#118634: Don't save embedded data source to a temporary preview documentMike Kaganski
Also don't use storeAsURL to store embedded datasource when the document is being saved using storeToURL. Change-Id: I69a7ee5ae066e591be5e45c87bcf57dff370decc Reviewed-on: https://gerrit.libreoffice.org/57178 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-10Translate German commentsJohnny_M
Including correction of earlier translations in case of and around "packen" Change-Id: Icaeaebb46a15edcc4abdcfee55d07b43e1767e06 Reviewed-on: https://gerrit.libreoffice.org/57156 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-10pass SvStream around by std::unique_ptrNoel Grandin
and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08Fix typoAndrea Gelmini
Change-Id: I1cc4544e807d7c04aa171358ccd1c204040dff55 Reviewed-on: https://gerrit.libreoffice.org/57078 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-06HSQLDB Migration: overwrite backup xmlTamas Bunth
Change-Id: I080568f2d278e8a7153188497e3987217d9d188f Reviewed-on: https://gerrit.libreoffice.org/56464 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06dbahsql: Look for properties only after nameTamas Bunth
Additional properties in SQL string like "DEFAULT" or "NOT NULL" should be searched only after column name, because what if a column name is "myEvilNOT NULLColumn" Change-Id: I21f0755ba14c7267243d9999f044db4d16963387 Reviewed-on: https://gerrit.libreoffice.org/56462 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06dbahsql: refactor, around parseColumnpartTamas Bunth
Change-Id: I663da1474d3f1c3bde8a3d3c041e8fd0fe4c7d43 Reviewed-on: https://gerrit.libreoffice.org/56459 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06tdf#117867 dbahsql: Migrate default valuesTamas Bunth
Default Value "NOW" is a special case, because Firebird likes it with single quotes. In contrast, HSQLDB uses the keyword without quotes. Add unit test for parsing default value "NOW" Change-Id: I34886f8ae53e98addb52bf5e85030a03721d6a45 Reviewed-on: https://gerrit.libreoffice.org/56454 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-03no need to switch models in the SvTreeListBoxNoel Grandin
since we're replacing it completely anyhow. which means we can remove DisconnectFromModel Change-Id: I2f31d93eb95a641f3364d715111e70817c7e5087 Reviewed-on: https://gerrit.libreoffice.org/56849 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29tdf#96099 Remove trivial std::map typedefs in [cd]*Arkadiy Illarionov
Change-Id: I043d265d3d73a3e16f05d5ca7e29a09341651d82 Reviewed-on: https://gerrit.libreoffice.org/56639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21Skip CppunitTest_dbaccess_hsqlbinary_import unless ENABLE_JAVATor Lillqvist
Change-Id: Ib31f2bb1234607f0da4806f2e991ecc5d323f9e6 Reviewed-on: https://gerrit.libreoffice.org/56239 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-06-20Resolves: tdf#118120 RET_ALL shares same value as RET_HELPCaolán McNamara
Change-Id: I766c379171ac25eb9c1d8036e052fb8f2b4e1459 Reviewed-on: https://gerrit.libreoffice.org/56167 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-19tdf#118220 Base : Tools -> Table Filter crashesNoel Grandin
regression from commit b69457c1a5cb31c8b0fb3d047e2826bc3d61fea4 loplugin:useuniqueptr in OTableSubscriptionDialog Change-Id: I9f29452736554b18dbc207c870ed1799fe38b6e1 Reviewed-on: https://gerrit.libreoffice.org/56110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-19Fix typoAndrea Gelmini
Change-Id: I95b12975f6444e7eb6a8de6053d8e8ca021eacfb Reviewed-on: https://gerrit.libreoffice.org/56069 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-18Back up content.xml when migrating databaseTamas Bunth
Change-Id: I4eacbf689989d20142c04dc8fe586d0054c46350 Reviewed-on: https://gerrit.libreoffice.org/55962 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-06-14menubar: update and sync all base menubarsandreas kainz
Change-Id: I9b7e31f2335f01e20ee71137fdb2fd0315f3bd91 Reviewed-on: https://gerrit.libreoffice.org/55542 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2018-06-14tdf#118043 dbahsql: Fix putDot funcitonTamas Bunth
Change-Id: Ia49b7e852446b05a4e20a7ff0c32d8acc6da52b2 Reviewed-on: https://gerrit.libreoffice.org/55594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11tdf#117115 dbahsql: respect escaped '\'Tamas Bunth
Change-Id: Id408f7a98011d806f01b6c63ae67008c4dba4b0d Reviewed-on: https://gerrit.libreoffice.org/55595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-06-10fix CppunitTest_dbaccess_hsqlbinary_importRene Engelhard
at least with system-hsqldb. add missing connectivity/source/drivers/hsqldb/hsqldb to gb_CppunitTest_use_components Change-Id: I6e845dadd67276b137734f68ba922a1d5890c809 Reviewed-on: https://gerrit.libreoffice.org/55551 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-06Translate German comments and debug stringsJohnny_M
And correct a few comments (translation and grammar) Change-Id: Ifafa521c683e9ca65aeba8031cd4cbfc1fadc137 Reviewed-on: https://gerrit.libreoffice.org/54888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-06-06enable incremental linking on windowsNoel Grandin
requires a handful of workarounds Change-Id: I77c25580135eeec437716eceea1412607f8d14ca Reviewed-on: https://gerrit.libreoffice.org/55244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke
and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-04Properly decompose vnd.sun.star.pkg URLStephan Bergmann
When the URL encoded in the vnd.sun.star.pkg URL's authority contains a "@" (e.g., because it is a file URL denoting a pathname containging a "@" in one of the segments), that "@" need not be encoded (cf. the grammar at the top of tools/source/fsys/urlobj.cxx) and INetURLObject::GetHost would only return the part following the "@". When constructing sBaseURI in ODatabaseContext::loadObjectFromURL (dbaccess/source/core/dataaccess/databasecontext.cxx), the path part shall obviously not be decoded (but which the original code erroneously did). However, when obtaining sStreamRelPath in ODBFilter::implImport (dbaccess/source/filter/xml/xmlfilter.cxx), it isn't clear to me whether the path should be decoded, so I left that in (and added a TODO). (Caused `make CppunitTest_sw_uiwriter CPPUNIT_TEST_NAME=SwUiWriterTest::testEmbeddedDataSource` to fail when SRCDIR is such a pathname containing a "@" in one of the segments.) Change-Id: I6ffd842f3f3d37d2682e7cf14399fb3dbfa0a2aa Reviewed-on: https://gerrit.libreoffice.org/55286 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-03tdf#96099 Remove some trivial std::vector typedefsArkadiy Illarionov
Change-Id: I21171bd90b5e19fe8e5b8f2d125b6dfcb9a8b766 Reviewed-on: https://gerrit.libreoffice.org/55198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-29loplugin:useuniqueptr in OTableSubscriptionDialogNoel Grandin
Change-Id: If8fa9edc62f75f41de1392688a169458ce003bda Reviewed-on: https://gerrit.libreoffice.org/54852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:useuniqueptr in ODbTypeWizDialogSetupNoel Grandin
Change-Id: I5d1e737510d423f9caa44ad5b498ef5e781c24d0 Reviewed-on: https://gerrit.libreoffice.org/54856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:useuniqueptr in DbaIndexDialogNoel Grandin
Change-Id: Ife795db29256a50a93b668890c85473872d350a9 Reviewed-on: https://gerrit.libreoffice.org/54853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:useuniqueptr in dbaui::SbaSbAttrDlgNoel Grandin
Change-Id: Ia24f948370b30ccc3870e36c19312e9eebb309b3 Reviewed-on: https://gerrit.libreoffice.org/54851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28tdf#117732: Mig FB, fix reading of timeJulien Nabet
Change-Id: Ie67b50d899c4684f6fadd0c42337f54ef952078e Reviewed-on: https://gerrit.libreoffice.org/54646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-28loplugin:useuniqueptr in ODbTypeWizDialogNoel Grandin
Change-Id: I4c364ddbad4881cc8a70a1827d7c51e7cc9313f1 Reviewed-on: https://gerrit.libreoffice.org/54850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28tdf#96099 Remove some trivial typedef std::vectorArkadiy Illarionov
Change-Id: I41fff78c10d46bde50063536d8cf1a3942dbf6af Reviewed-on: https://gerrit.libreoffice.org/54834 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-28loplugin:useuniqueptr in OMarkableTreeListBoxNoel Grandin
Change-Id: Ifd3ea7fa32e9b254ff901a014f559ab211948929 Reviewed-on: https://gerrit.libreoffice.org/54849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28loplugin:useuniqueptr in OQueryControllerNoel Grandin
Change-Id: I13ca3ea6c27d4572274b70b0481a8479852b569a Reviewed-on: https://gerrit.libreoffice.org/54857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28loplugin:useuniqueptr in DlgQryJoinNoel Grandin
Change-Id: Ia9a5534b6d69dde163fae54fbd2764dc9b279a5d Reviewed-on: https://gerrit.libreoffice.org/54855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-16 03:08:31 +0000