summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2022-01-14Recheck modules d* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I916f42c46efa1b6cfd7744a189b79659b2867431 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128196 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-11Drop unused file dbaccess/source/shared/registrationhelper.cxxGabor Kelemen
since commit d29a314300d523d29ed894f1822227497fcb68f8 Change-Id: I16c76e0cc56fe06d92fe37e38a5a4549fa205f83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128203 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06tdf#68341: trim some variables passed on Base wizardJulien Nabet
Here is a git grep -n fillString: dbaccess/source/ui/dlg/ConnectionPage.cxx:232: fillString(*_rSet,m_xJavaDriver.get(), DSID_JDBCDRIVERCLASS, bChangedSomething); dbaccess/source/ui/dlg/ConnectionPage.cxx:235: fillString(*_rSet,m_xConnectionURL.get(), DSID_CONNECTURL, bChangedSomething); dbaccess/source/ui/dlg/ConnectionPageSetup.cxx:134: fillString(*_rSet,m_xConnectionURL.get(), DSID_CONNECTURL, bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:144: fillString(*_rSet,m_xETBaseDN.get(),DSID_CONN_LDAP_BASEDN, bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:416: fillString(*_rSet,m_xETDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:417: fillString(*_rSet,m_xETHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:418: fillString(*_rSet,m_xETDatabasename.get(),DSID_DATABASENAME,bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:531: fillString(*_rSet,m_xETDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething); dbaccess/source/ui/dlg/admincontrols.cxx:117: OGenericAdministrationPage::fillString( *_rSet, m_xHostName.get(), DSID_CONN_HOSTNAME, bChangedSomething ); dbaccess/source/ui/dlg/admincontrols.cxx:118: OGenericAdministrationPage::fillString( *_rSet, m_xDatabaseName.get(), DSID_DATABASENAME, bChangedSomething ); dbaccess/source/ui/dlg/admincontrols.cxx:121: OGenericAdministrationPage::fillString( *_rSet, m_xSocket.get(), DSID_CONN_SOCKET, bChangedSomething ); dbaccess/source/ui/dlg/admincontrols.cxx:123: OGenericAdministrationPage::fillString( *_rSet, m_xNamedPipe.get(), DSID_NAMED_PIPE, bChangedSomething ); dbaccess/source/ui/dlg/adminpages.cxx:219: void OGenericAdministrationPage::fillString(SfxItemSet& _rSet, const weld::Entry* pEdit, sal_uInt16 _nID, bool& _bChangedSomething) dbaccess/source/ui/dlg/adminpages.cxx:227: void OGenericAdministrationPage::fillString(SfxItemSet& _rSet, const dbaui::OConnectionURLEdit* pEdit, sal_uInt16 _nID, bool& _bChangedSomething) dbaccess/source/ui/dlg/adminpages.hxx:218: static void fillString(SfxItemSet& _rSet,const weld::Entry* pEdit,sal_uInt16 _nID, bool& _bChangedSomething); dbaccess/source/ui/dlg/adminpages.hxx:219: static void fillString(SfxItemSet& _rSet,const dbaui::OConnectionURLEdit* pEdit,sal_uInt16 _nID, bool& _bChangedSomething); dbaccess/source/ui/dlg/advancedsettings.cxx:351: fillString( *_rSet, m_xAutoIncrement.get(), DSID_AUTOINCREMENTVALUE, bChangedSomething ); dbaccess/source/ui/dlg/advancedsettings.cxx:353: fillString( *_rSet, m_xAutoRetrieving.get(), DSID_AUTORETRIEVEVALUE, bChangedSomething ); dbaccess/source/ui/dlg/detailpages.cxx:146: fillString(*_rSet,m_xOptions.get(),DSID_ADDITIONALOPTIONS,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:303: fillString(*_rSet,m_xEDHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:406: fillString(*_rSet,m_xEDDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:407: fillString(*_rSet,m_xEDHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:408: fillString(*_rSet,m_xEDSocket.get(),DSID_CONN_SOCKET,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:608: fillString(*_rSet,m_xETBaseDN.get(),DSID_CONN_LDAP_BASEDN,bChangedSomething); So I don't think that trimming these may be harmful. Now we could also add a boolean fillString to indicated if a trim is needed but does it worth it? Change-Id: I6fa841a0c062d4b81a09549cbe865fd627d070cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128029 Tested-by: Jenkins Reviewed-by: Lionel Mamane <lionel@mamane.lu>
2021-12-26Avoid OUStringBuffer::toString where possibleMike Kaganski
Change-Id: I99abbe97a48b2077e28d6221fb70036e5e412657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127479 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-26Typo: insertHierachyElement->insertHierarchyElementJulien Nabet
Change-Id: I1e1114c77d4d8bbc9e1d927a2e8604981b1db7b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127516 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-26can use OUStringLiteral hereNoel Grandin
Change-Id: I1e71a35c2ce6bc7ef3081054e51494411d9a29ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24new comphelper::WeakImplComponentHelperNoel Grandin
to replace the cppu:: equivalent with a lightweight version that uses std::mutex instead of osl::Mutex Change-Id: I1b7873a0c2d9cda21f529e43a4ac2fa7574c91a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21loplugin:flatten in desktop..drawinglayerNoel Grandin
Change-Id: Ie6594c9961aba5517c6ff61fb3bc1142081b1197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21Use sal::systools::COMReference in getAdoDatalinkMike Kaganski
Change-Id: If0c474209da5390c0c6e28c11ca26a1c915ab51f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127218 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-20tdf#146333 don't create a new XTitle just to remove a listener from itCaolán McNamara
seeing as the listener obviously won't be in it Change-Id: If9944c003fa51309288276f1327011dc7403b31b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127159 Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-18remove some unused definesNoel Grandin
Change-Id: Ieeba8b55451dffa768d6bcc7f24dd33bd19c2a15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-18cid#1495784 Missing move assignment operatorCaolán McNamara
Change-Id: I44004ad1628fed0c71392a000cd0633107732651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-17loplugin:unusedvariablecheck improveNoel Grandin
to find unused smart pointer variables Change-Id: I200bdd8949032a0e061de61f7903a156651793e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127006 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-17use more OInterfaceContainer3::notifyEachNoel Grandin
Change-Id: I0dd6e9f1514792e73a31e81896d09c27c1912318 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126966 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-12only use css::awt::XPopupMenu methodsCaolán McNamara
Change-Id: Ibd3c54b91e757dbca17a4b95462cbd0b7fa16f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126699 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12prefer more css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ib008281d63071ea79935af83cbe434be66155455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12prefer css::awt::XPopupMenu apiCaolán McNamara
and using GetXGraphic will return a vcl unographic::XGraphic which also supports XBitmap as well as XGraphic so we can check if the XBitmap we're passing around supports XGraphic and use that if it does and drop the imagewrapper in favor of doing that Change-Id: I3bd7963b53c3f715fca4b5cfb2ddad650ca92e1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-11prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: I1d930c1c7ea06d066f3ae35eb0535290a02a2f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-10Generally determine Rdb content from gb_*_set_componentfile callsStephan Bergmann
...instead of by listing the content somewhat redundantly in the Rdb_*.mk files, to avoid duplication of logic for components that are only built conditionally (and thus should only be included conditionally in the corresponding Rdb). To achieve that, add an "rdb" parameter to gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros that internally call gb_ComponentTarget_ComponentTarget), which is used to make the appropriate gb_Rdb_add_component call internally from within gb_ComponentTarget_ComponentTarget. (As a special case, gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that has already been done by the corresponding gb_Library_set_componentfile call, so allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to support that special case.) Most Rdb_*.mk files are thus mostly empty now. One exception is i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as needed during the build in CustomTarget_i18npool/localedata. 1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built components" had already tried to do something similar (in addition to other things) under a new --enable-services-rdb-from-build option. However, that approach had four drawbacks that this approach here addresses (and which thus partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b): 1 Rdb_services shall not contain the component files of all libraries that are built. While that commit filtered out the component files that go into Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files that go into others like Rdb_postgresql-sdbc (connectivity/Rdb_postgresql-sdbc.mk). 2 The code added by that commit to Makefile.gbuild codified the knowledge that there is an Rdb_services, which is brittle. 3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle. 4 Introducing an --enable-services-rdb-from-build option needlessly provided two different ways how the content of Rdb_services is assembled. The changes done here would leave --enable-services-rdb-from-build as a misnomer, as it no longer controls how Rdb_services is assembled. I thus renamed it to --enable-customtarget-components, as that is apparently what it still does now. Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-05remove OMultiTypeInterfaceContainerHelperVar2Noel Grandin
superceded and replaced by OMultiTypeInterfaceContainerHelperVar3 Change-Id: I46ad14bcc9bfcfe1a5279414e72d9356ddb02329 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-04use more OUStringLiteral in dbaccessNoel Grandin
and remove some dead defines Change-Id: I432cfbac954ae6798813ca5a31684e66f772acb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03loplugin:stringliteraldefine in dbaccessNoel Grandin
Change-Id: Ic7c2d23747d56432037f145b7ce9a5b6cf3724cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03use OMultiTypeInterfaceContainerHelperVar3 in OContentHelperNoel Grandin
Change-Id: I04e8c5fd38618689ad148ba6fbe823971881cbb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126194 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03use OMultiTypeInterfaceContainerHelperVar3 in SbaXVetoableChangeMultiplexerNoel Grandin
Change-Id: I60088bdf046659ca94a2aa9c09a3091e2dd03945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126196 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03use OMultiTypeInterfaceContainerHelperVar3 in SbaXPropertyChangeMultiplexerNoel Grandin
Change-Id: I744a3e5a7c7f4172bd4619647fb6decc6cd8e132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03create OMultiTypeInterfaceContainerHelperVar3 templateNoel Grandin
to supercede OMultiTypeInterfaceContainerHelperVar2 and add (a) type-safety (b) skip the need for doing UNO_QUERY when firing events Change-Id: Iaeb2421da5d92d2d4fd4feb45ab5019ca85d0d7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126192 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03Fix --disable-scripting for DESKTOP buildJan-Marek Glogowski
Unfortunatly we cannot add --disable-scripting to sub_conf_defaults, because Java currently has no equivalent to the PYTHON_FOR_BUILD setting. Change-Id: I89938a17307a363f5de808200914940503312829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126186 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-11-28use more OInterfaceContainerHelper3 in dbaccessNoel Grandin
Change-Id: I03d75ff508ba8f9904e0ed30cff15e91f82b3300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125957 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-23O[U]String::replaceAt overloads that take string_viewNoel Grandin
which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-23remove ORowSetValue implicit conversion methodsNoel Grandin
in favour of the existing get*() methods. The get*() methods 0 or false or empty in the case of "null", which is exactly the same behaviour as the conversion methods. These implicit conversion methods cause lookup problems when combined with some upcoming OUString changes. And the code looks cleaner this way too, and has less magic when calling methods. Change-Id: Ieb4756bf693e83b996a32667fc1b955f89193496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125690 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-17Clear also m_aDestTypeInfo in dtor like m_aTypeInfo (dbaccess/WCopyTable)Julien Nabet
Change-Id: Ia73503628451a3e5ee5121022545c92b50d12b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125261 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-15add a rule to enforce always-show-image of True if an image is usedCaolán McNamara
If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12Replace some macros in dbaccess part 9Julien Nabet
Remove IMPLEMENT_LISTENER_MULTIPLEXER_CORE + BEGIN_DECLARE_LISTENER_MULTIPLEXER + END_DECLARE_LISTENER_MULTIPLEXER + DECLARE_MULTIPLEXER_BOOL_METHOD + DECLARE_MULTIPLEXER_VOID_METHOD + STOP_MULTIPLEXER_LISTENING + START_PROPERTY_MULTIPLEXER_LISTENING + STOP_PROPERTY_MULTIPLEXER_LISTENING + START_MULTIPLEXER_LISTENING Change-Id: I23dfa9d71b8ae84b9c4ff5e55145e8b350a1eeba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125105 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-12insert special character in sql view in dbaccess using an arbitrary fontCaolán McNamara
The font to use in the editengine is set with the fallback list notation "Font1;Font2;Font3" and while SvxCharacterMap::SetCharFont explicitly has... { // first get the underlying info in order to get font names // like "Times New Roman;Times" resolved vcl::Font aTmp(m_xVirDev->GetFontMetric(rFont)); } which is supposed to resolve to what the physical font is, it appears that since the ancient merge of: commit 2f382d6c2579a25c68dbd121af7f1f5dc7ec9852 Date: Thu Mar 27 16:59:30 2003 +0000 MWS_SRX644: migrate branch mws_srx644 -> HEAD a change was included of: - // Fontdaten ermitteln und setzen - aMetric.SetName( pMetric->maName ); + // set aMetric with info from font + aMetric.SetName( maFont.GetName() ); which means that font names like "Times:Times New Roman" appear in the FontMetric for the font and not the font name of the physical font that the metric describes. That doesn't look right to me, but rather than get bogged down in changing that and the undoubtedly infinite chain of knock on problems that will trigger just start with a simple font name here not the fallback list. The font is "Liberation Mono;etc;etc" so the first one is certain to be available. Change-Id: I58809be8edb515d9823867c7a0bce5931dccbd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12Resolves: tdf#145582 modify called too oftenCaolán McNamara
a problem since: commit 5b98dd53c7dc101d3a5ff693d3f0520ec1abd3d1 Date: Tue Aug 3 12:28:23 2021 +0100 tdf#143657 'execute' button doesn't get enabled when contents changed which was a fix for the problem since: commit 73c9ef661d9ef6237d3fd3c259fd040a545b44cf Date: Tue Jul 6 18:51:38 2021 +0200 tdf#132740 don't broadcast if modified status has not changed Change-Id: Ibae42251ce04229283283407bc2ab986272e945d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12simplify construction of XMLPropertyMapEntryNoel Grandin
so we don't have to pass in the size of the string literal. This is mostly a preparatory change, to make an another patch of mine less noisy. Change-Id: Idafcd68586b8b465e63dc89e4a4180d2e70ac3a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-12Replace some macros in dbaccess part 8Julien Nabet
Remove DECLARE_PROPERTY_MULTIPLEXER + IMPLEMENT_LISTENER_MULTIPLEXER_BOOL_METHOD + IMPLEMENT_LISTENER_MULTIPLEXER_VOID_METHOD + IMPLEMENT_LISTENER_ADMINISTRATION + IMPLEMENT_PROPERTY_MULTIPLEXER + IMPLEMENT_PROPERTY_LISTENER_ADMINISTRATION Change-Id: Ib0522fc895166489c70c163b9d6c0f65cd9a3d59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125078 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-12rtl::Static to thread-safe staticNoel Grandin
Change-Id: I6390d1811bad59c09a074039c635710d25a660d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124886 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-11Replace some macros in dbaccess part 7Julien Nabet
Remove FIRST_USER_DEFINED_FEATURE and LAST_USER_DEFINED_FEATURE + GRANT_REVOKE_RIGHT + ALL_STRING + ALL_INT + NSQLAllocHandle + NSQLFreeHandle + NSQLSetEnvAttr + NSQLDataSources + LbText + LbPos + CHECK_INVARIANTS + OUT_LF + TAG_OFF_LF + TAG_ON_LF + TAG_OFF + TAG_ON Change-Id: I07261ea0eafcc9f0630f92e47bf5c2f694661933 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125065 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-11Replace some macros in dbaccess part 6Julien Nabet
Remove DECL_PROP_IMPL + ELEMENT_COUNT + HANDLE_SQL_ERRORS + DO_SAFE Change-Id: I2208a22329f7611a7fdc896e25bb0ef0bb378abd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125050 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-11Replace some macros in dbaccess part 5Julien Nabet
Remove BEGIN_PROPERTY_SEQUENCE + BEGIN_PROPERTY_HELPER + BEGIN_PROPERTY_SEQUENCE + BEGIN_PROPERTY_HELPER + END_PROPERTY_HELPER + IMPLEMENT_SERVICE_INFO_IMPLNAME + IMPLEMENT_SERVICE_INFO_SUPPORTS Change-Id: I44499ba68a162b01a9dd5192228b8190b1f40c98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125028 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-11Replace some macros in dbaccess part 4Julien Nabet
Remove DECL_PROP0_BOOL + DECL_PROP1_BOOL + DECL_PROP0/1/2 Change-Id: I422d3dc4c09b5f8a88c8992de187458d74dc3d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125015 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-10Replace some macros in dbaccess part 3Julien Nabet
Remove IMPLEMENT_SERVICE_INFO1 + IMPLEMENT_SERVICE_INFO2 + DECLARE_PROPERTYCONTAINER_DEFAULTS + DECLARE_PROPERTYCONTAINER_DEFAULTS + IMPLEMENT_PROPERTYCONTAINER_DEFAULTS2 + DECL_PROP3 (unused) + DECL_PROP2_IFACE Change-Id: Idf18179218b9b1f2da8e4354d8e4909edc925143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125011 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-10Replace some macros in dbaccess part 2Julien Nabet
Remove MAP_CONST_TEXT + MAP_CONST_ROW + IMPLEMENT_SERVICE_INFO3 + IMPLEMENT_GETTYPES3 + IMPLEMENT_GETTYPES2 Change-Id: I56e96a782eda1e570a43cb6bad3fa5e52bc08d2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124960 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-08Replace some macros in dbaccess part 1Julien Nabet
Remove NOTIFY_LISTENERS_CHECK + CHECK_MATRIX_POS + REGISTER_PROPERTY_BV + REGISTER_PROPERTY + MAP_END + MAP_CONST_COLUMN + MAP_CONST_CELL Change-Id: I3cd32059aef6787c0e5f8338320d7e924199830c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124892 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-05Werror=nonnull in SbaXFormAdapter::cancelNoel Grandin
ever since commit 38d78d3c30183b11f5b643c147667b1d30325784 Author: Ocke Janssen <oj@openoffice.org> Date: Thu Oct 26 13:46:14 2000 +0000 new datasource browser spotted by new gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0 Change-Id: If054b949f4b4f93e785d315ddeb3423b52d1f55b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-05Refer to TLS/SSL in optionsIlmari Lauhakangas
Change-Id: I07bddadd9421ee5584f8d978c5c43eab067414af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124745 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-11-04elide unnecessary UNO_QUERY_THROW callsNoel Grandin
Change-Id: I0d0fc57f352e9717e721416c8941cfcf48af24c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-02Drop char*-based API from NamedValueCollectionMike Kaganski
Change-Id: I87f339b348580e256a8d65470ad15cbdabf2c9dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124609 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-01Resolves: tdf#144793 add scrollbar to sql editviewCaolán McNamara
Change-Id: I23126a89c136a134590900c38ccd589fb4ea29a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>