summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2019-04-28rename animate.hxx to animate/Animation.hxx, more changes followTomaž Vajngerl
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-25WIP: Further preparations for deeper Item changesArmin Le Grand
(1) Migrated all still existing binary load/save stuff in SfxPoolItem to legacy files. Isolated from Item implementations. Adapted all usages. No more methods Create/Store needed, also GetVersion removed (2) Removed operator= for SfxPoolItem. Adapted all usages. Goal ist to handle Items more as Objects ('Object-Oriented') in the sense to move/handle instances, not to copy one instance over another one (which is more and more problematic with hard to copy content as UNO API stuff or similar). This lead to much more usages of std::shared_ptr which correlates well with future plans fr Items (see dev branch). Next logic step will be to also remove copy constructor Linux build and corrections done Fixed Writer test and removed unused defines Fixed another unused m,acro Started to unify the AutoFormat stuff Changes to OUString constructor usages, tests completely No idea why, but SfxStringItem constructor which takes a OUString& now insists of not getting ::OUString's handed in - changed all 'SfxStringItem.*OUString.*".*"' accordingly Change-Id: Ibed7358b18fb019994a7490332b9d797a6694c29 Reviewed-on: https://gerrit.libreoffice.org/71075 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-24tdf#124197 Improve "Unexpected error" user-visible error message wordingDarkByt31
Change-Id: I11c2ac4855a5fec2d26255ec3ab14ffe50e0fbbe Reviewed-on: https://gerrit.libreoffice.org/71066 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-22Fix typoAndrea Gelmini
Change-Id: I89099bfae3b001e2006b8077ace82deab9f4c3ee Reviewed-on: https://gerrit.libreoffice.org/71052 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-22Fix typoAndrea Gelmini
Change-Id: I8ed9dacb0ecc21b4ed1e9e5b49494357e8252f07 Reviewed-on: https://gerrit.libreoffice.org/71051 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-22Fix typoAndrea Gelmini
Change-Id: I41e527ae8932bf5897c907d52a2053803dd8a7c6 Reviewed-on: https://gerrit.libreoffice.org/71058 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-22Fix typoAndrea Gelmini
Change-Id: I8874705fcd5f59b4ac177bc0bd586ac4bf5a36bd Reviewed-on: https://gerrit.libreoffice.org/71053 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19drop some unneeded includesCaolán McNamara
Change-Id: Idde1f747f500d94b3191a97e7d502794cc2b8450 Reviewed-on: https://gerrit.libreoffice.org/70972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-15tdf#14649 dbaccess menubar: show icons for most importent itemsandreas kainz
Change-Id: I6eb682acd0616162837809a9f89dfb2c66efb505 Reviewed-on: https://gerrit.libreoffice.org/70787 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-15Suppress migration dialog during unit test runheiko tietze
Change-Id: Ib148673235367081282c346d9b6d4ba9f795b877 Reviewed-on: https://gerrit.libreoffice.org/70120 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-15Fix typoAndrea Gelmini
Change-Id: I5d2751276497b0da8f50be21804ab6dd624b55ba Reviewed-on: https://gerrit.libreoffice.org/70746 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-15Fix typoAndrea Gelmini
Change-Id: I0eb72d26be05c5ce937f72930f2c16fce69c85e5 Reviewed-on: https://gerrit.libreoffice.org/70747 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-15Fix typoAndrea Gelmini
Change-Id: I0e9d0b444d9cb122c0e02cbf521ba8a8ff1bb52c Reviewed-on: https://gerrit.libreoffice.org/70748 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-14Fix typoAndrea Gelmini
Change-Id: I1dacc900707758d83a8cc31b107511bf926f72a6 Reviewed-on: https://gerrit.libreoffice.org/70738 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-13loplugin:sequentialassign in dbaccess..desktopNoel Grandin
Change-Id: I3f3108daf208fa8c6be90b28da5503846c27732e Reviewed-on: https://gerrit.libreoffice.org/70698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12loplugin:unusedmethodsNoel Grandin
Change-Id: Ie90e53583484ee4f378ec92634adf3be7cd9ecbb Reviewed-on: https://gerrit.libreoffice.org/70650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-09drop some unneeded includesCaolán McNamara
Change-Id: I8e41e28313a22148033c566edce50f5bfa58d065 Reviewed-on: https://gerrit.libreoffice.org/70452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-08tdf#42949 Fix IWYU warnings in include/sfx2/[t-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib3252828385d1dc8faf48a428b1593199647a679 Reviewed-on: https://gerrit.libreoffice.org/70383 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-08weld OAddTableDlgCaolán McNamara
Change-Id: Id0c94d3ab1a19a1bb47ba1d47caa95110dab3836 Reviewed-on: https://gerrit.libreoffice.org/70353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-07Don't use resettable/clearable guard where plain guard is enoughMike Kaganski
Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07Fix typoAndrea Gelmini
Change-Id: I88752cab3d9b49db11088947903dfaf80c6d8150 Reviewed-on: https://gerrit.libreoffice.org/70358 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-06weld OTableSubscriptionDialogCaolán McNamara
Change-Id: Idf66a9e49471d6651c03deecc4fb2f9a722f512c Reviewed-on: https://gerrit.libreoffice.org/70325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06weld OTableSubscriptionPageCaolán McNamara
Change-Id: I55c23448480384c9a7d78cd55550bb4812ebde72 Reviewed-on: https://gerrit.libreoffice.org/70314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-05Replace legacy dynamically-loaded functions with statically linked onesMike Kaganski
We don't need the dynamic load complexity for these now with baseline Windows version being Windows 7 SP1. Stuff used only for compatibility with older versions was dumped. Change-Id: I810f271796cfd875cfa18a3081c9ad444fe57b3e Reviewed-on: https://gerrit.libreoffice.org/70321 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-05tdf#42949 Fix IWYU warnings in include/sfx2/sidebar/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic2bd25bcbcc7f5fb6e29ced70fddb74385b5fb2f Reviewed-on: https://gerrit.libreoffice.org/70077 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-02drop some unneeded includesCaolán McNamara
Change-Id: I78b9682968acea7564554fb589d2759b6c8e67d0 Reviewed-on: https://gerrit.libreoffice.org/70126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01drop unnecessary includesCaolán McNamara
Change-Id: I12c02a03202d778d9c2d7bf41022db64af492e04 Reviewed-on: https://gerrit.libreoffice.org/70075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#42949 Fix IWYU warnings in include/sfx2/[sS]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4a3baffa8944b522b16b50975185759081662020 Reviewed-on: https://gerrit.libreoffice.org/69945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29tdf#42949 Fix IWYU warnings in include/sfx2/[n-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia2bea9bd4775f4ed5ef0133971106a6c0bfdd1c0 Reviewed-on: https://gerrit.libreoffice.org/69896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28simplify reset(nullptr) -> reset()Noel Grandin
Change-Id: Iec5e93d9c59dde44571376e46fb98ea854e16b6c Reviewed-on: https://gerrit.libreoffice.org/69784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28Fix typoAndrea Gelmini
Change-Id: I6ba022b55af8f54f8a2e01ac354a345d1fcbf075 Reviewed-on: https://gerrit.libreoffice.org/69876 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-27Remove unused using declarations in directories [a-d]*Gabor Kelemen
Found with: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: I50f6dfa881ac4e752668e762ade0943aaf28ab96 Reviewed-on: https://gerrit.libreoffice.org/69601 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25new loplugin:unoqueryNoel Grandin
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-22Fix typoAndrea Gelmini
Change-Id: I3cb9d607c468cf29ef3e409c4f59b7e0960362a7 Reviewed-on: https://gerrit.libreoffice.org/69544 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-20Fix typoAndrea Gelmini
Change-Id: Ic1e3440c29a1dc77761e94bde41ac3a000975a37 Reviewed-on: https://gerrit.libreoffice.org/69456 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-16clarify that set_visible(true/false) is just show/hideCaolán McNamara
ditch duplicate method Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b Reviewed-on: https://gerrit.libreoffice.org/69302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13weld DatabaseRegistrationDialogCaolán McNamara
Change-Id: I739785daef892ac16d2a41a98268f18670daeedb Reviewed-on: https://gerrit.libreoffice.org/69136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12tdf#121092: save db:suppress-version-columns to ODBMike Kaganski
The setting is only available from ODatabaseSource itself, not from its Settings property. So treat it separately on export (it is also treated separately at import: see OXMLDataSource::OXMLDataSource). Change-Id: I2ecdea8748e95380c123afdb9507dfa5a4abd838 Reviewed-on: https://gerrit.libreoffice.org/69031 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-12tdf#42949 Fix IWYU warnings in include/connectivity/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221 Reviewed-on: https://gerrit.libreoffice.org/68893 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-12Correctly match checkboxes and relevant settingsMike Kaganski
Regression from commit 1c4025babd7037a3292aa530c7d45ab8d6ef6dcb Change-Id: I59ce8b6ada368c5c3f444a6e35a1dcb487d3539e Reviewed-on: https://gerrit.libreoffice.org/69075 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-11Resolves: tdf#123975 support tri-state for PrimaryKey uiCaolán McNamara
typically indeterminate is an initial state which is not returnable to, this is not the case for PrimaryKey Change-Id: I82f318e18ad9beabd9ca6e3003a736fee9a5e931 Reviewed-on: https://gerrit.libreoffice.org/69043 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-10tdf#121092: save GenerateASBeforeCorrelationName to ODBMike Kaganski
As mentioned in connectivity/registry/README, the property should be named differently in Features and Properties sections. Also the default value set in ODbAdminDialog::createItemSet should be synchronized with the other defaults, because otherwise, in case when the value is absent in the set (when it is default), this value is used in the dialog... sigh, we have too much places where relevant defaults are generated and need to be in sync. TODO: this should be reimplemented to take all defaults from the xcu. Change-Id: Ia61ab2e585107ede9c977cf563cb30e45d624bed Reviewed-on: https://gerrit.libreoffice.org/69002 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-10Make m_xAsBeforeCorrelationName depend on m_xAppendTableAliasMike Kaganski
Regression from commit 5481ca586df8eed2c832e00bc5f7e910fa2cd174 Change-Id: I082625475b6e36cca5cd46c3500c91ca6e901c66 Reviewed-on: https://gerrit.libreoffice.org/69003 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-10Initializing boost::optional with a value then resetting is oddMike Kaganski
Change-Id: Iebf28bebb009a46872dd6d4662a7434e3c66b7dc Reviewed-on: https://gerrit.libreoffice.org/68993 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-10Simplify SpecialSettingsPage's booleans initializationMike Kaganski
Change-Id: I2e1e55d4111e3c996afc27e8970af331b5d76613 Reviewed-on: https://gerrit.libreoffice.org/68988 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-09Fix typoAndrea Gelmini
Change-Id: Idb164537abb0011b223b952df1dc2fc9cc414904 Reviewed-on: https://gerrit.libreoffice.org/68955 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-09loplugin:unusedmethodsNoel Grandin
Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa Reviewed-on: https://gerrit.libreoffice.org/68938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07log nice exception messages whereever possibleNoel Grandin
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>