summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2013-07-11microoptimisationLionel Elie Mamane
Change-Id: I977fbd8387b069574d9818923ada54392d39347a
2013-07-11ORDER BY columns are prioritarily *SELECT* columnsLionel Elie Mamane
as opposed to *table* columns, and notwithstanding HSQLDB 1.8 (our embedded database) bugs. Actually, supporting ORDER BY on non-select (but table) columns is OPTIONAL for DBMSs (but quite common) Change-Id: I6725dfda36b09429a78262bff6f3d3e3dd9032b6
2013-07-11delete in destructor checkbox created in constructorLionel Elie Mamane
Change-Id: Ifceae4c7ffe15bfc62ce34f4463fd4e071403359 fixes: debug build aborts when closing that window
2013-07-11XubString->OUStringCaolán McNamara
Change-Id: I1049249741f445ad7bd9c070f99812c4404597c9
2013-07-10Fix error: reference to 'ErrorCondition' is ambiguousTor Lillqvist
Either 'connectivity::ErrorCondition' or 'com::sun::star::sdb::ErrorCondition'. Change-Id: Ifeaa895497c8635b7801b2e79400634b11541373
2013-07-10don't use empty table nameLionel Elie Mamane
Change-Id: I9c8c3882f659747d53a047481ccabf1785835c99
2013-07-05cleanup src filesThomas Arnhold
Those items are unused. Change-Id: If4fce0f91309d2ca09cbb636d4a5d9f86f38eb9a
2013-07-04unusedeasy remove ORowSet_CreateInstanceJulien Nabet
Change-Id: I17e9eb168c664514dacc03d66911f72faf80e117
2013-07-03database suggestname: no '/' for queriesLionel Elie Mamane
In particular, this keeps the new query wizard from silently failing by default when the underlying table name has a slash: it would generate a name proposal based on the table name, and then use suggestName to get a similar, yet guaranteed allowed name. In this case, the "guaranteed allowed" part was failing, since suggestName failed to strip slashes, which are forbidden in query names. Change-Id: I53d3976979ee45f5659765ed5dd3371b78837b5b
2013-07-03fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFORadu Ioan
- replaced RTL_CONTEXT_ with SAL_INFO - replace OSL_* with SAL_* Change-Id: I26761cf1d4c1cfe21dec7d8ede6df6f177bf2c3e Reviewed-on: https://gerrit.libreoffice.org/4620 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-07-02i#112615 table names are allowed slashesLionel Elie Mamane
Change-Id: I1b69c4575d79ba1b6a6e9cd83abaf18bad54fd79
2013-07-02Resolves: #i122589# check if element is added before...Armin Le Grand
removing and deleting it (well, put it in undo) (cherry picked from commit 48558dc3e09ec442bc4caf867df4b97354b4d334) Conflicts: dbaccess/source/ui/inc/QueryTableView.hxx dbaccess/source/ui/querydesign/QueryTableView.cxx Change-Id: Id8ef54c0a223548affc007d25131a23618c5fe01
2013-07-02fdo#66464 initialise static join info at construct timeLionel Elie Mamane
to ensure that isReadOnly returns something sensible as soon as construct() finishes Change-Id: I5f9bef049297c5232df0ecdb9084add968a0052f
2013-06-30Clean String and sal_Bool in toolsNorbert Thiebaud
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655 Reviewed-on: https://gerrit.libreoffice.org/4627 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29remove some createFromAscii usageThomas Arnhold
there are a lot more of them: git grep 'createFromAscii[^)]*"' Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-28remove pointless external guards for standard headersMichael Stahl
Change-Id: I509984a6029b6a86fd1ee3f947394af9cdf71c6a
2013-06-28remove toolkit/unohlp.hxx hackThomas Arnhold
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913 Reviewed-on: https://gerrit.libreoffice.org/4601 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-27add missing VclBuilder::stringmap argument to some builder functionsCaolán McNamara
Change-Id: I57e13920b4707ebe5b6a7149dbdbfc45593c0d9d
2013-06-24Remove dbaui::OStatusbarControllerAriel Constenla-Haile
It actually does not override any method in svt::StatusbarController, so there is no point in keeping it (cherry picked from commit 83bf5a7b85a0e3430cc807415e081a10a1775f9f) Conflicts: dbaccess/source/ui/control/makefile.mk dbaccess/source/ui/control/statusbarontroller.cxx dbaccess/source/ui/inc/statusbarontroller.hxx Change-Id: Id6adc11c3a54f642ebdec9c6016996134908da71
2013-06-17fdo#43460 dbaccess: use isEmpty()Jelle van der Waa
Change-Id: Ie27a81f4e59c48ef5aa03fb82ab38e920c0646a1 Reviewed-on: https://gerrit.libreoffice.org/4321 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-14fix limit bug: selecting "All" has no effect to sqlZolnai Tamás
LimitBox set its value to -1 if the current text is "All" but just when it loses its focus so dispatching its value to the controller must be after this setting. (see limitboxcontroller.cxx) Plus some clean up in LimitBox.cxx Change-Id: Ic1d314a5a67c2b261b2e9c50973f51de2bfb8db8
2013-06-10mingw64: long -> sal_IntPtr in dbaccessFridrich Štrba
Change-Id: Ic9e049b6b79a8ae3777d8b2a6e918289445c21da
2013-06-10mingw64: NULL used in arithmeticFridrich Štrba
Change-Id: I87bf28e1d6db2afe5ffa095cbf9181602ec9fc3f
2013-06-07typosJulien Nabet
Change-Id: I3ebe1c03be3b7e84666ca6a19442c376f21a5491
2013-06-07cppcheck: reduce scopeJulien Nabet
Change-Id: Ia83fb8615dbe937b4b4478fd7bf128780f8c5289
2013-06-07cppcheck: reduce scopeJulien Nabet
Change-Id: Ie1eab551a2d5dce21b55226b17d62d9a78c1ffdd
2013-06-07cppcheck: fix reassignJulien Nabet
Change-Id: Ic1f02c6734cbb0ac4846f0003f70091d5d5b4315
2013-06-06cppcheck: unread variableJulien Nabet
Change-Id: I809cdbeb71bf4cf014e6d578f35c8a646a5c937e
2013-06-06Fix previous fixStephan Bergmann
Change-Id: I2d7ea38b743d78327fd19886019c1106bc1316d6
2013-06-06-Werror=sign-compareStephan Bergmann
(ListBox::GetSelectEntryPos returns sal_uInt16) Change-Id: Ia6e4bf4354523f5112ee3ade1d3da6db0f9ab2c4
2013-06-06Prevent out-of-range values coming from ListBox GetSelectEntryPos.Javier Fernandez
Change-Id: Ia787c412408ef53db3c8458f54c7843c669c81ad Reviewed-on: https://gerrit.libreoffice.org/4174 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-06-05fdo#64447 when changing setup mode, trigger changed DatasourceType eventLionel Elie Mamane
Change-Id: I961118331f534de103b83766a2c21a6bec479241
2013-06-05use uno::Reference#clear() method...Noel Grandin
...instead of assigning an empty value. Reduces code noise. Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05remove unused componentcontext.hxx includesNoel Grandin
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-03fdo#46808, Convert comphelper::ComponentContext in forms moduleNoel Grandin
Change-Id: I8a9913d964633381f00c0a4885cc655805fa1974
2013-05-31dbaccess: unused variableZolnai Tamás
Change-Id: I4bd8863bac0f5b4a5ff1936a9d6a240dbc40be72
2013-05-30gbuild: fix deps on svx/globlmn.hrcDavid Tardon
Change-Id: I5373c0a59fdbbe0230b74df967fdaf887b91f4e4
2013-05-30dbaccess: this can happen, that's why we check for itMiklos Vajna
Change-Id: Icc85dde5cc53a6880ac83d687bad498ab984c4cf
2013-05-30Bug 64984 - EDITING: Creating table with GUI - table could not be savedNoel Grandin
This bug was introduced by my commit 002aab309055b7feeeeeb25c1835b6abe6646729 "fdo#46808, convert sdb::tools::ConnectionTools to new style" Change-Id: Ib10f97bbe46d20db663047d2f35ec4850df839fa
2013-05-27Make .uno:Open a drop-down toolbar itemAriel Constenla-Haile
(cherry picked from commit b38a51d67373daf9a45a4701e7c760c7b3571a66) Conflicts: chart2/uiconfig/toolbar/standardbar.xml dbaccess/uiconfig/dbapp/toolbar/toolbar.xml sc/uiconfig/scalc/toolbar/standardbar.xml sd/uiconfig/sdraw/toolbar/standardbar.xml starmath/uiconfig/smath/toolbar/standardbar.xml sw/uiconfig/sglobal/toolbar/standardbar.xml sw/uiconfig/sweb/toolbar/standardbar.xml sw/uiconfig/swform/toolbar/standardbar.xml sw/uiconfig/swreport/toolbar/standardbar.xml sw/uiconfig/swriter/toolbar/standardbar.xml sw/uiconfig/swxform/toolbar/standardbar.xml Change-Id: Iac0c7e8e474e8d217ca4daf47232019c64ca888f
2013-05-25translatable="yes" for some elements in .ui filesAndras Timar
Change-Id: I915cd6e73f907850f17b102c7860a827b91eef37
2013-05-25Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"Stephan Bergmann
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at <http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re: fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again" appears to fix things again: The problem is that the implementation of the css.awt.UnoControlDialogModel involves UNO aggregation (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in toolkit/soruce/helper/registerservices.cxx creating a OGeometryControlModel<UnoControlDialogModel> instance that aggregates a UnoControlDialogModel instance). That means that queryInterface can return a reference to something that is technically a different object, and that's what's happening here, and explains why calling setPropertyValue in two different ways on what logically appears to be a single object can end up calling two different implementations (of two different physical objects). (UNO aggregation is known to be broken and should not be used. Nevertheless, there's still code that does---code that is a horrible mess and hard to clean up.) That all this worked as intended in the past is just sheer luck, but any way of substantially touching it is asking for trouble. I'm going to revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again. I wasn't able to revert without also reverting be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert awt::XUnoControlDialog to new style," as the two were tightly dependant. Also reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431 "-Werror,-Wuninitialized" (sans the const-ness fix in UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452 "Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again." Conflicts: basctl/source/dlged/dlged.cxx filter/source/t602/t602filter.cxx xmlscript/test/imexp.cxx Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-24stop delivering globlmn.hrcDavid Tardon
Change-Id: Ibcc9679b37f22fdfb6a53503b252f55a52834fbb
2013-05-24WaE: implicit conversion of NULL constant to nullptr_tTor Lillqvist
Change-Id: I2eefbca1ef986219f04504cba4ca09a22972e8cb
2013-05-23Resolves: #i120859# Advance the wizard when Socket edit field has textAriel Constenla-Haile
(cherry picked from commit a9c651aa7f7a05049229c0169e439dccde3b4d51) Change-Id: Ia027dc549e3157eeb7b1d924550ed89122ae1a23
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-21allow to create new database using the wizard again (fdo#62937)Petr Mladek
To be honest, I do not userstand the code much. Julien pointed out that the setParentTitle and onTypeSelected were newer called. The condition looked like an optimisation and it helped to remove it. It would be great to put it back. It might be enough to hand the intial values. Change-Id: Id06cc9c63a9e578cb3c698c8526851fec71ef9da
2013-05-21fdo#46808, Convert awt::UnoControlDialogModel to new styleNoel Grandin
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-19make OSingleSelectQueryComposer use *system* parse contextLionel Elie Mamane
and pass it to the parser and PredicateInput constructors. This makes the whole story consistent; before system locale settings were already manually passed to parseNodeToPredicateStr, which led to some things being parsed as en_US and others as system locale. Change-Id: Ib9571b10d79183571e8ab3f79660b41594dc2d1c