summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2018-10-11weld OParameterDialogCaolán McNamara
Change-Id: I46b38a4adb4e1e825918029c7b4aba1d267a6e62 Reviewed-on: https://gerrit.libreoffice.org/61665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11tdf#120478: fix wrong icon when JDBC driver test failsJulien Nabet
Change-Id: I1d96e4a5e091caddf46131385ff5274521844fa9 Reviewed-on: https://gerrit.libreoffice.org/61637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-10clean up column pos vs column idLionel Elie Mamane
everywhere GetColumnAtXPosPixel is used; see also tdf#119564 fix Change-Id: Ibab57c7305bf4dce9ea9f3df66e6214b0d1585b2 Reviewed-on: https://gerrit.libreoffice.org/61390 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-10-09tdf#120264 - Access to "Get Involved"heiko tietze
UNO command SID_GETINVOLVED added with access to the website from all main menus under Help Dispensable ellipsis removed from other UNO commands around Help Change-Id: I79536be3de31f55a7b208bcdd5a243e05b3d3668 Reviewed-on: https://gerrit.libreoffice.org/61238 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-09use unique_ptr in SfxUndoManager::AddUndoActionNoel Grandin
Change-Id: I11483e3cece12a7373f4276972b4c899edf1ce15 Reviewed-on: https://gerrit.libreoffice.org/61566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-06drop some now unnecessary includeCaolán McNamara
Change-Id: I9db3d9a172a41c70ed343efd76f4c7c8f88b3a3f Reviewed-on: https://gerrit.libreoffice.org/61471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06make OGenericUnoDialog take an awt::XWindowCaolán McNamara
Change-Id: I7c63397d0579306f4ade1947ce5bf9e1866bf876 Reviewed-on: https://gerrit.libreoffice.org/61469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05weld QueryPropertiesDialogCaolán McNamara
Change-Id: Id523fdb25a24e2ef205bd24e594c8e01772d7a58 Reviewed-on: https://gerrit.libreoffice.org/61406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SbaSbAttrDlgCaolán McNamara
Change-Id: Ic1478d92fcf829bebdf8ada1051a4373d47077cf Reviewed-on: https://gerrit.libreoffice.org/61330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld DlgSizeCaolán McNamara
Change-Id: I5e27d2a27810af98bd0cf59f9e9cbe1cf75d7f1b Reviewed-on: https://gerrit.libreoffice.org/61329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03tdf#72987 split firebird test into a regression test and a "new" testRene Engelhard
former with endianness and latter with the new fbk format. Add new endianness-independent firebird test odbs Change-Id: I29be2e6916fcca74744211dba04463376fb6b8d5 Reviewed-on: https://gerrit.libreoffice.org/60917 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-10-03tdf#72987 run firebird test for little endian only for nowRene Engelhard
since those old(er) files still use the endianness-depending format. And remove x64 from the filename... Change-Id: I24e56cd8561c2ec6a1f77a66907c14cdea8248b6 Reviewed-on: https://gerrit.libreoffice.org/60916 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org>
2018-10-03Related: tdf#93372 pass in parent to base's table format dialogCaolán McNamara
Change-Id: I06a39b6517aabac321c45b1a3ab92f13903b9daa Reviewed-on: https://gerrit.libreoffice.org/61265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27Fix typoAndrea Gelmini
Change-Id: I0542342f4a55bf4740fd8360b8e26dbd7e2ffa2d Reviewed-on: https://gerrit.libreoffice.org/61031 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-22tdf#119569 try most likely to succeed method to get column metadata _before_Lionel Elie Mamane
We first try to prepare the statement and get metadata information. That's fine. Some DB engines/drivers will not give column information on an unexectured prepared statement. In that case, first try to execute the statement with all parameters set to NULL, which is likely to succeed. If not, keep "execute the raw SQL indiscriminately" as a last resort. I'm not sure it will ever be useful, though. Change-Id: I76b5fd6b2059e96fabe9a611c8e3ed115acfc964 Reviewed-on: https://gerrit.libreoffice.org/60884 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-22tdf#119850 show missing mysql connector optionsTamas Bunth
For MYSQL connections there is an extra window which determines how to connect to a mysql/mariadb database. This functionality is handled in OGeneralPageWizard::approveDatasourceType. Change-Id: Ia3c548103b694731cba47ff5390c34b072a938a0 Reviewed-on: https://gerrit.libreoffice.org/60893 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-09-17New loplugin:externalStephan Bergmann
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14Fix warning out-of-range value from the DatasourceType selectionJulien Nabet
Fix warn:dbaccess.ui.generalpage:19437:19437:dbaccess/source/ui/dlg/generalpage.cxx:405: Got out-of-range value '2147483647' from the DatasourceType selection ListBox's GetSelectedEntryPos(): no corresponding URL prefix Just Launch Base and select "Open an existing database file" and see this log If there's nothing to display, we get 2147483647 which corresponds to LISTBOX_ENTRY_NOTFOUND Change-Id: Iaab680695d9816c6375d9ef04f02845890f99dda Reviewed-on: https://gerrit.libreoffice.org/60464 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2018-09-11loplugin:unusedfieldsNoel Grandin
Change-Id: I876183559a7d9f1e6d914fbf37d7ffe91459144e Reviewed-on: https://gerrit.libreoffice.org/60278 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-09Avoid getTokenCount()Matteo Casalin
Change-Id: I3d4ae7495f43cae35e8a149c6523bc0337621724
2018-09-09Remove return variableMatteo Casalin
Change-Id: I322386e103e21e2660716419dd0747765ee087de
2018-09-09Reduce OUString operationsMatteo Casalin
Change-Id: Ia95ced36201ee78d511604a33992be0eff4810df
2018-09-09Avoid getTokenCount()Matteo Casalin
Change-Id: Ib84104ea0c523729c3a7fe6019ed2e788ff7b189
2018-09-09Avoid getTokenCount()Matteo Casalin
Change-Id: I30b9a9122a1e20f50471d1864b8c08af985fc5d7
2018-09-09Avoid getTokenCount()Matteo Casalin
Change-Id: I13318d43d3c572bd81080d5bb164fdcd9cd7d27b
2018-09-08loplugin:useuniqueptr in OGenericAdministrationPageNoel Grandin
Change-Id: I3028aa7d40b5fea763a93b54bf5f4c5bc4294822 Reviewed-on: https://gerrit.libreoffice.org/60193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Missed in 085269d25a705b656436feac47149296b4b4b35d Change-Id: I3cfab57232908b48d090658e0fbc948d62b3fc6f Reviewed-on: https://gerrit.libreoffice.org/60180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-07Cppcheck: resource leak warningMike Kaganski
Change-Id: I855097279cd091c1e8bd665bb0b48ce9279a9ca8 Reviewed-on: https://gerrit.libreoffice.org/60121 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07tdf#119694: read embedded hsqldb file generated before 6.1Julien Nabet
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ebb34571c19c5ac939fbf5aed2ab66ee18e298dc Thank you Drew Jensen for the bibisect! Change-Id: I9550f61709e8582a52554f578ef043c6551f09f0 Reviewed-on: https://gerrit.libreoffice.org/60117 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-06loplugin:simplifyconstruct in dbaccess..drawinglayerNoel Grandin
Change-Id: I83624d8bc787aaaaf6071171c882a6e5bde70a0d Reviewed-on: https://gerrit.libreoffice.org/60075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06clang-tidy performance-unnecessary-value-paramNoel Grandin
Change-Id: I69247498e13331f6ef84afeb242479f8fb1178a8 Reviewed-on: https://gerrit.libreoffice.org/60068 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-02tdf#118750: fix migration assistantJulien Nabet
by catching throw if backup content file doesn't exist Regression from 9ceeb4619ba762c47589023d99c43c774caab441 Change-Id: I68bb27763573217a9dff0e263cb8be88e15255ad Reviewed-on: https://gerrit.libreoffice.org/59900 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-08-29Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29loplugin:constantparam (2)Noel Grandin
Change-Id: I528f22876497f87159e3b9453362ebbfb55b7092
2018-08-29new loplugin:oustringbufferNoel Grandin
look for places where we are appending the temporary result of adding strings together, to an OUStringBuffer, where we could rather call append repeatedly and avoid the temporary creation Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82 Reviewed-on: https://gerrit.libreoffice.org/59708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29loplugin:constantparam (1)Noel Grandin
Change-Id: I25077e391ecca1b678062d261a83d88daadf0a58 Reviewed-on: https://gerrit.libreoffice.org/59701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24Blind fix for -Werror,-Wunused-functionStephan Bergmann
...on Android tb24 Change-Id: I3119a660d6d38d3bff15b3a32a98b188ea06fdbd
2018-08-24give the migration warn dialog a parentCaolán McNamara
Change-Id: Ie133c81464d87e5fbcfa9ff5d3c43f470b48d620 Reviewed-on: https://gerrit.libreoffice.org/59508 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24pass DelFormats around using std::vectorNoel Grandin
instead of an array and a separate count Change-Id: Ia12a549da7e35092da2db35f8b2b9fc6a9e9c2be Reviewed-on: https://gerrit.libreoffice.org/59506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-23we have a suitable parent window at this pointCaolán McNamara
Change-Id: I018ebec7fcad946613b7f3b8a4755e28909b7ce9 Reviewed-on: https://gerrit.libreoffice.org/59505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-20loplugin:useuniqueptr in svt::DialogNoel Grandin
Change-Id: Ib13cd74f186de0db1be4414e893b2d4f66048b44 Reviewed-on: https://gerrit.libreoffice.org/59304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16Fix typo: s/an other/another/gAndrea Gelmini
Change-Id: I203c546cfca841e7853282267190e20b60919add Reviewed-on: https://gerrit.libreoffice.org/59098 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-16loplugin:returnconstant in dbaccessNoel Grandin
Change-Id: I37b7dc7f0a7786089034acc279cb6ed7a6ef863f Reviewed-on: https://gerrit.libreoffice.org/58426 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr in ODbAdminDialogNoel Grandin
Change-Id: I4487552b2936cdfcc38055bf16e114fb6b54a3ed Reviewed-on: https://gerrit.libreoffice.org/59013 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-14tdf#119245 Set a parent for OParameterDialogMaxim Monastirsky
Change-Id: I5a7f4b43027a72f049e12c06cd583c6545b028f5 Reviewed-on: https://gerrit.libreoffice.org/58952 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-07 14:17:41 +0000