summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-28drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for dbaccess part b Change-Id: I31e7bd41923f8167db50da4701990ba20fc582de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-26New loplugin:stringliteralvarStephan Bergmann
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-24drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for dbaccess part a Change-Id: I08c2faf9a82bc6f007ebe02c7ebac8d9a46430e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22split SotStorageStream into two classesNoel
since it has two completely different paths of control Change-Id: I89b739d318d52245208a4bda1230f69d19f3ae0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-21weld tabledesignrowmenuCaolán McNamara
Change-Id: If4fc3d02308afa27a4eb4d8ee5326440a0d4f5b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108097 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld querycolmenuCaolán McNamara
Change-Id: If13436a99c80b619c9deb8d559a617accee64040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108091 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld jointablemenuCaolán McNamara
Change-Id: Ie7beb73c6b685b131e7353c2e96b68e564c39351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108089 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld queryfuncmenuCaolán McNamara
Change-Id: If6a92f846b00ec5bd719879c3f37290640e2d109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108086 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21paste and delete are never enabled, so handlers never calledCaolán McNamara
Change-Id: If45a55d8b84d691bdfcabc6b68ef2843765262f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108092 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21wrong menu used hereCaolán McNamara
since... commit 9714e7460c3ff67f2683483bf3634b2f31cda361 Date: Tue Apr 18 10:34:10 2017 +0100 convert table design row menu to .ui Change-Id: I772da4b8f97f0e416e72af35e59dfbb8d127a32c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108093 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld joinviewmenuCaolán McNamara
Change-Id: I7c4bf69edb2a8b29ebf69ebdaa30f89123a0749b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld querycolmenuCaolán McNamara
Change-Id: I0b4e27b15b1526eb7122bc5eec98f8d389e58de1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19make *String(string_view) constructors explicitNoel Grandin
to make it more obvious when we are constructing heap OUStrings code and potentially inadvertently throwing away performance. And fix a handful of places so revealed. Change-Id: I0cf390f78026f8a670aaab53424cd31510633051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-15update pchesCaolán McNamara
Change-Id: I280dea8fe5f346a5555f4bf479896877579d63e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15don't need to include vcl/menu.hxx hereCaolán McNamara
Change-Id: I16c4c2fd84ea8af6b7601e49c38630bbbfdb2cb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15use views to parse rather than allocating OUStringNoel
Change-Id: If0a848c64ce8077d1681661873629c83307cf8b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107736 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-13tdf#138834: fix crash in table creation wizard when clicking nextJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=168082 Change-Id: Icc89803bd89ce82d4699eef3cfe7892395d0634f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107610 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-09Fix loplugin:stringviewparam handling of comparison operatorsStephan Bergmann
Change-Id: I58456efb9588b544d998ac6a4c27d55457280742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107510 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-09restructure WeldEditView for reuse in SwAnnotationWinCaolán McNamara
Change-Id: I9474553e595780fa61bac955d2d5ebf691408ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107437 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-08fastparser in stylesNoel Grandin
Change-Id: I39d285f1dd7dd18c396db96863f77f511741951c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107364 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07no longer need to include vcl/ctrl.hxx hereCaolán McNamara
Change-Id: I9b01eb670b9d2953bf25079ee84371c30a6dad41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-04create an awt::XPopupMenu the standard wayCaolán McNamara
Change-Id: If3349380d29ba56b5f61dc948a770ab2fe1fb671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107226 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-04update pchesCaolán McNamara
Change-Id: I3e22c2000da03f6f3345353846213203993aa865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-03convert EHistoryType to scoped enumNoel
Change-Id: I115fc0ed81d6392d3649757727c4d9468213619d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-01Related tdf#54021: Fields in tablecontrols of a form could not be copiedJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=54021#c42 for more details. Of course there's still the main pb to fix, moving columns Change-Id: I2308efa47cbb9b80f278cf2644bb9cf24ab831e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106849 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-01OSL_FAIL.*exception -> TOOLS_WARN_EXCEPTIONNoel
Change-Id: I6800e23ead2767d245d5da71d2d40e0f8a6d7e1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-26Use sal_IntPtr to transport HWND to IDataSourceLocator::put_hWndStephan Bergmann
The HWND hWnd source is in OConnectionHelper::implInitControls (dbaccess/source/ui/dlg/ConnectionHelper.cxx) and the IDataSourceLocator::put_hWnd call sinks are in PromptNew and PromptEdit (dbaccess/source/ui/dlg/adodatalinks.cxx). The IDataSourceLocator source code has virtual HRESULT __stdcall put_hWnd( COMPATIBLE_LONG hwndParent) = 0; with typedef LONGLONG COMPATIBLE_LONG; (both C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\msdasc.h), so it looks like an integer type large enough to hold pointers is what is appropriate here. (Which matches the fact that HWND aka HANDLE aka PVOID is a pointer type.) Change-Id: I3a18e9a1d2f75a1feac716ef6e7bca78165ffe95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106695 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-23Resolves: rhbz#1900428 don't crash on invalid index used in StarBasic macroCaolán McNamara
Change-Id: I05064f7e9216c9c43b49950b309afe72466857a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106401 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-19tdf#123936 Formatting files in module dbaccess with clang-formatPhilipp Hofer
Change-Id: I7056dc36b68021bdf16cc6c496645a2797958ab8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105660 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-19loplugin:stringview: Flag empty string converted to string viewStephan Bergmann
Change-Id: Idf412dc5f235230512160cb4fb7e1a00baa1cfa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106085 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18crashtesting: intermittent failure on tdf118824-1.odbCaolán McNamara
this thread has been in the wars before: commit 490f83d4807a4223bae61d34913e5bd2bf952f3a Date: Fri Mar 9 09:12:54 2012 +0100 fdo#47021: the naive join attempt leads to deadlock commit a2095b151409f0fb57aa8feaa4c6282f84040245 Date: Tue Jul 26 23:42:36 2016 +0200 comphelper,vcl: let DeInitVCL() join some AsyncEventNotifier threads current backtrace is... Thread 1 (Thread 0x7fb9d9af6700 (LWP 32393)): 0 0x00007fb9eff83705 in () at /lib/x86_64-linux-gnu/libstdc++.so.6 1 0x00007fb9eff8375e in () at /lib/x86_64-linux-gnu/libstdc++.so.6 2 0x00007fb9dcc308df in __gnu_debug::_Safe_iterator_base::_Safe_iterator_base(__gnu_debug::_Safe_sequence_base const*, bool) (__constant=false, __seq=<optimized out>, this=0x7fb9d9af4338) at /usr/include/c++/8/debug/safe_base.h:91 3 0x00007fb9dcc308df in __gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<rtl::OUString const, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > >, std::__debug::map<rtl::OUString, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > > > >::_Safe_iterator(std::_Rb_tree_iterator<std::pair<rtl::OUString const, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > > const&, __gnu_debug::_Safe_sequence_base const*) (__seq=<optimized out>, __i=..., this=0x7fb9d9af4330) at /usr/include/c++/8/debug/safe_iterator.h:130 4 0x00007fb9dcc308df in std::__debug::map<rtl::OUString, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > > >::end() (this=<optimized out>) at /usr/include/c++/8/debug/map.h:181 5 0x00007fb9dcc308df in dbaccess::DocumentEvents::hasByName(rtl::OUString const&) (this=0x559229945690, Name="OnLoad") at /home/buildslave/source/libo-core/dbaccess/source/core/dataaccess/documentevents.cxx:199 6 0x00007fb9dcc2a4de in dbaccess::DocumentEventExecutor::documentEventOccured(com::sun::star::document::DocumentEvent const&) (this=0x559229981050, Event=...) at /home/buildslave/source/libo-core/include/com/sun/star/uno/Reference.h:380 aScriptDescriptor = {m_pImpl = std::unique_ptr<struct comphelper::NamedValueCollection_Impl> = {get() = 0x5592297d7700}} bScriptAssigned = <optimized out> bDispatchScriptURL = <optimized out> bNonEmptyScript = <optimized out> sEventType = "\004\000晦晦⦾喒\000\000\000\000\000䄨\xdce2ç¾¹\000°⧘喒\000èŒâ§’å–’\000°⧘喒\000\001晦晦晦䅨\xdce2ç¾¹\000ä† \xdce2ç¾¹\000ä‰ \xdce2ç¾¹\000䊨\xdce2ç¾¹\000䌀\xdce2ç¾¹\000䌸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000䎸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000ä‘°\xdce2ç¾¹\000ä’ \xdce2ç¾¹\000䓘\xdce2ç¾¹\000䔈\xdce2ç¾¹\000ä• \xdce2ç¾¹\000ä– \xdce2ç¾¹\000ä—\xdce2ç¾¹\000䘀\xdce2ç¾¹\000䘰\xdce2ç¾¹\000䙨\xdce2ç¾¹\000䚨\xdce2ç¾¹\000ä› \xdce2ç¾¹\000䜘\xdce2ç¾¹\000ä\xdce2ç¾¹\000\000\000\000\000\000\000\000\000°⧘喒\000\000晦晦晦\000\000\000\000°⧘喒\000\000晦晦晦\000\000\000\000°⧘喒\000\000晦晦晦åšâ¦”å–’\000á⦘喒\000닰⦨喒", '\000' <repeats 13 times>, "\001\000晦晦\000\000\000\000"... sScript = "\004\000晦晦⦾喒\000\000\000\000\000䄨\xdce2ç¾¹\000°⧘喒\000èŒâ§’å–’\000°⧘喒\000\001晦晦晦䅨\xdce2ç¾¹\000ä† \xdce2ç¾¹\000ä‰ \xdce2ç¾¹\000䊨\xdce2ç¾¹\000䌀\xdce2ç¾¹\000䌸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000䎸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000ä‘°\xdce2ç¾¹\000ä’ \xdce2ç¾¹\000䓘\xdce2ç¾¹\000䔈\xdce2ç¾¹\000ä• \xdce2ç¾¹\000ä– \xdce2ç¾¹\000ä—\xdce2ç¾¹\000䘀\xdce2ç¾¹\000䘰\xdce2ç¾¹\000䙨\xdce2ç¾¹\000䚨\xdce2ç¾¹\000ä› \xdce2ç¾¹\000䜘\xdce2ç¾¹\000ä\xdce2ç¾¹\000\000\000\000\000\000\000\000\000°⧘喒\000\000晦晦晦\000\000\000\000°⧘喒\000\000晦晦晦\000\000\000\000°⧘喒\000\000晦晦晦åšâ¦”å–’\000á⦘喒\000닰⦨喒", '\000' <repeats 13 times>, "\001\000晦晦\000\000\000\000"... xEventsSupplier = uno::Reference to (class dbaccess::ODatabaseDocument *) 0x559229d80188 xDocument = uno::Reference to (class dbaccess::ODatabaseDocument *) 0x559229d80108 __func__ = "documentEventOccured" 7 0x00007fb9dcc2b3cb in comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const (listener=#8 0x00007fb9dcc2b3cb in comphelper::OInterfaceContainerHelper2::forEach<com::sun::star::document::XDocumentEventListener, comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> >(comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> const&) (func=..., this=0x559229a8b340) at /home/buildslave/source/libo-core/include/comphelper/interfacecontainer2.hxx:266 iter = {rCont = @0x559229a8b340, aData = {pAsVector = 0x559229b71540, pAsInterface = 0x559229b71540}, nRemain = 0, bIsList = true} __func__ = "impl_notifyEvent_nothrow" 9 0x00007fb9dcc2b3cb in comphelper::OInterfaceContainerHelper2::notifyEach<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>(void (com::sun::star::document::XDocumentEventListener::*)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) (Event=..., NotificationMethod=<optimized out>, this=0x559229a8b340) at /home/buildslave/source/libo-core/include/comphelper/interfacecontainer2.hxx:279 __func__ = "impl_notifyEvent_nothrow" 10 0x00007fb9dcc2b3cb in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow(com::sun::star::document::DocumentEvent const&) (this=this@entry=0x559229a8b2f0, _rEvent=...) at /home/buildslave/source/libo-core/dbaccess/source/core/dataaccess/documenteventnotifier.cxx:196 __func__ = "impl_notifyEvent_nothrow" 11 0x00007fb9dcc2b638 in dbaccess::DocumentEventNotifier_Impl::processEvent(comphelper::AnyEvent const&) (this=0x559229a8b2f0, _rEvent=...) at /home/buildslave/source/libo-core/include/comphelper/asyncnotification.hxx:215 rEventHolder = <optimized out> 12 0x00007fb9ef271835 in comphelper::AsyncEventNotifierBase::execute() (this=0x559229a8c460) at /home/buildslave/source/libo-core/comphelper/source/misc/asyncnotification.cxx:163 aEvent = {aEvent = rtl::Reference to 0x559229872990, xProcessor = rtl::Reference to 0x559229a8b2f0} __PRETTY_FUNCTION__ = "virtual void comphelper::AsyncEventNotifierBase::execute()" 13 0x00007fb9ef26ffb9 in comphelper::AsyncEventNotifierAutoJoin::run() (this=0x559229a8c460) at /home/buildslave/source/libo-core/comphelper/source/misc/asyncnotification.cxx:268 14 0x00007fb9ef27d4ab in osl::threadFunc(void*) (param=0x559229a8c470) at /home/buildslave/source/libo-core/include/osl/thread.hxx:185 pObj = 0x559229a8c470 15 0x00007fb9f04645b6 in osl_thread_start_Impl(void*) (pData=0x559229aaa9e0) at /home/buildslave/source/libo-core/sal/osl/unx/thread.cxx:258 terminate = false pImpl = 0x559229aaa9e0 __PRETTY_FUNCTION__ = "void* osl_thread_start_Impl(void*)" 16 0x00007fb9efd12fa3 in start_thread () at /lib/x86_64-linux-gnu/libpthread.so.0 17 0x00007fb9f01574cf in clone () at /lib/x86_64-linux-gnu/libc.so.6 Change-Id: I265c6d35d5690750454920e4155d99073d9e51ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103868 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-17loplugin:stringviewparam extend to constructorsNoel
Change-Id: Ia573921566ec6079b843cbcc0401d9d0f5c62089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17loplugin:stringviewparam check methods tooNoel
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16Resolves: tdf#138240 GtkComboBox without modelCaolán McNamara
just use a GtkComboBoxText which comes with one by default Change-Id: I041d37be137aed4c888336c62db574ea3d730e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105916 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done so we get the same behavior in glade as before 3.38 in that the grid preview don't show any unoccupied grid squares replace all existing n-columns=X n-rows=Y lines because they are all wrong, except for cui/uiconfig/ui/additionsfragment.ui sw/uiconfig/swriter/ui/pageheaderpanel.ui sw/uiconfig/swriter/ui/pagefooterpanel.ui which are correct. Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-12New loplugin:stringviewparamStephan Bergmann
...to "Find functions that take rtl::O[U]String parameters that can be generalized to take std::[u16]string_view instead." (Which in turn can avoid costly O[U]String constructions, see e.g. loplugin:stringview and subView.) Some of those functions' call sites, passing plain char string literals, needed to be adapted when converting them. Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-11loplugin:stringviewNoel
Add new methods "subView" to O(U)String to return substring views of the underlying data. Add a clang plugin to warn when replacing existing calls to copy() would be better to use subView(). Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11disable O(U)String::concat for internal codeNoel Grandin
in favour of the more widely used, and better optimised, operator+ Change-Id: I6a1b37e0f3d253af1f7a0892443f59b620efea63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-09tdf#42949 Fix new IWYU warnings in directories d*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8f3cd05dbd86bd22fd84d767adc44fc2b0c89404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105468 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-02create common macro and method for logging unknown attributesNoel
instead of repeating the code everywhere Change-Id: Idb94054b392ed256e64259cdb17d1522bf3c52b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02make SvXMLImport capable of mixing fast- and slow- contexts adhocNoel
so I can convert even *ImportContext subclasses in the middle of a context stack, and thus break the cyclic dependency nature of the writer import. and adjust the xmlimport loplugin for the new rules. As a consequence of the loplugin:xmlimport's checking, we remove a bunch of now unnecessary overrides of startFastElement. Change-Id: I97464522ede8ec5e345e928cdafa4b18364b1b80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for Experimental flagNoel Grandin
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-30convert some tools::Long->sal_Int32Noel
in places where it is obvious we only need a sal_Int32, because we are dealing with rows and columns, and not even calc needs more than 32 bits for that. Change-Id: I114417e639c224d45bfd9fc6838122ab195eefa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28convert some more long -> tools::LongNoel
grepping for stuff in template params this time Change-Id: Ia37bfd85480b3a72c3c465489581d56ad8dde851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-05-06 09:42:23 +0000