summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2016-12-06cleanup unused includes (related to tdf#88206)Jochen Nitschke
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only implbase*.hxx stuff is used. Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995 Reviewed-on: https://gerrit.libreoffice.org/31686 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05only IMG_PRIMARY_KEY is actually usedCaolán McNamara
Change-Id: Ie888ed93f0d511e0c040af32f41e8350113b586c
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05loplugin:unnecessaryoverride (dtors) in dbaccessStephan Bergmann
Change-Id: I22cf2fec8e543582a32b9a4f00221f1b2d864f7a
2016-11-29Use Size::Width/Height instead of inherited Pair::A/BStephan Bergmann
Change-Id: Ie0346d5ec054fbe7eff1d4b73814a5e2b9f654c2
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
2016-11-23convert SAD constants to o3tl::typed_flagsNoel Grandin
and drop unused SAD_TITLE_STORE_AS Change-Id: I5114958b3954e3dc3ffd941334c6c4dbfbed7aea
2016-11-23convert EF constants to o3tl::typed_flagsNoel Grandin
and remove now unused ByteVector typedef Change-Id: I9c4b30aea2608cf97e597b00b4a4ea800efac4ec
2016-11-23convert CBTP constants to o3tl::typed_flagsNoel Grandin
Change-Id: I453a9bacef737a56e381c4172710ec6acf225f0b
2016-11-22remove some more global OUStringsNoel Grandin
Change-Id: Ic02754f98bfda3b7cd8c06857123d363a96e8d0e Reviewed-on: https://gerrit.libreoffice.org/31071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-22trivial makefile cleanupsMichael Stahl
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
2016-11-21Revert "add missing component"David Tardon
This reverts commit 7fe1b39e8abe68357c88536923b7058807b32119.
2016-11-21Revert "add missing component"David Tardon
This reverts commit b55d17471f73b843943269c6cbd30f99995d8354.
2016-11-21add missing componentDavid Tardon
Change-Id: I53d50f8e338fcc64e24370a80ce390f7a2be34ba
2016-11-21add missing componentDavid Tardon
Change-Id: I8b6f6d650c011fc0611d6933894bc64a780ff8c0
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-17loplugin:datamembershadowNoel Grandin
Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-12coverity#1394296 Dereference before null checkCaolán McNamara
Change-Id: I143b7439b33695aa5bc4e32fd9386692eac37697
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09loplugin:expandablemethods in dbaccessNoel Grandin
Change-Id: I6087a3eff46926646ac1637615a0af30b38956a4 Reviewed-on: https://gerrit.libreoffice.org/30712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07style fix for cppcheck redundantConditionJochen Nitschke
Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe Reviewed-on: https://gerrit.libreoffice.org/30667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Resolves: #i119892# Missing "by" in descriptionDamjan Jovanovic
Fixes spelling errors in some Base messages. Reported by: Dwayne Henderson Patch by: me (cherry picked from commit 8df1c30b7f5e79c2757e7224677f9a487b1bed0a) Change-Id: I18dcf20e51e941ca8ccb47315ea453399ca0d88a
2016-11-04loplugin:oncevar in dbaccessNoel Grandin
Change-Id: I956063bb354fbbd002e922bb06d0b3863a2750fc Reviewed-on: https://gerrit.libreoffice.org/30565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30511 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02loplugin:unusedfieldsNoel Grandin
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-31No good reason for dbaccess::OCacheSet::updateRow to be pure?Stephan Bergmann
Most of its virtual member functions are (though insertRow is already a curious exception), even though they are defined, so smells like a copy/paste error rather than deliberate design. And appears to have been the only reason why loplugin:unnecessaryoverride filtered out such overriding of pure base functions. Change-Id: Ib2a40af9cd3cd3dbb26c4147f7d01de4e11f5f6e
2016-10-31update vclwidgets plugin to check local variablesNoel Grandin
Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22 Reviewed-on: https://gerrit.libreoffice.org/30428 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-30tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl
This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-30Allow using xml menus in DBTreeListBoxMaxim Monastirsky
Change-Id: I8dfab0ae5d64b416123ab5690b43cf2db77d92dc
2016-10-30Add resource name method to IContextMenuProviderMaxim Monastirsky
Change-Id: I218fd18101f8f7039052fe8a065096e4c9809adb
2016-10-30Convert RID_MENU_APP_EDIT to xmlMaxim Monastirsky
Change-Id: I6868624b1726b1044e741a1fc0cdabe703f84c31
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-27Sub menus no longer need manual disposingMaxim Monastirsky
after: commit ee79a2dd7ea60e902cab3a9203e307b8a78fee23 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jul 29 14:33:22 2016 +0100 Resolves: tdf#101169 crash using column menu in base Change-Id: I7c6e54dd5574c61cffd5884d1cf1b63075073001 Reviewed-on: https://gerrit.libreoffice.org/30343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-27dbaccess: OToolboxController is now unusedMaxim Monastirsky
This also removes the only occurrence of the "com.sun.star.frame.ToolboxController" service. However it shouldn't be considered as API CHANGE, as no 3rd-party code should rely on undocumented services, and fortunately a toolbox controller like this has no use for 3rd-party anyway. BTW there are other cases of using non-existent (unique) service names for toolbox controllers in non-sfx2 modules, rather than using the standard "com.sun.star.frame.ToolbarController". There is OToolboxController in reportdesign (which I hope to remove soon too, as it's just a wrapper around SvxColorToolBoxControl). And there was also ShapeToolbarController in chart2 which I removed in 2aea9e37d697ce51efc5fb37ba50f1bf177e0445 ("Introduce generic sub toolbar controller"). Change-Id: Iea8858be2406f32bb5a022920b4b1cee70603c09
2016-10-27Convert RID_MENU_REFRESH_DATA to xmlMaxim Monastirsky
Change-Id: I22107396eaab848224f26eb54f8638a354c13509
2016-10-27Convert RID_MENU_APP_NEW to xmlMaxim Monastirsky
Achieved by using GenericPopupToolbarController for the associated toolbar button. Change-Id: I406ff40e0c80d6db903de5629088d35487ab6416
2016-10-27make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin
Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-28 07:54:13 +0000