summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2013-06-24Remove dbaui::OStatusbarControllerAriel Constenla-Haile
It actually does not override any method in svt::StatusbarController, so there is no point in keeping it (cherry picked from commit 83bf5a7b85a0e3430cc807415e081a10a1775f9f) Conflicts: dbaccess/source/ui/control/makefile.mk dbaccess/source/ui/control/statusbarontroller.cxx dbaccess/source/ui/inc/statusbarontroller.hxx Change-Id: Id6adc11c3a54f642ebdec9c6016996134908da71
2013-06-17fdo#43460 dbaccess: use isEmpty()Jelle van der Waa
Change-Id: Ie27a81f4e59c48ef5aa03fb82ab38e920c0646a1 Reviewed-on: https://gerrit.libreoffice.org/4321 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-14fix limit bug: selecting "All" has no effect to sqlZolnai Tamás
LimitBox set its value to -1 if the current text is "All" but just when it loses its focus so dispatching its value to the controller must be after this setting. (see limitboxcontroller.cxx) Plus some clean up in LimitBox.cxx Change-Id: Ic1d314a5a67c2b261b2e9c50973f51de2bfb8db8
2013-06-10mingw64: long -> sal_IntPtr in dbaccessFridrich Štrba
Change-Id: Ic9e049b6b79a8ae3777d8b2a6e918289445c21da
2013-06-10mingw64: NULL used in arithmeticFridrich Štrba
Change-Id: I87bf28e1d6db2afe5ffa095cbf9181602ec9fc3f
2013-06-07typosJulien Nabet
Change-Id: I3ebe1c03be3b7e84666ca6a19442c376f21a5491
2013-06-07cppcheck: reduce scopeJulien Nabet
Change-Id: Ia83fb8615dbe937b4b4478fd7bf128780f8c5289
2013-06-07cppcheck: reduce scopeJulien Nabet
Change-Id: Ie1eab551a2d5dce21b55226b17d62d9a78c1ffdd
2013-06-07cppcheck: fix reassignJulien Nabet
Change-Id: Ic1f02c6734cbb0ac4846f0003f70091d5d5b4315
2013-06-06cppcheck: unread variableJulien Nabet
Change-Id: I809cdbeb71bf4cf014e6d578f35c8a646a5c937e
2013-06-06Fix previous fixStephan Bergmann
Change-Id: I2d7ea38b743d78327fd19886019c1106bc1316d6
2013-06-06-Werror=sign-compareStephan Bergmann
(ListBox::GetSelectEntryPos returns sal_uInt16) Change-Id: Ia6e4bf4354523f5112ee3ade1d3da6db0f9ab2c4
2013-06-06Prevent out-of-range values coming from ListBox GetSelectEntryPos.Javier Fernandez
Change-Id: Ia787c412408ef53db3c8458f54c7843c669c81ad Reviewed-on: https://gerrit.libreoffice.org/4174 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-06-05fdo#64447 when changing setup mode, trigger changed DatasourceType eventLionel Elie Mamane
Change-Id: I961118331f534de103b83766a2c21a6bec479241
2013-06-05use uno::Reference#clear() method...Noel Grandin
...instead of assigning an empty value. Reduces code noise. Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05remove unused componentcontext.hxx includesNoel Grandin
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-03fdo#46808, Convert comphelper::ComponentContext in forms moduleNoel Grandin
Change-Id: I8a9913d964633381f00c0a4885cc655805fa1974
2013-05-31dbaccess: unused variableZolnai Tamás
Change-Id: I4bd8863bac0f5b4a5ff1936a9d6a240dbc40be72
2013-05-30gbuild: fix deps on svx/globlmn.hrcDavid Tardon
Change-Id: I5373c0a59fdbbe0230b74df967fdaf887b91f4e4
2013-05-30dbaccess: this can happen, that's why we check for itMiklos Vajna
Change-Id: Icc85dde5cc53a6880ac83d687bad498ab984c4cf
2013-05-30Bug 64984 - EDITING: Creating table with GUI - table could not be savedNoel Grandin
This bug was introduced by my commit 002aab309055b7feeeeeb25c1835b6abe6646729 "fdo#46808, convert sdb::tools::ConnectionTools to new style" Change-Id: Ib10f97bbe46d20db663047d2f35ec4850df839fa
2013-05-27Make .uno:Open a drop-down toolbar itemAriel Constenla-Haile
(cherry picked from commit b38a51d67373daf9a45a4701e7c760c7b3571a66) Conflicts: chart2/uiconfig/toolbar/standardbar.xml dbaccess/uiconfig/dbapp/toolbar/toolbar.xml sc/uiconfig/scalc/toolbar/standardbar.xml sd/uiconfig/sdraw/toolbar/standardbar.xml starmath/uiconfig/smath/toolbar/standardbar.xml sw/uiconfig/sglobal/toolbar/standardbar.xml sw/uiconfig/sweb/toolbar/standardbar.xml sw/uiconfig/swform/toolbar/standardbar.xml sw/uiconfig/swreport/toolbar/standardbar.xml sw/uiconfig/swriter/toolbar/standardbar.xml sw/uiconfig/swxform/toolbar/standardbar.xml Change-Id: Iac0c7e8e474e8d217ca4daf47232019c64ca888f
2013-05-25translatable="yes" for some elements in .ui filesAndras Timar
Change-Id: I915cd6e73f907850f17b102c7860a827b91eef37
2013-05-25Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"Stephan Bergmann
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at <http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re: fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again" appears to fix things again: The problem is that the implementation of the css.awt.UnoControlDialogModel involves UNO aggregation (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in toolkit/soruce/helper/registerservices.cxx creating a OGeometryControlModel<UnoControlDialogModel> instance that aggregates a UnoControlDialogModel instance). That means that queryInterface can return a reference to something that is technically a different object, and that's what's happening here, and explains why calling setPropertyValue in two different ways on what logically appears to be a single object can end up calling two different implementations (of two different physical objects). (UNO aggregation is known to be broken and should not be used. Nevertheless, there's still code that does---code that is a horrible mess and hard to clean up.) That all this worked as intended in the past is just sheer luck, but any way of substantially touching it is asking for trouble. I'm going to revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again. I wasn't able to revert without also reverting be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert awt::XUnoControlDialog to new style," as the two were tightly dependant. Also reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431 "-Werror,-Wuninitialized" (sans the const-ness fix in UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452 "Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again." Conflicts: basctl/source/dlged/dlged.cxx filter/source/t602/t602filter.cxx xmlscript/test/imexp.cxx Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-24stop delivering globlmn.hrcDavid Tardon
Change-Id: Ibcc9679b37f22fdfb6a53503b252f55a52834fbb
2013-05-24WaE: implicit conversion of NULL constant to nullptr_tTor Lillqvist
Change-Id: I2eefbca1ef986219f04504cba4ca09a22972e8cb
2013-05-23Resolves: #i120859# Advance the wizard when Socket edit field has textAriel Constenla-Haile
(cherry picked from commit a9c651aa7f7a05049229c0169e439dccde3b4d51) Change-Id: Ia027dc549e3157eeb7b1d924550ed89122ae1a23
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-21allow to create new database using the wizard again (fdo#62937)Petr Mladek
To be honest, I do not userstand the code much. Julien pointed out that the setParentTitle and onTypeSelected were newer called. The condition looked like an optimisation and it helped to remove it. It would be great to put it back. It might be enough to hand the intial values. Change-Id: Id06cc9c63a9e578cb3c698c8526851fec71ef9da
2013-05-21fdo#46808, Convert awt::UnoControlDialogModel to new styleNoel Grandin
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-19make OSingleSelectQueryComposer use *system* parse contextLionel Elie Mamane
and pass it to the parser and PredicateInput constructors. This makes the whole story consistent; before system locale settings were already manually passed to parseNodeToPredicateStr, which led to some things being parsed as en_US and others as system locale. Change-Id: Ib9571b10d79183571e8ab3f79660b41594dc2d1c
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist
2013-05-14SolarMutex does not belong into the URE interfaceStephan Bergmann
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx. It looks like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an abstract interface to be used to implement a SolarMutex" put it here in the first place. I do not consider this an incompatible change really, as no external URE client code should have used SolarMutex anyway. (Also included some clean up, like removing unused {Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places it is used.) Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14fdo#46808, fix call to sdb::tools::ConnectionToolsNoel Grandin
In my previous conversion to new style I forgot to pass arguments into the service constructor. Change-Id: Ibbf750315b3e62869b1eb4c520808327002f2dcc
2013-05-14Initialise the default-constructed ConnectionToolsLionel Elie Mamane
Regression from the "convert to new style", which led to ignoring aArguments Change-Id: I09477578f77b253b8c6435d52e1e636d2e212023
2013-05-13Fix namingStephan Bergmann
Change-Id: Id167385e832b1cd78d0612fc2a7611aa76bf0601
2013-05-12Fix possible inefficient checking for variables emptinessJulien Nabet
Change-Id: I95a6784d5448b63b0cdde436484915692f8633be
2013-05-10Potty mouthChris Sherlock
Change-Id: I276fa2fa24b5553a748e6e628129d54419e69c9a Reviewed-on: https://gerrit.libreoffice.org/3843 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-05-07connectivity: remove Package_generatedMichael Stahl
This one is ugly, the Yacc generated header is used in lots of places; the dependencies are already right because using the header requires using the dbtools library which builds the YaccTarget, so just yet another include path has to be added. Change-Id: I031fde80ac326551d4719533305b1ae35351ca43
2013-05-07officecfg: remove Package_cppheaderMichael Stahl
Instead include generated headers directly from workdir. Change-Id: I9d2bcc07175d2bbc16d3cc548c2245e7a4fb0c65
2013-05-07dbaccess: remove Package_incMichael Stahl
Change-Id: I8e6748eef04f25603851a33d049cb9585fa04cc6
2013-05-06fix typos (wich instead of which)Philipp Riemer
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06Java cleanup, remove unnecessary @SuppressWarnings annotationsNoel Grandin
Change-Id: Ib5df091fc4a6233b526c44ae42dbdbacb0bef7c6
2013-05-01convert message box return types to an enumCaolán McNamara
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
2013-04-29fdo#63391 deadlock on opening .odb file that auto-connects to the databaseLionel Elie Mamane
Let foo.odb be a database file that has a macro that connects to the Database on "Open Document" event (and needs to prompt user for user/password). There was a race condition between two actions: 1) the asynchronous treatment of "OnFirstControllerConnected" in dbaui::OApplicationController, which tries to get dbaui::OApplicationController's mutex 2) the StarBasic macro calling dbaui::OApplicationController::connect which needs to display a dialog (to get username and password), and thus puts that dialog in the main thread's event queue and waits for it ... with dbaui::OApplicationController's mutex held Now, if "1)" is before "2)" in the event queue of the the main thread, *but* "1)" is executed *after* "2)" has taken the lock, there is a deadlock. Fix: 1) Make OnFirstControllerConnected synchronous. Make sure (by taking mutex in dbaui::OApplicationController::attachFrame, its ancestor in the call graph) that nothing else will happen with the OApplicationController as long as it is not finished. ---> it does not need to take mutex itself anymore This avoids the "order in the asynchronous events" dependency. 2) Change dbaui::OApplicationController::ensureConnection to do the user prompting WITHOUT HOLDING the mutex, and use the mutex "only" to protect actually assigning the connection to m_xDataSourceConnection. Theoretically, in some race condition, we could connect twice and then discard one connection <shrug>. ensureConnection will never return the discarded connection, though. (I think I got that right with respect to http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html) This keeps it from locking on another condition while holding the mutex. Change-Id: Iab1bbec5d5df12bb89d027d43e498c78c92ffc32 Reviewed-on: https://gerrit.libreoffice.org/3310 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-26remove never-generated "predicate_check" entryLionel Elie Mamane
Change-Id: Ib3957fbadf6bfebfaabd5bef09aaf7ab21862cd6
2013-04-26QueryDesign: in criteria, remove column_ref when table *and* column name matchLionel Elie Mamane
As opposed to only the column name Change-Id: I261d13f23214f950daa55a5b63cd486e59a0e127
2013-04-26String -> OUStringLionel Elie Mamane
Change-Id: Ibf566a11a383b77a930d46967e496752c88b39e4
2013-04-26Java cleanup, remove unused importsNoel Grandin
Change-Id: I697017f196a7f7e5684011ae23941e54051c45dd
generated by cgit (git 2.34.1) at 2024-12-30 19:12:31 +0000