summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2025-04-13Remove obsolete fw declarations from dbaccess/Gabor Kelemen
found with bin/find-unneeded-includes --fwdecl Change-Id: I1a3b1420119b0c79860a1fde69efa4272356af61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183882 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-04-06tdf#151876 shave some time off chart load (2)Noel Grandin
manage SvXMLImportPropertyMapper with unique_ptr instead of rtl::Reference, which avoids a bunch of ref-counting traffic Change-Id: I1e0e95408cdd5dc4271fa72178e57087737eb062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-01a11y: Merge OAccessibleComponentHelper and OCommonAccessibleComponentMichael Weghorn
Merge the two classes, now that OAccessibleComponentHelper is the only OCommonAccessibleComponent subclass after Change-Id: I05547b12806a6a90b166edbe196b4bc5a27344be Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Mar 31 13:49:20 2025 +0200 a11y: Merge OAccessible{,Extended}ComponentHelper, add default impl Change-Id: Ic7a36c40066f307f8df29dc4dd45ed3ee966bcb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183552 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-04-01dbaccess a11y: Implement OConnectionLineAccess::implGetBoundsMichael Weghorn
Don't manually override OAccessibleExtendedComponentHelper methods related to bounds/position, but implement OConnectionLineAccess::implGetBounds (i.e. override the base class implementation) instead so that the logic in OAccessibleExtendedComponentHelper "just works". Mark the OAccessibleExtendedComponentHelper methods that shouldn't be manually overriden as final, just as is already the case in OAccessibleComponentHelper. Change-Id: Ia24d254384757796a8357928af05dca48e16ada9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183550 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-03-31Revert "Move SingleSelectQueryComposer.java tests to C++"Noel Grandin
This reverts commit d1ec7e90772421331bef31eb934180c7f992e42f. To avoid deadlocks on jenkins. Change-Id: Icbe299ed29dfd02f61b14953344a902e2184c606 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-31tdf#145614 Convert #define to constexprSimon Chenery
Change-Id: I7823970bb3b222fcc2dbac9f4cbee4e3fc3f3813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183416 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2025-03-27fix CppunitTest_dbaccess_SingleSelectQueryComposer_test deadlockNoel Grandin
I have seen several deadlocks on jenkins in this unit test, normally with stacks like privateSnippetExecutor () connectivity::hsqldb::OHsqlConnection::flush() connectivity::hsqldb::ODriverDelegator::flushConnections() connectivity::hsqldb::OConnectionController::queryTermination framework::Desktop::impl_sendQueryTerminationEvent framework::Desktop::terminate() (anonymous namespace)::Hook::deinitHook((anonymous namespace)::Hook*, LinkParamNone*) (anonymous namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*) Link<LinkParamNone*, void>::Call(LinkParamNone*) const in DeInitVCL() Implement a proper teardown in the unit test so this does not happen. Change-Id: I3242752dc38d74128fcd134fe7391f04bd64ebc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183391 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-20tdf#165815 Base crashes on saving edited tableNoel Grandin
thanks to adamseskunas for finding the source file that contained the bug regression from commit 09e2627a83d4769983c39fb2cb260e11fce354f3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Feb 17 11:06:55 2025 +0200 use more concrete UNO types in some local vars Change-Id: I6884e5b7b20e45e3e7cfd11d5aa20d6e03ae34d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183151 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-19Rename con-const vcl::Font property getters for clarityMike Kaganski
There are two sets of getters there; and the non-const ones may copy the COW mpImplFont, and may call its AskConfig. The name overload is unfortunate. It is not obvious at the call site, which of the two will be called; and what is different. IMO, the way to fix it would be to keep only one set of getters (the const one), and make the call to AskConfig explicit (in the places that set font name, and know that resolution of other properties will be needed). But in this change, I only rename the non-const getters, making sure to keep the behavior unchanged (at least the intention is to have a non-functional change, meaning that the places that called non-const overload, now use the renamed functions), to make it clear where we actually may copy and initialize it. Change-Id: I9a5cd91d5c1c0de7ff8577b9b982d165e4cdd2c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183116 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-03-17tdf#145614 Convert #define CELL_X to constexprSimon Chenery
Change-Id: I46e09f1833bb55634e09d7cc110684cc837ac619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183000 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2025-03-14Fix typoAndrea Gelmini
Change-Id: I87849a595bfaef20cbb06e683b012f35fe628119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182912 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2025-03-13Move SingleSelectQueryComposer.java tests to C++Adam Seskunas
Move the tests to SingleSelectQueryComposer_test.cxx Remove the old SingleSelectQueryComposer JUnit tests/file Add makefile for SingleSelectQueryComposer_test Remove the java test from JunitTest_dbaccess_complex.mk Add the CppUnit test to the Module_dbaccess.mk file to be run only when Java is enabled on the test machine Change-Id: I832c80e294be6cd4dced4d358bcee383ea04b0fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182759 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-03-07use more concrete UNO in dbaccessNoel Grandin
Change-Id: I46188654135721d21dd05ac2778224a078e96293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182623 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-05improve type-safety in dbaccess::OConnectionNoel Grandin
Change-Id: I39ebd277431407b65c5c4a80698714399d39330f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182531 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-05improve type-safety in dbaccess::ORowSetNoel Grandin
Change-Id: I08ae1369a7b1e388bc6eeaed86587261ffb83943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-04improve type-safety in dbaccess OStatementBaseNoel Grandin
we can use unotools::WeakReference instead of untyped WeakReferenceHelper. Also rename the field to something more obvious Change-Id: Iff674893ec0c3144830c46d1745c920f910d6067 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182458 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-03expand the ObjectType typedefNoel Grandin
in preparation for making some of the code more typesafe Change-Id: I7c8a4b30cd1144feaaa2e31fce67cd6545065a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182425 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-03Missing test dependencyStephan Bergmann
> [_RUN_____] CRMDBTest::testCRMDatabase [...] > java.lang.ClassNotFoundException: org.hsqldb.jdbcDriver > at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:349) > at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:557) > at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:490) > unknown:0:CRMDBTest::testCRMDatabase > An uncaught UNO exception > - com.sun.star.sdbc.SQLException: {Message: "The driver class “org.hsqldb.jdbcDriver” could not be loaded.The additional driver class path is “vnd.sun.star.expand:$LO_JAVA_DIR/hsqldb.jar vnd.sun.star.expand:$LO_JAVA_DIR/sdbc_hsqldb.jar”. at /home/sberg/lo/core/connectivity/source/drivers/jdbc/JConnection.cxx:674", Context: @0x7b373fdfdb70, SQLState: "", ErrorCode: 1000, NextException: com.sun.star.sdbc.SQLException: {Message: "org.hsqldb.jdbcDriver at /home/sberg/lo/core/connectivity/source/drivers/jdbc/Object.cxx:185", Context: @0x7b373fd19b70, SQLState: "", ErrorCode: -1, NextException: void: void}} Change-Id: I4aeadfcf2a5c82eea4bf1fd646bceba4e8da5f4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182422 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2025-02-28dbaccess: fix typoXisco Fauli
Change-Id: Ibdac76ba3346fc623a04345550d6ffd83a3ff77d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182362 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-02-28CppunitTest_dbaccess_migration: Unify into 1 placeXisco Fauli
and use setUp and tearDown to enable/disable the experimental mode Change-Id: I922bc289179528d1fc1df1a3545315ec92489afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182355 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-02-26use more concrete UNO types in some local varsNoel Grandin
found by a little plugin I created. Plugin parked into store/ folder because it needs hand-holding when run. Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-26loplugin:unusedenumconstantsNoel Grandin
Change-Id: Ic5dee6225be56385a1ed4a8674dadba9a453dcb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182204 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-13Fix typoAndrea Gelmini
Change-Id: I469c85a564707cf50e5730bcac345d1879694919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181612 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2025-02-13Change the unparseable query to parse ODBC escape queryAdam Seskunas
dbaccess/qa/connectivity/tools/CRMDatabase.java - remove unparseable query dbaccess/qa/unit/dbtest_base.cxx - Add the ODBC escape query dbacces/qa/unit/CRMDatabase_test.cxx - Add test The unparseable query has been commented out for a number of years in the CRMDatabase.java. At some point, this query has become parseable so this commit removes the old commented out Java query, moves the it to C++ and adds a CPPUNIT test for the queries parseability. Change-Id: Ie4d700458bc6dfd52cd87aec75ec202dd12248ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181142 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-20remove code duplication - conversion hex char to valueTomaž Vajngerl
We use the same funciton all over the place, so create a common function in o3tl and use that in all instances where we duplicated the code. Change-Id: I74091fbbde8c2ba8c7e4ab30194ab53e2a338e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180372 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-14Port Query.java test to CppUnitAdam Seskunas
dbaccess/qa/unit/CRMDatabase_test.cxx add test dbaccess/qa/complex/dbaccess remove Query.java dbaccess/JunitTest_dbaccess_complex.mk remove test call Change-Id: If21863de1fa4db738e3d51f93a3c7ca19130bb1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177278 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-10ITEM: Refactor ItemTypeArmin Le Grand (Collabora)
ItemType is useful and faster than RTTI. Until now it was implemented by a 16-bit member in the base class, plus (potentially) all constructors having to hand a value in at item construction type (of type SfxItemType) to get that member set correctly. This works, but there is no reliable way to guarantee coverage, and there have already been cases with missing SfxItemType - these fallback to '0' and thus all Items with ItemType() == 0 are assumed equal and might be static_cast'ed to the wrong classes. Note that I identified *35* Items that had no correct ItemType set/implemented actually. It also uses 16-bit per incarnated Item at runtime. I thought and realized now a more systematic approach to do that with a pure virtual function at the Item itself. That can also be secured by a clang compiler plugin in the future to keep it working. It uses one virtual function per derived class, no longer space in incarnated Items. Also the constructors will get more simple again. But the main aspect is security - we cannot afford Items potentially being held as equal if they are not. Unfortunately C++ does not offer something like a 'strict pure virtual function' that would force to be overloaded in every derivation, but the used methotology and adding a clang test is reasonably safe. Have now done the cleanup of previous method. Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-12-18Resolves tdf#140298 - SQL dialog must not become oversizedHeiko Tietze
SQL history becomes quickly too large for the dropdown control The patch sets a fixed width so this control wont take over the dialog size. Change-Id: I106ae19dfd505388e5b528becbc06e9d6110d45d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178702 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-12-13a11y: Move VCLXAccessibleComponent from toolkit to vclMichael Weghorn
After commit 168512dce7f1f1453c045584d47bd78a0a6c73f7 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Dec 12 18:06:13 2024 +0100 a11y: Stop using VCLXWindow in vcl a11y classes and further related commits, VCLXAccessibleComponent no longer depends on anything in the toolkit module, so move it from there to vcl. This way, subclassing VCLXAccessibleComponent (as the a11y classes for vcl widgets do, currently located in accessibility/ ) no longer introduces a toolkit dependency. Change-Id: I4fd33fb1dc2265d75e8ca9ad87bcc70db61639d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178434 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-13Avoid a warning shown since bumping Windows baselineMike Kaganski
This is shown now, since commit b664c08a6d1096d279437c883e55735a0c431ac8 (Drop support for Windows versions prior to Windows 10, 2024-12-07): Change your target platform to Windows 7 or below if your application requires backward compatibility for the ADO interface. Change-Id: Ic95a0819440b958cc3e01bbc2ffe91d7495bb8fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-13tdf#144694 In direct SQL dialog, activate options 'Run SQL commandIlmari Lauhakangas
directly' and 'Show output of "select" statements' by default. Change-Id: I7708259ccbe8b81b6c0ef9d6bc10c5c2c9933194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178405 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-12a11y: Stop using VCLXWindow in vcl a11y classesMichael Weghorn
Adjust VCLXAccessibleComponent and subclasses to take a vcl::Window arg instead of a VCLXWindow in the ctor and drop the VCLXAccessibleComponent::m_xVCLXWindow member that used to hold a reference to the VCLXWindow. (VCLXAccessibleComponent still holds a VclPtr to the corresponding vcl::Window.) Instead of passing the UNO/toolkit peer (VCLXWindow and subclasses) to the AccessibleFactory to create an XAccessibleContext context for the underlying VCL widget, pass the underlying vcl widget, which can now be passed as is to the corresponding ctors of VCLXAccessibleComponent and specialized subclasses. This follows earlier commits replacing the use of the VCLXWindow classes by direct uses of the vcl::Window subclasses inside VCLXAccessibleComponent and subclasses and is the next step in reducing the UNO/toolkit dependency in the accessibility implementation for vcl widgets. For now, the logic where those accessible objects are created remains in VCLXWindow::CreateAccessibleContext and overrides, but that can change in the future. `IAccessibleFactory::createAccessibleContext(VCLXMultiLineEdit*)` is just dropped and doesn't need its own replacement: The previous VCLXMultiLineEdit variant was creating a VCLXAccessibleEdit like the variant taking a VCLXEdit, but VCLXMultiLineEdit doesn't subclass VCLXEdit. The vcl MultiLineEdit however subclasses Edit, so VCLXMultiLineEdit::CreateAccessibleContext can make use of `IAccessibleFactory::createAccessibleContext(Edit*)` as well now. This also implements what was mentioned in earlier commit Change-Id: I67bb7a6a237e57d0c522790c09a595c02ac06325 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Dec 12 17:16:29 2024 +0100 sw annotation win a11y: Skip VCLXWindow logic : > Drop the comment about the code being dodgy from > SwAnnotationWin::CreateAccessible. This commit partially > addresses it and switching VCLXAccessibleComponent > to using the vcl::Window will take care of the rest, > see upcoming commit > Change-Id If0894e733273eecad268c6a932ecee7c2e34b4c2 > ("a11y: Stop using VCLXWindow in vcl a11y classes"). Now that the VCLXAccessibleComponent ctor takes a vcl::Window, the sw::annotation::SwAnnotationWin can be passed directly. From a user perspective, no change in behavior is intended by this commit. Change-Id: If0894e733273eecad268c6a932ecee7c2e34b4c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178385 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-07weld: Rename weld::Treeview selection signal/connectMichael Weghorn
Rename weld::TreeView member + methods to clarify that these are about selection changes: * m_aChangeHdl to m_aSelectionChangedHdl, * signal_changed to signal_selection_changed * connect_changed to connect_selection_changed In GtkInstanceTreeview, also rename the related methods calling signal_selection_changed accordingly for consistency. Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-02tdf#120658 - Reworking of dialogues Organize macrosJim Raykowski
(make from 5 existing only one) Much of what makes up this patch is adapted from existing code that is used to organize and select macros and to assign macros to shortcut keys. Comments in the patch say where code is borrowed from. Known issues: + Scripting framework library rename for BeanShell, Java, and JavaScript always returns fail when there are no macro entries in the library even though it actually succeeds. The same thing happens using SvxScriptOrgDialog::renameEntry. + Deleting Basic macros from the Macro Manager dialog is not implemented yet. Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-01cid#1606986 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556101 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE Change-Id: Ibabd8fd59a5435b8ab6c33d78c1303e5e1bdfd9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177609 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29tdf#158237 dbaccess: use c++20 contains() instead of find() and end()Bogdan Buzea
Change-Id: I03e682093bff3b743b074d0d1dc68994f31ae707 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176800 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-27weld: Rename weld::Dialog::{widget -> button}_for_responseMichael Weghorn
Rename weld::Dialog::widget_for_response to weld::Dialog_button_for_response as it specifically returns a weld::Button, not a generic weld::Widget (other than GTK's `gtk_dialog_get_widget_for_response` [1] which returns a GtkWidget). [1] https://docs.gtk.org/gtk3/method.Dialog.get_widget_for_response.html Change-Id: I3b1dc34c0af752853551d2ebb706109f2214720d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177376 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-27weld: Return unique_ptr in weld::Dialog::widget_for_responseMichael Weghorn
... to make more obvious from the API that the caller owns the returned weld::Button* (but not the underlying toolkit widget). Change-Id: I64f57f80e4eea4c2c984fa7b615b5a2350ed892a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177375 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-24Let ESelection use EPaM for simplificationMike Kaganski
And drop EPosition, which duplicates EPaM, except for its default ctor (used in a single place). Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23Avoid new string allocations, when only checking if emptyMike Kaganski
Change-Id: I35a44dedd27b5c3470ed035e64ec0461d8d0cbdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177074 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23Use specific SvtModuleOptions::Is*Installed for clarityMike Kaganski
Change-Id: Ibe64b9fcccf33471d96bb0fb1aa896cb456657f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177069 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-19improve loplugin passparamsbyrefNoel Grandin
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-18dbaccess/qa - Seperate database connection so it can be reusedAdam Seskunas
Change-Id: I982cf589aff159149190c7f0f78dc8085a700240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174981 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-15tdf#130564: getTableTypes retrieves only table types of the current databaseJulien Nabet
So indicate to LO that at least PostgreSQL and MySQL/MariaDB support views Change-Id: I241fa3cfc599e11c1f1523a78a1905beadc80307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176308 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-14Give DocumentEventHolder (aka EventHolder<DocumentEvent>) a key functionStephan Bergmann
...that is not inline, so that RTTI and vtable are not emitted for each dynamic library individually. (Where they would be internal on macOS, which could break optimized uses of dynamic_cast for that final class just checking vtable pointer identity, as could happen for the dynamic_cast at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:232:51, > 232 | const DocumentEventHolder& rEventHolder = dynamic_cast< const DocumentEventHolder& >( _rEvent ); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ And with the extern explicit template instantiation, EventHolder needs to be SAL_DLLPUBLIC_TEMPLATE instead of just SAL_DLLPUBLIC_RTTI now, so that Library_comphelper will export the DocumentEventHolder ctors and DocumentEventHolder::getEventObject.) (This would ideally have been caught by an upcoming improvement of loplugin:dyncastvisibility, but might be complicated to check there for template instantiations.) Change-Id: I1e6280b185535968a870fbfadaff6238d38858e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176547 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-11-13new loplugin:reftotempNoel Grandin
look for places where we are taking a reference (i.e. "&") to a temporary object, which is misleading. Change-Id: Id0eb4dce3f1ca559f86e02edcbea3ca17bea8e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175978 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-12tdf#145614 Convert #define to enum classOromidayo Owolabi
Converted #define to enum class Change-Id: I16195a439643bcf0111c591a829272b5bf70179d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175027 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in dbaccessNoel Grandin
Change-Id: If72f9eea59e5f2a4e183b98888a037ea26333cb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176377 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-10com::sun::star -> cssMike Kaganski
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-05-06 17:55:58 +0000