summaryrefslogtreecommitdiff
path: root/desktop/inc
AgeCommit message (Collapse)Author
2017-01-02tdf#95416 Get rid of #include ../foo/bar.hxx style includesGaurav Dhingra
Change-Id: I9b05c261faebd3e0e5d65ca524a4379c1d5918f1 Reviewed-on: https://gerrit.libreoffice.org/32419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-21tdf#95416 Fix an include for 2 files in unopkgHuzaifa Iftikhar
Change-Id: Id1fa09b6db6c90cd727182133e5f9f39383aa5e5 Reviewed-on: https://gerrit.libreoffice.org/32255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-20tdf#95416 Fix an include for desktop directoryHuzaifa Iftikhar
Change-Id: I04a2181b05f2b15a55db306f49b47855db7753db Reviewed-on: https://gerrit.libreoffice.org/32204 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2016-11-09loplugin:expandablemethods in dbaccessNoel Grandin
Change-Id: I6087a3eff46926646ac1637615a0af30b38956a4 Reviewed-on: https://gerrit.libreoffice.org/30712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-06drop unused STD_MASKCOLOR definesCaolán McNamara
Change-Id: I9e6d499788467e5215464cf8f5146721b847909c
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-10LOK: new callback dropping implementationMarco Cecchetti
Now view callbacks have their own collection of last states where the key is made up by both the view id and the callback type. Callback dropping based on the last state is no more handled on queueing but on flushing, since what really matters is the last performed callback (for each callback type). Anyway in order to not modify the order of callbacks, that could be changed when an already queued callback is superseeded, dropping still occurs on queuing too, just by looking for the last queued callback of the same type. The result is a substantial reduction of redundant callbacks and fix the following problem in loleaflet: when there are more views for a speadsheet and cell cursors for two view are placed on the same cell, a continuos swapping between the two cell cursors can occur. That was due to a sequence of "EMPTY" and coordinates messages or cell cursor and cell view cursor messages which were sent in an alternating way. Change-Id: I79e14d11d4e8590aff715181e3410ad88c4e6175 Reviewed-on: https://gerrit.libreoffice.org/28783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-09-10LOK: tidy up `CallbackFlushHandler::queue`, improved cell view cursorMarco Cecchetti
Rewritten the switch statement in `CallbackFlushHandler::queue`: - Now, the new callback data is emplaced after removing all states overridden by the new one. - View callbacks are checked not only for the same type but even for the same view id: that allowed to fix the following issue: starting from the 3rd view for a spreadsheet it could occur that only the cell cursor of the previous last view was displayed in the new view. Change-Id: I2b63526deb4dca39e3a1f430443ebc5d0f61938d Reviewed-on: https://gerrit.libreoffice.org/28782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-08-31LOK: queue-up events while processing client callsAshod Nakashian
To prevent feedback effects and improve performance, we now queue up events fired during the processing of a client call on the LOK API. This has the advantage of giving us a chance to compress redundant events and to combine others (where possible) into fewer ones. Change-Id: I2f6ea12c5d85205e6495cb130f6a6262534b6bb2 Reviewed-on: https://gerrit.libreoffice.org/28311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-07-12desktop: validate OpenCL drivers before use.Michael Meeks
OpenCL validation needs to happen before drivers are used in anger. This should isolate any crashes, and/or mis-behavior to We use app version, CL driver version and file time-stamp to trigger re-testing the device. If anything fails: hard disable OpenCL. We use an opencl validation sheet (cl-test.ods) and install it. It is a minimal CL set - it requires a very short formula group length, and combines several CL functions into few formulae to test more. The sheet structure, in particular the manual squaring / SQRT is necessary to stick within the default CL subset, and ensure that formulae are CL enabled from the root of the dependency tree up. Change-Id: I18682dbdf9a8ba9c16d52bad4447e9acce97f0a3 Reviewed-on: https://gerrit.libreoffice.org/27131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-06-16sw lok: move filtering of callbacks during paint to desktopMiklos Vajna
This will be important when in the per-view case SwViewShell::libreOfficeKitCallback() won't be called anymore; as pointed out by online.git's TileCacheTests::testSimpleCombine() test. Change-Id: Ie68f8c51facdba127763df660e9220f820805ecc Reviewed-on: https://gerrit.libreoffice.org/26372 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09desktop lok: implement per-view CallbackFlushHandlerMiklos Vajna
With this, per-view cursor callbacks work again, as they did after commit 32f419fee5f9df4facb7a9b3ec910471d2a20247 (sw: implement per-view LOK_CALLBACK_CURSOR_VISIBLE, 2015-09-18). Change-Id: Ic589276f99164a1a8d46f7a029d1a59ab6e971f3 Reviewed-on: https://gerrit.libreoffice.org/26102 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09desktop lok: move CallbackFlushHandler impl details out of headerMiklos Vajna
To reduce the amount of rebuilt code when changing something there. Change-Id: I8f3c18c29d5c08d70910ee2b204cafb99d6b4011 Reviewed-on: https://gerrit.libreoffice.org/26088 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-29bccu#1781: Impress/Comments - selection not updated on deleteAshod Nakashian
Change-Id: I694d76785fcf6ec9c158c34cbe07f4d1f2c7a41d Reviewed-on: https://gerrit.libreoffice.org/25219 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b95e4e8681c9cefb4e1d4177192164e041baf9d9) Reviewed-on: https://gerrit.libreoffice.org/25428 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: don't filter cursor visibility during paintingAshod Nakashian
Change-Id: Ia44ffe08dc8f46e0d10a73db374a283eb032f771 Reviewed-on: https://gerrit.libreoffice.org/25120 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit f805637353e4463d5b64f1b010bb580e191bd3aa) Reviewed-on: https://gerrit.libreoffice.org/25427 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: improved event handling and fixesAshod Nakashian
During painting, when notifications are disabled, we could still receive notifications that are imporatant and cannot be suppressed. So certain events are let through during painting. A comment describes this better in the code. Some widgets (notably postit/comment control) emits events in relative (local) coordinates instead of absolute. This is patched in many cases but some cases still exist that are rather hard to patch due to the complex interaction with other parts of the code. These supurious local coordinate updates (notably cursor invalidation) are supressed to avoid the bad side-effects they cause in LOOL. Change-Id: Ie22a316d54ea163c6976ed04314d6ced8247824c Reviewed-on: https://gerrit.libreoffice.org/25013 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b5c2a3fdbbf4161b0699ba515f63f98d7607ddf2) Reviewed-on: https://gerrit.libreoffice.org/25424 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-13convert EXCEPTION_ to scoped enumNoel Grandin
- simplify VCLExceptionSignal_impl - drop "minor" part of error code, nobody passes it in, and nobody checks it - rename Display to UserInterface, to prevent -Werror=shadow Change-Id: I503fd8a50ded30d59c30fb388796f6b1a0c058de Reviewed-on: https://gerrit.libreoffice.org/24892 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09LOK: drop identical invalidation notificationsAshod Nakashian
And drop duplicate GRAPHIC_SELECTION notifications. (cherry picked from commit 7cdfe080432f69c2247cc7ff28316b653bd654ff) Change-Id: I0c372efa9a58620e24cea219d82479cdc9dff359 Reviewed-on: https://gerrit.libreoffice.org/24771 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09LOK: SAL_WARN for each removed event is unnecessaryAshod Nakashian
Change-Id: If5e4c7b8751ae4eeb278475fb00118e32c6bb565 Reviewed-on: https://gerrit.libreoffice.org/24730 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09Allow painting for arbitrary partAshod Nakashian
Painting should not cause any state changes, but to paint a tile on a different part than the current has to change the document, which sends notifications to all clients. A new API, paintPartTile, allows for painting tiles on any part without sending change of part notifications. Furthermore, because we block notifications during this operation, no tile invalidation is issued due to changing of the part. One issue remains in the cases when the LO Core resets the cursor position internally and we resume editing after painting, the cursor might be at the top of the page. This needs fixing separately. Change-Id: If19bd1c90ecad4d5ed5e8d09513741b7994fa6e5 Reviewed-on: https://gerrit.libreoffice.org/24698 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09Some LOK notifications are dropped if they are superseeded by later onesAshod Nakashian
Change-Id: I323e46a2a6c60b200b182b89199945f99a7f384a Reviewed-on: https://gerrit.libreoffice.org/24567 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit cf98799fff7ae999bd62cec6486c986bf44000cc)
2016-05-09std::tuple -> std::pairAshod Nakashian
Change-Id: I2f11436a5c9691c2a0aac3655bc2c543d1c3d684 Reviewed-on: https://gerrit.libreoffice.org/24566 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 8a6dab5da851f38a8ecef633e06e3cb2ac5e7849)
2016-05-09More LOK callback notification compressionAshod Nakashian
SET_PART, CELL_CURSOR, CELL_FORMULA, and CURSOR_VISIBLE are now deduplicated. Change-Id: I4c17307c6f8b7c68bdfe55b4e90da4d34c55d085 Reviewed-on: https://gerrit.libreoffice.org/24565 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit a9771e1f4d0d2602713983ab1f3e743784e9ae72)
2016-05-09Desktop compresses text selection start/end notificationsAshod Nakashian
Change-Id: Ia85ded04d0eaf9d9b846fab6d86a44a758fccb69 Reviewed-on: https://gerrit.libreoffice.org/24320 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 45037438d84485356a5ceb820ecc3e0bae4b112e) Reviewed-on: https://gerrit.libreoffice.org/24380 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-08Desktop compresses mouse pointer notificationsAshod Nakashian
Change-Id: Id76f4e2952c4c551b626d094c11eb3339d76e50c Reviewed-on: https://gerrit.libreoffice.org/24319 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 7c01cf652850a8b8d3fd5ef6eb0a12ca6e725943) Reviewed-on: https://gerrit.libreoffice.org/24379 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-08loplugin:redundantcastTor Lillqvist
Reinterpret_cast from 'void *' to 'desktop::CallbackFlushHandler *' can be simplified to static_cast. Change-Id: I648e91d0ca234162833f19595ae60838f81963bc
2016-05-07New LOKDocument callback queue to flush events lazily on idleAshod Nakashian
Since desktop now queues up callback notifications and flushes them to the client on idle, the unit-tests must yield and process all tasks before they validate post-conditions. (cherry picked from commit e6a429770bde5da75239961ae88c06c78cfa5686) (cherry picked from commit 1f278848117080cd6e819f04ba428be52416af7c) (cherry picked from commit 6ca6f22777eb3651109cbf403577d0022a735c9b) (cherry picked from commit 548faf728cf097d93c3f6478ceea5f8747e789c6) Change-Id: I78307db29a9ce647ffaed3539f953227c605968e Reviewed-on: https://gerrit.libreoffice.org/24377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-29Remove undocumented perftune.ini QuickstartPreloadConfigurationStephan Bergmann
...originally added to OOo in 2005 with 8a9d865b32b760804adf53b0d68fd74785890915 "INTEGRATION: CWS cov2src: #126234# Join MWS COV680 m4 into SRC680". Change-Id: I7167c99e28b56c9048de32576e793e2eaa1fc6a6
2016-02-25add way to add additional information to the crash reportMarkus Mohrhard
We can add several additional key value pairs during the execution of the program that will be used on the server to show more information. Change-Id: I4102adc15fc821415fa0b997ca7fe0dc4f7abcec Reviewed-on: https://gerrit.libreoffice.org/22553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-08vcl: cmdevt.[hc]xx -> commandevent.[hc]xxChris Sherlock
Change-Id: I77b30f28ae5a6fad360d7cada9acfaa9c324408b Reviewed-on: https://gerrit.libreoffice.org/22216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-06vcl: split exception types from input typesChris Sherlock
Having them in the file apptypes.hxx isn't necessary helpful, IMO so I've split the types into inputtypes.hxx and exceptiontypes.hxx Change-Id: I89a1ff168c3ae276b2f5486669d4ec2dda062d57
2016-02-03desktop: replace boost::bind with lambda or std::bindMichael Stahl
This requires working around MSVC 2013 error C3848, that compiler apparently just doesn't like to call its std::bind() functions if they're "const". Change-Id: Ic2e66cab3cadb36ab29cf2504a4c6107334f2ae1
2016-02-02boost::hash->std::hashNoel Grandin
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-27libreofficekit: password interaction optional and off by defaultMichael Stahl
Add setOptionalFeatures() function that clients must call during initialization, and enum LibreOfficeKitOptionalFeatures. Change-Id: I73035193c87033052921c3aad94fdc057fe81111 Reviewed-on: https://gerrit.libreoffice.org/21809 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-01-25libreofficekit: ask for password when loading encrypted documentsMichael Stahl
Change-Id: I3b3b0c0e64965280c24842b0cf70a21b8abb4dfb
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-11No need for a separate <vcl/graph.h>Tor Lillqvist
Change-Id: I962544005b5d408f7c044a02eefe09b87d8a81fe
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-03lok: Introduce LOK_CALLBACK_UNO_COMMAND_RESULT callback.Jan Holesovsky
Posting of the .uno:Something commands is asynchronous. To be able to find out when eg. .uno:Save finished, this commit introduces a callback that fires when that happens. To be able to receive such a notification, the appropriate postUnoCommand() must be called with 'true' as the parameter for bNotifyWhenFinished (defaults to 'false'). Change-Id: I254939ebc8ea5f309ae39686dcaaeddd5148b0c9
2015-11-02afl-eventtesting: can simplify this now we use QueryExitCaolán McNamara
Change-Id: Iddb96f51ed2fd2d7861e9448a7aa221d998ad2a5
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-09loplugin:staticmethodsStephan Bergmann
Change-Id: Ice121a65e38d47b4a26f7ed81fc3037e031ae7c4
2015-10-09afl-eventtesting: provide a way to pseudo-restartCaolán McNamara
i.e. to reset to the initial post-startup state performance still isn't great unfortunately, 0.7 cycles per second before this, 2.6 after this Change-Id: Ib9d83b70f0cf052af36a49ed5bacef295fe9ed11 Reviewed-on: https://gerrit.libreoffice.org/19269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-25tdf#94228 comphelper: replace BOOST_PPDaniel Robertson
Remove makeSequence. Change-Id: If07dc8702d811111fc634c9c7eb4c9a331517ca5 Reviewed-on: https://gerrit.libreoffice.org/18647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-25desktop: make LibLibreOffice_Impl visible to testcasesMiklos Vajna
Change-Id: I345a6cab57cc594614e348700bb3c1c9a0673989
2015-09-24desktop: missing header guardMiklos Vajna
Change-Id: Ibae1de013712e55930559b138aa07c15b590baea
2015-09-23desktop: avoid 'using' in headersMiklos Vajna
Change-Id: I9517a982daa48a6eb848360dee7739d15d42a971
generated by cgit (git 2.34.1) at 2025-01-15 16:52:46 +0000