summaryrefslogtreecommitdiff
path: root/desktop/source
AgeCommit message (Collapse)Author
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): desktopStephan Bergmann
Change-Id: Ieefdb08d6b92a0d70ecd9188f318e1738d61d803 Reviewed-on: https://gerrit.libreoffice.org/76685 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-30sfx2: Enable sidebar on calc and writer, but not in impressAshod Nakashian
Added by Noel to this commit: And add a special deregister mode to doc_registerCallback so we can unregister stack-based callback objects in the presence of multiple views. Reviewed-on: https://gerrit.libreoffice.org/71715 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit fba6d4267b3f827269d6550dcb003cc56b31e493) Change-Id: I8d846bc1f794cf16fd45486fd83ef87f43fd52c7 Reviewed-on: https://gerrit.libreoffice.org/76555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29sfx2: Re-enable the sidebars for LOKAshod Nakashian
This re-enables the sidebars for LOK, which were disabled to avoid overheads. Also, fixes a regression where editing stopped when loading a new view because the sidebar window creation killed the edit view. Revert "Avoid various desktop GUI elements when used from LibreOfficeKit" This reverts commit c0b70ec34d5e056bb92a66cbf83838923cb41fee. Also (added by Noel to the above commit) (1) Comment out parts DesktopLOKTest::testPaintPartTile test that trigger a crash. We are installing a callback that points to something on the stack, and then not removing that callback, resulting in calls to random stack memory. There is a further problem in the LOK code in that we cannot uninstall a callback when we have multiple views because the uninstall code in doc_registerCallback can only remove a callback for the __current__ view, which I do not fix here. (2) prevent code from accidentally creating empty entries in the mpCallbackFlushHandlers map, which is what happens when you use the index operator on map, which results in a crash in doc_registerCallback because the std::shared_ptr is empty. (3) In SdTiledRenderingTest, only turn off LOK via LibreOfficeKit::setActive(false) once the document has been torn down. Otherwise, we don't remove entries from the statically allocated s_pLOKWindowsMap map in vcl/source/window/window.cxx, which means that at process exit, we have dangling Window objects. Reviewed-on: https://gerrit.libreoffice.org/71165 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 88565c3662c6fde240c98a9b4f2ce6dfbcf4094e) Change-Id: I06b06a990f05c06b1889fa89b698dff6f494e09c Reviewed-on: https://gerrit.libreoffice.org/76466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25Fix typosAndrea Gelmini
Change-Id: I1efccb8b926e4aa10e9ccee7e8e36919e38c05fc Reviewed-on: https://gerrit.libreoffice.org/76339 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-25LOK: support resizing windowsAshod Nakashian
And delegate resizing of floating windows. Currently used for resizing sidebars in LOK. Change-Id: Iadc1b71c15a7d16a8c9dd7246490ae6bd645644c Reviewed-on: https://gerrit.libreoffice.org/73509 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: Do not offset window coordinates in LOKAshod Nakashian
This fixes the issue with selecting the incorrect color when clicking on the color presets in the color picker window in LOK. Because the window coordinates are shifted in Core, and LOK client sends in absolute coordinates, the shift causes a different color to be selected. (cherry picked from commit 171a2300d37d73065e5e3bd4b77678e35f678adf) Change-Id: Ib818b83c0f0c727944068cb244f8d10666e5bc1d Reviewed-on: https://gerrit.libreoffice.org/76323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: Reduce and improve logging of event compressionAshod Nakashian
Change-Id: I84e0e8806eb6f4fbda063ebc29fafa791d472bb8 (cherry picked from commit d5b900630caefc4d3b62a31906117cf4acd623b1) Reviewed-on: https://gerrit.libreoffice.org/76322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: Minor window event processing cleanupAshod Nakashian
This reduces the number of json reads we do when compressing window events, which happens quite often. (cherry picked from commit 0bb310d7ce39421ecc4ff90518ffdf6aa01d1b02) Change-Id: I1c85f28867b52cad85445fff8a031b990dad8b56 Reviewed-on: https://gerrit.libreoffice.org/76321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: Refactor large event queueing casesAshod Nakashian
This makes it more readable and reduces indentations. No functional change intended. (cherry picked from commit 570a3c5361d58635e4d0ac8baf6df787bd2290ad) Change-Id: I129ecff9083c459d633c0965eab6e06ba3dcf499 Reviewed-on: https://gerrit.libreoffice.org/76320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: Remove window invalidations prior to size_changedAshod Nakashian
A window size change is a full invalidation anyway, so remove any prior invalidations as they are redundant. Change-Id: I439a1bc38989df17b671e064beb26eb88c402be3 (cherry picked from commit 1a5af070d876b1ec4b69fe3be732426dba59b9af) Reviewed-on: https://gerrit.libreoffice.org/76319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: Window creation supersedes any events on same windowAshod Nakashian
This happens when we get multiple created events on same window, interspersed with invalidations. Change-Id: I2dbaa0f84306d770f1de047a23996209c28304fe Reviewed-on: https://gerrit.libreoffice.org/76312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: Reduce logging while processing eventsAshod Nakashian
Change-Id: I8ca457387715fcd085bcbf3107839d2629580f7b Reviewed-on: https://gerrit.libreoffice.org/76296 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25LOK: remove duplicate cursor invalidations for same view onlyAshod Nakashian
This limits duplicate cursor invalidation removal to same view only, which seems to have been left in error. We should now remove any old cursor invalidations (for the same view) and only keep the latest (current) one. Change-Id: Ie2323d0c5fcf3977576a1bdc098c95351a5753e0 Reviewed-on: https://gerrit.libreoffice.org/71846 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 8e9c36dfc346387abfbbaefbc15a518cbe3e257c) Reviewed-on: https://gerrit.libreoffice.org/76286 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25tdf#119228 Add storage and serialisation for the Resolved flagScott Clarke
Change-Id: I0278588dc533378104e544d05b60583c85271f6a Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75858 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-25LOK: trace queue only when it is changedAshod Nakashian
Change-Id: I9b8e060c2c7655565b95004d82bf50ada2ed0d08 Reviewed-on: https://gerrit.libreoffice.org/71845 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76267 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24sd lok: Remove the .uno:LeftPaneImpress call from sd lok initialization.Noel Grandin
this is combination of commit dd15e149326f5270ab9ceb5f21e32b25b96c0a44 Author: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Date: Sun Nov 11 23:37:24 2018 -0500 LOK: sd: initialize slide-sorter in sd (Change-Id: I4cb6ce6d961b4ba4d542c14cb37370788cf75e45) and commit 7e291eedbad335bf8bbc8a17cc3d633bf66d0e90 Author: Jan Holesovsky <kendy@collabora.com> Date: Thu Apr 25 05:54:15 2019 +0200 (Change-Id: I86b23b484674ad4c6a75246ee6186ad9b828931f) sd lok: Remove the .uno:LeftPaneImpress call from sd lok initialization. According to my testing, this makes no difference and the moving of slides and multiple selection behaves the same way with or without this. So let's return to not activating the SlideSorterBar, because otherwise we are doing a lot of pixel bashing behind the scenes unnecessarily. Having said that, if we want to activate it at some stage, it is better to do something like the following (+ remove the explicit LOK-only if's from svtools/source/config/slidesorterbaropt.cxx): SvtSlideSorterBarOptions().SetVisibleImpressView(true); instead (and potentially we can also make it floating not to occupy the space in the main view by GetWindow()->SetFloatingMode(true); in the LOK case in sd/source/ui/dlg/PaneChildWindows.cxxi). Change-Id: I719bc4ca5e43fce9949d494149b65ffd8587c601 Reviewed-on: https://gerrit.libreoffice.org/76220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24Redundant conditionMike Kaganski
Change-Id: I1c67cde8401106a7e9d7ecd5fd3e0b4925ab47d4 Reviewed-on: https://gerrit.libreoffice.org/76212 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-24Drop unneeded initializationMike Kaganski
Change-Id: Ieac1a0acb97664f3b86e2524cab79fd278f42e0e Reviewed-on: https://gerrit.libreoffice.org/76210 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-23Don't draw gridlines and document background in Online server processMike Kaganski
... see https://gerrit.libreoffice.org/72417 They will be drawn client-side. Borders and explicit cell background are still drawn in core. This mode is activated using "sc_no_grid_bg" option in SAL_LOK_OPTIONS environment variable. Change-Id: Ie10e7770b8168ec648d44ae5af0a0a0602d89ee6 Reviewed-on: https://gerrit.libreoffice.org/75484 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-19loplugin:referencecasting in desktopNoel Grandin
Change-Id: I9ba4243bc3d6b14e66694728deb270ed74a70d01 Reviewed-on: https://gerrit.libreoffice.org/75949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448295 Unchecked return valueCaolán McNamara
Change-Id: I4b0dd4fc9051f04448a651cb87b449a58d2a5349 Reviewed-on: https://gerrit.libreoffice.org/75874 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448296 Unchecked return valueCaolán McNamara
Change-Id: I09268bc22f4fb34160975063e38ea60a68123400 Reviewed-on: https://gerrit.libreoffice.org/75875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448333 Unchecked return valueCaolán McNamara
Change-Id: If23db9a245b4dd4b59b9b5410a094f2f374eedfd Reviewed-on: https://gerrit.libreoffice.org/75878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17Resolves: tdf#126304 resizing the extension manager breaks redrawCaolán McNamara
Change-Id: I1211c90a72048f868ec7ba7a7b6bed452ae8ac4b Reviewed-on: https://gerrit.libreoffice.org/75791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17scrollbar is outside the widget now, not insideCaolán McNamara
Change-Id: Ia92658c7a534928209906b8adfb5f9451b513ff0 Reviewed-on: https://gerrit.libreoffice.org/75786 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17LOK: support for ordering/moving partsAshod Nakashian
Currently reordering of slides is only supported for presentations, although it is provisioned for spreadsheets as well. Change-Id: I6c35066d6a5ef7586d34a8e8b89db69a20b86572 Reviewed-on: https://gerrit.libreoffice.org/69612 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73495 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-16tdf#1448393 Uninitialized scalar fieldCaolán McNamara
Change-Id: I0df15244d6208f49d9bce2e27ff3deccfe98f981 Reviewed-on: https://gerrit.libreoffice.org/75697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-10slide-sorter: multiple selectionAshod Nakashian
Change-Id: I8624de25b0bb66020002890f33758e52059a24ab Reviewed-on: https://gerrit.libreoffice.org/69610 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73493 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-04vcl lok: pre-load graphic librariesMiklos Vajna
This is needed to be able to load e.g. TIFF files in Online, which does not have code in the chroot since online.git commit ad21717498cc214d5d5d5c0ff378238552137e2f (Avoid copying most code into the chroot jail., 2018-03-10). Change-Id: Ib095191ee690d9da6269878a82b1c6995df50dfa Reviewed-on: https://gerrit.libreoffice.org/75077 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-02tdf#125655 disbale quick edit mode for iOS and AndroidTomaž Vajngerl
When clicking (tapping) on text in text based objects (shape with text or a text frame), it automatically enters editing mode, which is not a desired behaviour in a touch based environment. This behaviour comes from a quick edit mode, which is enabled by default on the desktop. For Andorid and iOS this is now disabled when LOK is initialized. For online this change might also make sense (if the user would use a mobile device), however this is not implemented now as this would require more than just changing the global configuration, as it needs to behave differently depending on the view/user. Change-Id: Ib4a71cba0aeb4238a5d5b708801a07b39fb5f316 Reviewed-on: https://gerrit.libreoffice.org/74986 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-21simplify some getSupportedServiceNamesNoel Grandin
Change-Id: I81195505d6006b6587f7b98c1545919083f0e588 Reviewed-on: https://gerrit.libreoffice.org/74497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-20Demote from std::unique_lock to std::scoped_lock where applicableStephan Bergmann
Change-Id: I53a019f05978bab62ad0da3d0eb08f37f8ec1e18 Reviewed-on: https://gerrit.libreoffice.org/74414 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-17tdf#125691: use _exit() instead of exit()...Dennis Francis
for ExitTimer which is used exclusively for the case when OOO_EXIT_POST_STARTUP is set, so that there is no waiting around for ThreadPool's threads to get joined. Setting OOO_EXIT_POST_STARTUP already evades any proper destruction of objects in the heap, so using _exit() instead of exit() here does not make things any worse w.r.t the purpose of this env var. Change-Id: Ib4a253d6e1a3fd8593e4a2115a51cf4c10344b3c Reviewed-on: https://gerrit.libreoffice.org/74016 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-17android: Unregistering in runLoop() is important even on Android.Jan Holesovsky
Otherwise we get crashes in online Kit when attempting to shutdown reasonably cleanly and the poll kicks in. Change-Id: I9a1744b42fec9f8ffddc6094773bda943caedf2a Reviewed-on: https://gerrit.libreoffice.org/74064 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-15loplugin:logexceptionnicely in desktopNoel Grandin
Change-Id: I19f70b0e9d1ca2bbcd2595af24f2e15766d14b33 Reviewed-on: https://gerrit.libreoffice.org/74046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-14remove some unused includesCaolán McNamara
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14weld ExtMgrDialog and UpdateRequiredDialogCaolán McNamara
Change-Id: I97e5cda847fd7f98990a87d0b1ca6d6b8b3f9d0f Reviewed-on: https://gerrit.libreoffice.org/73899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13no need for awt::Toolkit::create in UpdateDialogCaolán McNamara
since... commit bb3daa7351f0b07e6f4331c19837081e6c3e30b8 Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Thu Oct 7 13:54:14 2010 +0200 dba34b: #i112779# no need to use a UNO control/peer for the throbber - it exists as VCL control now Change-Id: I561642d78d76ab970ee12b6b2b2fbdd0be2850e5 Reviewed-on: https://gerrit.libreoffice.org/73954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13drop intermediate IExtensionListBox classCaolán McNamara
Change-Id: I415645fd61113577deef404cceb02d72d541291d Reviewed-on: https://gerrit.libreoffice.org/73898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-12move IExtensionListBox to where its usedCaolán McNamara
Change-Id: I73401787032643c4881934864d2ec1e0389e2cf2 Reviewed-on: https://gerrit.libreoffice.org/73897 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-12LOK: set the language for LOK before document loadingAshod Nakashian
So default dialogs will be created in the correct language, as requested by the client. Change-Id: I12ebf7443b7f19e733f66b88b5fadfb01cd5e75e Reviewed-on: https://gerrit.libreoffice.org/68260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/73484 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-07lok: re-factor getTextSelection.Michael Meeks
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e Reviewed-on: https://gerrit.libreoffice.org/73626 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-07Bin the much too verbose SAL_INFO() calls for the "vcl.cg" tagTor Lillqvist
Quikee agreed that they aren't really useful. Doing even the simplest things causes such a huge amount of logging that it is questionable whether anybody could have any use of it. Parts of it might be useful to restore later, if need arises. Like the mnContextStackDepth logging in vcl/inc/quartz/CGHelpers.hxx. Change-Id: If635e6492a50e5955c56c54fa310e7c0ab2986ae Reviewed-on: https://gerrit.libreoffice.org/73639 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-06-06loplugin:data (macOS)Stephan Bergmann
Change-Id: I404a8364a4c7f8d48533fb3c7757a5b7798de9d8 Reviewed-on: https://gerrit.libreoffice.org/73588 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-05Use hasElements to check Sequence emptiness in cppcanvas..desktopArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: I81c0ff78d2ecc7d984e3ed5e5ce60efe327fc162 Reviewed-on: https://gerrit.libreoffice.org/71799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-03LOK: Factor out iOS painting codeTomaž Vajngerl
Change-Id: Ica706842003fe60ba864e013614eb535580446bb Reviewed-on: https://gerrit.libreoffice.org/73363 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-03tdf#123697 we need to create a bitmap context with alphaTomaž Vajngerl
Change-Id: Ib934314e56163983e70a0b04eb667e6b8527c783 Reviewed-on: https://gerrit.libreoffice.org/73362 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-02drop some unneeded includesCaolán McNamara
Change-Id: I13019ae1b991b5910c50e760a8a825bcf50509d2 Reviewed-on: https://gerrit.libreoffice.org/73321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28drop some unneeded includesCaolán McNamara
Change-Id: I42b2ccbb4484ab2acb8208ad88c6f22e4af09f7d Reviewed-on: https://gerrit.libreoffice.org/73114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-25 20:21:16 +0000