summaryrefslogtreecommitdiff
path: root/desktop/source
AgeCommit message (Collapse)Author
2018-04-16cppcheck: variableScope & unreadVariableMuhammet Kara
Change-Id: Iaa3adc54d547e243b977a562fa4dbc2b9b9c6592 Reviewed-on: https://gerrit.libreoffice.org/52905 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-04-15remove some unused comphelper includesJochen Nitschke
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-14Fix typosAndrea Gelmini
Change-Id: I9ea95f5b7b6cd056cc1aad146c8841877d187d55 Reviewed-on: https://gerrit.libreoffice.org/52742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-12lok: sc: clicking outside a pop-up or context menu doesn't close itMarco Cecchetti
Change-Id: Iecf0659467264d921c7c9faddc98fd5519e7db93 Reviewed-on: https://gerrit.libreoffice.org/52617 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 1cd76097043a5ece899dd7c9468755dcd961b0eb) Reviewed-on: https://gerrit.libreoffice.org/52736 Tested-by: Jenkins <ci@libreoffice.org>
2018-04-11weld RestartDialogCaolán McNamara
Change-Id: Iae97806a11b6c950931a342d06b3eeea168c7559 Reviewed-on: https://gerrit.libreoffice.org/52721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-10tdf#42949 Remove unnecessary localization headers from desktopGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<dp_shared.hxx\> -e \<strings.hrc\> desktop | xargs grep -c DpResId | grep :0$ | grep -v /pch Change-Id: I6608eb94c7572040ae20ce8a3926f3a522ee66bd Reviewed-on: https://gerrit.libreoffice.org/52593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-07sw lok: View jumps to cursor position even if it is moved by an other view.Tamás Zolnai
Scrolling is done twice. Once in SwCursorShell::UpdateCursor() by SCROLLWIN flag. Here we can check the actual viewid and avoid scrolling if the cursor is move by an other user. The second instance in the LO online code, for it we need to pass the viewid identifying the view which moved the cursor. Change-Id: I033274f88ce41acbb632e2aeb0d986ab11cd2d52 Reviewed-on: https://gerrit.libreoffice.org/52220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-06weld linkeditdialogCaolán McNamara
which enables changing FileDialogHelper over to welded Change-Id: I988342a6574cb7ed09b2724929e8c7117474a56c Reviewed-on: https://gerrit.libreoffice.org/52388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-06Resolves: tdf#116796 Ok -> OkCancelCaolán McNamara
Change-Id: Ib816862a462614a47045628ffe57358a4986149b Reviewed-on: https://gerrit.libreoffice.org/52477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-03lok - calc: add support for show/hide tabs in onlineMarco Cecchetti
Change-Id: Ibd061414a0c3a5fad83d03f7047831cef62076d2 Reviewed-on: https://gerrit.libreoffice.org/49083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-04-03lok: Make the bundled dictionaries work.Tamás Zolnai
Create the user directory temporary in the temp directory and use that to load the dictionaries (bundled extensions). Co-author; Jan Holesovsky <kendy@collabora.com> Change-Id: I5c7c824b68571048ce870fd5218cb47a333f3ad8 Reviewed-on: https://gerrit.libreoffice.org/49495 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-27Handle also []any in unoAnyToPropertyTree()Tor Lillqvist
We add it as a subtree where each element in the sequence has as its name its number. Change-Id: I9422777d887d899f76ad6d259631d15c2db53f03 Reviewed-on: https://gerrit.libreoffice.org/51967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-03-27.uno:Save callback for the Android ViewerMert Tümer
Change-Id: Ic2e16985e52869092faa2a31a59a85cb77b8e28c Signed-off-by: Mert Tümer <merttumer7@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/51506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-27Fix typo ("x86_64" -> "X86_64")Stephan Bergmann
...introduced with 2d2294fb82bd4f0d1d805405631aeb1acbc36cbb "Add x64 Windows here, too". As reported by Richard Webb at <https://lists.freedesktop.org/archives/libreoffice/2018-March/079870.html> "Re: Manifest.xml for 64bit LO". Change-Id: I1681908012e73e520bebd79b8149788358ea49a3 Reviewed-on: https://gerrit.libreoffice.org/51946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-27desktop lok: handle NoFileSync in saveAs()Miklos Vajna
Similar to TakeOwnership: detect this, remove it from FilterOptions and turn it into its own sequence element. Online uses this for its convert-to functionality. The new cost for converting a small ODT file into PDF is 84% of the original (when opting in for this flag). Change-Id: Id2fcf5dd8b40eed04e0bc37f33519fd7691a9e5a Reviewed-on: https://gerrit.libreoffice.org/51909 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-27loplugin:expressionalwayszero improvementsNoel Grandin
Change-Id: I00bdbc58d2295a0be30b47c85eae6b9abfec17b2 Reviewed-on: https://gerrit.libreoffice.org/51868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20drop unnecessary includesCaolán McNamara
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15tdf#96796 - Added clipboard actions for the Android ViewerMert Tümer
Change-Id: I52e134532ab70e765b6ccd929f189be84f9c9a90 Signed-off-by: Mert Tümer <merttumer7@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/51286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-14Allow lok to re-set temporary paths on second init.Michael Meeks
Change-Id: I40cd0538b573c2d090f56424e1110b938981a878 Reviewed-on: https://gerrit.libreoffice.org/51292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-14Revert "tdf#96796 - Added clipboard actions for the Android Viewer"Thorsten Behrens
Breaks Android tinderbox This reverts commit 31e939c9f4b29fb2b2e63eb096450cf3da35d67f. Change-Id: Id565c9ef8330c0b3bce2c678facb7605dcf3e356
2018-03-14loplugin:constantparamNoel Grandin
Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d Reviewed-on: https://gerrit.libreoffice.org/51273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14tdf#96796 - Added clipboard actions for the Android ViewerMert Tümer
Change-Id: I2779ef9a9f68dcf08c3072ffe83b9f2450b7257e Signed-off-by: Mert Tümer <merttumer7@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/50757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:constantparam in desktop..i18npoolNoel Grandin
Change-Id: Ie2e1004c1ccc03777a8da9cb1144e89eb28ff313 Reviewed-on: https://gerrit.libreoffice.org/50928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:constantparam in canvas..comphelperNoel Grandin
Change-Id: Ia666cb46c409852a13789389c032f0ce4377c0d5 Reviewed-on: https://gerrit.libreoffice.org/50927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07use comphelper::containerToSequenceNoel Grandin
Change-Id: Ib1cd28c8cabf8899c43701cb638d1191c593dad0 Reviewed-on: https://gerrit.libreoffice.org/50872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07Use for-range loops in desktop (part2)Julien Nabet
+ use 1 time replace size() > 0 by !empty() Change-Id: If62a17171fc09e0bead7c0a791758705f62920d1 Reviewed-on: https://gerrit.libreoffice.org/50847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-05Use for-range loops in desktop (part1)Julien Nabet
+ remove some useless typedef + some reindent Change-Id: Ic1e445a7096b1663ca8cbc58c40bb8f7af0c70e1 Reviewed-on: https://gerrit.libreoffice.org/50787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-05loplugin:useuniqueptr in TheExtensionManagerNoel Grandin
Change-Id: Ic45feadb64410b3f7833edd52af118436cd9763d Reviewed-on: https://gerrit.libreoffice.org/50715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01...and some more asserts during CppunitTest_desktop_dialogs_testStephan Bergmann
Change-Id: I0a585ff4a0538c606153cb9d527838f5b50623a8 Reviewed-on: https://gerrit.libreoffice.org/50521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28Don't do unnecessary check for trailing slashMike Kaganski
The check is done in utl::TempFile::SetTempNameBaseDirectory Change-Id: I62b40a4f53f68da14aae6fcdfbf4c2dc7515a2c5 Reviewed-on: https://gerrit.libreoffice.org/50501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28lok: update main threadHenry Castro
In the pre-initialization phase of the tiled rendering case the SvpSalInstance is created in a different process and when a new process is created (fork), the main thread identifier does not match so it is required to update it. Change-Id: I189e53f0b46c60f34a8016222079c9b1e2b3fef8 Reviewed-on: https://gerrit.libreoffice.org/50477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-28Clean up Desktop::CreateTemporaryDirectoryStephan Bergmann
...avoiding the confusing, and apparently unnecessary back-and-forth between system path and file URL. (Superseding <https://gerrit.libreoffice.org/#/c/50422/> "Don't overwrite system temppath with old one that failed already".) Change-Id: I247982a40d54565f5c98bda9a36209cba83c5c9f Reviewed-on: https://gerrit.libreoffice.org/50494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28sneaky uppercase OK,CANCEL,HELP responsesCaolán McNamara
Change-Id: I02324d31822c37daa1e5e1b8c87aa597def58957 Reviewed-on: https://gerrit.libreoffice.org/50437 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27lok sc: Post mouse events to main threadPranav Kant
Change-Id: I1311938d7c01d0e3bfd239743e6cb2148da56cdf Reviewed-on: https://gerrit.libreoffice.org/50253 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-27postExtTextInputEvent() -> postWindowExtTextInputEvent()Pranav Kant
Let's avoid the confusion and name all these new APIs that can post both to document and window to have 'Window' in their name. The ones without window are the old APIs. In future, we can have postWindow{Key,Mouse}Event() to post to both document and window and deprecate the existing post{Key,Mouse}Event()s. Change-Id: I1f55386e7790e9c5b5d023b8831f3cd1e6faa2bb
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26ColorData->Color in variousNoel Grandin
Change-Id: I22018b6a535224316d93bfd621771248b873a218 Reviewed-on: https://gerrit.libreoffice.org/50167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-23get headless build to work again for LinuxThorsten Behrens
This makes --disable-gui option build successfully again - which means we again run on a headless server w/o any X11 or OpenGL libs. Change-Id: I60019af571aecdac277adbe6d34d5fff065014f9 Reviewed-on: https://gerrit.libreoffice.org/50214 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-22weld native message dialogsCaolán McNamara
just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-21lok: support of AutoCorrect -> While Typing menu in WriterAndras Timar
Change-Id: I7c07f3a6269cd4b92cc50f7aaf847faf04665029 Reviewed-on: https://gerrit.libreoffice.org/50068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-21New loplugin:nestedunnamedStephan Bergmann
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c Reviewed-on: https://gerrit.libreoffice.org/50048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-19fix updater on windowsMarkus Mohrhard
Change-Id: Ib6f2334a3f6f3f5c217a71e2967a69e354b0a473 Reviewed-on: https://gerrit.libreoffice.org/49956 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-16Revert "loplugin:changetoolsgen in dbaccess..desktop" and reapply pluginNoel Grandin
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit a9ca38bdf7ff9d15529b5903e640987fc14c0fa7. Change-Id: I662ef2f1100a06a68decb2c71975fbc61aeaa47d Reviewed-on: https://gerrit.libreoffice.org/49847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16native dialog initial basisCaolán McNamara
Change-Id: I392be563e38257390f748c70bb71c67a66778ddd Reviewed-on: https://gerrit.libreoffice.org/49677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-10 05:09:32 +0000