summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2015-04-17convert SCRIPTTYPE_ constants to scoped enumNoel Grandin
Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433 Reviewed-on: https://gerrit.libreoffice.org/15344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-10rhbz#1197614: Fix calculation of m_bHasActive when removing active elementStephan Bergmann
Assume m_vEntries.size() == 2; assume first element (nPos == 0) is m_bActive, gets removed, so m_nActive would have stayed at 0 and m_bHasActive at true; then assume second element (again nPos == 0, due to the removed element) is m_bNew, so nPos <= m_nActive is true and m_nActive gets updated to 1 (and m_bHasActive remains true); then selectEntry(nNewPos) (nNewPos == 0) would have tried to reset m_vEntries[1]->m_bActive but now m_vEntries.size() == 1. Change-Id: I31d3bbe97ca99f880aa99bdea015f7c0457f8331
2015-04-09Use comphelper::LibreOfficeKit::isActive() instead of LOK_TEST env varTor Lillqvist
Change-Id: Iaa0c751f101df6db25e9fca9123b81ac63033159
2015-04-09loplugin:staticmethodsNoel Grandin
Change-Id: Ie348778ea666c24e95e048386547f301083a0017
2015-04-08Add lok_init_2() that takes also the path to a user profile to useTor Lillqvist
In some LibreOfficeKit use cases it will be useful to use a separate (initially empty) user profile each time, instead of whatever the default might turn out to be. (When using the "instdir" of a LibreOffice build tree, the user profile is the "instdir/user" directory.) Also add a corresponding new function to be looked up, libreofficekit_hook_2. I did not bother with any more descriptive name. After all, "lok_init" already is quite terse, so calling the new function "lok_init_with_user_profile" or something similarly verbose would in my humble opinion have been inconsistent. (And if/when we need to extend the LibreOfficeKit initialisation function with even more parameters, the name would become really long.) But feel free to change this if you feel like it... Make sure to stay backward-compatible with source code calling lok_init() and with binaries looking for only the libreofficekit_hook entry point. Change-Id: Ifa9ce8f72c2f60554fb3431d522e5784afa8d8d3
2015-04-07Follow-up to 372f9bce4e28ffcc89f92dc9982ab9a5c4922994, forgot to remove thisTor Lillqvist
Change-Id: Ic3f004fbe83dc3df49147fadad8177ee64db0175
2015-04-07convert SvtModuleOptions::EModule to scoped enumNoel Grandin
Change-Id: I9665fc003cb3a44f4db857b24584fa3a70487259
2015-04-07convert SvtModuleOptions::EFactory to enum classNoel Grandin
and fix issues in iterating through o3tl::enumarray Change-Id: Ia59ef9be44d8c92c2e406fa71aa92269578e26e3
2015-04-07LOK: reimplement lok::Document::postKeyEvent()Miklos Vajna
Instead of posting an event to the main loop of the soffice thread, do what every other methods do: take the solar mutex and execute the task on the thread. This fixes random lost/delayed key events on Android. Change-Id: Ibe819282b5f3bb64e44d4b6f0a92611fe651bb39
2015-04-04Presumably at least the #ifndef DISABLE_BDB2PMAP thing can be killedTor Lillqvist
Not sure if the comment in desktop/source/deployment/inc/dp_persmap.h: "should be removed for LibreOffice 4.0" refers to just the DISABLE_BDB2PMAP parts or the class and functionality as a whole. Change-Id: Ie701576efc4076ab8be02a89145b5ecfcaaebc53
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02Remove obsolete INET_PROT_PRIVATE aliasStephan Bergmann
Change-Id: I6c82dad9d69e19d5596f23eacfbd20768f9f6442
2015-04-02Move osl::LibreOfficeKit stuff to comphelper for nowTor Lillqvist
Let's see where it actually will be needed. Sal is a "picky" place for new API, even inside LIBO_INTERNAL_ONLY. Change-Id: Ia0c5ee8cfc6ee526c5ad34d2f8aab0b14b5f805b
2015-04-01Check osl::LibreOfficeKit::isActive(), not Application::IsConsoleOnly()Tor Lillqvist
Console-only is really orthogonal to other things; it has one specific meaning that is relevant on OS X only, see svapp.hxx. Let's not overload it for LibreOfficeKit things. Change-Id: I8b94c3a4e6f938ad70f1555a12dac8596819e031
2015-04-01Add API to check whether being used through LibreOfficeKitTor Lillqvist
LibreOffice code, when used in a program through LibreOfficeKit, needs to be aware of that in certain crucial spots, to avoid behaviour and functionality that makes no sense in a LibreOfficeKit scenario. As LibreOfficeKit uses a normal LibreOffice installation to perform its job, this can't be a compile-time choice. Also, none of the existing run-time "headlessness" modes fully match what is needed. Change-Id: Iaccf7f958c549f019b508854800519f54dcadb11
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: Id85c1cd6c0eade60c7c347c3a3bc3f4a590e5ce5
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: I128d5b429a8f649f9236b2e007a90c24cac5b142
2015-03-30Revert "Merge the --invisible and --headless options"Tor Lillqvist
Stephan told about the intended use case for --invisible, and it does sound like a plausible use case, so let's revert this. "ah, now that I see 4fe56f3b9af814430a28a1880799f450fb8146b9: one use case for invisible + !headless might be in workflows where external code keeps a LO instance running and lets it pop up document windows, but you don't want the initial start center thing I think that's historically where the --invisible thing is coming from, now that I vaguely remember again" This reverts commit 4fe56f3b9af814430a28a1880799f450fb8146b9. Change-Id: I17f535adee7e533abbee150b0ce5156ecf78c781
2015-03-30Merge the --invisible and --headless optionsTor Lillqvist
No need to have both. Change-Id: Ibd2f9f6d352ffb52bf43f4e1a4f69f60a60458ff
2015-03-29m_nofirststartwizard was never testedTor Lillqvist
Change-Id: Ibd74eae829eb6bf5366a474628c1bf5ff6b4e839
2015-03-29Bin superfluous empty linesTor Lillqvist
Change-Id: I5bf8ef05aa0a1da972963ae44f04a0042c7b1162
2015-03-29Add a commentTor Lillqvist
Change-Id: Ic9da4b8cb28f0789cefa8cf1eb3073424f6ea552
2015-03-29Don't use any IPC pipe when in console-only mode or in a LOKit-based programTor Lillqvist
There is by definition no reason to do any IPC in those cases. Each program running LO code in such a mode is independent from any other. Do as before for Android, though, I don't have the patience now to check whether we actually need the pipe on Android for some reason. Change-Id: If0f54bf51e58b13c0c0b8f0bf6882bbef067960d
2015-03-29Bin pointless static const members used only in one placeTor Lillqvist
Change-Id: I5cf39093e01dfd381624975f3267a2f7349ed8e5
2015-03-28Remove #if 0 block of codeTor Lillqvist
Change-Id: I95320c0a3e0b7a405a1332e3826d2b917ecf3a6b
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: Idb32372009faf2bc2e223f1f8977cb3fc6b182a3
2015-03-28Bin a few SAL_INFOs that basically just say "we are here"Tor Lillqvist
Such are fairly pointless to keep permanently in the code. Use a temporary SAL_DEBUG if you need tracing output when you reach a certain lines while hacking. Change-Id: I13a898486731c6d2995e92e2c5dcd0d1429e47cc
2015-03-28Using LO code through LOKit should imply "console only", too, I thinkTor Lillqvist
The "console only" mode, which apparently is intended to mean something stronger than merely "headless" mode (?), is not checked much currently. But I plan to start checking it to avoid doing things that make no sense when running LO code through LibreOfficeKit. (If overloading "console only" mode turns out to be a bad thing, we will have to introduce a third degree of headlessness then, "LOKit mode".) Change-Id: Id4cd16c4d68e2f1aba8a6b8fba83325b7262563a
2015-03-28We already log successful UNO initialisation in initialize_uno()Tor Lillqvist
Change-Id: Id1315a35f84fee2a7c7a42df489237c2e641a189
2015-03-28Exclamation marks are unprofessionalTor Lillqvist
Change-Id: Ic75e73cf390872f4095d23a4388739330aeb1286
2015-03-26tdf#39440 cppcheck cleanliness, Fixing basic cpp errorsVarun
Initialized a non-initialized integer variable which is widely used in if else Change-Id: Ibd99c0baa4cd3d4d409310a9a70dc7b421f6a8b2 Reviewed-on: https://gerrit.libreoffice.org/14780 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-24loplugin:constantfunction: variousNoel Grandin
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-20Remove library urelibs. It was more just a temporary hack and is not used.Matúš Kukan
Change-Id: I7566dcf21aae6b800adb58d8c94e350bb0da720c
2015-03-20tdf#88230: cleanup solar mutex yieldingPranav Kant
Use SolarMutexReleaser, instead. Change-Id: I276459c42b688813ea168d6fc80466a07a5ecba4 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-03-20Drop paintTile's row stride output parameter that nobody is interested inTor Lillqvist
Change-Id: I166b4b713c2ea52c62c52045bb2073b6d84c1547
2015-03-20Don't include vcl's private include files in desktopTor Lillqvist
Introduce a handful of small public wrapper functions. Change-Id: I80e1e35d09675112d67b831f3efda483e709b540
2015-03-20drop unneeded includeDavid Tardon
Change-Id: I566678d55fa5d052a94a9b69732e2be4c0c39280
2015-03-19fix android buildNoel Grandin
workaround template issue Change-Id: Ifeb828685b3f63159249211aa32a90dcba2e5570
2015-03-19loplugin:constantfunction: vclNoel Grandin
Change-Id: I985b781a8d53190505fcb1182749cdaf5cd0f8d0
2015-03-19convert SFX_FILTER_ constants to enum classNoel Grandin
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
2015-03-16android: Make the Bold button actually work - switches to typing in bold.Jan Holesovsky
Change-Id: I48da0f3cc918bda1cdb396b4ea72a82eddafb9a8
2015-03-16LOK: Implement posting of .uno: commands.Jan Holesovsky
Implements also Bold button as an example in the gtktiledviewer. Change-Id: I3b07d51165f28534aadbb4673f964ec10d5fc6ef
2015-03-16android: add to JNI - setGraphicSelection, resetSelectionTomaž Vajngerl
Change-Id: Ib81763148b077423d3903802b13a11b15ba3b0c1
2015-03-16lok::Document: add resetSelection()Miklos Vajna
Change-Id: Ib24003178bb576ff1450d674d74ef8978b350b92
2015-03-16LOK: add lok::Document::setGraphicSelection() API and implement it for WriterMiklos Vajna
Change-Id: I115cf7e7978622d5108c4c792f7de861beb6efb6
2015-03-16CppCheck cleaning : remove unused struct memberMichaël Lefèvre
Change-Id: I07ebb82b71d6019a35b7cd2757464dab269d2098 Reviewed-on: https://gerrit.libreoffice.org/14855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-11Use osl/thread.h abstractionStephan Bergmann
...which already takes care of things like increasing stack size under ASan Change-Id: I89f9a25a660aacd41e1125766b23f7be395e7af8
2015-03-09Fix Linux baseline buildMiklos Vajna
1) One more place in desktop that missed the LOK_TEST check. 2) One testcase currently fails on baseline, disabled for now, need to check later. Change-Id: I8c8bcf2cec1618e39e8453120755dffd3feb79ce
generated by cgit (git 2.34.1) at 2025-02-12 14:51:24 +0000