summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2016-02-01libreofficekit: fix inverted conditionMichael Stahl
... that prevented loading the same URL multiple times. Also make this exception-safe while at it. Change-Id: Ic71735fef1ad8f79a210279d4d03f1fd5fa8cf69
2016-01-29sequence->vector in OInteractionRequestNoel Grandin
Change-Id: I995cb96e514e1aaa05a96f29344ef51e4ca83c64
2016-01-29vcl: add text alignment functions to ImplFont and FontAttributesChris Sherlock
ImplFont and FontAttributes now have GetAlignment and SetAlignment, and I have renamed Font::GetAlign to Font::GetAlignment, and Font::SetAlign to Font::SetAlignment. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit test added to vcl/qa/cppunit/font.cxx to test text alignment. Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba Reviewed-on: https://gerrit.libreoffice.org/21876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-28sw: add AnchorType parameter to .uno:PasteMiklos Vajna
Which allows not hardcoding as-char for LOK. Change-Id: I3b2987abbaf1f259c614b7b2a8709f15048d362d
2016-01-27libreofficekit: password interaction optional and off by defaultMichael Stahl
Add setOptionalFeatures() function that clients must call during initialization, and enum LibreOfficeKitOptionalFeatures. Change-Id: I73035193c87033052921c3aad94fdc057fe81111 Reviewed-on: https://gerrit.libreoffice.org/21809 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-01-26vcl: actually that shared_array was a scamMichael Stahl
The only things passed as buffers there were null pointers and shared_arrays that had the deletion explicitly disabled with a struct NoDelete, so it's sufficient to just pass a pointer. Change-Id: I68d618782aa654242048516d2e910b8136b16e2d
2016-01-26vcl: convert boost::shared_array to std::shared_ptrMichael Stahl
Change-Id: I9d0ad886c4c6e1c8496eb6129b22d327ca0968eb
2016-01-25loplugin:defaultparamsStephan Bergmann
Change-Id: I58f3b5301098b61c3d38afa9371dadc742a4b19b
2016-01-25libreofficekit: ask for password when loading encrypted documentsMichael Stahl
Change-Id: I3b3b0c0e64965280c24842b0cf70a21b8abb4dfb
2016-01-25desktop: use x prefix for uno::ReferenceMichael Stahl
Change-Id: I737f648a638447f3038dcea526db7a3797b63c84
2016-01-21sw tiled editing: default to anchoring new images as-charMiklos Vajna
Change-Id: I6aeb06fe1697b7a30e83a3b1b364f44e5822fe95
2016-01-21desktop: loplugin:defaultparamsMiklos Vajna
Change-Id: I487cfa6415615e6aa0409889e2c7be5e67eea1c4
2016-01-21Clean up lok::Office::freeError()Miklos Vajna
- let it take a non-const pointer, just like free() or g_free() does - remove lok::Document::freeError(), which was declared, but not implemented - move the declaration at the end of the stable API, but before the unstable section Change-Id: I5a8ced61fc87641dc2fa0ea3615a350361fae3a1
2016-01-21sc lok: Implement unit test for .uno:{Insert,Name,Remove} for sheets.Jan Holesovsky
And fix indexing when at that - the inserting is 1-based, so let's be consistent in the .uno:Name and .uno:Remove too. Change-Id: Ib854e81551ae0a39d3ba7c68512e81ea227e9eb1
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-20loplugin:stringconstantStephan Bergmann
Change-Id: I678c1fb7d5079dfb1d880e856a0d507f1c89b427
2016-01-19loplugin:cstylecastStephan Bergmann
Change-Id: Ib4052fa88cce3b21d20d050fff9c8d32fcde4c20
2016-01-19WaE: unused variableTor Lillqvist
Change-Id: I826a1eb45d0669dbe2495b4dbe4a171fcebb0865
2016-01-19CppunitTest_desktop_lib: add ModifiedStatus callback testcaseMiklos Vajna
Change-Id: Ieb7e808ebc7619c3a4a013cad776eeefd6163e22
2016-01-19LOK: include ModifiedStatus in CALLBACK_STATE_CHANGEDMiklos Vajna
Change-Id: Ic44a9266a67bfad8b0490a8acb4a419af99ea42c
2016-01-19Make LibreOffice kit usable on windowsOliver Specht
Uses Ascii variants of LoadLibrary,Get/SetEnvironmentVariable_A_ and adds a freeError function includes windows.h instead of pre/postwin.h Change-Id: I88b7e3ed3818078efec5688e207da47dc4049b98 Reviewed-on: https://gerrit.libreoffice.org/21600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-01-19CppunitTest_desktop_lib: add jpeg paste testcaseMiklos Vajna
Fails without commit 27c6b8586d5d2cd1fa5425b4969d915a0b739475 (svtools: implement clipboard import of JPEG files, 2016-01-19). Change-Id: Ic4e3b036b3a6a1c294bf15ef0b206cf1e458fc4e
2016-01-19Build the LibreOfficeKit bits also on WindowsOliver Specht
Change-Id: Ibbd5e50ffeeb061a30d6f0f09a393a67ba67421e Reviewed-on: https://gerrit.libreoffice.org/21598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-01-19Make sure desktop under LOK does not see osl_setCommandArgs CommandLineArgsStephan Bergmann
Our sal/cppunittester/cppunittester.cxx uses SAL_IMPLEMENT_MAIN, so forwards the cmd line args to osl_setCommandArgs. CppunitTest_libreofficekit_tiledrendering (run via that cppunittester) starts LOK, which starts SVMain on a lo_startmain thread, which calls deskopt::DispatchWatcher::executeDispatchRequests to process any cmd line arg requests to open documents. It sees the libtest_libreofficekit_tiledrendering.so (or .dylib/.dll) passed to cppunittester, and tries to open it as a LO document. Type detection will typically determine it is plain text that should be opened with Writer, which will succeed. But when the .so is built with GCC 6, it happens to be detected as a MacPaint document, loading which fails, so that executeDispatchRequests (desktop/source/app/dispatchwatcher.cxx) will call xDesktop->terminate(), which unwinds that lo_startmain thread (DeInitVCL etc.). But the main cppunittester thread is still calling into LOK, which is under the assumption that VCL etc. is still functional, and somewhat random crashes will happen. Change-Id: Ie7b00e797a0f3223b3942bb63a31aa9c44370247
2016-01-19-Werror=strict-aliasing (GCC 6)Stephan Bergmann
Change-Id: I080315852db2f6e852f63f3965a2b7bf91529168
2016-01-18basebmp now only used from vcl/headless codeCaolán McNamara
Change-Id: I068d404431d3565f6ad5741edbd3693225824a4d
2016-01-18loplugin: unused return valuesNoel Grandin
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-17vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16revert vcl patch series that brok Mac and WindowsNorbert Thiebaud
revert: 9bc2f3de8672e812f3a67541c6d7069b434a7e42 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight() 26371f105bc44e04469ec03fc5bb12505e651c6b vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic() 2dd0b4317372b8022efe3911b38b4fa02956d8b9 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual 5ab13bf3ead3539e4ad847656da81e7eb6029652 vcl: tabify font.hxx f99550dae55e40e49bf9c9875053fe2abb4c71ca vcl: change Font::SetName() to Font::SetFamilyName() 2b297116cb6bb1061c43e5714e2609c8ee9f57d2 vcl: rename Font::GetName to Font::GetFamilyName Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5 Reviewed-on: https://gerrit.libreoffice.org/21509 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-15sc tiled rendering: it's pointless to send selection changes during search allMiklos Vajna
Change-Id: I787cd1760bca0bf7fbc3132579b569882ec25ae2
2016-01-13tdf#95573 - stop (crazy) busy loop from blocking rendering.Michael Meeks
Attempt to blind fix extensions problem on OS/X. Some quite amazing code there. To avoid each busy idle from invalidating, avoid progress bar invalidation for the same %age being set. Change-Id: If96f8615c0ea712681e008972b3abe1c070a3227
2016-01-12Typo: 'It as' -> 'It is'Samuel Mehrbrodt
Change-Id: I6ce5dc2333429fa472e2d605a95385912175910e
2016-01-11loplugin: unused return values in desktopNoel Grandin
Change-Id: Iec7a150c6bdb3b25fe24d711e3e453e1d8a5d26e
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-06Use OUStringBuffer when constructing string in loopAndrzej Hunt
Change-Id: Ic29e301d0162d41ea5e38070e296610115735983 Reviewed-on: https://gerrit.libreoffice.org/20191 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-05new loplugin rangedforcopy - use reference in range based forAndrzej Hunt
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2 Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01 Reviewed-on: https://gerrit.libreoffice.org/20190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-04Cleanup after removing vcl::FontInfo classChris Sherlock
Change-Id: I544eac439cb7277e47a23a90c6fbc45496161c3b
2016-01-03vcl: Excise vcl::FontInfo classChris Sherlock
This may sound crazy, but literally vcl::FontInfo serves no purpose that I can see. The inheritance chain is like this: ┌────────────────────────┐ │ │ │ vcl::Font │ │ │ └────────────────────────┘ ^ ╱ ╲ │ │ ┌────────────────────────┐ │ │ │ vcl::FontInfo │ │ │ └────────────────────────┘ ^ ╱ ╲ │ │ ┌────────────────────────┐ │ │ │ FontMetric │ │ │ └────────────────────────┘ vcl::FontInfo (which, incidentally, needs to be put into the vcl namespace due to collisions with poppler!) literally does nothing and is acting as a bridge between FontMetric and vcl::Font. Unlike a bridge though, this bridge doesn't actually *do* anything. So I'm removing it, which means one less class to deal with in the vcl fonts world. Change-Id: I32725669c9bca7fbb0846b6a062135464046e4f6 Reviewed-on: https://gerrit.libreoffice.org/21058 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-27sal_uLong/sal_uIntPtr/sal_uInt16 to sal_uInt32Matteo Casalin
also avoid some explicit temporaries and group some checks. Change-Id: I7795b208dde53fd383b8c75f72dd9f56429aea2b
2015-12-24loplugin:unusedfieldsNoel Grandin
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf Reviewed-on: https://gerrit.libreoffice.org/20892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-23loplugin:unusedfields in desktopNoel Grandin
Change-Id: Ic816a7faf4d357d16c13f67533b3b409a531d14c
2015-12-21loplugin:unusedmethodsNoel Grandin
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
2015-12-18LOK: get feedback for all of the font/back color commandsMihai Varga
Change-Id: Id4aac707666420752b985bcfd03b5b9bb99f79f1
2015-12-14FreeBSD can live with default search pathBaptiste Daroussin
Change-Id: I3fa26aaf57d9620e952823c303ee77e2fc642045 Reviewed-on: https://gerrit.libreoffice.org/20651 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-11No need for a separate <vcl/graph.h>Tor Lillqvist
Change-Id: I962544005b5d408f7c044a02eefe09b87d8a81fe
2015-12-08Missing osl_destroyThreadStephan Bergmann
Change-Id: I526cb06b019b945931b24eb40477a1727c38cdc2
2015-12-07last arg of SetOutputSizePixelScaleOffsetAndBuffer no longer usedCaolán McNamara
Change-Id: I65e7e82e46c5751617b00a39df47d864b29b6ce1 Reviewed-on: https://gerrit.libreoffice.org/20441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-07Resolves: tdf#96224 don't fiddle around with a separate alpha bufferCaolán McNamara
use a format that supports alpha directly now we can unify the android and linux cases as well and drop the BGRX support Change-Id: I3c845913691d8194822423005d308cfa7ef13ec3 Reviewed-on: https://gerrit.libreoffice.org/20440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-07tdf#96250 desktop: empty str is the same as 0 str in jsonToPropertyValues()Miklos Vajna
Change-Id: I77306dc998afc53bb1d5710a8d1ae68717f945d1