summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2017-07-05new loplugin unnecessaryparenNoel Grandin
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec Reviewed-on: https://gerrit.libreoffice.org/39549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-05loplugin:casttovoid (clang-cl): desktopStephan Bergmann
Change-Id: Id14f6d0f234188b9e4576380f45dd3eec8d857b7
2017-07-05loplugin:unusedfields variousNoel Grandin
Change-Id: Ia7bcf2471381aa6a2768ea795fe6572e38209100
2017-07-04loplugin:unusedfields in cui..idlNoel Grandin
Change-Id: Icb393cc0b2f79ded154e186ab6975b95e5126903 Reviewed-on: https://gerrit.libreoffice.org/39496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:casttovoid in VCL_BUILDER_DECL_FACTORYStephan Bergmann
Change-Id: I4b0dd08963cf50daa41901975c6f92fe21db2048
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-02loplugin:casttovoid: desktopStephan Bergmann
Change-Id: Iea973ac2047c030019b70e6db37328d05058af08
2017-07-02Handle osl::File::setPos failureStephan Bergmann
Change-Id: Icf21c14f44250e1680dd7521dbb0e1260614a573
2017-06-30loplugin:oncevarStephan Bergmann
Change-Id: I070f06ed3195925e525066c6ba25a0bb01b824d0
2017-06-28remove default-able copy ctors and copy operatorsJochen Nitschke
The implicit defined ctors and operators will copy all members (and bases). Since C++11 implicit copy is depreciated if there is a non-default dtor, keep such copies. This commit includes only types that had either copy ctor or copy operator and were found by cppcheck. Change-Id: I93ee687fb3b3c5884f475a2c6054955cdde57ed7 Reviewed-on: https://gerrit.libreoffice.org/39351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-24updater: add a way to manually test updater command lineMarkus Mohrhard
Without this hack it is not possible to debug the updater invocation easily. Each time this code will be called the updater would be executed and an update directory already present. Change-Id: I1159ee504b8f4ebf211e2a719369a48ae2e32345 Reviewed-on: https://gerrit.libreoffice.org/39080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-24updater: forward the command line arguments to the updaterMarkus Mohrhard
The arguments will then be used again to restart LibreOffice with the same arguments. Change-Id: I17697c997a1dfeebecd9ec64e8f4ea66cadc4690 Reviewed-on: https://gerrit.libreoffice.org/39079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-23loplugin:unusedfields in desktop..editengNoel Grandin
Change-Id: Ieea12d0790a1034eba8975fe74fa205f02003b7d Reviewed-on: https://gerrit.libreoffice.org/39134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:oncevar in cppcanvas..drawinglayerNoel Grandin
Change-Id: I5456aad61fb0dfe6830eae62b91d1a6399d6343f Reviewed-on: https://gerrit.libreoffice.org/39128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-22updater: handle the SeeAlso property after the update succeededMarkus Mohrhard
Change-Id: Ib90f1f7def6de05144bf8215a97a6d6e15207b88 Reviewed-on: https://gerrit.libreoffice.org/39073 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-21convert ErrCode to strong typedefNoel Grandin
would have preferred to re-use o3tl::strong_int, of which this is a modified copy, but there are lots of convenience accessors which are nice to define on the class. Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a Reviewed-on: https://gerrit.libreoffice.org/38497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18updater: check every 12 hours for updates for nowMarkus Mohrhard
Change-Id: I566a0177f9bdbc523e88a17be746b3528f67403d
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-17updater: detect when user can not write to installation directoryMarkus Mohrhard
In this case we can not update right now. Change-Id: I19cda5ddef448ff81e1ca457774b2db036038c88
2017-06-16updater: only download language packs for installed languagesMarkus Mohrhard
Change-Id: I8c605e2c64fee4d369732f783cc9dd76f7dc858c
2017-06-16Make SfxItemSet ranges correct by constructionStephan Bergmann
This is a follow-up to 45a7f5b62d0b1b21763c1c94255ef2309ea4280b "Keep WID ranges sorted, and join adjacent ones". While SfxItemSet::MergeRange relies on the m_pWhichRanges being sorted (and, under DBG_UTIL, asserts if they are not), the various SfxItemSet constructors curiously only check (via assert or DBG_ASSERT) that each individual range has an upper bound not smaller than its lower bound. Arguably, all SfxItemSet instances should fulfill the stronger guarantees required and checked by MergeRange. And in many cases the ranges are statically known, so that the checking can happen at compile time. Therefore, replace the two SfxItemSet ctors taking explicit ranges with two other ctors that actually do proper checking. The (templated) overload taking an svl::Items struct should be used in all cases where the range values are statically known at compile time, while the overload taking a std::initializer_list<Pair> is for the remaining cases (that can only do runtime checking via assert). Most of those latter cases are simple cases with a single range covering a single item, but a few are more complex. (At least some of the uses of the existing SfxItemSet overload taking a const sal_uInt16* pWhichPairTable can probably also be strengthened, but that is left for another day.) This commit is the first in a series of two. Apart from the manual changes to compilerplugins/clang/store/sfxitemsetrewrite.cxx, include/svl/itemset.hxx, and svl/source/items/itemset.cxx, it only consists of automatic rewriting of the relevant SfxItemSet ctor calls (plus a few required manual fixes, see next). But it does not yet check that the individual ranges are properly sorted (see the TODO in svl::detail::validGap). That check will be enabled, and the ensuing manual fixes will be made in a follow-up commit, to reduce the likelyhood of accidents. There were three cases of necessary manual intervention: * sw/source/core/unocore/unostyle.cxx uses eAtr of enum type RES_FRMATR in braced-init-list syntax now, so needs explicit narrowing conversion to sal_uInt16. * In sw/source/uibase/uiview/formatclipboard.cxx, the trailiing comma in the definition of macro FORMAT_PAINTBRUSH_FRAME_IDS needed to be removed manually. * In svx/source/svdraw/svdoashp.cxx, svx/source/svdraw/svdotext.cxx, sw/source/uibase/app/docstyle.cxx, sw/source/uibase/shells/frmsh.cxx, sw/source/uibase/shells/grfsh.cxx, and sw/source/uibase/shells/textsh1.cxx, some comments had to be put back (see "TODO: the replaced range can contain relevant comments" in compilerplugins/clang/store/sfxitemsetrewrite.cxx). A few uses of the variadic form erroneously used nullptr instead of 0 for termination. But this should have been harmless even if promoted std::nullptr_t is larger than promoted sal_uInt16, assuming that the part of the nullptr value that was interpreted as sal_uInt16/promoted int was all-zero bits. Similarly, some uses made the harmless error of using 0L instead of 0. Change-Id: I2afea97282803cb311b9321a99bb627520ef5e35 Reviewed-on: https://gerrit.libreoffice.org/38861 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-15use more SAL_N_ELEMENTS part 3Noel Grandin
Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623 Reviewed-on: https://gerrit.libreoffice.org/38789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-13remove TDE integration (vclplug, address book, config backend)Michael Stahl
It has ~no users, can't even be built on modern Linuxes, and it annoys folks who want to refactor VCL. Per ESC decision from 2017-06-08, remove --enable-tde and --enable-tdeab. Change-Id: I51ce4786f29f8fcac2e2bb2a654c41fbfbbd8afd Reviewed-on: https://gerrit.libreoffice.org/38718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12use the shared path codeMarkus Mohrhard
Change-Id: I046b8f497b78c4067abbf22180edb1b210020f4e Reviewed-on: https://gerrit.libreoffice.org/38684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12better variable namesMarkus Mohrhard
Change-Id: I14e667f10ae472f24fbb6107eee449ff9cf7f4a4 Reviewed-on: https://gerrit.libreoffice.org/38683 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12make it easier to extend the responseMarkus Mohrhard
Change-Id: I95d60fe38bbb16c502eccaae3bc25a35dd269d1a Reviewed-on: https://gerrit.libreoffice.org/38682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12use the shared path codeMarkus Mohrhard
Change-Id: I02cc24d7a9e3b679a7bd883cd7085682063520ee Reviewed-on: https://gerrit.libreoffice.org/38681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12better updater loggingMarkus Mohrhard
Change-Id: I6012f2159d058cbb2afb4b685badb8c870adf07b Reviewed-on: https://gerrit.libreoffice.org/38679 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-09Add --script-cat parameter to dump scripts content.Michael Meeks
Also factor out over-long print method into its own helper. Change-Id: Ica98dc9c999d5655e78662774e0140d70369d0b7 Reviewed-on: https://gerrit.libreoffice.org/38579 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-06tdf#36019: Disable context menu entry for extension removal properlyMuhammet Kara
When ExtensionSecurity::DisableExtensionRemoval is set in expert configurations, context menu entry of 'remove' for installed extensions should also be disabled along with the "Remove" button on the dialog. Change-Id: I66e4a8aafbaa633ab5626844c8df9e036045cd09 Reviewed-on: https://gerrit.libreoffice.org/38283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-01desktop: fix misformatted makefile lineMichael Stahl
(regression from 99b7c4f57d7fe3cac772cce38e2dd6879e128315) Change-Id: I2c3c0478a12e86d78074a8e1b25818de32d4b091
2017-05-31Remove some unnecessary scaffolding around SAL_WARN callsStephan Bergmann
Change-Id: Iaec105d85a283ad15fdca6ffc5cf3d2ec5acac18
2017-05-31tdf#36019: Fix tooltipMuhammet Kara
Change-Id: I8c1a01fa54addfdf78eaff45952e306de812e954 Reviewed-on: https://gerrit.libreoffice.org/38128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Tested-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-05-31Avoid implementation-defined behavior when mapping non-ASCII charactersStephan Bergmann
...into the basic source character set (translation phase 1) and then into the execution character set (translation phase 5). Change-Id: I3d40bb9c2a64bc62c04db0fbe09408b1911893c8
2017-05-31clang-tidy readability-redundant-string-cstrNoel Grandin
and readability-redundant-string-init Change-Id: I7b25659ace9e1d5be042ec5e179f01191693334e Reviewed-on: https://gerrit.libreoffice.org/38225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31clang-tidy readability-redundant-control-flowNoel Grandin
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04 Reviewed-on: https://gerrit.libreoffice.org/38215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30teach redundantcast plugin about functional castsNoel Grandin
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-29lok: Notify about the Formatting Marks changes.Jan Holesovsky
Change-Id: Ibcbd370c99cf63789637ad6642c91775066ecfad Reviewed-on: https://gerrit.libreoffice.org/38157 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-27allow to override settings based updater URL and channel through envMarkus Mohrhard
Change-Id: Ie2d96c1f6c15f91db6410997185161e5fb443dfc
2017-05-26tdf#36019: Dynamically enable/disable extension removal via GUIMuhammet Kara
Now extension removal via the Extension Manager dialog can be dynamically enabled/disabled from the expert configurations. This doesn't affect the unopkg commands. Change-Id: I2b718d48977ca18cc3d808e98cf7804d4a47dcff Reviewed-on: https://gerrit.libreoffice.org/37990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-05-24tdf#36019: Dynamically enable/disable extension installation via GUIMuhammet Kara
Now extension installation via the Extension Manager dialog can be dynamically enabled/disabled from the expert configurations. This also affects the installation by double-clicking the extension file in the file manager, but doesn't affect the unopkg commands. Change-Id: I70c2c83c2458115b366c7fdcc06f72e11df4726b Reviewed-on: https://gerrit.libreoffice.org/36688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-05-23iOS, remove curl to make iOS compilejan Iversen
Commit 9c3b05f2d571b58ee2322a942162ecec654544dc added curl, without affect on iOS some of the conditions changed later making curl be included when compiling iOS Added filter_out macro for iOS Change-Id: I22a9ffd47f56893ea366fffa3ef0a0610ea54370
2017-05-20cleanup unused css/uri/ includesJochen Nitschke
Change-Id: I08c7981ecce45e343ff9e98277dd3aea4ed68ab9 Reviewed-on: https://gerrit.libreoffice.org/37860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-20cleanup unused css/script/ includesJochen Nitschke
but keep exception includes in headers for now Change-Id: I826828675a2d14b906e57068cbced2e790e12bce Reviewed-on: https://gerrit.libreoffice.org/37846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-20conditionally disable test that depends on additional fontsMarkus Mohrhard
Change-Id: Idb066bf9dcaf0d606327214c9628fc12fefc7b19
2017-05-19loplugin:stringcopy: desktopStephan Bergmann
Change-Id: Ic27d5296dc6854a27f4848dc9047feef90cb6ff7
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19remove unused languagetag.hxx includesJochen Nitschke
and fix the fallout Change-Id: I8f59944bcc01a8e2ab371808c40eaf9b5198c143 Reviewed-on: https://gerrit.libreoffice.org/37785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-04 05:25:06 +0000