summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2016-03-04tdf#92191: Don't use any IPC pipe in a sandboxed OS X appTor Lillqvist
Creating the pipe fails when sandboxed. This caused us to not start the OfficeIPCThread, and that then meant that the file open requests coming in through VCL_NSApplication's application:openFile: method in vclnsapp.mm were not processed properly. The OS takes care of not starting multiple LO apps simultaneously anyway, so we don't really need any pipe, I hope. Conflicts: desktop/source/app/officeipcthread.cxx Change-Id: Ia920520ce2928787313f83199028f9c9942f61f3 (cherry picked from commit e2f4c9eae3f53aaba968d7567f912df6fa911326)
2016-03-02tdf#98210 do not require R_OK for pipe dirHank Leininger
Also better error handling if pipe dirs are really not usable. Change-Id: I1c865b9a9f1f08d2cffd07343494feca585ec75e Reviewed-on: https://gerrit.libreoffice.org/22727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-02loplugin:unuseddefaultparam in desktopNoel Grandin
Change-Id: I9a7ac03dcbc3849eced0f8431e186b59b31b2418
2016-03-01ccu#1573 sc lok: fix reporting of hidden row heightMiklos Vajna
For columns we use ScDocument::GetColWidth(), which returns 0 for hidden columsn. Do the same for rows: so instead of using GetOriginalHeight(), use GetRowHeight(), and then 0 size will be reported for hidden rows as well. Change-Id: Ic23b6af744bbc8e194e1906614adebe5ba0c7ced
2016-03-01loplugin:sallogareasStephan Bergmann
Change-Id: I0abd86a259673596f39f0b6ab62d02f15a8e18b9
2016-03-01loplugin:stringconcatStephan Bergmann
Change-Id: I2ca9ebdce00fdaeeb2ee690fffd75b21e9acc14b
2016-02-29desktop: fix infinite loop with --enable-breakpadMichael Stahl
Change-Id: I81a0405edc29fa7205d00a5cb920b2d0e800602e
2016-02-27store the crash ini file inside of the user profileMarkus Mohrhard
Change-Id: I9d85d3daba288091f9aa406a24b24facf5d20b1e
2016-02-27leave comment about minidump locationMarkus Mohrhard
Change-Id: Ic2f44caabe14efc2555e8d155273f75a2602932c
2016-02-27work on adding crash report UIMarkus Mohrhard
Change-Id: I66f4dca3cd32381ecd52cc36490e7ee1dddf3699 Reviewed-on: https://gerrit.libreoffice.org/22566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26loplugin:stringconcatStephan Bergmann
Change-Id: I39a55a9ac67aafa3f770509430b956e2fa81e6d8
2016-02-26better error reporting for crash uploaderMarkus Mohrhard
Change-Id: I6a2b5bd72187de2b646ec0d6fdb5fe20f5d6a2d8 Reviewed-on: https://gerrit.libreoffice.org/22565 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26store the URL in the crash ini fileMarkus Mohrhard
Change-Id: I1b5f29f864d01c238f2e21de87dde8005236f332 Reviewed-on: https://gerrit.libreoffice.org/22564 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26use the new ini file based minidump uploaderMarkus Mohrhard
Change-Id: Iaf85fb53e6eff34e268b6948d62ca84b7f8e6dd2 Reviewed-on: https://gerrit.libreoffice.org/22558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26loplugin:redundantcastTor Lillqvist
Change-Id: I8c44383a751d7b3440dcdede3646231414e2f89c
2016-02-26loplugin:nullptrTor Lillqvist
Change-Id: I11f661b31db8073010a520ccd44d93e1eb7c5bc0
2016-02-26Use an XInitialization-based channel to request service mgr pre-initStephan Bergmann
...instead of private cppu::preInitBootstrap function Change-Id: Id0e6fcf721b697c993e5acffaf7836452cfa9750 Reviewed-on: https://gerrit.libreoffice.org/22699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-02-26write an own minidump uploaderMarkus Mohrhard
This one is platform independent and uses a key-value file. Change-Id: I28a4483763666a5a8520874bf8e984eaaf24e9c0 Reviewed-on: https://gerrit.libreoffice.org/22557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-25loplugin:stringconcatStephan Bergmann
Change-Id: I6213a4102b019e3b509f4e0f2b632604dd1032d1
2016-02-25typoStephan Bergmann
Change-Id: Id0b3cb33996a73f9be1f268a369af9f4d5f2df60
2016-02-25loplugin:staticmethodsStephan Bergmann
Change-Id: Ia7cdf11b668286360a1701a52263a1e57261cf39
2016-02-25don't hardcode the version string in crash report urlMarkus Mohrhard
Change-Id: I9814e5975d69d4b93dd2a2b142e9368dc665c225 Reviewed-on: https://gerrit.libreoffice.org/22554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-25add way to add additional information to the crash reportMarkus Mohrhard
We can add several additional key value pairs during the execution of the program that will be used on the server to show more information. Change-Id: I4102adc15fc821415fa0b997ca7fe0dc4f7abcec Reviewed-on: https://gerrit.libreoffice.org/22553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-23Various loplugin warningsStephan Bergmann
Change-Id: I6489043ee629e1f411f303c1c43a00975aacf5c4
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-22LIBO_LIBEXEC_FOLDER is the correct place for executablesMarkus Mohrhard
Change-Id: I09010819e37baacf02277ad294a6436b13e285fc Reviewed-on: https://gerrit.libreoffice.org/22552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-22upload crashes correctly to server for linuxMarkus Mohrhard
Change-Id: I75778dc572a2888b3966cb5731f7e59209c7a942 Reviewed-on: https://gerrit.libreoffice.org/22551 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-22include breakpad into the buildMarkus Mohrhard
Change-Id: I1bfd107502332fc86ae5e96bbc1f475b8d669c6c Reviewed-on: https://gerrit.libreoffice.org/22547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-22WaE buggy warning in vs2015-r1Norbert Thiebaud
http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynamically-initialized-vs2015-1-static-const-std Change-Id: Icbe882ad237d1e4f105006d8821ed5c89b06f525 Reviewed-on: https://gerrit.libreoffice.org/22601 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-19desktop: loplugin:loopvartoosmallMiklos Vajna
Change-Id: Ic17077b48e0ebf1fe72ba5a5c401dd0e2c609c68
2016-02-19lok: Add a new sheet selection testPranav Kant
This is a test for commit ab199e4748b45384602479c735dbac538e714d34. Change-Id: I38905cfab8fe1c5721e5fa628ea564f08e0c2ad3
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-16lok: add desktop terminateHenry Castro
When lokit is destroyed, the Desktop service is still alive. So in order to avoid debug assertion "Desktop disposed before terminating it", terminate to quit application. Change-Id: Id1391cde516915d915e5321799436e92b444e935 Reviewed-on: https://gerrit.libreoffice.org/22359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-02-15loplugin:nullptrTor Lillqvist
Change-Id: I768b45818eaa0138d033bfcf6fd6e94459e44c0b
2016-02-15Re-work cppu::preInitBootstrap()Henry Castro
In the preinit stage, the preInitBootstrap is called to load implementations for each service registered by the service manager. All service requests are: initial Component Context and the process service factory is set. However, some services require that VCL is properly initialized. Change-Id: Ib116e3da172b860f2df4d672f6181b5de0b7e6b2
2016-02-15Introduce lok_preinit() to preload all registered UNO implementationsHenry Castro
Intended to be used from an application like the LibreOffice On-Line server so that it can be called in a process that then will call fork() several times, and much space consuming data will end up being shared. Change-Id: I65341c57d00308d246ec90deab8050b2c4bb3e61
2016-02-15lok: Expose DisplayName of styles, not internal onesPranav Kant
Change-Id: I2119713600703e3aa18f673979c7cd84c38177d7 Reviewed-on: https://gerrit.libreoffice.org/22349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-02-11loplugin:stringconstantStephan Bergmann
Change-Id: I78f28906c3ceae323b608018f929c66358e9aa39
2016-02-11Remove forgotten debug stuff.Jan Holesovsky
Change-Id: Iad6bb5ba62d114ca760c4215aa8eec872c5d181b
2016-02-11lok: Extend the StatusModified unit test with Save As.Jan Holesovsky
Change-Id: Ie9bbce6892fe1dcf55e23028e68037f996d7c71f
2016-02-11lok: Only add interaction handler when LOK fully initialized.Jan Holesovsky
Necessary for unit testing. Change-Id: I8db8b4c469864a915a00f8d8c4932634d74f11a7
2016-02-11lok: Introduce a "TakeOwnership" filter option for saveAs().Jan Holesovsky
It is consumed by the saveAs() itself, and when provided, the document identity changes to the provided pUrl - meaning that '.uno:ModifiedStatus' is triggered as with the "Save As..." in the UI. This mode must not be used when saving to PNG or PDF. Change-Id: I11b5aa814476a8dcab9eac5202bd052828ebbd96
2016-02-11lok: Interaction handler for saveAs() too.Jan Holesovsky
The LOK does not have to be fully initialized, eg. during the unit tests, don't use the interaction handler in such a case. Change-Id: I11bb8db37c92b05e2c1ad06e1a6632db7fb0ea60
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08Revert "lok: Interaction handler for saveAs() too."Michael Stahl
This reverts commit 809154904fe66441ada6985b153b4c1b20f3eb8f. Revert "lok: Take over the identity of the document when performing saveAs()." This reverts commit bcc940956c4689888297c7bbe8d3744becc2fe9e. The CppunitTest_desktop_lib crashes due to a null gImpl and i can't figure out how to call lok_init so it actually works.
2016-02-08vcl: cmdevt.[hc]xx -> commandevent.[hc]xxChris Sherlock
Change-Id: I77b30f28ae5a6fad360d7cada9acfaa9c324408b Reviewed-on: https://gerrit.libreoffice.org/22216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08lok: Interaction handler for saveAs() too.Jan Holesovsky
Change-Id: I3f0365e05685c21987da194e24a1165c7a3f8b5c
2016-02-08lok: Take over the identity of the document when performing saveAs().Jan Holesovsky
This way we are getting the .uno:ModifiedStatus notification even when performing saveAs(). Change-Id: I370bf483c50161fd4b7f2255ae85fdb76487a9a0
2016-02-08lok: notify the states of undo and redo toolbar itemsHenry Castro
Also included .uno:InsertPage, .uno:DeletePage and .uno:DuplicatePage Change-Id: I91dd2609d6a48be75005a44490614bcf8bcf62e9 Reviewed-on: https://gerrit.libreoffice.org/22195 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>