Age | Commit message (Collapse) | Author |
|
Change-Id: I1efccb8b926e4aa10e9ccee7e8e36919e38c05fc
Reviewed-on: https://gerrit.libreoffice.org/76339
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
|
|
And delegate resizing of floating windows.
Currently used for resizing sidebars in LOK.
Change-Id: Iadc1b71c15a7d16a8c9dd7246490ae6bd645644c
Reviewed-on: https://gerrit.libreoffice.org/73509
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This fixes the issue with selecting the incorrect
color when clicking on the color presets in the
color picker window in LOK. Because the window
coordinates are shifted in Core, and LOK client
sends in absolute coordinates, the shift causes
a different color to be selected.
(cherry picked from commit 171a2300d37d73065e5e3bd4b77678e35f678adf)
Change-Id: Ib818b83c0f0c727944068cb244f8d10666e5bc1d
Reviewed-on: https://gerrit.libreoffice.org/76323
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I84e0e8806eb6f4fbda063ebc29fafa791d472bb8
(cherry picked from commit d5b900630caefc4d3b62a31906117cf4acd623b1)
Reviewed-on: https://gerrit.libreoffice.org/76322
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This reduces the number of json reads we do
when compressing window events, which happens quite
often.
(cherry picked from commit 0bb310d7ce39421ecc4ff90518ffdf6aa01d1b02)
Change-Id: I1c85f28867b52cad85445fff8a031b990dad8b56
Reviewed-on: https://gerrit.libreoffice.org/76321
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This makes it more readable and reduces indentations.
No functional change intended.
(cherry picked from commit 570a3c5361d58635e4d0ac8baf6df787bd2290ad)
Change-Id: I129ecff9083c459d633c0965eab6e06ba3dcf499
Reviewed-on: https://gerrit.libreoffice.org/76320
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
A window size change is a full invalidation anyway,
so remove any prior invalidations as they are redundant.
Change-Id: I439a1bc38989df17b671e064beb26eb88c402be3
(cherry picked from commit 1a5af070d876b1ec4b69fe3be732426dba59b9af)
Reviewed-on: https://gerrit.libreoffice.org/76319
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This happens when we get multiple created events on
same window, interspersed with invalidations.
Change-Id: I2dbaa0f84306d770f1de047a23996209c28304fe
Reviewed-on: https://gerrit.libreoffice.org/76312
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8ca457387715fcd085bcbf3107839d2629580f7b
Reviewed-on: https://gerrit.libreoffice.org/76296
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This limits duplicate cursor invalidation removal to same
view only, which seems to have been left in error.
We should now remove any old cursor invalidations (for
the same view) and only keep the latest (current) one.
Change-Id: Ie2323d0c5fcf3977576a1bdc098c95351a5753e0
Reviewed-on: https://gerrit.libreoffice.org/71846
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 8e9c36dfc346387abfbbaefbc15a518cbe3e257c)
Reviewed-on: https://gerrit.libreoffice.org/76286
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I0278588dc533378104e544d05b60583c85271f6a
Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/75858
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I9b8e060c2c7655565b95004d82bf50ada2ed0d08
Reviewed-on: https://gerrit.libreoffice.org/71845
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/76267
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
this is combination of
commit dd15e149326f5270ab9ceb5f21e32b25b96c0a44
Author: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Date: Sun Nov 11 23:37:24 2018 -0500
LOK: sd: initialize slide-sorter in sd
(Change-Id: I4cb6ce6d961b4ba4d542c14cb37370788cf75e45)
and
commit 7e291eedbad335bf8bbc8a17cc3d633bf66d0e90
Author: Jan Holesovsky <kendy@collabora.com>
Date: Thu Apr 25 05:54:15 2019 +0200
(Change-Id: I86b23b484674ad4c6a75246ee6186ad9b828931f)
sd lok: Remove the .uno:LeftPaneImpress call from sd lok initialization.
According to my testing, this makes no difference and the moving of
slides and multiple selection behaves the same way with or without this.
So let's return to not activating the SlideSorterBar, because otherwise
we are doing a lot of pixel bashing behind the scenes unnecessarily.
Having said that, if we want to activate it at some stage, it is better
to do something like the following (+ remove the explicit LOK-only if's
from svtools/source/config/slidesorterbaropt.cxx):
SvtSlideSorterBarOptions().SetVisibleImpressView(true);
instead (and potentially we can also make it floating not to occupy the
space in the main view by
GetWindow()->SetFloatingMode(true);
in the LOK case in sd/source/ui/dlg/PaneChildWindows.cxxi).
Change-Id: I719bc4ca5e43fce9949d494149b65ffd8587c601
Reviewed-on: https://gerrit.libreoffice.org/76220
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This might lead to confusion as if there were different macro types depending on the current downstream package name. E.g. "LibreOffice Basic macros" might become "LibreOffice Vendor XY basic macros".
Remove that confusion by using just "Basic macro" in the UI.
Change-Id: Ifc2543bb151e94fc6c6e47d878720dd99294f596
Reviewed-on: https://gerrit.libreoffice.org/76216
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I1c67cde8401106a7e9d7ecd5fd3e0b4925ab47d4
Reviewed-on: https://gerrit.libreoffice.org/76212
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ieac1a0acb97664f3b86e2524cab79fd278f42e0e
Reviewed-on: https://gerrit.libreoffice.org/76210
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
... see https://gerrit.libreoffice.org/72417
They will be drawn client-side. Borders and explicit cell background are
still drawn in core. This mode is activated using "sc_no_grid_bg" option
in SAL_LOK_OPTIONS environment variable.
Change-Id: Ie10e7770b8168ec648d44ae5af0a0a0602d89ee6
Reviewed-on: https://gerrit.libreoffice.org/75484
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I9ba4243bc3d6b14e66694728deb270ed74a70d01
Reviewed-on: https://gerrit.libreoffice.org/75949
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I4b0dd4fc9051f04448a651cb87b449a58d2a5349
Reviewed-on: https://gerrit.libreoffice.org/75874
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I09268bc22f4fb34160975063e38ea60a68123400
Reviewed-on: https://gerrit.libreoffice.org/75875
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If23db9a245b4dd4b59b9b5410a094f2f374eedfd
Reviewed-on: https://gerrit.libreoffice.org/75878
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1211c90a72048f868ec7ba7a7b6bed452ae8ac4b
Reviewed-on: https://gerrit.libreoffice.org/75791
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia92658c7a534928209906b8adfb5f9451b513ff0
Reviewed-on: https://gerrit.libreoffice.org/75786
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Currently reordering of slides is only supported
for presentations, although it is provisioned for
spreadsheets as well.
Change-Id: I6c35066d6a5ef7586d34a8e8b89db69a20b86572
Reviewed-on: https://gerrit.libreoffice.org/69612
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/73495
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I0df15244d6208f49d9bce2e27ff3deccfe98f981
Reviewed-on: https://gerrit.libreoffice.org/75697
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Moved from TDF wiki to avoid duplication.
These three stop us getting poor performance from unusual allocators:
unset MALLOC_CHECK_ MALLOC_PERTURB_ G_SLICE
If we wedge, at least we don't do it while grabbing the mouse:
export SAL_DISABLE_FLOATGRAB=1
Turns off recovery dialog, which can be a pain:
export OOO_DISABLE_RECOVERY=1
Turns off GL watchdog. It normally kills the application, if it
seems to hang in a GL block:
export SAL_DISABLE_GL_WATCHDOG=1
Change-Id: I4ec30d363280b727cd305a6a81ccb85849697159
Reviewed-on: https://gerrit.libreoffice.org/73773
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: Ifca7c0626f9671c1539e7828eb993278574ea10c
Reviewed-on: https://gerrit.libreoffice.org/75367
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8624de25b0bb66020002890f33758e52059a24ab
Reviewed-on: https://gerrit.libreoffice.org/69610
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/73493
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
This is needed to be able to load e.g. TIFF files in Online, which does
not have code in the chroot since online.git commit
ad21717498cc214d5d5d5c0ff378238552137e2f (Avoid copying most code into
the chroot jail., 2018-03-10).
Change-Id: Ib095191ee690d9da6269878a82b1c6995df50dfa
Reviewed-on: https://gerrit.libreoffice.org/75077
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
When clicking (tapping) on text in text based objects (shape with
text or a text frame), it automatically enters editing mode,
which is not a desired behaviour in a touch based environment.
This behaviour comes from a quick edit mode, which is enabled by
default on the desktop. For Andorid and iOS this is now disabled
when LOK is initialized.
For online this change might also make sense (if the user would
use a mobile device), however this is not implemented now as this
would require more than just changing the global configuration,
as it needs to behave differently depending on the view/user.
Change-Id: Ib4a71cba0aeb4238a5d5b708801a07b39fb5f316
Reviewed-on: https://gerrit.libreoffice.org/74986
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: If863d28c6db470faa0d22273020888d4219e069e
Reviewed-on: https://gerrit.libreoffice.org/74559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I81195505d6006b6587f7b98c1545919083f0e588
Reviewed-on: https://gerrit.libreoffice.org/74497
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I53a019f05978bab62ad0da3d0eb08f37f8ec1e18
Reviewed-on: https://gerrit.libreoffice.org/74414
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
for ExitTimer which is used exclusively for
the case when OOO_EXIT_POST_STARTUP is set, so
that there is no waiting around for ThreadPool's
threads to get joined.
Setting OOO_EXIT_POST_STARTUP already evades any
proper destruction of objects in the heap, so
using _exit() instead of exit() here does not
make things any worse w.r.t the purpose of this
env var.
Change-Id: Ib4a253d6e1a3fd8593e4a2115a51cf4c10344b3c
Reviewed-on: https://gerrit.libreoffice.org/74016
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Otherwise we get crashes in online Kit when attempting to shutdown
reasonably cleanly and the poll kicks in.
Change-Id: I9a1744b42fec9f8ffddc6094773bda943caedf2a
Reviewed-on: https://gerrit.libreoffice.org/74064
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I19f70b0e9d1ca2bbcd2595af24f2e15766d14b33
Reviewed-on: https://gerrit.libreoffice.org/74046
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb
Reviewed-on: https://gerrit.libreoffice.org/74035
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I97e5cda847fd7f98990a87d0b1ca6d6b8b3f9d0f
Reviewed-on: https://gerrit.libreoffice.org/73899
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
since...
commit bb3daa7351f0b07e6f4331c19837081e6c3e30b8
Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com>
Date: Thu Oct 7 13:54:14 2010 +0200
dba34b: #i112779# no need to use a UNO control/peer for the throbber - it exists as VCL control now
Change-Id: I561642d78d76ab970ee12b6b2b2fbdd0be2850e5
Reviewed-on: https://gerrit.libreoffice.org/73954
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I415645fd61113577deef404cceb02d72d541291d
Reviewed-on: https://gerrit.libreoffice.org/73898
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I73401787032643c4881934864d2ec1e0389e2cf2
Reviewed-on: https://gerrit.libreoffice.org/73897
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
> warn:vcl:5039:5039:vcl/source/image/ImplImage.cxx:63: Failed to load scaled image from res/script.png at 1
> warn:vcl:5039:5039:vcl/source/image/ImplImage.cxx:90: Failed to load stock icon res/script.png
> cppunittester: vcl/source/gdi/bmpacc.cxx:38: BitmapInfoAccess::BitmapInfoAccess(Bitmap &, BitmapAccessMode): Assertion `xImpBmp && "Forbidden Access to empty bitmap!"' failed.
Change-Id: I6d1d1ae80f13471e9715afe95ef6b7532b48affe
Reviewed-on: https://gerrit.libreoffice.org/73845
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
> warn:vcl:32616:32616:vcl/source/app/salusereventlist.cxx:114: Uncaught com.sun.star.container.NoSuchElementException message: file:///home/sbergman/lo2/core/instdir/share/config/soffice.cfg/cui/ui/hyperlinkdialog.ui
Change-Id: If7091708d5c6cb6370c26d27bff553f43d8044ba
Reviewed-on: https://gerrit.libreoffice.org/73843
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
So default dialogs will be created in the correct
language, as requested by the client.
Change-Id: I12ebf7443b7f19e733f66b88b5fadfb01cd5e75e
Reviewed-on: https://gerrit.libreoffice.org/68260
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/73484
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e
Reviewed-on: https://gerrit.libreoffice.org/73626
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Quikee agreed that they aren't really useful. Doing even the simplest
things causes such a huge amount of logging that it is questionable
whether anybody could have any use of it.
Parts of it might be useful to restore later, if need arises. Like the
mnContextStackDepth logging in vcl/inc/quartz/CGHelpers.hxx.
Change-Id: If635e6492a50e5955c56c54fa310e7c0ab2986ae
Reviewed-on: https://gerrit.libreoffice.org/73639
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I404a8364a4c7f8d48533fb3c7757a5b7798de9d8
Reviewed-on: https://gerrit.libreoffice.org/73588
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Similar to clang-tidy readability-container-size-empty
Change-Id: I81c0ff78d2ecc7d984e3ed5e5ce60efe327fc162
Reviewed-on: https://gerrit.libreoffice.org/71799
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
It avoids all those calls to _dl_runtime_resolve_xsave that
in KCachegrind's call graph lead to nowhere and make navigating harder.
Change-Id: Ie3843676298d92b8ed6d598ead16f4d410ba8b2b
Reviewed-on: https://gerrit.libreoffice.org/73382
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Ica706842003fe60ba864e013614eb535580446bb
Reviewed-on: https://gerrit.libreoffice.org/73363
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|