summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2019-07-24sd lok: Remove the .uno:LeftPaneImpress call from sd lok initialization.Noel Grandin
this is combination of commit dd15e149326f5270ab9ceb5f21e32b25b96c0a44 Author: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Date: Sun Nov 11 23:37:24 2018 -0500 LOK: sd: initialize slide-sorter in sd (Change-Id: I4cb6ce6d961b4ba4d542c14cb37370788cf75e45) and commit 7e291eedbad335bf8bbc8a17cc3d633bf66d0e90 Author: Jan Holesovsky <kendy@collabora.com> Date: Thu Apr 25 05:54:15 2019 +0200 (Change-Id: I86b23b484674ad4c6a75246ee6186ad9b828931f) sd lok: Remove the .uno:LeftPaneImpress call from sd lok initialization. According to my testing, this makes no difference and the moving of slides and multiple selection behaves the same way with or without this. So let's return to not activating the SlideSorterBar, because otherwise we are doing a lot of pixel bashing behind the scenes unnecessarily. Having said that, if we want to activate it at some stage, it is better to do something like the following (+ remove the explicit LOK-only if's from svtools/source/config/slidesorterbaropt.cxx): SvtSlideSorterBarOptions().SetVisibleImpressView(true); instead (and potentially we can also make it floating not to occupy the space in the main view by GetWindow()->SetFloatingMode(true); in the LOK case in sd/source/ui/dlg/PaneChildWindows.cxxi). Change-Id: I719bc4ca5e43fce9949d494149b65ffd8587c601 Reviewed-on: https://gerrit.libreoffice.org/76220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24"Basic macros" instead of "$Productname Basic macros"Samuel Mehrbrodt
This might lead to confusion as if there were different macro types depending on the current downstream package name. E.g. "LibreOffice Basic macros" might become "LibreOffice Vendor XY basic macros". Remove that confusion by using just "Basic macro" in the UI. Change-Id: Ifc2543bb151e94fc6c6e47d878720dd99294f596 Reviewed-on: https://gerrit.libreoffice.org/76216 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-24Redundant conditionMike Kaganski
Change-Id: I1c67cde8401106a7e9d7ecd5fd3e0b4925ab47d4 Reviewed-on: https://gerrit.libreoffice.org/76212 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-24Drop unneeded initializationMike Kaganski
Change-Id: Ieac1a0acb97664f3b86e2524cab79fd278f42e0e Reviewed-on: https://gerrit.libreoffice.org/76210 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-23Don't draw gridlines and document background in Online server processMike Kaganski
... see https://gerrit.libreoffice.org/72417 They will be drawn client-side. Borders and explicit cell background are still drawn in core. This mode is activated using "sc_no_grid_bg" option in SAL_LOK_OPTIONS environment variable. Change-Id: Ie10e7770b8168ec648d44ae5af0a0a0602d89ee6 Reviewed-on: https://gerrit.libreoffice.org/75484 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-19loplugin:referencecasting in desktopNoel Grandin
Change-Id: I9ba4243bc3d6b14e66694728deb270ed74a70d01 Reviewed-on: https://gerrit.libreoffice.org/75949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448295 Unchecked return valueCaolán McNamara
Change-Id: I4b0dd4fc9051f04448a651cb87b449a58d2a5349 Reviewed-on: https://gerrit.libreoffice.org/75874 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448296 Unchecked return valueCaolán McNamara
Change-Id: I09268bc22f4fb34160975063e38ea60a68123400 Reviewed-on: https://gerrit.libreoffice.org/75875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448333 Unchecked return valueCaolán McNamara
Change-Id: If23db9a245b4dd4b59b9b5410a094f2f374eedfd Reviewed-on: https://gerrit.libreoffice.org/75878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17Resolves: tdf#126304 resizing the extension manager breaks redrawCaolán McNamara
Change-Id: I1211c90a72048f868ec7ba7a7b6bed452ae8ac4b Reviewed-on: https://gerrit.libreoffice.org/75791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17scrollbar is outside the widget now, not insideCaolán McNamara
Change-Id: Ia92658c7a534928209906b8adfb5f9451b513ff0 Reviewed-on: https://gerrit.libreoffice.org/75786 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17LOK: support for ordering/moving partsAshod Nakashian
Currently reordering of slides is only supported for presentations, although it is provisioned for spreadsheets as well. Change-Id: I6c35066d6a5ef7586d34a8e8b89db69a20b86572 Reviewed-on: https://gerrit.libreoffice.org/69612 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73495 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-16tdf#1448393 Uninitialized scalar fieldCaolán McNamara
Change-Id: I0df15244d6208f49d9bce2e27ff3deccfe98f981 Reviewed-on: https://gerrit.libreoffice.org/75697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-13Add more useful exports to soffice's callgrind modeIlmari Lauhakangas
Moved from TDF wiki to avoid duplication. These three stop us getting poor performance from unusual allocators: unset MALLOC_CHECK_ MALLOC_PERTURB_ G_SLICE If we wedge, at least we don't do it while grabbing the mouse: export SAL_DISABLE_FLOATGRAB=1 Turns off recovery dialog, which can be a pain: export OOO_DISABLE_RECOVERY=1 Turns off GL watchdog. It normally kills the application, if it seems to hang in a GL block: export SAL_DISABLE_GL_WATCHDOG=1 Change-Id: I4ec30d363280b727cd305a6a81ccb85849697159 Reviewed-on: https://gerrit.libreoffice.org/73773 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-10Fix typoAndrea Gelmini
Change-Id: Ifca7c0626f9671c1539e7828eb993278574ea10c Reviewed-on: https://gerrit.libreoffice.org/75367 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-10slide-sorter: multiple selectionAshod Nakashian
Change-Id: I8624de25b0bb66020002890f33758e52059a24ab Reviewed-on: https://gerrit.libreoffice.org/69610 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73493 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-04vcl lok: pre-load graphic librariesMiklos Vajna
This is needed to be able to load e.g. TIFF files in Online, which does not have code in the chroot since online.git commit ad21717498cc214d5d5d5c0ff378238552137e2f (Avoid copying most code into the chroot jail., 2018-03-10). Change-Id: Ib095191ee690d9da6269878a82b1c6995df50dfa Reviewed-on: https://gerrit.libreoffice.org/75077 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-02tdf#125655 disbale quick edit mode for iOS and AndroidTomaž Vajngerl
When clicking (tapping) on text in text based objects (shape with text or a text frame), it automatically enters editing mode, which is not a desired behaviour in a touch based environment. This behaviour comes from a quick edit mode, which is enabled by default on the desktop. For Andorid and iOS this is now disabled when LOK is initialized. For online this change might also make sense (if the user would use a mobile device), however this is not implemented now as this would require more than just changing the global configuration, as it needs to behave differently depending on the view/user. Change-Id: Ib4a71cba0aeb4238a5d5b708801a07b39fb5f316 Reviewed-on: https://gerrit.libreoffice.org/74986 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-21simplify some getSupportedServiceNamesNoel Grandin
Change-Id: I81195505d6006b6587f7b98c1545919083f0e588 Reviewed-on: https://gerrit.libreoffice.org/74497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-20Demote from std::unique_lock to std::scoped_lock where applicableStephan Bergmann
Change-Id: I53a019f05978bab62ad0da3d0eb08f37f8ec1e18 Reviewed-on: https://gerrit.libreoffice.org/74414 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-17tdf#125691: use _exit() instead of exit()...Dennis Francis
for ExitTimer which is used exclusively for the case when OOO_EXIT_POST_STARTUP is set, so that there is no waiting around for ThreadPool's threads to get joined. Setting OOO_EXIT_POST_STARTUP already evades any proper destruction of objects in the heap, so using _exit() instead of exit() here does not make things any worse w.r.t the purpose of this env var. Change-Id: Ib4a253d6e1a3fd8593e4a2115a51cf4c10344b3c Reviewed-on: https://gerrit.libreoffice.org/74016 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-17android: Unregistering in runLoop() is important even on Android.Jan Holesovsky
Otherwise we get crashes in online Kit when attempting to shutdown reasonably cleanly and the poll kicks in. Change-Id: I9a1744b42fec9f8ffddc6094773bda943caedf2a Reviewed-on: https://gerrit.libreoffice.org/74064 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-15loplugin:logexceptionnicely in desktopNoel Grandin
Change-Id: I19f70b0e9d1ca2bbcd2595af24f2e15766d14b33 Reviewed-on: https://gerrit.libreoffice.org/74046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-14remove some unused includesCaolán McNamara
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14weld ExtMgrDialog and UpdateRequiredDialogCaolán McNamara
Change-Id: I97e5cda847fd7f98990a87d0b1ca6d6b8b3f9d0f Reviewed-on: https://gerrit.libreoffice.org/73899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13no need for awt::Toolkit::create in UpdateDialogCaolán McNamara
since... commit bb3daa7351f0b07e6f4331c19837081e6c3e30b8 Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Thu Oct 7 13:54:14 2010 +0200 dba34b: #i112779# no need to use a UNO control/peer for the throbber - it exists as VCL control now Change-Id: I561642d78d76ab970ee12b6b2b2fbdd0be2850e5 Reviewed-on: https://gerrit.libreoffice.org/73954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13drop intermediate IExtensionListBox classCaolán McNamara
Change-Id: I415645fd61113577deef404cceb02d72d541291d Reviewed-on: https://gerrit.libreoffice.org/73898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-12move IExtensionListBox to where its usedCaolán McNamara
Change-Id: I73401787032643c4881934864d2ec1e0389e2cf2 Reviewed-on: https://gerrit.libreoffice.org/73897 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-12Missing test dependencyStephan Bergmann
> warn:vcl:5039:5039:vcl/source/image/ImplImage.cxx:63: Failed to load scaled image from res/script.png at 1 > warn:vcl:5039:5039:vcl/source/image/ImplImage.cxx:90: Failed to load stock icon res/script.png > cppunittester: vcl/source/gdi/bmpacc.cxx:38: BitmapInfoAccess::BitmapInfoAccess(Bitmap &, BitmapAccessMode): Assertion `xImpBmp && "Forbidden Access to empty bitmap!"' failed. Change-Id: I6d1d1ae80f13471e9715afe95ef6b7532b48affe Reviewed-on: https://gerrit.libreoffice.org/73845 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-12Missing test dependencyStephan Bergmann
> warn:vcl:32616:32616:vcl/source/app/salusereventlist.cxx:114: Uncaught com.sun.star.container.NoSuchElementException message: file:///home/sbergman/lo2/core/instdir/share/config/soffice.cfg/cui/ui/hyperlinkdialog.ui Change-Id: If7091708d5c6cb6370c26d27bff553f43d8044ba Reviewed-on: https://gerrit.libreoffice.org/73843 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-12LOK: set the language for LOK before document loadingAshod Nakashian
So default dialogs will be created in the correct language, as requested by the client. Change-Id: I12ebf7443b7f19e733f66b88b5fadfb01cd5e75e Reviewed-on: https://gerrit.libreoffice.org/68260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/73484 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-07lok: re-factor getTextSelection.Michael Meeks
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e Reviewed-on: https://gerrit.libreoffice.org/73626 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-07Bin the much too verbose SAL_INFO() calls for the "vcl.cg" tagTor Lillqvist
Quikee agreed that they aren't really useful. Doing even the simplest things causes such a huge amount of logging that it is questionable whether anybody could have any use of it. Parts of it might be useful to restore later, if need arises. Like the mnContextStackDepth logging in vcl/inc/quartz/CGHelpers.hxx. Change-Id: If635e6492a50e5955c56c54fa310e7c0ab2986ae Reviewed-on: https://gerrit.libreoffice.org/73639 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-06-06loplugin:data (macOS)Stephan Bergmann
Change-Id: I404a8364a4c7f8d48533fb3c7757a5b7798de9d8 Reviewed-on: https://gerrit.libreoffice.org/73588 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-05Use hasElements to check Sequence emptiness in cppcanvas..desktopArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: I81c0ff78d2ecc7d984e3ed5e5ce60efe327fc162 Reviewed-on: https://gerrit.libreoffice.org/71799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-03LD_BIND_NOW=1 if running under callgrindLuboš Luňák
It avoids all those calls to _dl_runtime_resolve_xsave that in KCachegrind's call graph lead to nowhere and make navigating harder. Change-Id: Ie3843676298d92b8ed6d598ead16f4d410ba8b2b Reviewed-on: https://gerrit.libreoffice.org/73382 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-06-03LOK: Factor out iOS painting codeTomaž Vajngerl
Change-Id: Ica706842003fe60ba864e013614eb535580446bb Reviewed-on: https://gerrit.libreoffice.org/73363 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-03tdf#123697 we need to create a bitmap context with alphaTomaž Vajngerl
Change-Id: Ib934314e56163983e70a0b04eb667e6b8527c783 Reviewed-on: https://gerrit.libreoffice.org/73362 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-02drop some unneeded includesCaolán McNamara
Change-Id: I13019ae1b991b5910c50e760a8a825bcf50509d2 Reviewed-on: https://gerrit.libreoffice.org/73321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28drop some unneeded includesCaolán McNamara
Change-Id: I42b2ccbb4484ab2acb8208ad88c6f22e4af09f7d Reviewed-on: https://gerrit.libreoffice.org/73114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-27disable a few failing unit tests in MPLv2 subsetAndras Timar
Change-Id: If7595983f7bf2d990687a64659a63a8a66b120bd Reviewed-on: https://gerrit.libreoffice.org/73049 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-24Fix typo in help: 'urb' => 'urp'Jan-Marek Glogowski
Introduced in commit a4066c770fec ("Fix documented 'soffice --accept' parameter syntax"). Change-Id: Iaa8e821abeb8bdbce36091c4d0264f658c677a76 Reviewed-on: https://gerrit.libreoffice.org/72905 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-23Fix documented 'soffice --accept' parameter syntaxJan-Marek Glogowski
The parameter value for '--accept' is no UNO-Url, but uses a similar syntax. This was wrongly changed in commit d78f29ab3f40 ("tdf#100836 "Starting the LibreOffice Software With Parameters" help update"). So this changes the parameter value back to {accept-string}, documents its syntax and adds some common examples. Change-Id: If8159b1d982c54e3dca6d27a1c400d2450ff2d1e Reviewed-on: https://gerrit.libreoffice.org/72859 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-05-23sw: add IgnoreComments parameter to .uno:PasteMiklos Vajna
Which allows not hardcoding true for LOK. Change-Id: I644763ba052b148fc34283e361aa02f9bba2c5ee Reviewed-on: https://gerrit.libreoffice.org/72832 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-22New loplugin:dataStephan Bergmann
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-21tdf#125397: Fixes for threads and SolarMutex on iOSTor Lillqvist
We need to call SfxApplication::GetOrCreate() in lo_initialize() now. Otherwise we will crash in sfx2. No idea why it worked earlier. I think we want to avoid the "VCLXToolkit VCL main thread" ever running in the iOS app. I don't think we had it running earlier, but now for some reason it got started when creating a document from a template, and that seemed to cause a hang. Also, when creating a document from a template, lo_initialize() is called from the app's real main thread (the one that the process starts in). In that case we do want to release the SolarMutex after InitVCL() if this was the first time we called InitVCL(). Awful crack. Not really sure I fully understand all that is going on, but this change does seem to fix recent problems... All this thread and SolarMutex stuff is so incredibly fragile. Change-Id: Ib04498ad199b64f27701f89d2df7003bca316406
2019-05-20lok: chart: constrained dragging of pie segmentsMarco Cecchetti
The extra information for the graphic selection is now formatted according to JSON syntax so that is easier to parse. Information for allowing the client to performa constrained dragging of a pie segment is appended when needed to the graphic selection message. A polygon approximation of the pie segment in svg format is attached too to the graphic selection message. Core now is able to handle a specific msg from the client with data about the new pie segment offset computed by the client on drag end. This information is dispatched by the chart controller to a specific method: executeDispatch_LOKPieSegmentDragging. Change-Id: I42e7742508fa3a453383bf7b95e47df169f24834 Reviewed-on: https://gerrit.libreoffice.org/70568 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: dragging and resizing chart elementsMarco Cecchetti
This patch make possible to set the new position or size of a chart object through setting directly the property value instead of sending mouse events to the core. Change-Id: Ifc06dac6bdad78081d63e0ea0db55563a1ae57bc Reviewed-on: https://gerrit.libreoffice.org/70566 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: shape selection: perform the needed unit conversion in a clever wayMarco Cecchetti
Change-Id: I505bd41801b5fd1898a9eddc81b102f2f7ae20b5 Reviewed-on: https://gerrit.libreoffice.org/70563 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-01 05:11:43 +0000