summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu
Change-Id: I3099818283a9801976288d0efa67a8711106f376 Reviewed-on: https://gerrit.libreoffice.org/28360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25cid#1371326 Misused comma operatorNoel Grandin
Change-Id: I8b27c4d20e86b6cf173374df0242f438909b4db6
2016-08-24tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu
Change-Id: I59c605bb31859a2a419cc9e9e60c174e842a03db Reviewed-on: https://gerrit.libreoffice.org/28349 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-22clearly we want to match "-env:" only at arg start, not as substring anywhereEike Rathke
Change-Id: Id7238329118ac6f9ddf58b31c6477be002895307
2016-08-19sw redlines: expose description as part of the UNO/LOK APIMiklos Vajna
A redline can have a manual comment and also an autogenerated description, like "Insert 'abc'". Expose this later property as well, as it provides useful additional information, especially when the comment property is empty. Change-Id: Id0f0ff62aef58d96b9b6071706c6f5b4a0d74800
2016-08-19coverity#1371375 Resource leakCaolán McNamara
Change-Id: I53b5ddc26e77168c29ba1bcfd199b1accbc54d3a
2016-08-19coverity#1371119 Unchecked return valueCaolán McNamara
Change-Id: I6a39ee4aafe646c542f03c8548e1822837dfde5c
2016-08-19tdf#101592 sw: track changes state is doc-specific, not view-specificMiklos Vajna
So update the bindings of all views after changing it. Change-Id: I5355f40ba27be521dcdf343b08305f3736979bbb Reviewed-on: https://gerrit.libreoffice.org/28233 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-18experiment with renaming for bogus coverity#1371326 Misused comma operatorCaolán McNamara
Change-Id: Idd2cc5e888c85a33c9d26aac26c48f3c74571724
2016-08-18cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I61ab542f4cc777ecd8f8393c7bcbb681e529de5f
2016-08-18cppcheck: passedByValueCaolán McNamara
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
2016-08-18screenshots: add new global make targetArmin Le Grand
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for desktopArmin Le Grand
Only one dialog had to be disabled, some others look not very useful Change-Id: I2f8e786c0bb94259c5d03e7a72cc1d6ed9bbc066
2016-08-17lok::Document::getCommandValues: expose redline infoMiklos Vajna
Index is added as a property for each item, so that later changes can be identified by the index when they are accepted/rejected. Change-Id: I9362d208fdbed1f46d64558d44498d2b19150c81
2016-08-15Resolves: tdf#44241 highlight the newly installed extensionCaolán McNamara
this was changed by commit a6efec83cee0ab447f9e6a5716aee5d2165f95c7 Date: Mon Nov 28 10:54:55 2011 -0200 Fix for bug fdo39748, Easy-hack Cleanup extension list. so restore addPackageToList to not remove the old one before potentially re-adding it, and instead follow the same model as TheExtensionManager::modified to refresh the list Change-Id: I8c3207760361dbd42e400fa9f323ca42971bbcc0 Reviewed-on: https://gerrit.libreoffice.org/28137 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-14tdf#100965: Restart on initialisation-time OpenCL crashTor Lillqvist
Add a flag to the OpenCLZone indicating whether we are performing the first-start OpenCL functionality verification, so that if we run into a crash that is caught by the VCL VCLExceptionSignal_impl() handler, we terminate the process with the EXITHELPER_NORMAL_RESTART status after first having disabled OpenCL use. The wrapper process will then restart soffice.bin. This is for Windows only so far. This matches what we do if OpenGL fails early during start of LibreOffice. Change-Id: Ibb9bf3a86b7521bf16728de2a118ad4323be674b Reviewed-on: https://gerrit.libreoffice.org/28086 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-08-05(initial) sparc64 portJames Clarke
Change-Id: I8ec9bb5415a9e6b9083ba89a7790872d67625de1
2016-08-05desktop: add undo/redo support to lok::Document::getCommandValues()Miklos Vajna
Expose the undo/redo stack and the metadata of each item. Change-Id: I66b81e855a945c97be3d491ed709959f310d4b73 Reviewed-on: https://gerrit.libreoffice.org/27905 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-05loplugin:countusersofdefaultparams in chart2..desktopNoel Grandin
Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee Reviewed-on: https://gerrit.libreoffice.org/27896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04CppunitTest_desktop_app needs the Foundation framework when sandboxedTor Lillqvist
Because cmdlineargs.cxx uses NSTemporaryDirectory when HAVE_FEATURE_MACOSX_SANDBOX. Change-Id: I120a1f69bc94be161b76a9b813623103adc5fbe7
2016-08-01lok: re-load UNO bootstrap pieces and set UserInstallation on second init.Michael Meeks
Ideally should check whether the path is different. Changing the user-install path is useful for valgrinding online outside of a chroot jail. Change-Id: I6ad76af1245491acdcb6664896be89073406b742 Reviewed-on: https://gerrit.libreoffice.org/27782 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-31tdf#100837: honor LibreOffice command line arguments for Office URIsMike Kaganski
This patch allows modifying open mode set in Office URI by using LibreOffice usual command line arguments. For instance, if there is -p "ofe:...", then the file won't be open for editing, but instead will be printed. Change-Id: I4bde9b6e1c0e92b63ee3834ee1fd8f6e1bd321f2 Reviewed-on: https://gerrit.libreoffice.org/27629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-07-28desktop: fix Android buildMiklos Vajna
Change-Id: I1ea8edba2dc34386c2748c3ee2310963252082e6
2016-07-27add uui component to some other placesCaolán McNamara
Change-Id: If07caacf7bc18b39820db73fe64201f9cb97bc6c
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26Restructure CommandLineArgs::ParseCommandLine_ImplMike Kaganski
CommandLineArgs::ParseCommandLine_Impl is restructured to remove multiple redundant booleans and make its structure more clear. Command line "events" (that specify following filenames treatment) are grouped to an enum. (NB: "events" is not invented by me, this is currently used term). Normalized treatment of --display param: now it is always ignored. Previously, if it happened to be a known switch like --writer, it handled as it's not after --display. Immediate parameters to switches --pt, --convert-to, --outdir, --printer-name are now treated likewise. They are treated as corresponding values, even if they happen to be known switches. --language (without "=") is no more a recognized switch. Before this it skipped all filenames until next file management switch. After this gets approved, TODO is to tweak Office URIs to take current event into account: e.g., to print opened file if it's after -p. Change-Id: Ic2f3980548f8906f695d297dc6677bd2cbd19c5b Reviewed-on: https://gerrit.libreoffice.org/27316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25Fix some misleading commentsTor Lillqvist
Change-Id: I0f29133c3e9b881835b970b2226583ec348828cb
2016-07-19desktop: simplify $(ENABLE_BREAKPAD) checksMichael Stahl
Change-Id: Ibe2da6214b1f6555922313b22e2882a2ddb4b9e7
2016-07-19desktop: CppunitTest_desktop_app requires breakpadMichael Stahl
Change-Id: I314fd2ba94ec6efdfecbc9694138a6410665163c
2016-07-19clang-tidy performance-unnecessary-value-param in desktopStephan Bergmann
Change-Id: I1b1bf615c5afcb6e14929fde456c6b734be65414
2016-07-19tdf#100837: Support Office URI SchemesMike Kaganski
This patch adds support for Office URI Schemes (see https://msdn.microsoft.com/en-us/library/dn906146). This will enable browser (non-CMIS) integration of LibreOffice with MS SharePoint server (v.2013 tested). In this patch, in addition to ms-* schemes, a new scheme is introduced: vnd.libreoffice.command, which is analogous to ms-*. Its purpose is to enable flexible configuration of server and client, where some types of documents are declared as handled by LibreOffice, and other are handled by other software. E.g., ODTs may have "vnd.libreoffice.command" scheme, while DOCXs could be "ms-word". Client may register LibreOffice to handle both, or to handle only "vnd.libreoffice.command" scheme. Unit test included. TODO in a later patch: add a mechanism to register LibreOffice to the schemes with OS. Change-Id: I1c449a211102036f87163058a4c90a93eb32c948 Reviewed-on: https://gerrit.libreoffice.org/27094 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-18lok: Skip saving unmodified doc if DontSaveIfUnmodified=truePranav Kant
Change-Id: Ia2687bd4bef61df1ff101cab2a19394859b7df58 Reviewed-on: https://gerrit.libreoffice.org/27212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2016-07-15Related tdf#37531: Make --cat headless/hidden like --convert-toStephan Bergmann
...which automatically takes care of the open problem from 08960441558743f222280637985690bb8b41b861 "Related tdf#37531: Handle conversion args sent over pipe" that --cat terminates the called soffice. Change-Id: Ief8cdf8c1335749dad1504966d635e0519fe92f7
2016-07-15Related tdf#37531: --convert-to output relative to caller's CWDStephan Bergmann
Change-Id: Ifad33650694c16e89fc5e51fd4322da732f7d3eb
2016-07-15Related tdf#37531: Handle conversion args sent over pipeStephan Bergmann
However: * "soffice --convert-to pdf foo.odt" creates foo.pdf in the called soffice's CWD, not the caller's. * "soffice --cat foo.odt" prints to the called soffice's stdout, not the caller's (though this will unlikely ever be fixed), and then also terminates the called soffice. Change-Id: I2f4420881b2bee00b0476c76f739966c13101be4
2016-07-15Log PipeIpcThread communicationStephan Bergmann
Change-Id: I9e818351a435d39a9d1d8988214185f5bc504e8c
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-14sc lok: add more toolbar itemsHenry Castro
.uno:SortAscending .uno:SortDescending Change-Id: I3d307b43fb18ffce75b00a0b919b63320bf6db05 Reviewed-on: https://gerrit.libreoffice.org/27223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-07-13Remove __cplusplus-checks from apparently-C++-only filesStephan Bergmann
Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6 Reviewed-on: https://gerrit.libreoffice.org/27187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-12tdf#100883 - opencl impls. that use SEH are still bad.Michael Meeks
Amazingly we fell-back to the old calculation path for crashes in older LibreOffices, might as well have this on master. Change-Id: Ifc1de41c93329207d7a1917c736e361d840c2821 Reviewed-on: https://gerrit.libreoffice.org/27166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-12opencl: bail out early in missing OpenCL case.Michael Meeks
Change-Id: I2ff1466ec89f4ad9743cedbfa5dd52be8bf86590 Reviewed-on: https://gerrit.libreoffice.org/27136 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-12desktop: validate OpenCL drivers before use.Michael Meeks
OpenCL validation needs to happen before drivers are used in anger. This should isolate any crashes, and/or mis-behavior to We use app version, CL driver version and file time-stamp to trigger re-testing the device. If anything fails: hard disable OpenCL. We use an opencl validation sheet (cl-test.ods) and install it. It is a minimal CL set - it requires a very short formula group length, and combines several CL functions into few formulae to test more. The sheet structure, in particular the manual squaring / SQRT is necessary to stick within the default CL subset, and ensure that formulae are CL enabled from the root of the dependency tree up. Change-Id: I18682dbdf9a8ba9c16d52bad4447e9acce97f0a3 Reviewed-on: https://gerrit.libreoffice.org/27131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-11loplugin:nullptr: Better heuristic to determine code shared between C and C++Stephan Bergmann
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-10lok: disable unused UNO commandsHenry Castro
Change-Id: I9804c1c8528747e719971f51b59d0a01a9fba878 Reviewed-on: https://gerrit.libreoffice.org/27091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-07-09Resolves: tdf#90526 don't show splashscreen for -pt -or -pCaolán McNamara
Change-Id: I64c6d82e3ff738fbc83b00d640765e8863ccd9b6
2016-07-09Resolves: tdf#71064 failed to open display with -h but not --helpCaolán McNamara
when there is no DISPLAY set Change-Id: Ic4f10d6f4781d01a05e51862b41311a2c1a3dc66
2016-07-08sw lok: add LOK_CALLBACK_VIEW_CURSOR_VISIBLEMiklos Vajna
With this, in case a text cursor is turned into a graphic selection in view#0, then view#1 can also hide the text cursor of view#0. Change-Id: I7de89b8537ef8b0985336793b719d93733604bff Reviewed-on: https://gerrit.libreoffice.org/27044 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>