summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2017-12-28rtl: support start/stop threads around pre-initAshod Nakashian
This is necessary to avoid having extra threads while forking. After forking, the second stage of pre-init is started and so we start the stopped rtl threads. The comment for rtl_alloc_preInit_phase_t has more details. Change-Id: I1a3f7be74d4b04d0b2fc4a72b02124c2faa3c047 Reviewed-on: https://gerrit.libreoffice.org/47060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-23LOK: support password-protected PDF docsAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/45547 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit dc773e81bd360316a96b1b61c552d263e1d87e89) Reviewed-on: https://gerrit.libreoffice.org/45563 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 82fb0abc37320fb1157b21efbf31954190353d41) Change-Id: I48d959dba2c38b72d1d6fc0fa9171b96dbed0e7c Reviewed-on: https://gerrit.libreoffice.org/46986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-22request installation of langpack via packagekitCaolán McNamara
if ui is set to track the locale automatically and the current locale has no match in installed resources but has a match in the list of languages that libreoffice was compiled to contain so e.g. de_AT locale shouldn't trigger the installation of anything if langpack-de is already installed and yue_HK shouldn't trigger install of anything cause that not supported (at time of writing) for libreoffice put Fedora/RHEL/Ubuntu naming schemes in here. I moved the lang code from svl to svtools so I could use the restart dialog to prompt to restart after the langpack is installed, but packagekit's blocking mode seems to be no longer blocking and control returns immediately which is a change since the last time I played with this stuff, so drop the restart thing for now. The lack of a blocking modal also makes the "run this on idle when there's a toplevel window up and running" a bit futile, but lets keep that for now anyway. caolanm->rene: I know you'd disable this anyway, so Debian is left out, there's also config key Office/Common/PackageKit/EnableLangpackInstallation to disable this too. Change-Id: Ice731be539850338ccdd8af87839e0b4d83f01e7 Reviewed-on: https://gerrit.libreoffice.org/46856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-20lokdialog: Use Application::Post{Mouse,Key}Event() to post to main threadPranav Kant
... instead of custom machinery there to post to main thread. This also now posts window key events to the main thread instead of processing them on the lok thread. Change-Id: Ided1efb3f237a1838fa50bb8d74752be714c3032
2017-12-19lokdialog: Handle closing of modeless dialogs tooPranav Kant
Change-Id: I87ed60e940fad199b14a2e2179cc1f10008bfe93
2017-12-19lokdialog: Allow windows / dialogs in different languages.Jan Holesovsky
Change-Id: I9f32161981aed73e6d97696e5f976af276d1625a Reviewed-on: https://gerrit.libreoffice.org/46327 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46775 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19remove unused typedefsNoel Grandin
Change-Id: I6fd7a9fed3a80c91a3766fceefd43c5db0aa5275 Reviewed-on: https://gerrit.libreoffice.org/46763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18coverity#1426312 Unchecked return valueCaolán McNamara
Change-Id: I59c65a2fc43e55c445efde351e7bd959f6dfbd04
2017-12-18loplugin:unusedindexMike Kaganski
Change-Id: I256a807dd2a4c81126b5a76f3d472e31b8224146 Reviewed-on: https://gerrit.libreoffice.org/46652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16lok: sc: append the col, row position to the cell cursor messageMarco Cecchetti
The payload changes from: "x, y, width, height" to: "x, y, width, height, column, row". This feature is exploited by online starting from the 3.0 release. This change is compatible with older online release: the column, row coordinates are just ignored. Change-Id: I7f8c0e3685c57ff20520ee068b215037f6137389 Reviewed-on: https://gerrit.libreoffice.org/46528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-15lok: calc: LOK_FEATURE_RANGE_HEADERSMarco Cecchetti
For allowing the client to enable/disable the new range based header data Change-Id: I95da8ec3e48137fb75b9b22af3bb1296001ba9ca Reviewed-on: https://gerrit.libreoffice.org/46095 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 069cf9321be51e7203e336e0e87d8ba7dc9b729e) Reviewed-on: https://gerrit.libreoffice.org/46570 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-15sal: add pre-initialization scheme for allocations.Michael Meeks
This saves several megabytes of dirtied pages for each LOK client of Online. Change-Id: I425a2e7896879f0a64d71fcc0655e9e1fa1256aa
2017-12-12Fix binary incompatible change in the LOK API + add unit test.Jan Holesovsky
Change-Id: I53cb40ea351bf56b1a299857a59ae4bf7c6b6dc3 Reviewed-on: https://gerrit.libreoffice.org/46272 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08sw lok: enable Page Header/FooterHenry Castro
Change-Id: I5e0d080c53079069a086f06c2a314b6372bf6391 Reviewed-on: https://gerrit.libreoffice.org/39782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-08loplugin:salcall vcl builder methodsNoel Grandin
these don't need to be SAL_CALL, and the function pointer definition was not annotated SAL_CALL either Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e Reviewed-on: https://gerrit.libreoffice.org/46067 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07lokit: add .uno:DocumentRepair commandHenry Castro
Change-Id: I5b13ea6f4785bc91c29111fa63c4a1b0ea9b2660 Reviewed-on: https://gerrit.libreoffice.org/38908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-07lok: discard name languages not registeredHenry Castro
there is a STR_ARR_SVT_LANGUAGE_TABLE table that all language names are registered But not all, like locale "es" { LANGUAGE_SPANISH_LATIN_AMERICA, "es", "" , k0 } Avoid that names until get registered appropriately Change-Id: I148f2c30f72c82c978f5e9a1e977bf4b5e923a9c Reviewed-on: https://gerrit.libreoffice.org/46027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06lokdialog: State change events for dialogs uno commandsPranav Kant
Change-Id: I92f60e717cd2a0695c8b86b103076d26c0c22cef
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04lokdialog: Merge dialog & dialog child mouse event APIs into onePranav Kant
Change-Id: I91aaa6a58f33dd2d817e02533de96e0c8191f2ca
2017-12-04lokdialog: Rename postDialogKeyEvent -> postWindowKeyEventPranav Kant
Change-Id: I78b434106fbef153adde255d4fcc8f74a7169175
2017-12-04lokdialog: Simplify; make the LOK dialog API more genericPranav Kant
Merge the dialog floating window callbacks and function calls into one. Unique window ids across vcl::Window is enough to distinguish between them. Floating windows don't have a LOK notifier as they are created in the vcl itself (so we can't access them from sfx2). Use the parent LOK notifier in that case (which would be a dialog). This API should also help in autopopup filter tunneling later. Change-Id: I63a2c97ffdd84695dc967e14c793089a7c50b41b
2017-12-04lokdialog: Kill some code; use already existing method to paintPranav Kant
This is not require now in the new approach where the dialog is already created by the time paint request call for dialog happens. Layouting is already complete by that time. Change-Id: I610b050a268e61e8d4036aa7eb5766cf0c8b37e0
2017-12-04lokdialog: Allow closing a dialog from LOK clientPranav Kant
... and rename paintDialog -> paintWindow before it's too late. We not only render dialogs now but also popups. Change-Id: I6b1253c4d9be0c79199b683df4413658a461f850
2017-12-04lokdialog: Execute all UNO commands asynchronously for LOKPranav Kant
Especially in case of dialogs, Online cannot afford to wait till the call to UNO command returns as the same thread is responsible for doing many more tasks as well. And just adding this check doesn't seem to have any repurcussions, so I guess we are fine. Change-Id: Iac7c1413d90e8a264502dcf2bc280e09fd52683b Reviewed-on: https://gerrit.libreoffice.org/45527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-12-04new loplugin salcall: remove unnecessary SAL_CALLNoel Grandin
In this first commit, I use the plugin to verify the consistency of our SAL_CALL annotations. The point being to make the next commit more mechanical in nature, purely using the rewriter. There are various chunks of unix-only code that have never had to be compiled by MSVC, hence the inconsistencies. In bridges, I had to inline some typedefs to make the verification code happy, since it cannot see into typedefs. Change-Id: Iec6e274bed857febf7295cfcf5e9f21fe4a34da0 Reviewed-on: https://gerrit.libreoffice.org/45502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-01lok: calc: set outline stateMarco Cecchetti
use a specific message from the client for set the visibility state of a group instead of hijacking the update row/column header message Change-Id: I9634c24bbffaddc916c8ad716ac6d5d31e735a55 Reviewed-on: https://gerrit.libreoffice.org/45445 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-11-30lok: Replace this custom loop with STLPranav Kant
Change-Id: I3b93654ba3d41733209ff819ca1d0250fb47ce74 Reviewed-on: https://gerrit.libreoffice.org/45526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-30lokdialog: Compress DIALOG_CHILD callbacksPranav Kant
In complex dialogs, they flood the lok client otherwise with duplicate callbacks. Change-Id: I6ab1ef12b90caed22dfc464e18068f5830cb9532
2017-11-29lok - calc: outline and group handlingMarco Cecchetti
Change-Id: Ibb287468653bc381acf034dcb8531c5faf61aef3 Reviewed-on: https://gerrit.libreoffice.org/45356 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-11-29Fix 'unused parameter' warnings.Jan Holesovsky
Change-Id: I8478e907a66ca918eddc7a543cbcf23e17d9ee5a
2017-11-29lokdialog: Remove getDialogInfo + update gtktiledviewer accordingly.Pranav Kant
Change-Id: I6f810c97f2fadd3b1ea602a97e24c8b42f4a84b9
2017-11-29lokdialog: Move the LOKWindowId <-> VclPtr<Window> mapping to Window.Jan Holesovsky
This allows registering & de-registering of non-sfx windows too, and makes the Calc autofilter popup to appear. Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93
2017-11-29lokdialog: Move the painting down to Window, and enable Calc and Impress.Jan Holesovsky
Tested with .uno:FormatCellDialog in Calc, Impress not tested. Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8
2017-11-29lokdialog: Make vcl::DialogID an integerPranav Kant
This will help launching multiple instances of dialog from multiple views. The earlier approach of using the UNO command strings as dialog id would not have been useful for multi-view case. Change-Id: I01cfb3c8b204d5654df2417efdac6b50dc920f0e
2017-11-29loplugin:unusedmethodsNoel Grandin
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1 Reviewed-on: https://gerrit.libreoffice.org/45386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-25LOK: provide user feedback while preloading.Michael Meeks
Problems are hard enough to debug in a jailed kit process inside a docker image; provide some visual feedback via stderr. Change-Id: I54b0a21c1375be2acc9da0bbacf959a419471b08 Reviewed-on: https://gerrit.libreoffice.org/45256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-24Remove redundant callPranav Kant
This call, which sets the DialogCancelMode to fatal is superceded by another call which resets the DialogCancelMode back to Silent, as follows. 0 0x00007fffc8c1ece3 in Application::SetDialogCancelMode(Application::DialogCancelMode) (mode=Application::DialogCancelMode::Silent) 1 0x00007fffc8c1f1fc in Application::EnableHeadlessMode(bool) (dialogsAreFatal=false) 2 0x00007fffdd3824af in desktop::Desktop::RegisterServices(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) 3 0x00007fffdd361eeb in desktop::Desktop::Main() (this=0x7fffde919950) 4 0x00007fffc8c261f3 in ImplSVMain() 5 0x00007fffc8c2635c in SVMain() Change-Id: I30efe63932e98309f4d6ac609d09b08378076007
2017-11-23tdf#90794 Position of progress bar on high res screensheiko tietze
Introduced two new consts Change-Id: I15e01eabe9fd3225c36d06cbb59310a07a30f2c1 Reviewed-on: https://gerrit.libreoffice.org/45105 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-11-23tdf#112689 Replace chained O(U)StringBuffer::append with operator+Timotej Lazar
Change-Id: Iea9a6e2104966bd47f09a82df9b01f065f678d17 Reviewed-on: https://gerrit.libreoffice.org/45079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Various loplugin warnings in --enable-online-update=marStephan Bergmann
Change-Id: I5dabd5b65420d30b8d5b631de4d755ecf385b762 Reviewed-on: https://gerrit.libreoffice.org/45027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-21fix fallout from orcus upgrageDavid Tardon
Change-Id: I79a9988c24d04b9c6a9369653a60b2324465b1d8
2017-11-13Fix typosAndrea Gelmini
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-12iOS, make sure SfxApplication::GetOrCreate() is calledjan Iversen
For some reason SfxApplication::GetOrCreate() was never called, this leads to problems when opening documents (reference to shared pointer). Adding dummy call to SfxApplication::GetOrCreate() to make sure the list contains at least one entry. Change-Id: Ic8848c17efae5a0a38c9e9f7299a5f36f69aef31
2017-11-10Upgrade these SAL_WARNs to INFOPranav Kant
These are very common occurrences. Let's not flood the warning output. Also ressurrect some helpful looking commented out SAL_INFOs Change-Id: I3368fb46b27b72edd8ba1f52e2a145a661c40477
2017-11-09lokdialog: Compress invalidation callbacks in Callback flush handlerPranav Kant
Change-Id: Id76bde54395611f509a5d4be6bb2ac9b7f6ed1c0 Reviewed-on: https://gerrit.libreoffice.org/44474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-09lokdialog: Move getting dialog information in separate LOK callPranav Kant
Using outparameters to get the dialog information with the paintDialog call was quite confusing. Change-Id: Ief331b251dc66e66084b827ce5b025ba6c9ce7d2 Reviewed-on: https://gerrit.libreoffice.org/44473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-17 09:43:24 +0000