summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2016-08-18tdf#100965: Restart on initialisation-time OpenCL crashTor Lillqvist
Add a flag to the OpenCLZone indicating whether we are performing the first-start OpenCL functionality verification, so that if we run into a crash that is caught by the VCL VCLExceptionSignal_impl() handler, we terminate the process with the EXITHELPER_NORMAL_RESTART status after first having disabled OpenCL use. The wrapper process will then restart soffice.bin. This is for Windows only so far. This matches what we do if OpenGL fails early during start of LibreOffice. Also, the enter() and leave() functions are not used anywhere (cherry picked from commit 32881f01833dbcefd5600e1135dd8743178bfd96) (cherry picked from commit b9898f03eb05411c508b1b02588812074d40417a) Change-Id: Ibb9bf3a86b7521bf16728de2a118ad4323be674b Reviewed-on: https://gerrit.libreoffice.org/28138 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-12tdf#100883 - opencl impls. that use SEH are still bad.Michael Meeks
Amazingly we fell-back to the old calculation path for crashes in older LibreOffices. Change-Id: Ia182f7a25c5560b68494d5cdd68e02925bfd5845 Reviewed-on: https://gerrit.libreoffice.org/27169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-12desktop: validate OpenCL drivers before use.Michael Meeks
OpenCL validation needs to happen before drivers are used in anger. This should isolate any crashes, and/or mis-behavior to We use app version, CL driver version and file time-stamp to trigger re-testing the device. If anything fails: hard disable OpenCL. We use an opencl validation sheet (cl-test.ods) and install it. It is a minimal CL set - it requires a very short formula group length, and combines several CL functions into few formulae to test more. The sheet structure, in particular the manual squaring / SQRT is necessary to stick within the default CL subset, and ensure that formulae are CL enabled from the root of the dependency tree up. Reviewed-on: https://gerrit.libreoffice.org/27131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit c44726c48228d9c6a5960e302b1c0bd16b0099c4) + opencl: bail out early in missing OpenCL case. (cherry picked from commit 605a5dc088385ad21c33028d8107125c0316ddb1) + Remove bogus dependency from opencl to configmgr Since f41eb66302208f384a475fb20c98b6d1b0676cb6 "opencl: OpenCLZone, detect CL device change and disable CL on crash" vcl links against opencl (so indirectly linked against configmgr), which caused CppunitTest_configmgr_unit to include the configmgr object files both statically (through gb_CppunitTest_use_library_objects) and through the linked-in configmgr dynamic library, which in turn caused ASan builds to report an ODR violation for a doubly defined 'typeinfo name for configmgr::Access'. (cherry picked from commit 9c711f05fa10dc70e4257a1f48d43f539353541a) Change-Id: I18682dbdf9a8ba9c16d52bad4447e9acce97f0a3 Reviewed-on: https://gerrit.libreoffice.org/27141 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-08Resolves: tdf#100713 on cancel curData points to deleted parents vector entryCaolán McNamara
Change-Id: Ic2f313c357ce9526eb045791e2d27451e52a7572 (cherry picked from commit 17cb84338d6921d012af1e1245f434f90bc25142) Reviewed-on: https://gerrit.libreoffice.org/27039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-06-20move the code for tdf#99410 to the sal init windows codeMarkus Mohrhard
Change-Id: I4ead30fa1736a3a99fb3379e89367934c8df2809 Reviewed-on: https://gerrit.libreoffice.org/26444 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 909d87cc6187ecffa2704e67ffbe372fd2d90e49) Reviewed-on: https://gerrit.libreoffice.org/26489
2016-06-16work around MSVCR2013 bug around AVX, tdf#99410Markus Mohrhard
http://crashreport.libreoffice.org/stats/crash_details/d7bc6c8a-e8c2-4c1f-8291-ccab84ea892c Change-Id: I76f9614bc54988c001c9b252707e4b5d4c588112 Reviewed-on: https://gerrit.libreoffice.org/26339 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 4f32fcf59854fe1abe375c8702cc5c4258abbf3d) Reviewed-on: https://gerrit.libreoffice.org/26342
2016-06-08use a dynamic library for minidump shared codeMarkus Mohrhard
This has the disadvantage to make the minidump_upload executable depend on LibreOffice libraries but there seems to be no other way to make the 7.1 SDK happy. Change-Id: I82c37f503ed29cb50711eae7db22063f49747a48 Reviewed-on: https://gerrit.libreoffice.org/26055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-06report the crash id back to the userMarkus Mohrhard
Change-Id: I5cc1e698294a5674d691529af8cc14e4cd87a711 Reviewed-on: https://gerrit.libreoffice.org/25865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 660b91b07788077cfee9ba309d45db6819c00781) Reviewed-on: https://gerrit.libreoffice.org/25933
2016-06-06don't just silently ignore the return valueMarkus Mohrhard
Change-Id: Ia65c29b61e78de4b908b11cd803d93da4b7e3a2d Reviewed-on: https://gerrit.libreoffice.org/25864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit d2796282721dd2ed4d2c67e4e8982fb32263b55d) Reviewed-on: https://gerrit.libreoffice.org/25932
2016-06-05integrate the minidump upload into the normal LibreOfficeMarkus Mohrhard
Reviewed-on: https://gerrit.libreoffice.org/25863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4e074fb8183ac8649c9cb202da4ce93526c1b6d8) Conflicts: svx/source/dialog/crashreportdlg.cxx Change-Id: Id1808ceebf6c54698f7d1656a0ce96bcaece89ac Reviewed-on: https://gerrit.libreoffice.org/25931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-05extract the minidump uploader code into a static libMarkus Mohrhard
The plan for the near future is to still ship the executable but replace the interal use if possible with using the static library. At some point when it is not needed for debugging anymore and everything works correctly we should only build the uploader executable in dev configurations. The huge disadvantage of the interal solution is that it is nearly impossible for a user to upload a crash report if LibO starts working correctly. Also LibO overwrites the file with the information after the upload whereas the executable does not. Change-Id: Ib9854946be3a34e580964c18e1a9c0cce16221d1 Reviewed-on: https://gerrit.libreoffice.org/25862 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 2d1fc99275315bd6f45c1b73540f2b55e94bef9f) Reviewed-on: https://gerrit.libreoffice.org/25930 Tested-by: Jenkins <ci@libreoffice.org>
2016-06-05add some more error checking to minidump uploaderMarkus Mohrhard
Change-Id: Ia06fec80ea67e88b8c26cdeb5bfc9cee2459ad4a Reviewed-on: https://gerrit.libreoffice.org/25861 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit f2d18f8a7125f4f4d1d72be11fb3fb6637f25fde) Reviewed-on: https://gerrit.libreoffice.org/25929 Tested-by: Jenkins <ci@libreoffice.org>
2016-06-03A slightly better DbusIpcThreadStephan Bergmann
...that doesn't burn CPU by always directly returning again from a dbus_connection_read_write call with zero timeout. But still doesn't look like it uses DBus the way it's intended to. Help appreciated. Change-Id: I0d130adfb921409a27a847053b0b3646dc566a86 (cherry picked from commit a4740c8ea92cc50c1dc6e87d06db190800269a5d) Reviewed-on: https://gerrit.libreoffice.org/25869 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-03support the json key value data upload for crash report on client sideMarkus Mohrhard
Change-Id: I93f77f9363c016e0cc5a3e3c867de9f426e5bdf0 (cherry picked from commit 4aca087c7cb9ffe831b277a62ad3e993c3b2ca58) generate correct json files Change-Id: I0d39724e550427c7de31ebc4221f1b008a2451c3 Reviewed-on: https://gerrit.libreoffice.org/25648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4d4be0c0f1fd1c9bdfe815eddd0ff6b49b5bba39) Reviewed-on: https://gerrit.libreoffice.org/25821
2016-06-02use the existing url to path function also in the ini file partMarkus Mohrhard
Change-Id: Ia92261a63cfe1d51f68f312a27d5ba4b42719c47 Reviewed-on: https://gerrit.libreoffice.org/25647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4405180546bce4b4237f1a23c0bc5bcc5d7bb3a7) Reviewed-on: https://gerrit.libreoffice.org/25819
2016-05-31Move exithelper.h to includeTor Lillqvist
We will want to use EXITHELPER_CRASH_WITH_RESTART in vcl, too. Change-Id: If34244a361b157e0e9c7cca55fc34f0574f39984 (cherry picked from commit 64061d8dd687efa1c78e5284ab01f2f16e5817c3) (cherry picked from commit 46d5d475b114b93a76502d58637468e404a8562b) Reviewed-on: https://gerrit.libreoffice.org/25674 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-05-25Silence clang-cl -Werror,-Wmicrosoft-enum-value in external includeStephan Bergmann
Change-Id: Ic08f063efc27e4bd573c684955e69edb7e4f8bc1
2016-05-25Fix mis-mergeStephan Bergmann
Change-Id: Ia16ac2eec2b31aeb12b90e0f3fb2f3a37940c314
2016-05-25Silence clang-cl -Werror,-Wmicrosoft-enum-value in external includeStephan Bergmann
Change-Id: Ied864f8fde22a83ed35b5ce51054f055e84bac78
2016-05-25-Werror,-Wunused-variableStephan Bergmann
Change-Id: I83ef9f123156061ec5befb38dba4f46aec95d96d
2016-05-24add the file extension for minidumps on windowsMarkus Mohrhard
Change-Id: Ib5692ef839c500cac7d2551d0b0ee6faf141132a
2016-05-24use correct URL for crashreportMarkus Mohrhard
Change-Id: Ia7d584685961e8573c1c35f2560a66664632f5f7
2016-05-24copy and paste error in minidump uploaderMarkus Mohrhard
Change-Id: I114325f2de2f2953d158b88f5f0e0a3bac853368
2016-05-24fix previous commitsMarkus Mohrhard
Change-Id: I91e9f1d0f40dd3dd50b03a27ded2f96c71cd1ffd
2016-05-24return paths and not URLsMarkus Mohrhard
Change-Id: I03553a1fe98ac7ac780333b2ec247ed0cd781ffb Reviewed-on: https://gerrit.libreoffice.org/25379 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-24update the minidump location as soon as possibleMarkus Mohrhard
Change-Id: I7525ba7ff48b6df51ce8f7fdccf5ff512cdfec89 Reviewed-on: https://gerrit.libreoffice.org/25378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-24handle std::string vs std::wstring during exportMarkus Mohrhard
Change-Id: I00a32eb465b54e2a2747eebd00605212f14e5384 Reviewed-on: https://gerrit.libreoffice.org/25380 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-23use the TDF server as target for crash reportsMarkus Mohrhard
Change-Id: I0518bbad2f3550f8cac453c98af88a092448b5cd
2016-05-23lok: Subcribe to more uno commands for state changePranav Kant
Change-Id: Id2870b176de4163fbe01e4ac380b4981d3187d90
2016-05-22Convert DragMode to scoped enumNoel Grandin
Change-Id: I68dafefc74bad355047738605defd97f3c6bebcd Reviewed-on: https://gerrit.libreoffice.org/25209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-21add the breakpad exception handler also for windowsMarkus Mohrhard
Change-Id: I85a297ff79d9216cf2329b642bf8fe0bfe3e6886
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19somewhere I lost the filenameMarkus Mohrhard
Change-Id: Id806b0a9824c8f65dd8afa06bbbb93af60e24c57 Reviewed-on: https://gerrit.libreoffice.org/24028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-19update the location for breakpad as soon as we have access to profileMarkus Mohrhard
Change-Id: I33b29c06fdc9ec9b6d4c7d5f1b6db6024f39e92e Reviewed-on: https://gerrit.libreoffice.org/24027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18Inlucde TableStyles in GetStyles testJakub Trzebiatowski
Change-Id: I8df7cb9baf2359c632bb2a23ed5f3e6eb0f6577c Reviewed-on: https://gerrit.libreoffice.org/25058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-15coverity#1361589 Resource leakCaolán McNamara
this is the pattern used everywhere else. Change-Id: I18bdb43203bae8b9e36d59b4c457aa2087fdc117
2016-05-13convert EXCEPTION_ to scoped enumNoel Grandin
- simplify VCLExceptionSignal_impl - drop "minor" part of error code, nobody passes it in, and nobody checks it - rename Display to UserInterface, to prevent -Werror=shadow Change-Id: I503fd8a50ded30d59c30fb388796f6b1a0c058de Reviewed-on: https://gerrit.libreoffice.org/24892 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12Silence -Werror,-Wimplicit-fallthrough under NDEBUGStephan Bergmann
Change-Id: I7b2d5275614af69f6065d1838a76436801be30ef
2016-05-12warn to info for something that isn't a surpriseCaolán McNamara
Change-Id: I7427d2970d81d700f1ecc3e48c33ffb5a8045f2c
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-11xdg-app got renamed to FlatpakStephan Bergmann
Change-Id: Ib5ea4ad5b6033ee1634ea2f245742f862a40042d
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-09desktop: warning C4101 unreferenced local variableMichael Stahl
Change-Id: I6059dd33828e4d8034e0489068615e96bf5f2e02
2016-05-09LOK: drop identical invalidation notificationsAshod Nakashian
And drop duplicate GRAPHIC_SELECTION notifications. (cherry picked from commit 7cdfe080432f69c2247cc7ff28316b653bd654ff) Change-Id: I0c372efa9a58620e24cea219d82479cdc9dff359 Reviewed-on: https://gerrit.libreoffice.org/24771 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09LOK: SAL_WARN for each removed event is unnecessaryAshod Nakashian
Change-Id: If5e4c7b8751ae4eeb278475fb00118e32c6bb565 Reviewed-on: https://gerrit.libreoffice.org/24730 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09Don't change part on text documents to paint tilesAshod Nakashian
Change-Id: Icb5fb46cbc9d2f72c814cf9f1f166382493d403f Reviewed-on: https://gerrit.libreoffice.org/24702 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit aadab5f4a72e38ccc8bbe9b7811d2cdcaa00124c)
2016-05-09Allow painting for arbitrary partAshod Nakashian
Painting should not cause any state changes, but to paint a tile on a different part than the current has to change the document, which sends notifications to all clients. A new API, paintPartTile, allows for painting tiles on any part without sending change of part notifications. Furthermore, because we block notifications during this operation, no tile invalidation is issued due to changing of the part. One issue remains in the cases when the LO Core resets the cursor position internally and we resume editing after painting, the cursor might be at the top of the page. This needs fixing separately. Change-Id: If19bd1c90ecad4d5ed5e8d09513741b7994fa6e5 Reviewed-on: https://gerrit.libreoffice.org/24698 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09Some LOK notifications are dropped if they are superseeded by later onesAshod Nakashian
Change-Id: I323e46a2a6c60b200b182b89199945f99a7f384a Reviewed-on: https://gerrit.libreoffice.org/24567 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit cf98799fff7ae999bd62cec6486c986bf44000cc)
generated by cgit (git 2.34.1) at 2024-06-28 17:50:40 +0000