summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2016-12-09loplugin:staticmethodsTor Lillqvist
Change-Id: I385e54f5ddadda894102be2bb9a7dc408415ac68
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08lokit: support password protected binary MS and OOXML documentsTomaž Vajngerl
Change-Id: Id7fa1f428d07271e71f3df962bd6718a35372389 Reviewed-on: https://gerrit.libreoffice.org/31730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-12-08No glxtest library unless USING_X11Tor Lillqvist
Change-Id: Ibcc0eeba9beaaeea86bdda5e0ea80e54c25621a9
2016-12-08loplugin:unreffunTor Lillqvist
Change-Id: I15d868892a3ea4eadd526a0d3371f9fea39910cf
2016-12-08loplugin:staticmethodsTor Lillqvist
Change-Id: I90bb57370853c7606304c721e294999626c2af01
2016-12-07Match conditional in Repository.mkTor Lillqvist
Change-Id: Ie9deeb673cd5083a2f57a502bfbf49319aa00165
2016-12-07Fix typo in comments: et -> edTakeshi Abe
Change-Id: I447c46cc3d66c7f482314626826dd708bf1c01c4
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06cleanup unused includes (related to tdf#88206)Jochen Nitschke
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only implbase*.hxx stuff is used. Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995 Reviewed-on: https://gerrit.libreoffice.org/31686 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05tdf#100836 "Starting the LibreOffice Software With Parameters" help updatetagezi
rewritten cmdHelp in accordance with the attached document in bug tdf#100836 Change-Id: I6453ee87039272388fe1bc0efd747dc706b570ff Reviewed-on: https://gerrit.libreoffice.org/31244 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05Revert "lok: in preinit stage, do not force locale"Tor Lillqvist
Fixes unit-prefork in online for me. Kendy suggested to also change the forced locale to en-US.UTF-8 instead of just en-US, but that caused: warn:i18nlangtag:32416:1:i18nlangtag/source/languagetag/languagetag.cxx:1369: LanguageTagImpl::convertLocaleToLang: with bAllowOnTheFlyID invalid 'en-US.UTF-8'. This reverts commit c3d25b8b74867b5b8419d09f6e362aa6c8eae34f. Change-Id: I2cd8c50a783918c380505e7a3aaf37d578e76031 Reviewed-on: https://gerrit.libreoffice.org/31489 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-12-05Lok: better logging and warningsAshod Nakashian
Change-Id: Ia933ae65197893592eeb04cb8a1a617a931ad623 Reviewed-on: https://gerrit.libreoffice.org/31606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-12-05Lok: disable DesktopLOKTest::testTileInvalidationCompressionAshod Nakashian
For some reason this test fails on TinderBox and for others while passing on Jenkins on all platforms. This might be related to the compiler version used. Disabling until resolved. Change-Id: Ic05dbb290818506c78ceaa4c416fb00e8c0dc8da Reviewed-on: https://gerrit.libreoffice.org/31607 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-12-03first cut at adding a GDI handles attribute to the windows crash report.Michael Meeks
Change-Id: I4e6fee65a1416398f6f59feb8734b3b00c0aed3b Reviewed-on: https://gerrit.libreoffice.org/31570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-02Lok: correct tile invalidation mergingAshod Nakashian
Rectangles that are empty (i.e. IsEmpty() returns true) were incorrectly considered to mean equivalent to "EMPTY". The latter means full-area, while the former mean zero-area. This fixes the issue by restrict full-area to rectangles with 2 billion units on the each side (roughly INT_MAX) or more, and using this new check rather than IsEmpty(). Change-Id: I12aca17267f5dd33b2932012d1d9db3545f9af6f Reviewed-on: https://gerrit.libreoffice.org/31458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-12-02svl: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Ice929418e46ff42517a47dfcd5888a5cce36ae51 Reviewed-on: https://gerrit.libreoffice.org/31523 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-02convert some anonymous enums to scopedNoel Grandin
Change-Id: Ia989376c983ff475359e4964abeb1f5a2300ff5b Reviewed-on: https://gerrit.libreoffice.org/31486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-01tdf#104126 - comphelper thread-pool, use reliable std::condition_variable.Michael Meeks
The existing osl::Condition is an API and reliability disaster area. Change-Id: I3be84e1c6a83e58c43c40c9c8720790d923a6694 Reviewed-on: https://gerrit.libreoffice.org/31163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-30sw: use auto when initializing with a cast to avoid duplicating the type nameMiklos Vajna
Change-Id: Ide7bd0f1f444824b78aa53cfe1db0129cbca1a5d Reviewed-on: https://gerrit.libreoffice.org/31397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-30lok: ensure positive values for width and heightHenry Castro
also check the pointer memory block allocated Change-Id: I0ded04e06f80400e64c5e58126a32ee503aeb394 Reviewed-on: https://gerrit.libreoffice.org/31388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-29Window::Invalidate must be called with SolarMutex lockedStephan Bergmann
...it internally calls Scheduler::Start, which asserts now since c00d8271ba443c4f0acf657c226eea4824597f95 "vcl: assert solar mutex is held for various timer / scheduler ops." Caused the assert to fire when removing an extension via "Tools - Extension Manager... - Remove". Change-Id: Ied0591b799af333b3a4c11af07f5f8f1657304d6
2016-11-28Revert "Remove extra "=" symbol for "--splash-pipe" argument"Stephan Bergmann
This reverts commit 87a098e3bb72910399473ee0fbe32a70cad9c737: '--splash-pipe=N' is a "private" command line argument between oosplash (desktop/unx/source/start.c) and soffice.bin (desktop/source/splash/unxsplash.cxx). No need to silently accept a bogus '--splash-pipe' (without '=' part) provided by the user.
2016-11-28sw lok: notify repair when exist a conflict of multiple users undo/redoHenry Castro
Change-Id: I026f4df6239fa87ee191f92127f9fa98ac2993eb Reviewed-on: https://gerrit.libreoffice.org/31161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-28lok: avoid render font with empty rectangleHenry Castro
Change-Id: I58e24e0de37144ae5d67857b243e6a7091f2b77a Reviewed-on: https://gerrit.libreoffice.org/31281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-28lok: in preinit stage, do not force localeHenry Castro
force locale load some fonts before the lokit process is jail rooted, so it causes invalid rendering special characters in doc_renderFont function Change-Id: I25f00e5bb947753b820c6966a99a6c3849413315 Reviewed-on: https://gerrit.libreoffice.org/31280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-27Lok: compress duplicate state-changed eventsAshod Nakashian
STATE_CHANGED callback events that have the form of name=value are only removed when newer ones are identical. This is not very helpful since often the same name (i.e. state type) changes its value and we need to superseed older ones with new values. This patch makes sure that a STATE_CHANGED with a given name has its latest value and doesn't change multiple times while in the queue. Change-Id: Ibfa18359464d7137411e5846b1c6d415a0aad43d Reviewed-on: https://gerrit.libreoffice.org/31258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-11-26Remove extra "=" symbol for "--splash-pipe" argumenttagezi
This argument ignores any parameters since commit 5c22a03320f20ae9ac2c3c16025e7c5e3a7915d5. It is a part of documenting cmdline. Change-Id: I9d7f06f692d77379b3d96b741987f83771bd13c2 Reviewed-on: https://gerrit.libreoffice.org/31243 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-23New o3tl::runtimeToOUString to convert from C++ runtime NTBS to OUStringStephan Bergmann
Change-Id: I613bb70b6828f615fd45af38b2d873ece55ace60
2016-11-23loplugin:unnecessaryoverride (dtors) in desktopStephan Bergmann
Change-Id: I9153f2506a9d054ec2e81a5c0d6f9bb089b73f64
2016-11-23tdf#100826: use console for -h and --version also on WindowsMike Kaganski
This removes the dialog used to show version information and command line help on Windows. Now, selecting and scrolling becomes possible, code is simplified and unified under all platforms. Change-Id: Ia749bbb62d697eff655b3a646859c1986a023ec0 Reviewed-on: https://gerrit.libreoffice.org/31059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-22lok: add command values .uno:FontSubsetHenry Castro
Conflicts: desktop/Library_sofficeapp.mk Change-Id: Id36a98c32f0eb5e88e4e9a714e260a71d7465c05 Reviewed-on: https://gerrit.libreoffice.org/31033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-21tdf#103146 Revamp Extension Manager Dialog, Part 3Muhammet Kara
Move the "Enable"/"Disable" button which was customly implemented from the ExtBoxWithBtns_Impl to the new row. This should also solve some accessibility issues. Also remove some unnecessary code pieces for clean-up. Change-Id: Iec7820779110eea3411a774de8277ef238f562e7 Reviewed-on: https://gerrit.libreoffice.org/30973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-17that should have been LibreOfficeKit*Document*ClassChristian Lohmaier
Change-Id: I48f9db39be18ae9a456002de8f40fbb0fb3be707
2016-11-16Demonstrate that (extension) .xcu can contain <item> with nested <node>sStephan Bergmann
This sprang from an IRC conversation with uniscript about allowing .xcd in extensions, so that an extension with (localization) data for many packages would not need one .xcu file per package, but rather only a single file. That is possible with a single .xcu file using the <item> syntax, as shown here. (I had thought that originally only registrymodifications.xcu supported the <item> syntax, but can't find any traces of that; so looks like an extension with an .xcu file using <item> syntax should be supported by OOo and derivates "since ages".) Change-Id: I1101793e6b14ba9c1e7647edab76927d4d31a81c
2016-11-16tdf#92346 - Copy functionality in the viewerChamal
Reference class added to desktop/source/lib/lokandroid.cxx for Java_org_libreoffice_kit_Document_getTextSelection() Change-Id: I211d5709df39fd9fafdab9232af760613f6b86c0 Reviewed-on: https://gerrit.libreoffice.org/29804 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-15tdf#103146 Revamp Extension Manager Dialog, Part 2Muhammet Kara
Move the "Remove" button which was customly implemented from the ExtBoxWithBtns_Impl to the new row. This should also solve some accessibility issues. Also wipe some useless code which implements custom tab behavior. Change-Id: I602fcf23631498145d8b9ead2936ee549caf3f0d Reviewed-on: https://gerrit.libreoffice.org/30867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-14lok: add character parameter to renderFontHenry Castro
When client side request special character, it is very useful to send a preview of the rendered font character Conflicts: desktop/source/lib/init.cxx Change-Id: I1f5727163dfcc861add121e616bdb17881c28197 Reviewed-on: https://gerrit.libreoffice.org/30784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-13drop extra semicolonsDavid Tardon
Change-Id: Ie6713d1bdf0010e5bc0bb70ca995c4dd36408673
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09tdf#103146 Revamp Extension Manager Dialog, Part 1Muhammet Kara
Moved the "Check for Updates", and "Add" buttons to the new row, and started moving the buttons from the ExtBoxWithBtns_Impl to the new row. Needed to create new public methods to be able to update button states of ExtMgrDialog from within the ExtBoxWithBtns_Impl class. Change-Id: Iea784d0b7237da3f8aa05862dbf1faf5acf98655 Reviewed-on: https://gerrit.libreoffice.org/30560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>