summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2023-11-20Extended loplugin:ostr: desktopStephan Bergmann
Change-Id: I0c86c1207f906e19c770b71ae1c5daec1c912845 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159717 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-18c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 3)Julien Nabet
Change-Id: I1ea95e0bfeaed88b9484403e6796574f1d06f133 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159612 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-17cool#6893 pre-init dictionary listNoel Grandin
so the forked processes don't need to Change-Id: Id37688ac88c14679e216cca744563ee75c7c4736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-14loplugin:unusedfieldsNoel Grandin
Change-Id: I5869e9974c37b1b525d316367f1dc5051d8aa197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-13Re-introduce build config to version info reported by LOKMike Kaganski
... as an opt-in --with-buildconfig-recorded configure option. This allows to have the data in the admin console, as implemented in commit cbfac11330882c7d0a817b6c37a08b2ace2b66f4 (Send build config (configure options) in LOKit version info JSON, 2022-11-07), when reprobuilds are not required. The default is no build config, which is compatible with reprobuilds. This reverts commit 389def871853c885289627452f40b3ae0a8dabc8. Change-Id: I7f0be489a1c82268d0ca38cb761843c9d432a14b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159344 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11Move user agent initialization to InitCurl_easyMike Kaganski
Places that didn't initialize it previously, would benefit automatically Change-Id: I2f1ff25fc58d9378462072bc92d7b37be2370fc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159299 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-09officecfg,desktop: add Office::Security::Net::AllowInsecureUNORemoteProtocolMichael Stahl
This disables the "com.sun.star.office.Acceptor" UNO service that handles the soffice "--accept" argument; now it can be disabled and locked in configuration by system administrator. Change-Id: I6747a128c3afa6a0cb351766365c8affc0b2614e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159151 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-09officecfg,*: add Office::Security::Net::AllowInsecureProtocolsMichael Stahl
By default, unencrypted network connections are allowed. But now it can be disabled, for everything that uses libcurl. Change-Id: I8e103f5a968ace2a19fdb9d6934c9a51b2aeabe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159011 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-09Move "Acceptor already exists" warning to where it belongsStephan Bergmann
036ed05fe35044e49a91e12b6a8e5f36a5b9c4c2 "MWS_SRX644: migrate branch mws_srx644 -> HEAD" had added this with misleading indentation, so it (apparently accidentally) did not pertain to the "aAcceptString was found in the map of already existing acceptors" case. Then 4acffc240b4845beedfe66eaa571b814d65e2e57 "catch by const reference" fixed the indentation, but left the warning at the apparently wrong place. Change-Id: Ie73368bc1294e9b716e3fca75e12363cb6240fdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159157 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-08loplugin:unnecessarygetstr (clang-cl)Stephan Bergmann
Change-Id: Ic0ec1614d48382bb5735a67bf9588657b9ebd521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159106 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-07curl: mitigate migration to OpenSSL on LinuxMichael Stahl
The problem is that curl 8.3.0 removed the NSS backend, so we now have no other choice than to use the bundled OpenSSL on Linux. Currently any curl https connection fails with: CurlSession.cxx:963: curl_easy_perform failed: (60) SSL certificate problem: unable to get local issuer certificate Apparently this requires manually telling curl which CA certificates to trust; there is a configure flag --with-ca-bundle but that is useless as it tries to load the file relative to whatever is the current working directory, and also did i mention that there are at least 3 different locations where a Linux system may store its system trusted CA certificates because ALL ABOUT CHOICE. So add a new header with an init function to try out various file locations listed in this nice blog article and call it from way too many places that independently use curl. https://www.happyassassin.net/posts/2015/01/12/a-note-about-ssltls-trusted-certificate-stores-and-platforms/ TODO: perhaps bundle a cacert.pem as a fallback in case the system chose to innovate by putting its certificates in yet another unexpected place (regression from commit c2930ebff82c4f7ffe8377ab82627131f8544226) Change-Id: Ibf1cc0069bc2ae011ecead9a4c2b455e94b01241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158915 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-05reprobuild: don't include build machine setup in binariesThorsten Behrens
The configure line can leak data from the building machine (path names, level of parallelism etc), which leads to non-reproducible build results. Change-Id: I042afc3d7bad19e8e274147be2a9eb0abcf5436e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158871 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-04External data must be checked when parsedMike Kaganski
Change-Id: I8bc5afb29fe22a4b06462a7c61b689c88c41003f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158938 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-04LOK: Simplify a bit, and use more compile-time knowledgeMike Kaganski
Bring some C++20 goodness to LOK code: avoid lots of small memory allocations when constructing OUString from ASCII char arrays; use string lengths known at compile and run time; use safer and cleaner syntax. Change-Id: Ia59ed3c8d8ce521880bb8d70b69a64b2d3e73c14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158927 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-03tdf#114441 Convert sal_uLong to better data typesAnkit_Jaipuriar
The function getLength() returns a value as sal_Int32, which is then assigned to the variable nLinks. Change-Id: I44d626e2a26e3d9eb15b0884500f0dfddff12e9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157755 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2023-10-31lok a11y: calc: make possible to enable accessibility for spreadsheetsMarco Cecchetti
Change-Id: I462b2d386b58a895bd4c45d4bd61a049404d3848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158512 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit e5481fdaf33a3921ef0624e8a62e28e2f68086da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-27lok: a11y: impress: help screen reader to report shape selectionMarco Cecchetti
Refactored LOKDocumentFocusListener::notifyEvent. Implemented 2 new callbacks: - LOK_CALLBACK_A11Y_EDITING_IN_SELECTION_STATE: it says the client if editing in a shape or cell is active or it isn't. - LOK_CALLBACK_A11Y_SELECTION_CHANGED: it says if a shape has been selected/unselected, the name of the shape and text content are sent too for being reported by a screen reader. (cherry picked from commit 76899152ec3d1924cc72d2b869e197a1e34a0a1a) Conflicts: sfx2/source/view/viewsh.cxx Change-Id: I644bcc7daeb8772805688a9bccdabd0631ce0a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158562 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-23Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]StringStephan Bergmann
...in include files. This is a mix of automatic rewriting in include files and manual fixups (mostly addressing loplugin:redundantfcast) in source files that include those. Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-22lok: remove old hack for LanguageTool localesSzymon Kłos
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146779 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153962 Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154162 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 9a5329a266bd74abc4794f1fcbae3db07582dbde) Change-Id: I44cc4a5b1a0d92e2b0857cdc1d68c931ab95c0d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158332 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-22lok: LanguageTool provides list of languagesSzymon Kłos
- it sends supported list to the LOK client - disables Spell Checker for locales supported by LanguageTool - duden protocol supports only german - initialize language tool config before usage to fetch correct list of supported languages Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146665 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153960 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154161 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 21d0489a5efa970e975ce1a70dfda2fd9e2c186d) Change-Id: Id0f909fbd2cca47e93ed8632217a45b5087c1ecf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158331 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-22lok: a11y: impress: screen reader support for text shape editingMarco Cecchetti
Now accessibility support can be enabled in Impress. Fixed an issue that prevented to receive accessibility event when a shape text content was edited. Some rectangles overlapping check is performed for excluding not visible shapes from the a11y tree Anyway client and core visible area can differ some shape was wrongly pruned from the a11y tree. The problem has been fixed by not performing the overlapping test in the LOK case: we already do the same for shape area invalidation. In order to avoid the screen reader to report no more focused paragraph we send an empty paragraph to clear the editable area when shape selection state changes. When shape ediding becomes active the text content of the shape is sent to the client. Change-Id: Ia9ee08d060162891725d26efd2aa36e47b38ed50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157525 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: desktopStephan Bergmann
Change-Id: I896fb07e753bfd7be5df892b1608954ad6a9cece Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158188 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-18LOK: send state of protected cellsPranam Lashkari
Change-Id: I432a3af50b6089faa80a28804d95d816af6cd278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154936 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> (cherry picked from commit 5f13751cefd725cb2a38e66c9484046e6141c6c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158150 Tested-by: Jenkins
2023-10-16jsdialog: enable Hyperlink DialogSzymon Kłos
- removed old "tunneled window" test for hyperlink dialog which cannot work when using jsdialogs Change-Id: I62b6c568149d4ea4656b23c47f4c79efe61abfb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156668 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Attila Szűcs <attila.szucs@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-14Remove duplicated includeAndrea Gelmini
Change-Id: I0a5bbd375e1841e3a441ab241b18933858ecd45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157864 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-12Make NC_ constexpr-friendlyStephan Bergmann
...by moving the char8_t -> char reinterpret_cast out of any potential constexpr paths into a new TranslateId::getId. And demonstrate constexpr'ability by making the aCategories var in OApplicationIconControl::Fill (dbaccess/source/ui/app/AppIconControl.cxx) constexpr. (And there might be more such cases that could now be made constexpr.) Change-Id: I0b4e3292faf8f6b901f9b9e934e1aa6bf0f583ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-11Removing unused variable in preLoadShortCutAcceleratorsMarco Cecchetti
When all warnings are treated as errors the following error was reported: desktop/source/lib/init.cxx: OUString language = LanguageTag(installedLocales[i]).getLocale().Language; The problem started after commit 1cd46ba9140b7f5f077d8e9da405b180857f008d. Remove the allowed language check from UI languages. Change-Id: Id1f4269fe262b61b4fb05d61bf9c64a747275c28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152561 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit b0fa2ea7decadae61ad10e340698a8dd4af45e6e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157813 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11Remove the allowed language check from UI languages.Gökay Şatır
Allowed langauges list is for spell checking algorithms. No need to use it for UI shortcuts. Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I996861b79247269e9b788b008fe6fc26e5ef44c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152416 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 1cd46ba9140b7f5f077d8e9da405b180857f008d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157812 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11lok: flush the VOC primitives when trimming memoryAshod Nakashian
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I0a7748a1fb1b58b3bcfc6b8fdfa1410a345849a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154812 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 5fba074e7f22ff0e5d5b9591a912193f7be8c08c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154868 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10lok: set help root URLAndras Timar
Change-Id: Id4089027f095daebb69942eb3315d516cfb14779 (cherry picked from commit 2239e4c1b2dcf06650316a106e5bd883ceefb6c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10lok: fix getting SID_DOC_READONLY slot propertyHenry Castro
Unfortunately, the property is not always set when import XLSX documents. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If501734704174b92b3589b61a019ba973592c331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157259 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157736 Tested-by: Jenkins
2023-10-09lok: add getter function to read "ReadOnly" flagHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Id9d2bc638d0f48cb33764b07fb8976b97117a621 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156621 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157733 Tested-by: Jenkins
2023-10-09lok: implement "handleLoadReadOnlyRequest"Henry Castro
Is used for interaction handle to query user decision regarding to open the document read only. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ia945eae7b1627d57d6211ae92a784d50313c2627 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156623 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157703 Tested-by: Jenkins
2023-10-07loplugin:ostr: automatic rewriteStephan Bergmann
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-10-02lok: add broken package interaction handlerSzymon Kłos
in case of repair don't use template flag to not make file readonly so we can overwrite it and upload to storage updated version Conflicts: desktop/source/lib/lokinteractionhandler.cxx desktop/source/lib/lokinteractionhandler.hxx sfx2/source/doc/sfxbasemodel.cxx Change-Id: Ia460009fc3b77582dde06dd6f94a85aef3aee11b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157493 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-09-29make FunctionBasedURPConnection simplerCaolán McNamara
and leave it to the client how it wants to read/provide the data Change-Id: Ibd4d967b79a699c96d1ea8529544b585a97cc0c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157405 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-28tdf#105303: re-introduce single-document html export filterXisco Fauli
which was deleted in 28b6480c6bdd179f3943f768926b7f196226c768 "tdf#105303: Drop html export wizard" With this commit, exporting to HTML from File - Export dialog behaves the same way as using --convert-to html:"impress_html_Export" from the commandline. The slides are exported as a single document For more information see the discussion in tdf#105303 Change-Id: Ib96b3d855ae807e79f276099422903c86ea2628a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157331 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-23tdf#105303: Drop html export wizardXisco Fauli
Done during the conference hackfest Change-Id: I765e6dc839a98038c4071c8444ce3db9293c8a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157173 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-18JavaScript uno bindings for WASM with Embind - first cutSarper Akdemir
A rough implementation of uno bindings for LOWA using embind. Adds new parameter '-W' to cppumaker to generate _embind.cxx files alongside .hdl & .hpp. For usage examples see static/README.wasm.md Change-Id: Iee5d05e37bfba8e101c08212b15c05f7f2fa6c33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156273 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2023-09-14Fix --disable-curl buildMike Kaganski
Change-Id: I3020d41eb6d0988cc886495a88a073a23bc8161c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156910 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-09-12Added parent / child relationship to comments.Gökay Şatır
Adding parent name of a comment into odf file when there is a parent. Also includes: Added test case to comment property test. Change-Id: I033f6574b4875fcb76b16c8b5b9d9f7d55b52cbe Also includes: Add parent / child relations to replied comments. Change-Id: Ia7d95c4e6020b501798a89cbdcae64dc5691437c Change-Id: I08b5ab6eb11adcafcbf3559896d79d41b449b26a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156824 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-09-02Remove duplicated includeAndrea Gelmini
Change-Id: I3a3ca7313e1921f806b256c7a66340d0e90a582e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156428 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-09-02replace set(nullptr) with clear()Noel Grandin
It's a little easier to read, but mostly it makes an upcoming loplugin easier to implement Change-Id: I4ae7db8eda77795dab3255d1afd8ba4f20a8de76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-01Add a FunctionBasedURPConnection and a websocket URP connectorSkyler Grey
- FunctionBasedURPConnection is used to enable a client to open a URP connection to a fresh Kit instance in COOL. - This URP connector can be used with that and https://github.com/CollaboraOnline/online/pull/6992 to use a Java Uno Remote Protocol client over websockets - For interoperability with existing Collabora Online websockets a prefix (urp ) is added to each message sent and a similar prefix (urp: ) is expected on each message recieved. This allows sending over the same websocket as other data is being transmitted through. If you are writing a bridge to work with this, you will need to add/strip the prefixes accordingly - This commit uses Java WebSocket (https://github.com/TooTallNate/Java-WebSocket) to send data over websockets. Change-Id: I2bda3d0b988bef7883f9b6829eeb5b7ae8075f27 Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-01lok: use constant keys enumerationHenry Castro
Useful to better readability code. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I335d010c3b1ddf3f8052b7ed6cb0f94ad20045f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155495 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156416 Tested-by: Jenkins
2023-08-29jsdialog: detect special window id earlierSzymon Kłos
Change-Id: Ib90d9d728d93a26d44a7f52b7ca0074338b1fae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155853 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156235 Tested-by: Jenkins
2023-08-22tdf#156825 Half of the splash screen is visible on both monitors under LinuxNoel Grandin
Blind fix, since I don't have two screens. regression from commit 4c00a5bce384c5fa3b46cf5bb29c7e9b1e506ea0 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Jul 20 11:27:17 2023 +0200 Assume that, if we have X11, it supports Xinerama It looks like I missed the removal of some USE_XINERAMA pieces Change-Id: I402db170916efe935d8ff9f96cc9b327070809b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-18ucbhelper,ucb,desktop: InternetProxyServer is problematicMichael Stahl
It turns out that every single client of InternetProxyDecider simply concatenates the 2 members of InternetProxyServer into a single string and passes it on to curl_easy_setopt(CURLOPT_PROXY), which will happily take a URL including scheme and everything. It turns out that the awful GetUnixSystemProxy() tries to cut off the scheme in a terrible way, but GetPACProxy() does no such thing and WINHTTP_PROXY_INFO::lpszProxy may or may not contain scheme in its entries; fix this to only separate the port and leave the rest alone. So why do we need a InternetProxyServer struct? Because officecfg has separate entries that correspond to its members, and so InternetProxyDecider gets separate events on its listener interface when any of them changes, which is easiest to handle if it stores these separately. So just return a concatenated URL with or without scheme in getProxy(). Change-Id: I43c696471c8bec90667b5930fa00975adb432fe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155840 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-18logs full of "OConfigurationNode::hasByName: object is invalid"Caolán McNamara
warn:legacy.osl:3509:3314:unotools/source/config/confignode.cxx:408: OConfigurationNode::hasByName: object is invalid! warn:legacy.osl:3509:3314:unotools/source/config/confignode.cxx:409: OConfigurationNode::hasByName: object is invalid! warn:legacy.osl:3509:3314:comphelper/source/misc/types.cxx:90: comphelper::getBOOL : invalid argument ! in cool, open a document, switch from light to dark with sidebar open, click on a paragraph and then on another with different properties, e.g. normal vs heading and each change of a sidebar context triggers the warning over and over again. The config has no mention of notebookbar_online.ui but we set notebookbar_online.ui as the default to use for a notebookbar so replace mentions in the config of notebookbar.ui with notebookbar_online.ui for consistency when we do that and we can drop the constant log spam. Change-Id: I41860f5422d4426d8e3786b38c967e52bc803ae3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155804 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-14lok: a11y: when we are inside a table notify table and current cell infoMarco Cecchetti
When we get in one or more tables we notify row and column count. When we get out one or more table we notify we are leaving a table. When the fosused cell changes we notify the new row/col index. The paragraph content is notified together with table info, so that client has some opportunity for getting the screen reader to report together content and table info. Change-Id: Ic524259aa1879a70fc3de2467bdee27475352b7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155577 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-15 02:43:13 +0000