summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2014-02-21Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-18coverity#984085 Uninitialized scalar fieldCaolán McNamara
Change-Id: I84ff62f0a592a012fa7963f81f4bafcc0ebf420f
2014-02-18Drop unnecessary #includeTakeshi Abe
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12normalize values of SYSTEM_NPAPI_HEADERS, SYSTEM_ICUMichael Stahl
Change-Id: I7f1153e4a07a4116417a7734d867f2d0feda1ee4
2014-02-12fdo#63154 Remove unused solar.h ref in vcl, basctl, desktop..Alexandre Vicenzi
Change-Id: Ic0187495d8f7f64ddf9d3c202ec41201c9ac3a8c Reviewed-on: https://gerrit.libreoffice.org/8001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-11coverity#704224 Logically dead codeCaolán McNamara
Change-Id: Ic113260ff969f3bb670cb8ecaf5d6068dea5dbdd
2014-02-11coverity#704223 Logically dead codeCaolán McNamara
Change-Id: I4d5380f7c60ff10d1e1c2560e1e1288eb79cd056
2014-02-11fwk: Constructor feature for one instance SessionListener.Matúš Kukan
Converted as usual service implementation. Change-Id: I37c2f25e8a463abb236753c1299cc0aeb3007cd9
2014-02-10Typo: diretory -> directoryJulien Nabet
Change-Id: I46270104db3192f427bb7a954e6c074ab3aced33
2014-02-07remove the 4 send crash report tabpagesCaolán McNamara
and other logical consequences of officecfg::Office::Recovery::CrashReporter::Enabled == false because we have this disabled by default since the first LibreOffice release and we have no backend infrastucture to handle the submissions anyway and it's blocking conversion of legacy .src dialogs to .ui format Change-Id: Id5481af3ec970032b3728c0e6cc0c6a52d3ed3dc
2014-02-06typo fixes in commentsAndras Timar
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06Typo: seam(s) -> seem(s)Julien Nabet
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
2014-02-06Introduce com.sun.star.ui.theWindowStateConfiguration singleton.Matúš Kukan
Change-Id: I50861ac8952d54cb1a45846ea72a2ecac4f83409
2014-02-04Change Application::SystemSettingsChanging to OverrideSystemSettingsChris Sherlock
The name Application::SystemSettingsChanging implies that the app is being notified that system settings are being changed. This is not what the function does - in fact, SystemSettingsChanging overrides a settings object with user defined settings Change-Id: Ibbf821ff3c7ec5b38e2e79751058494c749b6428 Reviewed-on: https://gerrit.libreoffice.org/7629 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-02-03EXC_SYSOBJNOTCREATED was not really usedTor Lillqvist
Change-Id: Id5ece6db33aa92b619571252df91b965a8805c96
2014-02-01coverity#707748 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I9155c4ab7409d1fa00abbc3c81ff03d0c0d3910b
2014-01-30Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-29coverity#1158237 Resource leakCaolán McNamara
Change-Id: I2204ec36344b8f7662efa8aed31e9363bb791616
2014-01-29Introduce com.sun.star.ui.theUIElementFactoryManager singleton.Matúš Kukan
To replace single-instance com.sun.star.ui.UIElementFactoryManager service. Change-Id: I4262909c4396e3907d271a56696a06903168a58d
2014-01-29Introduce com.sun.star.frame.ControllerFactory singletons:Matúš Kukan
com.sun.star.frame.thePopupMenuControllerFactory com.sun.star.frame.theStatusbarControllerFactory com.sun.star.frame.theToolbarControllerFactory To replace their single-instance service variants. Change-Id: I00586d0d61e63f9482cb659071e88aa9cf02d5b5
2014-01-28bool improvementsStephan Bergmann
Change-Id: Ie4c9d7f01fef2604d80d8e465ce30daab7481eed
2014-01-28Introduce com.sun.star.frame.theUICommandDescription singleton.Matúš Kukan
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28Introduce com.sun.star.frame.theAutoRecovery singleton.Matúš Kukan
To replace com.sun.star.frame.AutoRecovery single-instance service, incorrectly converted in 279859fdbc40f68d8f1649fa5b928d9de49e8d9e Unfortunately needs a lot of changes in autorecovery.cxx. Change-Id: Iba5188dffea3e03803236f23e0b3f343746ace90
2014-01-24Introduce com.sun.star.task.theJobExecutor singleton.Matúš Kukan
To replace com.sun.star.task.JobExecutor single-instance service, incorrectly converted in 748aa84e9808ad31c6ff6b71459525c82de10e58 [including changes by Stephan Bergmann <sbergman@redhat.com>] Change-Id: I4cea2c63a20b5b22f6e1f822fb35fcc4d0397687 Reviewed-on: https://gerrit.libreoffice.org/7609 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-23Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23Move defines into settings.hxxChris Sherlock
For some unknown reason, there are a bunch of defines in the middle of Desktop::SystemSettingsChanging() that should really be in include/vcl/settings.hxx. I have now moved DRAG_OPTIONS_ALL into settings.hxx but entirely removed DRAG_OPTIONS_NONE because it is confusing. I also removed it in the one place this combination of options is used in the Desktop class. I have also removed the options DRAG_OPTIONS_OBJECT_* from settings.hxx because they are used nowhere in the code. I have carefully looked through the code and nothing flips bits 0x00000004 or 0x00000008 on the private member of ImplStyleData's mnDragFullOptions in any way. Basically, it is safe to remove. Change-Id: Icf6268f940cfaed271bd43c977473fecfc726949 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-22Improve settings code reabilityChris Sherlock
Application::SetSettings relies on Application::GetSettings to initialize the application's settings if this hasn't happened. This means that GetSettings is being used not to get the app's settings, but to initialize the settings! I have corrected this by introducing a private static function InitSettings(). Note that I assert if it attempts to initialize already initialized settings, because the (Get|Set)Settings does the check for you. Also changed a local variable from nGet to nDragMode in Desktop::SystemSettingsChanging to make it easier to read the code. Whilst this is minor, a variable name of "nGet" seems very sloppy. Change-Id: I04975217c2028b3489179997db4287957578cc93 Reviewed-on: https://gerrit.libreoffice.org/7586 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22bool improvementsStephan Bergmann
Change-Id: Iddc92e42a100a0fb36c77c21d4c176dded8f3391
2014-01-20Remove unused Window parameter from SystemSettingsChangingChris Sherlock
This took a bit of code archaelogy for me to track down. It turns out that as part of an effort to optimize startup, the line of code in this function was commented out, presumably to be rewritten later. This happened in commit ee3351d78c in July 2001 (!). About three years later, in February 2004, the function was rewritten in commit 189c2388d80. As it turns out, the only two functions that used the Window parameter were vcl/source/window/window.cxx (which passed itself in, but of course this did nothing) and vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in the first frame, so it didn't really do anything either. Consequently, the function as it stands *now* only notifies the application that system settings have been changed. It doesn't care which window it tells. Therefore, I have excised this parameter from the function. I don't think it made sense when it was implemented anyway, so there is no net loss. After removing the unneeded parameter, I was also able to remove the Window parameter from winproc.cxx's ImplHandleSalSettings function as it was only ever used to set the top level window, which is now irrelevant. Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1 Reviewed-on: https://gerrit.libreoffice.org/7541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-17fdo#73549 do not attempt to resolve an empty localeEike Rathke
... to match installed UI locales Change-Id: If0ad0fde392bc5ea3cf454f4858330f5e93a6666
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-16Introduce com.sun.star.frame.theGlobalEventBroadcaster singletonStephan Bergmann
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance service. Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-14EndDialog takes long nResult, not boolStephan Bergmann
Change-Id: Ic6283b7a71a5d1c539ae99155f448e34e877080a
2014-01-08Missing XServiceInfoStephan Bergmann
Change-Id: Ifc5454bbcd29730002b0a3261d2c34dee8ffb843
2014-01-08Some ConfigurationProvider -> theDefaultProvider simplificationsStephan Bergmann
Change-Id: I7c25cd94f8a1ca339f7423c26f21f13c7a68906d
2014-01-07remove unnecessary sal_Unicode casts in OUStringBuffer::append callsNoel Grandin
Convert code like: buf.append( static_cast<sal_Unicode>('!') ); to: buf.append( '!' ); Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2013-12-27Some make file fixingZolnai Tamás
Related to d1c74734c8d9026b0f0c03f7382ca60165cec8c6 Change-Id: Ic3a6147f0615e79640ec9f567168f93219d34020
2013-12-27Transex3: NO_LOCALIZE_EXPORTZolnai Tamás
In the past, NO_LOCALIZE_EXPORT macro must be used to skip uneeded parsing of src files which has no localizable content. It is unsued by now and it is more effective to handle this files on gmake level: gb_SrsTarget_add_nonlocalizable_files gb_SrsTarget_add_nonlocalizable_templates Plus remove some empty src file. Change-Id: I8fc9b2db0b5fd7a3379d3c5be970c4fc691f4c53
2013-12-26WaE: unused variable 'ARGUMENT_PREFIX'Tor Lillqvist
Change-Id: I88b8a66ccc4da951e92cce0e4b5d66dcff8bf477
2013-12-26WaE: unused variable 'url'Tor Lillqvist
Change-Id: I6ae6a95bdf9b0f82384dfdcbdefc6a546f81ef0f
2013-12-26WaE: unused variable 'XDG_CONFIG_PART'Tor Lillqvist
Change-Id: I35435dc466478002d065e13f6e31c3c68528d7d5
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-19use proper LanguageTag fallback instead of dumb startsWith(), fdo#68714Eike Rathke
A ca_ES@valencia (=> ca-ES-valencia) locale did not result in 'ca-valencia' UI being selected but 'ca' only instead. Change-Id: Ifa405add2ff7b45e030b02af4338de195b457cb2
2013-12-18resolved fdo#72778 keep setting system locale and LanguageTag in syncEike Rathke
Change-Id: I3547786bf77b8f611bc08d0e52c66ac00e199f13
2013-12-17No need for implbase1.hxx to include XComponentContext.hppStephan Bergmann
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up, of course. Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83