summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2023-02-16SfxViewShell::GetViewFrame never returns null, change to a referenceCaolán McNamara
various null checks can be seen to be redundant and removed Change-Id: Icf49c1de4b0302795d2769a370af3abceaad0221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-14osl::Mutex->std::atomic in DispatchWatcherNoel Grandin
Change-Id: I7cad64f9031dd05e08321110ec670d3c744f03c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13Rename: Extension Manager -> ExtensionsSamuel Mehrbrodt
simplify dialog title, should be clear what this is about. Change-Id: I65d8ca89e32cc225a07483703cd27b0fdc630b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146715 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-13Fix/simplify some vnd.sun.star.expand: handlingMike Kaganski
The vnd.sun.star.expand: payload must be URL-decoded prior to passing it to expandMacros; the protocol must be checked case-insensitively. Use startsWithIgnoreAsciiCase for that. Change-Id: I2be993a0400a27cb7dc57207cd0824b4505afd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146855 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-09Enable opening of downloaded fonts only in ForKit in OnlineTor Lillqvist
We want that only the ForKit process needs to have access to new font files added to a Collabora Online instance dynamically by downloading from a server. There are however many locations in the Kit process, in core and in external libraries like harfbuzz, where the code wants to open a font file. Handle this so that the ForKit process opens such a downloaded font file and doesn't close it. The file descriptor is thus inherited by Kit processes. The font file pathname passed on to other code is a fake on in the format "/:FD:/%d" where the %d is the file descriptor of the opened font file. Add checks in all places where font files are opened, look for this special pathname format, and modify the code to just dup() the already open file descriptor in that case. All this is relevant for Linux only, as Collabora Online runs on Linux. Do the above for harfbuzz, cairo, fontconfig, and freetype. In addition make sure that these libraries (except harfbuzz which needs to be a static library and freetype) when bundled, on Linux, are built as shared libraries, and won't be confused with the corresponding system libraries by making sure their sonames are different. Change-Id: Ib059cb27e1637d07bb709249abd0d984f948caa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140714 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146341 Tested-by: Jenkins
2023-02-07cid#1520802 Dereference null return valueCaolán McNamara
Change-Id: Iba193386d1ee82c8f47ece2445cfb2ecaeeed998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-07improve readability of VirtualDevice constructorNoel Grandin
(a) It is not obvious what DeviceFormat::DEFAULT means (b) There are two parameters (each with two states), but only really 2 possible overall states So (1) use more useful names (2) combine the two parameters into one enum Change-Id: Ic0595b39e032cc9e019b88326389d055b977da00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-06Make LOKClipboard available to other modulesSzymon Kłos
LOKClipboard has higher level dependencies (sfx2) so it cannot be moved to the vcl where SystemClibpoard instance is created. - introduce new interface LokClipboard to differentiate from SystemClipboard so we can have vcl's and lok's implementations at the same time - publish LOKClipboard using new interface for other modules by adding component file in desktop module Thanks to that when code calls GetClipboard and we cannot get clipboard assigned to the vcl::Window* (for welded widgets) in GetSystemClipboard correct instance is returned (shared clipboard for current view) so we can access content which was copied before. Previously always a new instance was created (with empty content). test ScTiledRenderingTest::testPasteIntoWrapTextCell was broken add some content to clipboard to simulate more real case and test the content copied Change-Id: I23c0298960a710c498646493f33122b908864cba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126310 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131644 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135198 Tested-by: Jenkins
2023-02-03lok: fix query language statusHenry Castro
The Calc and Impress return language status as a SfxStringItem, but Writer is a SfxListStringItem. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I88f77288e422a8f80473f0e33257078cfaa704b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145675 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146479 Tested-by: Jenkins
2023-02-03lok: add function getDocLanguagesHenry Castro
If the spell checker is disabled to use a remote spelling feature, the getLanguages function is obsolete. In order to not break stable functions, introduce the getDocLanguages for the remote spelling feature. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ic210f31eddd3208b29d073ff35ba4fa2d98ea772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145363 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit bb0c63cc73998a0f67ae4c3e59acea3827a6e11c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146399 Tested-by: Jenkins
2023-02-01lok: disable spell if remote language tool enabledHenry Castro
. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I73158c3feaa84af4d713d3f1b1fc9a60dcf95463 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144785 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145601 Tested-by: Jenkins
2023-01-31lok: add Rest Protocol propertyHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I7353e16dbf835684e5ce5963387359924352937b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145599 Tested-by: Jenkins
2023-01-30Added option to disable ssl verification for languagetoolMert Tumer
This will allow to use self-signed certificates with local run languagetool APIs Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I2bda575fa6174dfc0f6c24da45267ee732643db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136811 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145594 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-01-30lok: set LanguageTool config parameters from environmentMert Tumer
Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: Ic7343439536abee626c269d2a824bb36f9abc40f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135583 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145573 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-01-29lok: support per-user timezoneAshod Nakashian
This adds support for user-specific timezone. When none is provided during loading, the system default is used. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: Ie863450687eb82bc475268a09c9112e9fd50020f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144816 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit abaf8c0af1c6c7fe01276fdf2ae62419c7b0f654) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146211 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-28Avoid compiler warningTor Lillqvist
Change-Id: I322b2c0ea14bbf8ed2fe1a306c0ed28f5e5ae258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136875 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit ece304df9ad2aa0f974927320a1324c06b89f337) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146076 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-27Remove support for 32-bit S390Stephan Bergmann
As discussed in the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2023-January/089808.html> "Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)", the bridge implementation at bridges/source/cpp_uno/gcc3_linux_s390 is apparently dead and should thus be removed. However, that was the only bridge implementation for 32-bit S390, which implies that support for the 32-bit S390 architecture as a whole is dead and should thus be removed. Change-Id: I18b3b4fa11df4ce693107bad6bbea2fab1c19f26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146058 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-27Remove support for AIXStephan Bergmann
As discussed in the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2023-January/089808.html> "Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)", the bridge implementation at bridges/source/cpp_uno/gcc3_aix_powerpc is apparently dead and should thus be removed. However, that was the only bridge implementation for AIX, which implies that support for the AIX platform as a whole is dead and should thus be removed. Change-Id: I96de3f7f97d4fd770ff78256f0ea435383688be9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146057 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-24Surround recently added code that breaks on COWASM with ifdefTor Lillqvist
After 7a6324ea0d81bbe2bba09f8a7f5230342a4f4e85 I started getting UNO exceptions with the message "component context fails to supply service com.sun.star.xml.crypto.SEInitializer of type com.sun.star.xml.crypto.XSEInitializer". It is likely that it breaks in the iOS and Android apps, too, so bypass for those, too. Change-Id: Id08afbf6bea071c8b0b6564342716e0b064cb712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146071 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-01-23lok: ensure to initialize the security contextHenry Castro
if the backend NSS is used, before load the document ensure the NSS is initialized otherwise NSS next functions calls will fail. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I7ac1d7eeee681995e6c284e2dd4595a33d044af4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142213 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142289 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-18don't crash with --disable-pdfiumCaolán McNamara
Change-Id: Ibc88d9f32ae86f7137c24e2fe1d581ff1cd64497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12Curl:CURLOPT_REDIR_PROTOCOLS(_STR): use only "https", not "http"Julien Nabet
Change-Id: If615503b598f6823d7978f12e666832c82b63ece Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145334 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-12drop internal support for 1-bit imagesNoel Grandin
on modern hardware, these are less efficient than regular alpha channels. Also, this greatly simplies the range of stuff that vcl needs to deal with, which will make the upcoming transparency->alpha patch easier to deal with. Enhance vcl::CreateFromData to convert incoming 1-bit data to 8-bit image. Change-Id: I35829da750029fe373d0d2911a669d10bab6ad23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-11Fix types for Curl elements (update part)Julien Nabet
"CURLOPT_REDIR_PROTOCOLS_STR" has been added with Curl 7.85 so check if Curl version is 7.85 min or use the previous version "CURLOPT_REDIR_PROTOCOLS" Change-Id: Iacf6a3c37aba63d615eaa93352b098b1c9183533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145208 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-01-11rename BitmapEx::GetAlpha to GetAlphaMaskNoel Grandin
to ease the reading of code related to an upcoming patch to convert transparency to alpha, since there is already a GetAlpha in Color. Change-Id: I1af0f8f6dd94acfe4673c8556c7aff6c20da3f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-10vcl ITiledRenderable: rename supportsCommandValues() to supportsCommand()Miklos Vajna
It gets a single command (to determine if using it with getCommandValues() is OK or not), so the plural was confusing, as mentioned at <https://gerrit.libreoffice.org/c/core/+/145082/5#message-802b1be9194440a3dcee0cad5e54795cbbdea584>. Change-Id: Idf3c81aadeaeb3d42a50aba2ac58d5ed4278651f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145212 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-09Fix deprecated Curl elements for update partJulien Nabet
Change-Id: Ide008c8a80800b33c8104ec3d697e836fae73827 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145186 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-09use std::this_thread::sleep_for instead of osl equivalentArnaud VERSINI
Change-Id: I5b4edc5417e5bb5e082688df616e1d5735717d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142357 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-08Fix deprecated Curl elements for minidump partJulien Nabet
Change-Id: I43df411eed24e86f5d72982b5d24188e0cb7e507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145177 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-06tdf#86630 sw: Add one-step page number insertion wizardofftkp
Add a one-step wizard for easy insertion of the page number to the header/footer. Change-Id: Idb33c92d594e04d9256460fe414e4b10e5166af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144683 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-05sw lok: expose field type & command of fieldmark under cursorMiklos Vajna
It was possible to get the properties of all fieldmarks, but you could not get the properties of the fieldmark under the current cursor. Getting the properties of the current fieldmark is useful for Zotero: if we already have a citation and want to insert one more, then we should turn the current citation into a citation cluster. Fix the problem by adding API similar to what commit 24219cc1e9829f82a533667aef0f51b6a7df6fc2 (sw lok, .uno:TextFormFields: expose field code of fieldmarks, 2022-11-25), did: but here we return properties of the innermost fieldmark, not all fieldmarks. Also introduce a ITiledRenderable::supportsCommandValues(), this way next time a command value getter is added in sw/sc/sd, no need to touch desktop/ anymore. Change-Id: I7f1a7064307034a18527ab5e985d2eac56807cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145062 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-03sw, lok: implement a getCommandValues(Fields)Miklos Vajna
There was no LOK API to get a list of all fields of a given type where the name matches a certain prefix. This is useful in case the API cilent wants to know what previously inserted refmarks were deleted by the user as part of deleting text content. Add a new getCommandValues(".uno:Fields") that returns the names of matching refmarks. Do not return the refmark text, assuming that would be updated by the API client anyway. In practice this is needed by Zotero in case it wants to model its citations with refmarks. Change-Id: Ie469253891896aa8ab00d434c9ab116adbe3864b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144985 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-28Introduce lo_get_app_data_dir() for Emscripten, tooTor Lillqvist
And not just Android. Hardcoded to return "/instdir" to match what is in the emscripten_fs_image. Change-Id: I26d4ec5e02ec9900e35ca47f1565a13ad2b723b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144849 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-12-19tdf#145538 Use range based for loopsLeonid Ryzhov
Change-Id: I6d04185f14c3ec72b40426bd881cac80528cc736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143244 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-12-16check SfxObjectShell::Current()Caolán McNamara
SfxObjectShell::Current() can return null, it's based on the equally vile SfxViewFrame::Current() Change-Id: Ia5c7783680e9d8e5d3075078f16a2c15cb6f7a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16misc: check SfxViewFrame::Current()Caolán McNamara
these ones look potentially worth backporting Change-Id: Ie01c0b598c3408f4766318267de8438e997dd1a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144278 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-13Attempt to add ifdefs for WASM (Emscripten) for LOKit-based codeTor Lillqvist
Change-Id: I5b2556d1be61fa3a1d7996ce8d61958fbe7984c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144002 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-12-07sw, lok: implement a getCommandValues(Bookmarks)Miklos Vajna
There was no LOK API to get a list of all bookmarks where the name matches a certain prefix. This is useful in case the API client wants to know what previously inserted bookmarks were deleted by the user as part of deleting text content. Add a new getCommandValues(".uno:Bookmarks") that returns the names of matching bookmarks. Do not return the bookmark text, assuming that would be updated by the API client anyway. In practice this is needed by Zotero in case it wants to model its citations with bookmarks. Change-Id: I42a544c3c64496519eec6826b58a310ec86dee74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143764 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-11-30Add LOKit functions and whitelist export for it to WASMThorsten Behrens
For calling into LOWA from native JS, make lokit functions available Change-Id: I6458806f33131e48692f35f2a2438b35efb1f06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143497 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-11-30sw lok, .uno:SetDocumentProperties: expose value of custom document propertiesMiklos Vajna
LOK API clients currently have no knowledge about document properties. Clients like Zotero that want to store custom properties on documents need a way to read and write such properties. This commit focuses on the reading side. Add a getter for .uno:SetDocumentProperties that allows filtering for a certain prefix, this way the returned value can contain only the relevant information. Rework doc_getCommandValues() and SwXTextDocument::getCommandValues() a bit, so adding new getters require less duplication. Change-Id: I0c52cd2efcc8b1ea7307763c8252dd1e8ffdea2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143468 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-25sw lok, .uno:TextFormFields: expose field code of fieldmarksMiklos Vajna
The fieldmarks in a document were kind of invisible for LOK clients previously. The Zotero use-case requires a way to fetch certain types of fieldmarks from a document, to be able to update them and then write back those updated versions to the document later. Fix this by introducing a new .uno:TextFormFields, you can get its value using the getCommandValues() LOK API. This allows filtering for a certain field command prefix, which is generic, but e.g. in the Zotero case allows getting the citations or the bibliography. The returned JSON is an array of matching fieldmarks, containing their type and field command. It seems there is no way to return the field result, till the motivation is to just update that field result. (If there will be need, the field result can be added.) Do this in a way that next time we add a Writer-specific command (to be able to return its values), there will be no need to touch include/vcl/ITiledRenderable.hxx, causing a large rebuild. Change-Id: I2ef1159bec4034bbdd6b4ba00715a69423106edd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143275 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-11-19lok: masterpage: Introduce mode property to tile renderingSzymon Kłos
This is needed for Impress which can have slides in two Edit Modes: Master Page and Page. Change-Id: I3eca0f51ba7970e793026d1ac6aa09b19b7a904b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137869 Reviewed-by: Ashod Nakashian <ash@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142969 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-19lok: masterpage: disable callbacks on paintingSzymon Kłos
We did that only for original view, but we need to disable callbacks for used view - so when we switch mode or part it will not send the notification to the client. Bug fixed by this patch: 1. open impress in two LOK sessions 2. A enters MasterPage mode 3. B switched slide 4. A exits MasterPage mode result: A was switched to the slide selected by B Change-Id: I7dde8bb4c73862813d064319922aba4c4b727db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142716 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142966 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-14gtktiledviewer: Fix getting tiles on WindowsMike Kaganski
The "CanvasSize + 1" hack was implemented by myself in commit ebb3a72ba0c4f070c9c254c439147beea8b2d93d (Paint tiles on Windows; Oct 24 09:01:32 2022 +0200) to workaround a rounding error, where converting pixels to logic and back resulted in 1 pixel smaller size (when I worked in Writer). This hack breaks in Calc, because the size then is 1 pixel larger than expected, failing the assert below. This fixes the problem by disabling the map mode, as everywhere else in such cases. Change-Id: I37f0f03ae4cb19f2de0e7995064843d17b0c7189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142714 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-10lok: Introudce getDataArea for CalcSzymon Kłos
It will share information about real size of a data inside spreadsheet so we can easily check where data ends in online side. Change-Id: I376187a33c5c82d409f559d5cc826a4f36d4252e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139472 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142503 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-10lok: masterpage: use EditMode as parameter in invalidation callbackSzymon Kłos
Change-Id: I3905fc9e6376ca1cef3e438e7a5f229d3720b1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138961 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142501 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-09UnoApiTest: factor out common codeXisco Fauli
Change-Id: I1d84d8c1e371016a4f4f068af1e9c76635f28cf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142490 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-07Send build config (configure options) in LOKit version info JSONAndras Timar
Change-Id: I29a6cca467e5f1e9ba59528edefbb397ceb81780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141197 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141494 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-11-06-Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): desktopStephan Bergmann
Change-Id: I438acf8e63a5d855bb19daee07af0f92b4b609a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142323 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-05lok: show Math cursorMike Kaganski
Change-Id: I17a449f0a0662f0433de9cad1522a090434c1e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142178 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-25 07:23:03 +0000