summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2017-01-27lok: Unit test for comments apiPranav Kant
Change-Id: Ieedb50a4d376c1214ea23b56c8cab19c96c159d0 Reviewed-on: https://gerrit.libreoffice.org/33615 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Allow to reply to comments using postit idPranav Kant
Change-Id: Ic6aaa3066923d62f197bc2b0e02e8049c9d7cd2c Reviewed-on: https://gerrit.libreoffice.org/33612 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: New commandvalues command - .uno:ViewAnnotationsPranav Kant
Change-Id: I1c3560ab4609c64da7a77e9a65febeb569ec1a3c Reviewed-on: https://gerrit.libreoffice.org/33468 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27Put crash directory config in soffice.ini, instead of own ini fileSamuel Mehrbrodt
Change-Id: I3a7aa394792c47c6c5a3a553174d177e66ade617 Reviewed-on: https://gerrit.libreoffice.org/33582 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-27Remove dynamic exception specifications from !LIBO_INTERNAL_ONLYStephan Bergmann
...only odk/examples/ remains to be clean up Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24Crashdump: Make crash directory configurableSamuel Mehrbrodt
Change-Id: I8106ec674080ede7072581dab2e6700040de5828 Reviewed-on: https://gerrit.libreoffice.org/33032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23lok: New feature flag to turn off tiled annotationsPranav Kant
Change-Id: Ie418642242ada98d4a41f30bb6cefcd57f398ef0 Reviewed-on: https://gerrit.libreoffice.org/33472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-01-23loplugin: unnecessary destructor: comphelper..desktopNoel Grandin
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23lok: Listen for state change events for cell alignment commandsPranav Kant
We used to use HorizontalAlignment uno command for cell alignment both in online and gtktiledviewer. To make things simpler, lets use separate cell alignment uno commands for spreadsheets like we have in writer and impres. Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c Reviewed-on: https://gerrit.libreoffice.org/33444 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-23Lok: unittest batch APIAshod Nakashian
Change-Id: I33bc59756f46b51a69efd91b89813ba17eca6218 Reviewed-on: https://gerrit.libreoffice.org/33403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-23Lok: support for batch API callsAshod Nakashian
Mouse and keyboard operations typically come in batches, and often each results in tile invalidations and/or layout modifications. Processing each input event on its own, then processing the resulting output event is very costly and unecessary when we know there is more of the same. The new API adds support for batching such related input events by disabling the output events generated by Core until the batch is done. The client can then process the resulting events, which will be compressed and deduplicated. Change-Id: Id381dab807186d010021a8778ee440074a739920 Reviewed-on: https://gerrit.libreoffice.org/33402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-21coverity#1399016 Logically dead codeCaolán McNamara
Change-Id: Ib3f0ca4d07dffb568287bcd6a283ab4e529519ff
2017-01-20unused hicontrast iconCaolán McNamara
Change-Id: Iebab45a52319ab531ec27d10fc5c5304d8e7a0a0
2017-01-20const these upCaolán McNamara
Change-Id: Ide19ec6a04a591327effe6d3c4da5db62e58b4c9
2017-01-19New loplugin:dynexcspec: Add @throws documentation, desktopStephan Bergmann
Change-Id: I1e97b929174ba23fdf21c405ec4129f0e56ed2f3
2017-01-18d*: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Ibf741af5e5043fae6139a19cec3d244dee06f225
2017-01-18XPackageTypeInfo::getIcon is uselessCaolán McNamara
nothing in LibreOffice calls it, and anything external would get a resource id which is useless to anything except LibreOffice internals Change-Id: I9d6d91a047da64dc98b556ae46fc86d84cf774f4
2017-01-17set the default startup document locale fallback to work locale, not UI localeEike Rathke
Do as the comment says and #i32939# intended but never was implemented. This matters only for initial startups when no document locale at all (of the locale's corresponding western/cjk/ctl type) is configured yet, to preselect a matching locale for each under Tools->Options. Change-Id: I73588568dd34b0f7807588194579b95cde33f0fd
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-16Lok: improved tile invalidation compressionAshod Nakashian
Handle corner cases better and eliminate invalid rects and out-of-bounds coordinates. Change-Id: Ib9247ae4f0306cf68937cd2678f6386fe7710eec Reviewed-on: https://gerrit.libreoffice.org/31665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-15Add build id to crash metadataSamuel Mehrbrodt
Change-Id: I0e11a96936ea08cc439fcc1b1e3ff1f59c636665 Reviewed-on: https://gerrit.libreoffice.org/33026 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-14-Werror,-Wunused-lambda-captureStephan Bergmann
Change-Id: Idb3c9673d8c20782ff2d7995aad30ed9253b5337
2017-01-13refactor this to open the display just onceCaolán McNamara
and use the https://wiki.gnome.org/HowDoI/HiDpi HiDPI detection rules. all of this does nothing in practice, cause there is no hidpi splashscreen image Change-Id: I609faab0f207d71fd4a17bb54ef688bdd623eaea
2017-01-13tdf#90794 Fix the Linux HiDPI start screenAbhilash Singh
Change-Id: I2553cf69d6968865dc6011c73a0d2c0e7519b7a8 Reviewed-on: https://gerrit.libreoffice.org/32018 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10New loplugin:conststringvar: desktopStephan Bergmann
Change-Id: Ib7b946fd033857d7b1b436ac478c1a9ecfccaa0d
2017-01-09New loplugin:externvar: desktopStephan Bergmann
Change-Id: I3942e7496c6014c0118a9e90a8fa8251bffe8443
2017-01-06add the locale info to the crashreporter metadataMarkus Mohrhard
We have a few crashes that seem locale dependent. Especially the font related problems. Change-Id: I0cc977413dc2328ea705c96c2d4048e4f3c58bbc Reviewed-on: https://gerrit.libreoffice.org/32764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-06loplugin:nullptrStephan Bergmann
Change-Id: I279e65c2ec5fa7b3b06f01e7ef4e50ed822fcd03
2017-01-06Work around clang-cl -Werror,-Wmissing-field-initializersStephan Bergmann
...the same way as in other uses of GetStartupInfo Change-Id: Ieeadf028d15c915df32e055e3725513b2047da4d
2017-01-03desktop: remove unnecessary #define _WIN32_WINNT 0x0501Michael Stahl
gb_OSDEFS already globally sets at least 0x0502 Change-Id: I52b75dc114eb498232faeb70ec75948ad01d3675
2017-01-02tdf#95416 Get rid of #include ../foo/bar.hxx style includesGaurav Dhingra
Change-Id: I9b05c261faebd3e0e5d65ca524a4379c1d5918f1 Reviewed-on: https://gerrit.libreoffice.org/32419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-02Fix inefficient usage of string::find() in condition (CWE597)Muhammet Kara
string::compare() will be faster when string::find's result is compared with 0, because it will not scan the whole string. Change-Id: I78596a6d796fe9779f88b7c7b91da09aa27b7035 Reviewed-on: https://gerrit.libreoffice.org/32430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-23tdf#100826: Use parent console for output if possibleMike Kaganski
This patch uses either passed standard handles, or parent console for output of --help and --version command line switches. Change-Id: Iabbec79d3792ae091ca06d134345c1669eb1ac13 Reviewed-on: https://gerrit.libreoffice.org/31187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-22bodge fix buildCaolán McNamara
Change-Id: I5ef90ad7bf39618cc65641ffa85d056adc48d555
2016-12-21convert VclButtonsType to scoped enumNoel Grandin
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21No apparent reason for an unnamed namespace in an include file hereStephan Bergmann
Change-Id: I8467fbb8b4e82e58a66990ed049a12e26aabd4f0
2016-12-21tdf#95416 Fix an include for 2 files in unopkgHuzaifa Iftikhar
Change-Id: Id1fa09b6db6c90cd727182133e5f9f39383aa5e5 Reviewed-on: https://gerrit.libreoffice.org/32255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-20tdf#95416 Fix an include for desktop directoryHuzaifa Iftikhar
Change-Id: I04a2181b05f2b15a55db306f49b47855db7753db Reviewed-on: https://gerrit.libreoffice.org/32204 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2016-12-17tdf#104441 Addition to output to the console helptagezi
There is no documentation in the help on how to open a file and automatically run a macro Change-Id: I94c5e87ae0f573a5546a83b118021744b439c7cd Reviewed-on: https://gerrit.libreoffice.org/32122 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-16lok: Fix state feedback for ToggleMergeCellsPranav Kant
Now it broadcasts "disabled" to disable the command and true/false to tell the status of the command which automatically means "enabled" Change-Id: I3314da77fb2b84d97f64b9832d65791b84fcd7df Reviewed-on: https://gerrit.libreoffice.org/32086 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2016-12-16loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: I557e752ca05146e2a571d027fc3d1875afd6ef26
2016-12-16-Werror,-Wnonportable-include-path (clang-cl)Stephan Bergmann
Change-Id: I2a64b18c707085f7d4485ba46d599e8ab0df2408
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-14-Werror,-Wunused-variableThorsten Behrens
Change-Id: I32e6bad89b7cdcf0b181c0bb3a158b003fcfb767
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12loplugin:unreffunTor Lillqvist
Change-Id: If538d5d5347f58e18869cab2b687af26a39a89eb