summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2016-03-22Closing is implicitly done in the osl::Pipe dtor, anywayStephan Bergmann
Change-Id: I6002e42c75d68de9f999b481f41f18f5f765266b
2016-03-22~OfficeIPCThread can only be reached with pGlobalOfficeIPCThread clearedStephan Bergmann
...as only one instance of OfficeIPCThread is ever created (in OfficeIPCThread::EnableOfficeIPCThread), which is then either assigned to pGlobalOfficeIPCThread (if this is the first soffice instance), or pGlobalOfficeIPCThread is left unassigned and the OfficeIPCThread instance goes out of scope at the end of EnableOfficeIPCThread (if another soffice instance is already running). So mpDispatchWatcher also does not need to be cleared here, as it is only ever accessed through pGlobalOfficeIPCThread. And thus, there is no longer a need to lock GetMutex() here, either. Change-Id: I56cffc43361d01d747084153f318b8488519cf9b
2016-03-22Only access pGlobalOfficeIPCThread & mpDispatchWatcher with GetMutex lockedStephan Bergmann
Change-Id: Ia8093525935b02a019bbecd81a087af54471c592
2016-03-22No need for a static Security instance hereStephan Bergmann
Change-Id: I03f0042bd9de07b8d254118d1b4a0a016e217476
2016-03-22tdf#84323: Make osl::Thread::wait more readableGurkaran
It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-21No, I don't want to see that "bootstap" typo on every start of sofficeStephan Bergmann
Silly of 221144f9c995fe30adf577c02f756b3123fb2550 "tdf#91794 OSL_DEBUG_LEVEL > 1 removed (desktop)" to make that output conditional on just OSL_DEBUG_LEVEL>0. Can't use sal/log.hxx here, and demand for this debug output is probably rare to non-existant, so just remove it. Change-Id: Ie8c7846f785c7875375af215934c71ff28085458
2016-03-21No need to wrap SAL_WARN in #ifStephan Bergmann
Change-Id: I31cef28308acf86aec7e2bbd00ab49019fa73891
2016-03-18convert SvLBoxButtonKind to scoped enumNoel Grandin
Change-Id: Ia8e19473132cf95837acc499c5831b5ca8786a68
2016-03-17desktop.deployment • get rid of PLATFORM_ #define~sDouglas Mencken
it’s just damn double work to maintain Change-Id: I1ea9f28024770460a575890333347cf8b8681e5c Reviewed-on: https://gerrit.libreoffice.org/23315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-13quieten debugging soffice startupCaolán McNamara
Change-Id: I3f9ef32d789b7b344cc09bbed6f344e428a31ca4
2016-03-13loplugin:stringconstantCaolán McNamara
Change-Id: I80e034bc3718ddb9bb518073653e374133e6ab6f
2016-03-12tdf#91794 OSL_DEBUG_LEVEL > 1 removed (desktop)Rohan Kumar
[UPDATED PATCH]: I removed the trailing newline characters in the SAL_WARN macro as pointed by Jan Iverson Change-Id: If90b0d44777ec2ab1bd646f22f4c9cdf798cf8b4 Reviewed-on: https://gerrit.libreoffice.org/22315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-11Thread safetyStephan Bergmann
Change-Id: I13282ac1d6b3f1323e9056a4160301bd503ac271
2016-03-11No need for a complicated arg to SetReadyStephan Bergmann
Change-Id: Iacb900ab7de0f01a78441019d2455abacc974617
2016-03-11Turn static s_bInEnableRequests into an ExecuteCmdLineRequests argStephan Bergmann
Change-Id: Idb0b252d986bc866409928f4a126f55608c6347c
2016-03-11Combine mbDowning, mbRequestsEnabled as mStateStephan Bergmann
Change-Id: I3110f1690f0d7b0f19e7576f02cb1159342881a1
2016-03-11pDocsRequest cannot be nullStephan Bergmann
Change-Id: I399175f154e0a75779b90b74396c13fe2acbca49
2016-03-11Create DispatchRequest via list-initializationStephan Bergmann
Change-Id: Ic1fc17b028281e64290c6c1d25bbd94fbf27251d
2016-03-11Resolve trivial DispatchList typedefStephan Bergmann
Change-Id: I5a304701aed843f6cdbffcdcf6e04255453f0f48
2016-03-11Use range-based for loopStephan Bergmann
Change-Id: Icf9dd7ffdc39ff64e9eac11050c8bfbfef6f004d
2016-03-11There's only a single DispatchWatcher, no need for a static mutex memberStephan Bergmann
Change-Id: I410d07210bd80379fd2de1b8d76843794fa5f660
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10No more need for jfw_freeJavaInfoStephan Bergmann
Change-Id: I2426a76936b4099a243ce8c102da867e7868aac3
2016-03-10mpDispatchWatcher is a natural place to hold the DispatchWatcher singletonStephan Bergmann
Change-Id: I6221023f0158388b05db045453111974c5cb0458
2016-03-10Just use "this"Stephan Bergmann
Change-Id: If9921d73188e95395b81eb2341487423df7bc750
2016-03-10Remove unnecessary class DispatchWatcherHashMapStephan Bergmann
Change-Id: Ie73f964651aac4571ce0ddd56b5b821669188495
2016-03-10Hold DispatchWatcher by rtl::ReferenceStephan Bergmann
Change-Id: I2bdd63c864a5b1486f01907f9598a0c25a0f144d
2016-03-10ProcessDocumentsRequest ctor inits pcProcessed to nullStephan Bergmann
Change-Id: I109f4acae9ac0a61004d06a82a479541f14cfd22
2016-03-10No need for heap allocation hereStephan Bergmann
Change-Id: I34e96e3101f80398f238cdb5a94c00fee4b0faae
2016-03-09include/jvmfwk/*.h -> .hxx (only ever included from C++ code)Stephan Bergmann
Change-Id: Ia912e937d5a48afb6f8f5345b20bb7bd517fc4f1
2016-03-07fix typo getSupportedPlaforms -> getSupportedPlatformsDouglas Mencken
Change-Id: I6adecfc0475b3c93a538874515be478efb733fae Reviewed-on: https://gerrit.libreoffice.org/22968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07improve defaultparams lopluginNoel Grandin
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04lok: Export only programmatic style namesPranav Kant
First, it reverts b0111f494c1ee2d75ac4f1544c06c24d464cc416. It was a bad idea to export UI names via LOK because the client would need the programmatic ones anyways for UNO commands. We cannot expect UNO commands to accept UI style names and work, though that's another thing that they will work in most cases because mostly UI names are equal to programmatic ones. Clients are now supposed to have their own UI name <-> programmatic name mapping, if they want style names to use for translations. Secondly, it fixes a bug that was already there mixing programmatic names with UI ones in an effort to put default writer styles on the top of the list. Change-Id: I307f987fe740b3c43b0e14ec4773edcb672a11df Reviewed-on: https://gerrit.libreoffice.org/22810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-03-04tdf#92191: Don't use any IPC pipe in a sandboxed OS X appTor Lillqvist
Creating the pipe fails when sandboxed. This caused us to not start the OfficeIPCThread, and that then meant that the file open requests coming in through VCL_NSApplication's application:openFile: method in vclnsapp.mm were not processed properly. The OS takes care of not starting multiple LO apps simultaneously anyway, so we don't really need any pipe, I hope. Conflicts: desktop/source/app/officeipcthread.cxx Change-Id: Ia920520ce2928787313f83199028f9c9942f61f3 (cherry picked from commit e2f4c9eae3f53aaba968d7567f912df6fa911326)
2016-03-02tdf#98210 do not require R_OK for pipe dirHank Leininger
Also better error handling if pipe dirs are really not usable. Change-Id: I1c865b9a9f1f08d2cffd07343494feca585ec75e Reviewed-on: https://gerrit.libreoffice.org/22727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-02loplugin:unuseddefaultparam in desktopNoel Grandin
Change-Id: I9a7ac03dcbc3849eced0f8431e186b59b31b2418
2016-03-01ccu#1573 sc lok: fix reporting of hidden row heightMiklos Vajna
For columns we use ScDocument::GetColWidth(), which returns 0 for hidden columsn. Do the same for rows: so instead of using GetOriginalHeight(), use GetRowHeight(), and then 0 size will be reported for hidden rows as well. Change-Id: Ic23b6af744bbc8e194e1906614adebe5ba0c7ced
2016-03-01loplugin:sallogareasStephan Bergmann
Change-Id: I0abd86a259673596f39f0b6ab62d02f15a8e18b9
2016-03-01loplugin:stringconcatStephan Bergmann
Change-Id: I2ca9ebdce00fdaeeb2ee690fffd75b21e9acc14b
2016-02-29desktop: fix infinite loop with --enable-breakpadMichael Stahl
Change-Id: I81a0405edc29fa7205d00a5cb920b2d0e800602e
2016-02-27store the crash ini file inside of the user profileMarkus Mohrhard
Change-Id: I9d85d3daba288091f9aa406a24b24facf5d20b1e
2016-02-27leave comment about minidump locationMarkus Mohrhard
Change-Id: Ic2f44caabe14efc2555e8d155273f75a2602932c
2016-02-27work on adding crash report UIMarkus Mohrhard
Change-Id: I66f4dca3cd32381ecd52cc36490e7ee1dddf3699 Reviewed-on: https://gerrit.libreoffice.org/22566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26loplugin:stringconcatStephan Bergmann
Change-Id: I39a55a9ac67aafa3f770509430b956e2fa81e6d8
2016-02-26better error reporting for crash uploaderMarkus Mohrhard
Change-Id: I6a2b5bd72187de2b646ec0d6fdb5fe20f5d6a2d8 Reviewed-on: https://gerrit.libreoffice.org/22565 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26store the URL in the crash ini fileMarkus Mohrhard
Change-Id: I1b5f29f864d01c238f2e21de87dde8005236f332 Reviewed-on: https://gerrit.libreoffice.org/22564 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26use the new ini file based minidump uploaderMarkus Mohrhard
Change-Id: Iaf85fb53e6eff34e268b6948d62ca84b7f8e6dd2 Reviewed-on: https://gerrit.libreoffice.org/22558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26loplugin:redundantcastTor Lillqvist
Change-Id: I8c44383a751d7b3440dcdede3646231414e2f89c
2016-02-26loplugin:nullptrTor Lillqvist
Change-Id: I11f661b31db8073010a520ccd44d93e1eb7c5bc0
2016-02-26Use an XInitialization-based channel to request service mgr pre-initStephan Bergmann
...instead of private cppu::preInitBootstrap function Change-Id: Id0e6fcf721b697c993e5acffaf7836452cfa9750 Reviewed-on: https://gerrit.libreoffice.org/22699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-23 03:55:48 +0000