summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2020-12-20tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorhomeboy445
Change-Id: Ib40fc069105cbf93c617055a7c6fe466570f0b32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107844 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18lok: add parameter "MacroExecMode"Henry Castro
It is required to execute VBA scripts. Change-Id: Ibaafc62ecedcefcd0596c701728039783b5a0de7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107891 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: initialize to dispatch ".uno:RunMacro" commandHenry Castro
The ".uno:RunMacro" command it is needed for client side to show the Macro Selector Dialog. Change-Id: I8f01b9f5cc985119c9215734a6484ed7a0e30080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107886 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-15update pchesCaolán McNamara
Change-Id: I280dea8fe5f346a5555f4bf479896877579d63e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-08jsdialog: don't skip commandsSzymon Kłos
api was extended and now we send no only the latest state of a current window (may be skipped), but also commands like: close window <ID>. Make sure commands will not be skipped when new dialog appears. Change-Id: I17fa0f09d7ef78cbbcbf8786182dfeb92e6021ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107165 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107350 Tested-by: Jenkins
2020-12-08reap glxtest process early in soffice_main unconditionallyLuboš Luňák
With the VCL OpenGL backend code removal also isVCLOpenGLEnabled() will be removed, so there won't be anything to call this. And reaching this point in soffice_main takes long enough for the call to be non-blocking, so there's no good reason to delay it anyway. Change-Id: I8f7fee3d8d53bd632672afd8e8941ee7f922f8e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107361 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-06Clean up CrashReporter::IsDumpEnableStephan Bergmann
...avoiding construction of an OString from a potentially null pointer, which relied on undocumented behavior of the OString ctor Change-Id: I8f65375ba29cf345b35409019a39de1bac397625 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107278 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-06Directly check for nullptrStephan Bergmann
...instead of relying on the OString(pText) ctor's undocumented behavior of treating a null pText as an empty string Change-Id: I884c789b9b4c63bc1f013ed6bbf6c3ab9880f0e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107277 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-04update pchesCaolán McNamara
Change-Id: I3e22c2000da03f6f3345353846213203993aa865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-01OSL_FAIL.*exception -> TOOLS_WARN_EXCEPTIONNoel
Change-Id: I6800e23ead2767d245d5da71d2d40e0f8a6d7e1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-30tdf#48413 handle wildcards on WindowsDeb Barkley-Yeung
Since Windows doesn't handle wildcards on the command line, handle wildcards manually. Change-Id: I8c61ad77184827237edb3722183bf4a0b9a480a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106393 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-29Fix unmodified pdf does forced-saveMert Tumer
This is a problem when dealing with the large pdfs which take long amount of time to save. Adding or removing annotations do change the state of IsModified() Change-Id: I872cb3aec5188986cc13c6659e1bb741a6870409 Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106778 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 455cd8fe00d1c756da1bb50a50bac68a1ad645ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106741 Tested-by: Jenkins
2020-11-29LOK: send state of SheetRightToLeftPranam Lashkari
Change-Id: I4b58ab74003065a63e4274293b868c909f4f583f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105428 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit cc7bf1755c31fcd4c388f25e642c37d0e2fd758a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106810 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-11-25jsdialog: implement TreeViewSzymon Kłos
Change-Id: I7c1cc683e8c5d5bdc00c1e3d3d0a2c85846bbda0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106560 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-23desktop: rr --ignore-nested was renamed to --nested=ignoreMichael Stahl
Change-Id: Id1c1789c24b8eec27db0b24e1e43e2eb7d562509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106291 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-11-21Must now call the lovely SfxViewShell::SetCurrentDocId()Tor Lillqvist
Fixes fallout from 4fd2679a7a2b0494da84f344ab97b835edf73377. Otherwise the SfxViewShell doesn't know the id of its document, and counting the number of views of a document in SfxLokHelper::getViewsCount() fails. Change-Id: I16ba209463281aae4ab9fdfd4ee1cd6b98205774 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102025 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106254 Tested-by: Jenkins
2020-11-21Test also that loading more documents after closing all open ones worksTor Lillqvist
Just run the code in DesktopLOKTest::testMultiDocuments() in a short loop. Sadly this did not find the actual problem that is present in the code, though. (A follow-up commit will fix that problem, and then I might also change this unit test so that it would have found that problem.) Change-Id: Ie847d04e77ea3d712820413fa0f00521207eb7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102018 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106253 Tested-by: Jenkins
2020-11-21sfx2: lok: reliably support multi-documentsAshod Nakashian
Instead of using the current view to set the DocId, we instead make sure that the ShellView object has the DocId set at construction time. This turned out to be necessary in at least one case (which has a unit-test that failed), which is when events fired during the creation of a new view. The cursor position is notified before we have a chance to set the DocId and because of that we miss the notifications (or worse, we end up sending them to all other documents' views in an effort to fix this bug). This approach is clean and always guarantees that all views have the correct DocId set as soon as possible and that all notifications are sent as expected. A unit-test is added to exercise mult-document usage, which exposed a number of bugs and issues that have been addressed in this patch. Change-Id: Icf5145fb1dabd0d029368310c2b9bf73ae927ccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99975 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106252 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-21DesktopLOKTest: cleanupAshod Nakashian
Refactor the handling of document loading and unloading and cleanup to allow more flexibility when loading multiple documents and for manual destruction. Also, correctly set the document type when loading, which was defaulted to TEXT even when loading spreadsheet and presentation documents. Minor misc cleanup such as dangling semicolons and unregistering the callback twice. Change-Id: Ia244aafd526d60f73c46e99fb8c7e63f63b0a8f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99974 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106225 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-20sfx2: lok: refactor notifications and const correctnessAshod Nakashian
This reduces the stringification and reuses the notificaiton helpers to reduce code duplication. Change-Id: Icf9f9c50f3eeee61a0ded741d39fed37cfcc8da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99972 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106221 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-18loplugin:stringviewparam: No good reason to exclude operator functionsStephan Bergmann
(at least not in general) Change-Id: I71337b53dc9735e90a37ee532d0a8a08797b518c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-17loplugin:stringviewparam check methods tooNoel
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done so we get the same behavior in glade as before 3.38 in that the grid preview don't show any unoccupied grid squares replace all existing n-columns=X n-rows=Y lines because they are all wrong, except for cui/uiconfig/ui/additionsfragment.ui sw/uiconfig/swriter/ui/pageheaderpanel.ui sw/uiconfig/swriter/ui/pagefooterpanel.ui which are correct. Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-15Remove Bottom DrawTextFlag on renderFont for WatermarkMert Tumer
Alignment should be done for watermark in online side this breaks the positioning. Change-Id: I202f671269aaacd266f6443a5e336d987f680a72 Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105853 Tested-by: Jenkins
2020-11-13tdf#123936 Formatting files in module desktop with clang-formatPhilipp Hofer
Change-Id: I39856d77a2ef506612b68fccfd0ba9c9d6b1debc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105661 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-13lok: Simplify the check for command in sendDialogEvent.Jan Holesovsky
Change-Id: I1d2c967b68113d2528b80e91c32170f749ed9335 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104434 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105738 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-11-11loplugin:stringviewNoel
Add new methods "subView" to O(U)String to return substring views of the underlying data. Add a clang plugin to warn when replacing existing calls to copy() would be better to use subView(). Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11make tools::Long 64-bit on Windows platformNoel Grandin
This is only for the 64-bit windows platform. I don't see the point in messing with the 32-bit platforms, they are (a) become more and more rare (b) unlikely to even have enough available process memory to load extremely large calc spreadsheets The primary problem we are addressing here is bringing Windows-64bit up to same capability as Linux-64bit when it comes to handling very large spreadsheets, which is caused by things like tools::Rectangle using "long", which means that all the work done to make Libreoffice on 64-bit Linux capable of loading large spreadsheets is useless on Windows, where long is 32-bit. The operator<< for tools::Rectangle needs to be inside the tools namespace because of an interaction with the cppunit printing template stuff that I don't understand. SalPoint changed to use sal_Int32, since it needs to be the same definition as the Windows POINT structure. Change-Id: Iab6f1af88847b6c8d46995e8ceda3f82b6722ff7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104913 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-09tdf#42949 Fix new IWYU warnings in directories d*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8f3cd05dbd86bd22fd84d767adc44fc2b0c89404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105468 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-07ScriptForge - Update build filesJean-Pierre Ledure
modified: Repository.mk modified: desktop/CppunitTest_desktop_lib.mk modified: scp2/source/ooo/directory_ooo.scp modified: wizards/Module_wizards.mk modified: wizards/source/configshare/dialog.xlc modified: wizards/source/configshare/script.xlc Change-Id: Ia2c905179f3c1784a1bd31fcca7340e65c5ce27a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105410 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2020-11-05use a utl::TempFile and clean it up after testAndras Timar
Change-Id: I1cbe7fd8002f6ba54532135de935805dd6a4e0e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105319 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-01use officecfg for UseSystemFileDialogNoel Grandin
Change-Id: I1419af229a67d6ebb1cf2c63757656beb3f512db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105142 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28strtol returns long, so that needs to be used hereStephan Bergmann
Reverting part of 6436302f40252bc6619e304e2051115fee902e20 "convert some more long -> tools::Long" Change-Id: I72a0029e580885a1714a85d105b6f666343ebdd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104916 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-28Extend loplugin:elidestringvar to OStringStephan Bergmann
(In VisitVarDecl, filtering out AbstractConditionalOperator avoids an unhelpful > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:63:32: error: replace single use of literal 'rtl::OString' variable with a literal [loplugin:elidestringvar] > aXmlWriter.content(sPdfConformance); > ^~~~~~~~~~~~~~~ > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:52:21: note: literal 'rtl::OString' variable defined here [loplugin:elidestringvar] > OString sPdfConformance = (mnPDF_A == 1) ? "A" : "B"; > ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I7d0410f04827d79b4b526752917c37d33cad2671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-28convert some more long -> tools::LongNoel
grepping for stuff in template params this time Change-Id: Ia37bfd85480b3a72c3c465489581d56ad8dde851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-23Missing call to curl_easy_cleanup (--enable-online-update=mar)Stephan Bergmann
<https://curl.haxx.se/libcurl/c/curl_easy_init.html> states that each call to curl_easy_init "MUST have a corresponding call to curl_easy_cleanup". (And <https://curl.haxx.se/libcurl/c/curl_easy_cleanup.html> states: "Passing in a NULL pointer in handle will make this function return immediately with no action.") The call to curl_easy_cleanup appears to be missing ever since the code calling curl_easy_init was introduced with 9c3b05f2d571b58ee2322a942162ecec654544dc "improve update checker and update downloader code". Change-Id: I5757efe131f73783c6f66a77d07676b8ce440f9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104711 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-23Prevent crash with invalid lang tag.Gülşah Köse
Change-Id: I778b5b007d4edce946e8b4c26e5a07f12103a968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104707 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22Add gbuild/platform/FREEBSD_POWERPC[64]_GCC.mk files.Gleb Popov
Add "freebsd_powerpc64" case to the checkOSandCPU switch in dp_platform.cxx. Change-Id: Iedee32ecb5b49ee99cd5cf7f8d7e0e33aef1c312 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104616 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-22long->tools::Long in dbaccess..drawinglayerNoel
Change-Id: I15760da167e7d0b4c410acccd1c8c90210e28b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104623 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-21new tools::Degree10 strong typedefNoel Grandin
partly to flush some use of "long" out the codebase, but also to make it obvious which units are being used for angle values. Change-Id: I1dc22494ca42c4677a63f685d5903f2b89886dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104548 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20ensure solarmutex is locked when closing splashscreen (tdf#137177)Luboš Luňák
AFAICT all drawing is done with solarmutex held, at least Skia asserts that and this case is the only problem I've found. Here the solarmutex is not held because of c5cf78e1529970c04e1999e1 that unlocks it for DeInit(), but that call leads to closing the splashscreen. Change-Id: I453f71cc53fe229e539a862927a58fd4161c40d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104423 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-20remove unnecessary `if (!true) return;` statement from Desktop::Init()Platon Pronko
Seems that this specific piece of code was introduced in commit bc66bf4608557d757555aef1f46abf8a15c3538b by Noel Grandin, where `if (true)` wrapper was removed and `if (!true) return;` seems to have been left over. But the original `if (true)` statement was introduced in commit 4d258787559426e1e2a0279888eb669622889899 by Michael Meeks, where `if ( m_aBootstrapError == BE_OK )` before starting IPC thread was replaced with `if (true)`. I asked on IRC and they were not sure for the reason of this change, so I will add Michael Meeks as a reviewer of this patch, just in case. Change-Id: I1ffb781464fa2fde152eb21bc61e4b244e8812d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104530 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2020-10-15Fix check for inclusion of <sys/sysmacros.h>Stephan Bergmann
30a5d201144cba04dd708c11d87cc5517c04c0c3 "Do not include <sys/sysmacros.h> header unconditionally, but perform a check for it in the configure script" had added an AC_DEFINE without a corresponding mention in any config_host/config_*.h.in (we use AC_CONFIG_HEADERS), so the #ifdef was always false. The #include <sys/sysmacros.h> had been added with 01bf741a79241829b0d5c048e8f45e3cf6914d3e "WaE: include needed header" for the declaration of a major function, but which is only used in #ifdef LINUX code anyway. Change-Id: I81b574c4a3e5fa2ef4e64a507b4841044217409b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104351 Tested-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-15Do not include <sys/sysmacros.h> header unconditionally, but perform a check ↵Gleb Popov
for it in the configure script. This header is missing at least on FreeBSD. Change-Id: Iecb8c35e2ea8af84cf1488334a4d39ba0b5af7e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104214 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-10-12desktop: fix misleading commentMiklos Vajna
REQUEST_START is triggered with --show. Change-Id: I83fec4f0ae4df15ed7974f484b3001e886f82a65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104217 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-18 02:20:04 +0000