summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2022-05-17add truncate-multiline to match vcl defaultCaolán McNamara
Change-Id: Ic3e8840bd124eacdcd30182a584568d5ee0081fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-13sw content controls, dropdown: add LOK APIMiklos Vajna
- expose the available list items in a new "items" key of the LOK_CALLBACK_CONTENT_CONTROL callback - add a new lok::Document::sendContentControlEvent() function to be able to select a list item from the current drop-down - add a new listbox to the gtktiledviewer toolbar to select a content control list item when the cursor is inside a dropdown - add tests for the array API of tools::JsonWriter Change-Id: I47f1333a7815d67952f7c20a9cba1b248886f6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134256 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-09osl::Mutex->std::mutex in desktop::AcceptorNoel Grandin
Change-Id: I450734e615c4c214f18641a3ac79f6810d98922c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05use more o3tl::getTokenNoel Grandin
found by inspecting call sites of OUString::getToken Change-Id: I4269c7476c7aa46fac39528227e350568f0eb34a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05Just use Any ctor instead of makeAny (Linux, sequel)Stephan Bergmann
Change-Id: Idcf537a838bb0e47cfa31db8bc09e477b277ee37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05use more string_viewNoel Grandin
found by examining the call sites of OString::getToken which means I needed to add a new o3tl::equalsAscii function Change-Id: I7dc0ea1cf5ce8090a708d44f2cf7c938fa200c5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-04Just use Any ctor instead of makeAny in desktopStephan Bergmann
Change-Id: Ieca85ea1b822ffa80420ed1cb6950bdedd15d000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133828 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-03add o3tl::matchIgnoreAsciiCaseNoel Grandin
Change-Id: Iad8e1ed256d84808404bf20ed7a16b05b3db5818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-30jsdialog: used for formulabarSzymon Kłos
- do not block painting - use welded wrappers to send JSON - don't send tunneled dialog Change-Id: I54c3cd02ab63bad4a50a3623a32f13b0c94a3595 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132757 Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133651 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-29use more string_view in INetURLObjectNoel Grandin
Change-Id: I4462f7cf4740fa4d1b129d76a0775f4250f41bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-26cid#1504268 Silence false data race condition warningStephan Bergmann
Change-Id: I058a0f9d2e3c7434b5dc742c82067cb97c6102d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133425 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25tdf#126672 Add search field to extension managerSamuel Mehrbrodt
Change-Id: Ie5c44e79cff236c5d306c34492a5c6c789d6fb60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133381 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-04-25Update to glade 3.38.2Samuel Mehrbrodt
Change-Id: Ia57eef82cd74e14aa9f09143dcc0e5101eab9949 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133380 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-04-21Drop special-casing for Chart's sidebar property deckMike Kaganski
Introduced in commit b33b2afe6a8b4224450da7c686beb81dbf5cd24a Author Markus Mohrhard <markus.mohrhard@googlemail.com> Date Thu Jul 09 20:39:06 2015 +0200 big step towards real chart sidebar later in commit da57c32c5cb27eee38e32d10232b31d459c399df Author Tor Lillqvist <tml@collabora.com> Date Fri Feb 28 17:02:30 2020 +0200 tdf#130348: Add special case for ChartDeck, too and then in commit ff23d87cb00388095a94b90e061564fc179e1823 Author Mert Tumer <mert.tumer@collabora.com> Date Fri May 08 17:23:12 2020 +0300 mobile: fix calc chart wizard properties is not shown The normal PropertyDeck can host all the chart-specific panels, and the other decks that had "all" application context, but are not needed for charts, have their context fixed. This cleanup is needed for a following introduction of sidebar in Math. Change-Id: I5bb24d52b8dec2133213d7dddfeb91359ed4cb4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133262 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-21rhbz#2075918: Join ExtensionCmdQueue::ThreadStephan Bergmann
...so that it can't still run when the main thread is already in DeInitVCL, and this thread would crash with SIGSEGV at > #6 0x00007fe79001ac74 in dp_gui::TheExtensionManager::modified (this=<optimized out>) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/gui/dp_gui_theextmgr.cxx:498 > #7 0x00007fe790834a0b in operator() (__closure=<optimized out>, xListener=...) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/manager/dp_extensionmanager.cxx:1416 > #8 cppu::OInterfaceContainerHelper::forEach<com::sun::star::util::XModifyListener, dp_manager::ExtensionManager::fireModified()::<lambda(const com::sun::star::uno::Reference<com::sun::star::util::XModifyListener>&)> > (func=..., this=<optimized out>) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/include/cppuhelper/interfacecontainer.h:292 > #9 dp_manager::ExtensionManager::fireModified (this=0x5613a450e050) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/manager/dp_extensionmanager.cxx:1414 > #10 0x00007fe79082d907 in dp_manager::ExtensionManager::activateExtension (this=0x5613a450e050, identifier=..., fileName=..., bUserDisabled=<optimized out>, bStartup=<optimized out>, xAbortChannel=..., xCmdEnv=...) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/manager/dp_extensionmanager.cxx:425 > #11 0x00007fe790830b5f in dp_manager::ExtensionManager::addExtension (this=0x5613a450e050, url=..., properties=..., repository=..., xAbortChannel=..., xCmdEnv=...) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/manager/dp_extensionmanager.cxx:721 > #12 0x00007fe79002d628 in dp_gui::ExtensionCmdQueue::Thread::_addExtension (bWarnUser=<optimized out>, rRepository=..., rPackageURL=..., rCmdEnv=..., this=0x5613a4753490) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:870 > #13 dp_gui::ExtensionCmdQueue::Thread::execute (this=0x5613a4753490) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:744 (Which can apparently happen when you quit/restart LO quickly enough after installing an extension through "Tools - Extension Manager...") The join was missing ever since the code's introduction in f167d090345c9c7950665e50006aff4fc0ace078 "INTEGRATION: CWS extmgrui01" (there originally was an unused stopAndWait that would have joined, but which got removed in 0014f10d9237e82357e11aedecca817f67827536 "#i105556#: remove unused code", but there doesn't appear to be at least any obvious reason why joining in ~ExtensionCmdQueue should cause problems (at least with the recent fixes 2dce6754355a06e567427c39154d8747538864b1 "Reliably stop ExtensionCmdQueue::Thread::execute" and 057f504e6518d1cefd141713c98a15cf9160e676 "Use the sander std::condition_variable semantics in ExtensionCmdQueue::Thread".) Change-Id: Iaad47fb77feed529dadf230088e1cb8ffccc80c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-21Use the sander std::condition_variable semantics in ExtensionCmdQueue::ThreadStephan Bergmann
This avoids the need for the tricky osl::Condition::reset call. Change-Id: Id441fe6be42409fa43624bc0c1cbc8a62462d3e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133240 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-21Reliably stop ExtensionCmdQueue::Thread::executeStephan Bergmann
...even if nSize == 0 Change-Id: I624a5958d0826aad70277af6291f62d31ced6798 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133236 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-20Fix regression in the iOS app (and possibly the Android and GTK apps)Tor Lillqvist
The problem was caused by my remote font downloading changes. We need to be more careful in lo_initialize() and libreofficekit_hook_2() to distinguish whether the code is called from "normal" Online (with "pre-initialisation" through lok_preinit_2()) or otherwise, for instance the iOS app, where not pre-initialisation is done. Sadly, this fix makes state handling in init.cxx even more complex with one more static Boolean flag. Change-Id: I2a8fa96740eb79725aa162cf7adc86d49a8ba603 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133175 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133196 Tested-by: Jenkins
2022-04-19Fix heap-use-after-freeStephan Bergmann
...when dp_gui::ExtensionRemovedListener::disposing (desktop/source/deployment/gui/dp_gui_extlistbox.cxx) calls > m_pParent->removeEntry( xPackage ); on an already destroyed m_pParent in e.g. the following scenario: In an installation with some bundled extensions (e.g., --enable-ext-ct2n), "Tools - Extension Manager...", deselect "Display Extensions - Bundled with LibreOffice", "Close", "File - Exit LibreOffice". It appears the issue was present ever since at least 051f7b163fa4bf1917fb3db98fed2a6a932a827e "jl152#i77196# Use ExtensionManager instead of PackageManager" Change-Id: I446cba382103828b97a2b1db9fa8afc207b73bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133180 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-19new loplugin:stringviewvar looks for OUString vars that can beNoel Grandin
... that can be string_view Change-Id: I0ddf66725e08b58e866a764f57200dd188b9f639 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133066 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-17loplugin:stringviewparam convert methods using copy()Noel Grandin
which converts to std::string_view::substr() Change-Id: I3f42213b41a97e77ddcc79d84d512f49d68ca559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132729 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-15lok: report state for sparkline UNO commandsTomaž Vajngerl
Change-Id: Ic1e8464ec97ef91f631944dbaa3de0e5bff26c89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133006 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-14lok: send status update for .uno:SplitCellSzymon Kłos
Change-Id: Ic972d3ff3334f4c3a507868a95ac955c9ffbc614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132585 Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132871 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-13Clean up O[U]StringBuffer ctors taking a length parameterStephan Bergmann
For !LIBO_INTERNAL_ONLY, go back to the state before d91d98a53612a972de368186415aa48698e074d9 "fix gcc-4.0.1 and/or 32bit build for string literals" of having just a sal_Int32 overload. (For !LIBO_INTERNAL_ONLY, the current state was confusing, as the existence of further overloads depended on __cplusplus >= 201103L.) And for LIBO_INTERNAL_ONLY: * Have overloads for all integral types, with an assert checking that they do not use out-of-bounds length arguments. (The std::make_unsigned_t dance in the assert is needed to avoid signed/unsigned mismatch warnings as seen at least with MSVC.) This removes the need for explicitly casting arguments that are larger than (unsigned) int. (And I cleaned up two such places that I had become aware of with the abandoned previous attempt <https://gerrit.libreoffice.org/c/core/+/132825> "Let O[U]StringBuffer ctors take sal_Int32 length parameters"; there may be more places to clean up, though.) * Have deleted overloads for all integral types that are not actually integer types. (This excludes signed char and unsigned char, as at least > OUStringBuffer aBuf( rToken.GetByte()); in ScTokenConversion::ConvertToTokenSequence in sc/source/ui/unoobj/tokenuno.cxx does a legitimate call with an argument of type sal_Int8 aka signed char.) Change-Id: I2df77429f25b74f19cc3de5064e6fd982e87b05e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132951 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-13Follow-up fix to Collabora Online "addfont" handling: avoid assertion failureTor Lillqvist
Change-Id: Ib75954a39d515088dbd432d0aa0ca5893194ecc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132970 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-04-13Handle "addfont" from Collabora OnlineTor Lillqvist
We use the AddTempDevFont() API to add a new font. Sadly there is no corresponding way to remove such a temporarily added font. Change-Id: I6fe61919daa5af29e964cec1caf7293aefa8ea4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132948 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-04-13loplugin:stringviewparam whitelist some more functionsNoel Grandin
for which we have o3tl:: equivalents Change-Id: I4670fd8b703ac47214be213f41e88d1c6ede7032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132913 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-13Update remaining DevGuide wiki links.Ilmari Lauhakangas
My Kate editor decided to do some whitespace cleanup, but maybe it's fine as the main changes are not targeting functional bits anyway. Change-Id: I5292e77e43055f94a6256a7f72d49fd59287d194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132928 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-04-12loplugin:stringview more o3tl conversionNoel Grandin
look for call sequences that can use string_view and the new o3tl functions in o3tl/string_view.hxx Also add a few more wrappers to said #include file Change-Id: I05d8752cc67a7b55b0b57e8eed803bd06bfcd9ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132840 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-11loplugin:stringview add check for getToken().toInt32Noel Grandin
where we can convert that to o3tl::toInt32(o3tl::getToken( and avoid the heap allocation of a temporary string Change-Id: Ib11c19c6e6cdc0de3e551affd3578d181e292de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-10loplugin:stringview check for getToken and trimNoel Grandin
since we now have o3tl versions of those that work on string_view. Also improve those o3tl functions to support both string_view and u16string_view Change-Id: Iacab2996becec62aa78a5597c52d983bb784749a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132755 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-08loplugin:stringviewparam convert methods using trimNoel Grandin
for which we add a new o3tl::trim method Change-Id: I9d37b6264eea106aa2f3502bd24b8cccf7850938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-06Fix --enable-breakpad buildsStephan Bergmann
...after c9b69e412b9646f7d49f500d47a078c2ea155c8c "tdf#130924 replace debugging printf calls with SAL_INFO/SAL_WARN" (and remove now-redundant "\n") Change-Id: I11fb72d3b2f71ec0fce2386b1c0560cc873e2859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132623 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-06tdf#130924 replace debugging printf calls with SAL_INFO/SAL_WARNofftkp
Change-Id: I2e7225b846c307e9a182dadfa490d9f7ff15d35e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132488 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-03-30desktop : use std::mutex instead of osl::MutexArnaud Versini
Change-Id: I775baf9a2c9599b10eb855535ac0f8e438dd863b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-28Drop support for OpenGL denylist on X11Stephan Bergmann
...which appears to have become even less relevant with db89f53c31af997b9bf422b0e784afba8d62a42e "remove OpenGL VCL backend code". And the vcl/unx/glxtest.cxx machinery that it is based on is (a) known to cause issues like <https://gitlab.freedesktop.org/mesa/mesa/-/issues/3957> "LibreOffice's OpenGL version detection code hangs when running inside a flatpak container with a different mesa version", and (b) is one of the two reasons why an soffice that uses Wayland nevertheless also requires Xwayland during startup (the other reason being oosplash). So getting rid of the glxtest machinery is beneficial. The remaining two potential uses of OpenGL on X11/Wayland are the obscure css.rendering.SpriteCanvas.OGL service implementation (about which db89f53c31af997b9bf422b0e784afba8d62a42e states that "it seems has never been finished or enabled (or so it most probably should be dumped too)") and some slideshow transitions. About the latter, Caolán stated on IRC: "I think we grew this set of stuff to check for dodgy opengl primarily for the case where vcl used opengl for ordinary UI optimizations; but I think that use is gone now so I wonder does it make sense to just drop all of that entirely; for just slide transitions we apparently survived fine without the denylist for ages". (And in any case there is still the WatchdogThread support with OpenGLZone::hardDisable in VCLExceptionSignal_impl, vcl/source/app/svmain.cxx, should any OpenGL code run into problems.) (The removal of gb_LinkTarget_use_glxtest from gb_LinkTarget_use_vclmain, which indirectly brought in gb_LinkTarget_use_libraries,*,vcl, revealed that an explicit use of vcl was missing from various Executables etc., which thus had to be added now.) Change-Id: Ifa5220fd09910a4459ca546d9655e479a2e38f1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131943 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-14Send Calc Insert Headers and Footers state change to LOKAron Budea
Change-Id: Id51b4cf1eb962f22ee1e381873f4670789675525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131293 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131543 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-03-14add TypedWhichId version of QueryStateNoel Grandin
Change-Id: I95b86fc081847da01e06f50a1b2c7e7f5456c638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-14lok: Fix freshly added comments are not displayedMert Tumer
Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: Ice772eff8b9f8ae8c23ec1e66675e33a80492028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128217 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131515 Tested-by: Jenkins
2022-03-11loplugin:constparamsNoel Grandin
Change-Id: I5f184f93dbdb414514855c85c9dc1624e7ec8636 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-11new loplugin:trivialdestructorNoel Grandin
look for potentially trivial destructors that can then be elided Change-Id: I435c251bd4291b5864c20d68f88676faac7c43fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-07do not pass XComponentContext to officecfg::...::get() callsLuboš Luňák
It's used only for the ConfigurationWrapper singleton, so it's used only the first time and then ignored. It also causes calls to comphelper::getProcessComponentContext() for every single invocation despite the value not being needed, and the calls may not be cheap (it's ~5% CPU during ODS save because relatively frequent calls to officecfg::Office::Common::Save::ODF::DefaultVersion::get()). Change-Id: I02c17a1a9cb498aeef220ddd5a0bde5523cb0ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131056 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-01use SfxItemSet::GetItemIfSet in desktop..reportdesignNoel Grandin
Change-Id: Iaa0ddf4e97866d537a478e668e3c651a9eabc465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-25make sure that LOK "updated types" start a timer as wellLuboš Luňák
273a25c796fca9afa0dfadac57dc3f336831221c changed the handling of LOK messages to only set up an "updated" flag for types and then when flushing the value is fetched. This means that queue() is not called for such updates, and so the timeout to flush the messages wasn't started. Change-Id: I3a7324c86a55697f509f80b6c54cb949fb1daa72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130526 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-25set the dialog contents to be approx 50 characters wideCaolán McNamara
which is what was used in the original effort of... commit ebc07e1bde64a37ebe9c4326cfea7fbffd94f099 Date: Thu Jul 13 16:02:57 2006 +0000 INTEGRATION: CWS jsc7 (1.1.2); FILE ADDED this dialog can be see on clicking through to the end of the installation process triggered with ./instdir/program/soffice desktop/test/deployment/dependencies/unknown-dependency.oxt Change-Id: Ice4908422858299c1f8d2be20d892c3100c4c7db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130516 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18lok: sc: unit test drag & dropHenry Castro
.. Change-Id: I774ece93e5c439c65df50e6a67d1447a062708b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121898 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129470 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-18lok: test: fix testSheetSelectionsHenry Castro
The unit test is selecting again range, it will conflict with the drag & drop because it will drop to new cell address. The unit test will fail, the removed code will be used to a new unit test for drag & drop. Change-Id: I896f5cd7e6b671f3fac95c8ae76e7558fa8dd1d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123062 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129468 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-15Fix xml namespaceSamuel Mehrbrodt
Follow-up to 82f8a96065194913a6f452bd8fe0ac2ad26a4be0 Change-Id: I3f347b162dd6c094557e9b13e24aa8290ecc1d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129947 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-02-14Add LibreOffice Crash extensionSamuel Mehrbrodt
This extension crashes LibreOffice. It is to be used to test the crashreporter setup. Change-Id: I494cdcd746dd49a4f566507712c601494a0bbfac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128906 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
generated by cgit (git 2.34.1) at 2025-01-02 18:16:11 +0000