summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2019-03-09loplugin:unusedmethodsNoel Grandin
Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa Reviewed-on: https://gerrit.libreoffice.org/68938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-08Removed duplicated includesAndrea Gelmini
Change-Id: I4b701814e40f1ca3ced81c619696d7c3e18dc765 Reviewed-on: https://gerrit.libreoffice.org/68894 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07log nice exception messages whereever possibleNoel Grandin
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06remove some unnecessary typedef struct... sugarNoel Grandin
Change-Id: I1576282b0a0a3af8ae14c04725d9c4900073f2c4 Reviewed-on: https://gerrit.libreoffice.org/68758 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05improve documentation of soffice --accept parameterMichael Stahl
Change-Id: I8058bad949c973981013d099dba78b3e64cee0aa Reviewed-on: https://gerrit.libreoffice.org/68735 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27weld UpdateDialogCaolán McNamara
Change-Id: Ieca75774925a8766162481713f6e8a6ba0e9feb0 Reviewed-on: https://gerrit.libreoffice.org/68396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27weld LicenseDialogImplCaolán McNamara
Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf Reviewed-on: https://gerrit.libreoffice.org/68389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27lok: sc: clicking on individual chart elements doesn't select objectMarco Cecchetti
Exporting to svg a selected object of a chart does not work. In the chart case the selected object for the current document is always the chart itself, not an internal chart object. Moreover the exporting action cause the exported object to be selected again. So you try to selected the chart legend and you end up with the whole chart selected again. Change-Id: Ib4aa91afd592909ad354ca373dc03298547f9fb5 Reviewed-on: https://gerrit.libreoffice.org/68347 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27Fix typoAndrea Gelmini
Change-Id: Ida6deb31f393d9c7457e41f2047ee364aa95ad2e Reviewed-on: https://gerrit.libreoffice.org/68415 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-25weld UpdateInstallDialogCaolán McNamara
Change-Id: I56f1de2ac91076a35f1f3583d7500e5b2fa4ce54 Reviewed-on: https://gerrit.libreoffice.org/68315 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-23weld ShowLicenseDialogCaolán McNamara
Change-Id: Ia7e158a4f5a4bc629c4ad4aafc71d7c10d453099 Reviewed-on: https://gerrit.libreoffice.org/68234 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-23weld DependencyDialogCaolán McNamara
Change-Id: I2ec86617f17cbee25e6de04c5db944b03204996a Reviewed-on: https://gerrit.libreoffice.org/68235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-23loplugin:unusedfields in desktopNoel Grandin
Change-Id: I72df89e96ea31c684a5255e19796191481bc8be5 Reviewed-on: https://gerrit.libreoffice.org/68231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22LOK: reuse cached json object for ViewId where availableAshod Nakashian
Change-Id: I5e29ec2863e06d3dfcbad95c55e355805f12e259 Reviewed-on: https://gerrit.libreoffice.org/67895 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: always update the payload string via the cacheAshod Nakashian
Change-Id: I090ceb7d214d0809e86b023a8806b6655627918a Reviewed-on: https://gerrit.libreoffice.org/67894 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Validate cached queued callback payloadsAshod Nakashian
And with DBG_UTIL validate and dump LOK queue state. Change-Id: I211ddf89dbcecf17c4f1401e5d96919c4bc966ea Reviewed-on: https://gerrit.libreoffice.org/67893 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Cache JSON payloadsAshod Nakashian
Change-Id: I81f74027363d4b2959c053057851cf01fc94af8b Reviewed-on: https://gerrit.libreoffice.org/67892 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Cache RectangleAndPart payloadsAshod Nakashian
Change-Id: I3a2d98426729ad1b4e43a8f657b512679be82c26 Reviewed-on: https://gerrit.libreoffice.org/67891 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Use a struct instead of std::pair to support cachingAshod Nakashian
Change-Id: I48e8de8709e017f2667c0bf2c850004128c840d1 Reviewed-on: https://gerrit.libreoffice.org/67890 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Move RectangleAndPart to the headerAshod Nakashian
This is in preparation to cache them. Change-Id: Ic511caf5a8798750288e9271f6898ab38fe2055f Reviewed-on: https://gerrit.libreoffice.org/67889 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-20Simplify containers iterations in desktop, dtrans, editeng, extensionsArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: Ic5389d123d0a6a32a8bb46b081165e94a7c55292 Reviewed-on: https://gerrit.libreoffice.org/68036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-19pretty up logging of exceptionsNoel Grandin
Add exceptionToString() and getCaughtExceptionAsString() methods in tools. Use the new methods in DbgUnhandledException() Add special-case case code for most of the exceptions that contain extra fields, so all of the relevant data ends up in the log Change-Id: I376f6549b4d7bd480202f8bff17a454657c75ece Reviewed-on: https://gerrit.libreoffice.org/67857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15Mention that temporaryHackToInvokeCallbackHandlers() is for LibreOfficeLightTor Lillqvist
Change-Id: I0b53fea8df48bea17c56678d6d9b7d43c571d0a1
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15tdf#123474: use INetURLObject methods to construct valid URIMike Kaganski
This ensures that no extra slashes are added to the path when it already ends with a slash; for Windows drive root path (e.g. C:\) the trailing slash is always kept to not change the meaning to "current path on the drive", which is different from "root of the drive". Our IsValidFilePath does not allow more than one slash after <drive:>. Change-Id: Ife3cd9e146573a0c278834f795f0d7318c2d303a Reviewed-on: https://gerrit.libreoffice.org/67850 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-12tdf#120703 PVS: remove redundant static castsMike Kaganski
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I5fee1c4bebd1972fbb5e43da37149d4e2ff6ce0d Reviewed-on: https://gerrit.libreoffice.org/67664 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-08loplugin:indentation in dbaccess..drawinglayerNoel Grandin
Change-Id: I05de6c01e827e596c9802c04964f43508dfd4d64 Reviewed-on: https://gerrit.libreoffice.org/67537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-07lok: intercept the UNO command ".uno:EditRegion"Henry Castro
Change-Id: I3a1072e6ededbd0322c4b1dcd0ef4b16ace219d1 Reviewed-on: https://gerrit.libreoffice.org/67478 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 32555d9b5c9ef37276984eaa9d9b84007fd02038) Reviewed-on: https://gerrit.libreoffice.org/67482 Tested-by: Jenkins
2019-01-30-Werror,-Wlogical-op-parentheses (clang-cl)Stephan Bergmann
Change-Id: Ia505271b395588647a2e0b3db449000d110cb395 Reviewed-on: https://gerrit.libreoffice.org/67139 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-25lok: don't crash in simple LOK use-case with no callback.Michael Meeks
Change-Id: I7bceba10f002ad5751e3d810f9a9767ad2e875bc Reviewed-on: https://gerrit.libreoffice.org/66924 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-01-25CppunitTest_desktop_lib: avoid use-after-freeMiklos Vajna
The LOK callback registers a DesktopLOKTest instance, but depending on timing, VCL may invoke that callback after that instance is already deleted. The symptom is that all tests run fine, but the testsuite still crashes at the end. This can happen because DeInitVCL() indirectly calls Scheduler::ProcessEventsToIdle(), which desktop::CallbackFlushHandler::Invoke(), which may or may not invoke the (now gone) callback, depending on timing. This typically doesn't happen in debug builds, but it happens in release builds. Change-Id: I00fc07046c46ad602a8b26c022ffcc916d211346 Reviewed-on: https://gerrit.libreoffice.org/66909 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-21o3tl::make_unique -> std::make_unique in dbaccess...frameworkGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Iad5a422bc5a7da43d905edc91d1c46793332ec5e Reviewed-on: https://gerrit.libreoffice.org/66545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-17lok: We cannot skip duplicates of SELECTION_START / _END.Jan Holesovsky
The scenario is like this (see the unit test): * double-click a word to select it (the handles appear) * click somewhere else (the selection and handles disappear) * double-click the same word again (the handles did not appear in this case) The reason was that the old state was remembered and the now thought duplicate state was discarded. Change-Id: Ia49200f12907c520067258b7570d4e21b365a8dd Reviewed-on: https://gerrit.libreoffice.org/66171 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-01-15tdf#42949 Fix IWYU warnings in include/toolkit/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icebcf1a6ab073dce935a74ce79ee0f302b62e8a8 Reviewed-on: https://gerrit.libreoffice.org/65947 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-15Use utl::TempFile for exception safetyMike Kaganski
... to not leak temporary cat files Change-Id: I99e230054f1a3ed6aabce63d427483808e969716 Reviewed-on: https://gerrit.libreoffice.org/66343 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-13Reduce OUString operationsMatteo Casalin
Change-Id: I11f9205e82dff9df5b235860df1b36d266d17334 Reviewed-on: https://gerrit.libreoffice.org/66221 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-11Replace OUStringBuffer::appendCopy with append(std::u16string_view)Stephan Bergmann
...which is more general Change-Id: I94f28f8eda887120cf5f143b4549e0339b60e6a7 Reviewed-on: https://gerrit.libreoffice.org/66155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-11Resolves: tdf#122404 unlock just the toplevels that were lockedCaolán McNamara
push what toplevels got locked to just unlock those ones. otherwise the just dismissed toplevel may still be present in the Application toplevel list. merge all the similar examples of this. Change-Id: I77c0d55d1e4b3bcc3b8d88fef00ba289edd1e831 Reviewed-on: https://gerrit.libreoffice.org/66076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-08use unique_ptr in desktop::IpcThreadNoel Grandin
Change-Id: I7f67b4c9a157d7a1a5992174397c061b14c8a674 Reviewed-on: https://gerrit.libreoffice.org/65952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-06tdf#82504 writer table cell background color SvxColorItem uno functionJim Raykowski
Current background color function only sets table cell background when multiple table cells are selected. Paragraph background is otherwise set. This gives expected results for use in sidebar Paragraph panel when multiple table cells are not selected but unexpected results when multiple table cells are selected. For background setting from the table tool bar unexpected paragraph background color is set when multiple cells are not selected. This fix creates a table cell background color uno command specific for setting table cell background color. Change-Id: Ic56723b635252415d932c5499f996c3e46eee13b Reviewed-on: https://gerrit.libreoffice.org/65591 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-01lok: add signDocument to "Office" iface - to sign not opened docs.Tomaž Vajngerl
LOKit function "signDocument" can sign document without the need to open them. This is useful to sign PDF documents after they are created from a currently opened (ODF, DOCX) document. This adds DocumentDigner to sfx2, which could also be used in desktop LibreOffice without opening them and in further tests. Change-Id: Id6f242e817f594aa672f94f9c6f9b34e4035d46a Reviewed-on: https://gerrit.libreoffice.org/65767 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-29Fix typo in codeAndrea Gelmini
Change-Id: I1e6d483e7cc7f03149fbd0a0f5f49a62677faecd Reviewed-on: https://gerrit.libreoffice.org/65695 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-27lok: add test signing DOCX -> testInsertCertificate_PEM_DOCXTomaž Vajngerl
Change-Id: I1918041793935b012e60fe64073480ed4b9581d5 Reviewed-on: https://gerrit.libreoffice.org/65630 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-27lok: simplify and cleanup testInsertCertificate_{PEM,DER}_ODTTomaž Vajngerl
Change-Id: I61891d1295a342e546cab56ef80315c9f5018f90 Reviewed-on: https://gerrit.libreoffice.org/65629 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-26Use vector<PropertyValue> and containerToSequence to simplify thingsMike Kaganski
This makes creating a sequence of initially unknown size more readable and straightforward. Change-Id: I2c42aea7cc69efd0b53b7a35b72c4ae1a6ed4e87 Reviewed-on: https://gerrit.libreoffice.org/65612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-27 01:46:27 +0000