summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2017-02-08coverity#1242486 Out-of-bounds accessCaolán McNamara
Change-Id: I24d73edd90a7fbfe63dd70a1784fb2276ceb079b
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06Revert "fix desktop scripts"Stephan Bergmann
This reverts commit f52eb759f61e1806014972cb736e07479f157aa6. I assume this was intented to be a fix for e6a9dc22a4e58b565894f8cdb6a19755af7b14de "tdf#105204 fix shellcheck warnings in desktop/scripts" (later addressed with 7ba0b28cc3ac82f5c5c6d7e2536cb89771041893 "Unbreak soffice.sh"). But I think these quotations are actually useful parts of that original commit. I fail to see how pathname expansion (aka globbing; nor field splitting, if that is what was actually meant in "we want globbing here") should be a useful feature here. Change-Id: I5c33c40cfe2a817f628442fed70a07f06dd275cc
2017-02-04Unbreak soffice.shStephan Bergmann
Change-Id: I8c827db4c16a4a169dd710787bf9beb123ddc7b6
2017-02-04fix desktop scriptsJochen Nitschke
reverts parts of e6a9dc22a4e58b565894f8cdb6a19755af7b14de we want globbing here Change-Id: Ibe4672f41b0fe6a75d1aca898cc55414e138f6ef Reviewed-on: https://gerrit.libreoffice.org/33913 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-02-04tdf#105204 fix shellcheck warnings in desktop/scriptsqarkai
Use $(..) instead of `..`, use && and || instead of -a and -o, double quote to prevent word splitting, handle cd failure. Change-Id: I860891323a81ac4a46c868ab028df1e1f837c115 Reviewed-on: https://gerrit.libreoffice.org/33897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-02-04sc rowlimit: Make the cursor better fit the rendering.Marco Cecchetti
Change-Id: If4d02161bd8a37100d7403c05ea0840a3d2d0cf8
2017-02-03Typo: progess->progressJulien Nabet
Change-Id: Ic13529f4bc9ac49059a59067c50d5f2c0f569822 Reviewed-on: https://gerrit.libreoffice.org/33902 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-02unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01Need <config_features.h> here, tooTor Lillqvist
Change-Id: I39d443e582a6e82947f9c833b157f137a082a358
2017-02-01stoi not a member of std under android toolchainCaolán McNamara
Change-Id: I73a4e7894e33dd95ca50ea25f5f95bf94a43531e
2017-01-31Replace a terribly expensive json parsing with a peek for the value.Jan Holesovsky
We should reduce the amount of callbacks from the core in the first place, so that we don't have to deduplicate this much here, but this already helps a lot. Change-Id: Idf4a3681ac0f47536e00c1d97152f3f8bb99894b
2017-01-31Revert "Lok: support for batch API calls"Jan Holesovsky
This was for the moment removed from the online.git, so let's disable the API bits too before it shows this is really necessary. Reverts also: Revert "Lok: unittest batch API" Change-Id: I7bf3fe62d1e73b6f233992d51f587868a78f4bec
2017-01-31Remove meaningless commentStephan Bergmann
Change-Id: I4385376dffa6b7cbc0da3903f285185a6db928dc
2017-01-31Create missing parent dirs when checking for r/o dirStephan Bergmann
...can happen when 'unopkg add' is called before soffice had ever been run, so UserInstallation isn't populated yet Change-Id: I0c6b9444f196da5ad5a32cc90f2e1e2a5dbd0f58
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31a whole bunch of SAL_WARN_UNUSEDNoel Grandin
Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6 Reviewed-on: https://gerrit.libreoffice.org/33693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30lok: Allow to edit comment by postit idPranav Kant
Change-Id: Ice1d40b7813226fe99c423047392b3416d763dd4 Reviewed-on: https://gerrit.libreoffice.org/33614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Unit test for comments apiPranav Kant
Change-Id: Ieedb50a4d376c1214ea23b56c8cab19c96c159d0 Reviewed-on: https://gerrit.libreoffice.org/33615 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Allow to reply to comments using postit idPranav Kant
Change-Id: Ic6aaa3066923d62f197bc2b0e02e8049c9d7cd2c Reviewed-on: https://gerrit.libreoffice.org/33612 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: New commandvalues command - .uno:ViewAnnotationsPranav Kant
Change-Id: I1c3560ab4609c64da7a77e9a65febeb569ec1a3c Reviewed-on: https://gerrit.libreoffice.org/33468 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27Put crash directory config in soffice.ini, instead of own ini fileSamuel Mehrbrodt
Change-Id: I3a7aa394792c47c6c5a3a553174d177e66ade617 Reviewed-on: https://gerrit.libreoffice.org/33582 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-27Remove dynamic exception specifications from !LIBO_INTERNAL_ONLYStephan Bergmann
...only odk/examples/ remains to be clean up Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24Crashdump: Make crash directory configurableSamuel Mehrbrodt
Change-Id: I8106ec674080ede7072581dab2e6700040de5828 Reviewed-on: https://gerrit.libreoffice.org/33032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23lok: New feature flag to turn off tiled annotationsPranav Kant
Change-Id: Ie418642242ada98d4a41f30bb6cefcd57f398ef0 Reviewed-on: https://gerrit.libreoffice.org/33472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-01-23loplugin: unnecessary destructor: comphelper..desktopNoel Grandin
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23lok: Listen for state change events for cell alignment commandsPranav Kant
We used to use HorizontalAlignment uno command for cell alignment both in online and gtktiledviewer. To make things simpler, lets use separate cell alignment uno commands for spreadsheets like we have in writer and impres. Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c Reviewed-on: https://gerrit.libreoffice.org/33444 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-23Lok: unittest batch APIAshod Nakashian
Change-Id: I33bc59756f46b51a69efd91b89813ba17eca6218 Reviewed-on: https://gerrit.libreoffice.org/33403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-23Lok: support for batch API callsAshod Nakashian
Mouse and keyboard operations typically come in batches, and often each results in tile invalidations and/or layout modifications. Processing each input event on its own, then processing the resulting output event is very costly and unecessary when we know there is more of the same. The new API adds support for batching such related input events by disabling the output events generated by Core until the batch is done. The client can then process the resulting events, which will be compressed and deduplicated. Change-Id: Id381dab807186d010021a8778ee440074a739920 Reviewed-on: https://gerrit.libreoffice.org/33402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-21coverity#1399016 Logically dead codeCaolán McNamara
Change-Id: Ib3f0ca4d07dffb568287bcd6a283ab4e529519ff
2017-01-20unused hicontrast iconCaolán McNamara
Change-Id: Iebab45a52319ab531ec27d10fc5c5304d8e7a0a0
2017-01-20const these upCaolán McNamara
Change-Id: Ide19ec6a04a591327effe6d3c4da5db62e58b4c9
2017-01-19New loplugin:dynexcspec: Add @throws documentation, desktopStephan Bergmann
Change-Id: I1e97b929174ba23fdf21c405ec4129f0e56ed2f3
2017-01-18d*: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Ibf741af5e5043fae6139a19cec3d244dee06f225
2017-01-18XPackageTypeInfo::getIcon is uselessCaolán McNamara
nothing in LibreOffice calls it, and anything external would get a resource id which is useless to anything except LibreOffice internals Change-Id: I9d6d91a047da64dc98b556ae46fc86d84cf774f4
2017-01-17set the default startup document locale fallback to work locale, not UI localeEike Rathke
Do as the comment says and #i32939# intended but never was implemented. This matters only for initial startups when no document locale at all (of the locale's corresponding western/cjk/ctl type) is configured yet, to preselect a matching locale for each under Tools->Options. Change-Id: I73588568dd34b0f7807588194579b95cde33f0fd
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-16Lok: improved tile invalidation compressionAshod Nakashian
Handle corner cases better and eliminate invalid rects and out-of-bounds coordinates. Change-Id: Ib9247ae4f0306cf68937cd2678f6386fe7710eec Reviewed-on: https://gerrit.libreoffice.org/31665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-15Add build id to crash metadataSamuel Mehrbrodt
Change-Id: I0e11a96936ea08cc439fcc1b1e3ff1f59c636665 Reviewed-on: https://gerrit.libreoffice.org/33026 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-14-Werror,-Wunused-lambda-captureStephan Bergmann
Change-Id: Idb3c9673d8c20782ff2d7995aad30ed9253b5337
2017-01-13refactor this to open the display just onceCaolán McNamara
and use the https://wiki.gnome.org/HowDoI/HiDpi HiDPI detection rules. all of this does nothing in practice, cause there is no hidpi splashscreen image Change-Id: I609faab0f207d71fd4a17bb54ef688bdd623eaea
2017-01-13tdf#90794 Fix the Linux HiDPI start screenAbhilash Singh
Change-Id: I2553cf69d6968865dc6011c73a0d2c0e7519b7a8 Reviewed-on: https://gerrit.libreoffice.org/32018 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10New loplugin:conststringvar: desktopStephan Bergmann
Change-Id: Ib7b946fd033857d7b1b436ac478c1a9ecfccaa0d
2017-01-09New loplugin:externvar: desktopStephan Bergmann
Change-Id: I3942e7496c6014c0118a9e90a8fa8251bffe8443
2017-01-06add the locale info to the crashreporter metadataMarkus Mohrhard
We have a few crashes that seem locale dependent. Especially the font related problems. Change-Id: I0cc977413dc2328ea705c96c2d4048e4f3c58bbc Reviewed-on: https://gerrit.libreoffice.org/32764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-06loplugin:nullptrStephan Bergmann
Change-Id: I279e65c2ec5fa7b3b06f01e7ef4e50ed822fcd03
2017-01-06Work around clang-cl -Werror,-Wmissing-field-initializersStephan Bergmann
...the same way as in other uses of GetStartupInfo Change-Id: Ieeadf028d15c915df32e055e3725513b2047da4d
generated by cgit (git 2.34.1) at 2025-01-01 17:30:16 +0000