summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2017-09-07tdf#109202 add help blurp for new --convert-images-toThorsten Behrens
Change-Id: I5e66263f7ce1b1a8cf15775dc38e08b8f7c0f237 Reviewed-on: https://gerrit.libreoffice.org/41943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-07desktop: fix loplugin:unnecessaryparen warningMiklos Vajna
Change-Id: I10253c38208da7e5881af7611f80e03059ccc5e5
2017-09-07Improve error messages for not-standalone command line switchesMike Kaganski
--printer-name and --outdir are only valid command-line parameters if they directly follow their parent parameters (--print-to-file and --convert-to). Placing them out-of-order (e.g., using another parameter between --convert-to and --outdir) results in a generic message that --outdir is an unknown parameter. This change makes more useful message for these errors to avoid user confusion. Change-Id: I924e8571eec3de9058fe18be3789ccee2bc98c7d Reviewed-on: https://gerrit.libreoffice.org/42039 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-06lok - support for watermarkMarco Cecchetti
Extends doc_renderFont in order to generate text of requested size. Change-Id: I0ebd48f8714b7772b764f3aba3e13754869c5117 Reviewed-on: https://gerrit.libreoffice.org/41899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-09-06Don't poll the extension install progress barJan-Marek Glogowski
Just start the Idle, if actually something changed. Quite probably we shouldn't rely on an Idle at all, but this fixes the busy loop while installing an extension waiting in a confirmation dialog. Change-Id: I3abbe2eb6651ce9320ef6e4d9c5251a23ab87216
2017-09-05tdf#109202: pass arg of --convert-images-to to (f)odt filterKatarina Behrens
Tunelling 1 piece of information through 20 layers of abstraction Advanced tunelling all the way to sfx2 Exhausted beyond recognition arrived to [Flat]ODF filter Change-Id: I0597c20c28f5cf8e2c60c4398622b36bda83abd0 Reviewed-on: https://gerrit.libreoffice.org/41777 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-05tdf#109202: Convert images via command line parameter, CLI supportSamuel Mehrbrodt
Change-Id: Iea65bc24ed9a76ca35f7f91e0867a0853ced93e6 Reviewed-on: https://gerrit.libreoffice.org/41136 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-05Remove useless commentSamuel Mehrbrodt
Who is AS? Change-Id: I492978e6ed34a78a8bead2e6fea760fcb0ab458b Reviewed-on: https://gerrit.libreoffice.org/41135 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-01tdf#109241 desktop: Win32: prepend "program" dir to $PATHMichael Stahl
The problem is that python modules (*.pyd) find DLLs in the wrong places. This is because sal_detail_initialize() calls SetDllDirectoryW(""), which removes (sometimes?) the "current directory" from the DLL search order, which is deliberately initialized to the "program" dir by CreateProcess() calls in officewrapper.cxx. Loading DLLs still works for LO's own DLLs since they are all in the "program" directory, which is the same directory where all the executables are, so it is searched first. But CPython loads its modules with LOAD_WITH_ALTERED_SEARCH_PATH, which doesn't search the directory of the executable but the directory of the immediately loaded DLL i.e. the *.pyd file instead, i.e. python-core-X.Y.Z/lib. It would be possible to call SetDllDirectory(".../program") instead but probably that would require patching python since it needs to be done in the real exectuable, not in the wrapper executable. So overwrite the $PATH again (like was done in the days of the office of the holy trinity) in the officewrapper.cxx and genericloader.cxx to prepend "program" and get priority over the rest of $PATH. This still doesn't protect against C:/Windows/System32/LIBEAY32.DLL since that has higher priority than $PATH but hopefully nobody is *that* stupid. This patch fixes soffice.exe, swriter.exe etc., and unopkg.exe. The python.exe wrapper already prepends "program" to $PATH. Change-Id: If03f07eba9a2c7fc6cf44f82f639b5d0b4c62e20
2017-08-31Remove unused desktop/StaticLibrary_minidump.mkStephan Bergmann
...after f4c68d3ad80734e15d093eeee211519e97e2a8ec "use a dynamic library for minidump shared code" Change-Id: I155fdfbdcd6bdeff4def94c713c4372c13c3a0b2 Reviewed-on: https://gerrit.libreoffice.org/41732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-31Revert loplugin:constparam behavior when param is subject of castStephan Bergmann
...cf. 72cfd4d024aa9deb68010824a804f252e37b8388 "loplugin:constparams: Also handle ObjCObjectPointerType" Change-Id: Ieec294d721002cac0c37bf2590a9ce20b3e123e3
2017-08-29revert "convert all sal_Bool to bool in start.c"Chris Sherlock
Didn't realise this was introduced in a version of C that was later than our minimum version... Reverts 59a25f6f82656d34735168036f7c5f923a505ce1 Change-Id: I6b6656f510251e4f3f70e499ff8a7729ee6fcc90
2017-08-29revert 36e31c6a6fbbeebd4825f318ebae2ea6c7e6719fChris Sherlock
Change-Id: If5039ab54df40f263a947c83fceba4d844467a88
2017-08-29desktop: convert all sal_Bool to bool in start.cChris Sherlock
Change-Id: I27480e0ee5e247730e5368f57d57c8dea439d3d5
2017-08-29desktop: change NULL to nullptr in start.cChris Sherlock
Change-Id: I943d33470a4cd61d78d8d465dfebe9df9cba444f
2017-08-29desktop: start.c cleanupChris Sherlock
Change-Id: I3b18abc8f01ddca70203fbae96efe09329a2d4fb
2017-08-27[Android Viewer] Password supportXimeng Zu
Added password support for documents. Change-Id: Ifd9cf86894ddaf2fd5ad97510d2ac1b5850611ad Reviewed-on: https://gerrit.libreoffice.org/40458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-08-25Get rid of need to use initial :: for ::opencl to avoid clash with sc::openclTor Lillqvist
Rename the global opencl namespace to openclwrapper. Its public API is after all declared in a file called openclwrapper.hxx. The confusion started when part of the OpenCL code was moved out from sc some years ago. Change-Id: I98ebd8498b2244804411e5de9169eb619f86070b
2017-08-23convert message box style bits to scoped enumNoel Grandin
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21tdf#111908: only freopen if we try to use another consoleMike Kaganski
Change-Id: If513faa4aac03b4c41759445e34cc965ece0b48e Reviewed-on: https://gerrit.libreoffice.org/41378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-21updater: looser throw specification for what() of exceptionMarkus Mohrhard
Change-Id: Ia73dea0cb845e1fb9a743157bbeadbcfeb1d3627
2017-08-20updater: move the update channel info from the config to versionrcMarkus Mohrhard
Change-Id: Id19578a889de51cacac869d7ec681c5c18c40cf9 Reviewed-on: https://gerrit.libreoffice.org/41365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-20updater: make it easier to test some parts of the updating codeMarkus Mohrhard
Change-Id: I7f3758eb8c12d912a47ac3a3c632347e6e124601
2017-08-20updater: windows prevents moving file with open file handlesMarkus Mohrhard
Change-Id: Iebd4886f3d44f816fc06b7c80e7368bbac3d159a
2017-08-20updater: better error loggingMarkus Mohrhard
Change-Id: I9acdfc6e493bc8ae6d2335e5aae65699bf2665c0
2017-08-19convert extended WinBits to scoped enumNoel Grandin
Change-Id: If35f4fcda2415c858ba8f963e9f471c87169bc99 Reviewed-on: https://gerrit.libreoffice.org/41301 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19updater: use forward slashesMarkus Mohrhard
Change-Id: I56b46e55007a4c30eb3e1438f8238bd3271fb993
2017-08-18fix typosdennisroczek
Change-Id: Ie0228b07bf801faab5241d835bca36676a07682e Reviewed-on: https://gerrit.libreoffice.org/39736 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17implementing callback for ruler invalidationAditya Dewan
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-08-14updater: fix -Werror=undef problemsMarkus Mohrhard
Change-Id: I5a76a302419e911f541ad75e85ed6462ebe5f07f Reviewed-on: https://gerrit.libreoffice.org/41148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14updater: fix dependency for desktop testMarkus Mohrhard
Change-Id: I699124813f375185b408a1a0c4f49a91b518971e Reviewed-on: https://gerrit.libreoffice.org/41141 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13updater: fix the updater path on windowsMarkus Mohrhard
Change-Id: I69ff622c12a289c4ac240ee4a7313eeffc3203b9 Reviewed-on: https://gerrit.libreoffice.org/40987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13updater: use desktop.updater log scope consistentlyMarkus Mohrhard
Change-Id: I242890aeda4820ada6f06e4cbe01b73d5faf549e Reviewed-on: https://gerrit.libreoffice.org/40924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13updater: make sure we pass the correct path for the updater executable on winMarkus Mohrhard
Change-Id: Ia7655317582b891e109f3b310498264cc59a3924 Reviewed-on: https://gerrit.libreoffice.org/40923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13updater: call the updater executable on windowsMarkus Mohrhard
Change-Id: Ibbcfea2e42bc55cf5c018bfb1856be7f1981f57d Reviewed-on: https://gerrit.libreoffice.org/40922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-11convert std::map::insert to std::map::emplace IINoel Grandin
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-09desktop,extensions: updater: only allow redirects to HTTP/HTTPSMichael Stahl
Configure curl to prevent redirects to other protocols. Change-Id: Ied73b3d9a062ea6e0a1d594f4c12162dffd6c4a7
2017-08-08loplugin:constantparamNoel Grandin
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03lok: Support RTF as output format.Jan Holesovsky
Change-Id: Ifea2d1dbf3d4424af557c18e31404e07f8ae89c2 Reviewed-on: https://gerrit.libreoffice.org/40691 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-02updater: fix incorrect installation directory pathMarkus Mohrhard
With this change one step updates are finally working correctly. Change-Id: I41a33b670039adc85a24de713bd0938d99da6662 Reviewed-on: https://gerrit.libreoffice.org/40660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02updater: flush the configuration changes before we call execvMarkus Mohrhard
Without this the external configuration writer thread might not have written the config yet. Change-Id: I361fd8a7ee102a8ca50899fb644a0745ed3386ca Reviewed-on: https://gerrit.libreoffice.org/40659 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02updater: always log all Updater messages also to SAL_INFOMarkus Mohrhard
Change-Id: Iafb9ebc8c1bc0ed317fa51b40e22bc8531bda6f1 Reviewed-on: https://gerrit.libreoffice.org/40657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02updater: log the update check timeMarkus Mohrhard
Change-Id: I41092b3548715a89baf9d795aa58c87a0e1621b2 Reviewed-on: https://gerrit.libreoffice.org/40658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02updater: switch to an one-step updateMarkus Mohrhard
Change-Id: I72af514ed0b3f83c8cc1fdfb8009ad523fc1a5a8 Reviewed-on: https://gerrit.libreoffice.org/40655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02updater: remove the updater files after an updateMarkus Mohrhard
Change-Id: Iaf12cb66fae2ead6d899864309f0d7f4d131e072 Reviewed-on: https://gerrit.libreoffice.org/40654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02updater: make it easier to test indenpendent updater partsMarkus Mohrhard
Change-Id: I3f06c6315349c9c53e3e76a8a01153679260c272 Reviewed-on: https://gerrit.libreoffice.org/40653 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02updater: extract the build ID generation into own methodMarkus Mohrhard
Change-Id: Ieee90215c155d031da40b2d9d0b50bc41ff2e980 Reviewed-on: https://gerrit.libreoffice.org/40652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-01tdf#109347: don't verify SSL certificate for crashreport uploadMarkus Mohrhard
Seems that on Windows we can not rely on the CA information to include the necessary info to verify the connection to the server. Change-Id: Ieed639c438f5a66e538d1126bb1e8ec1ea02b168 Reviewed-on: https://gerrit.libreoffice.org/40641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>