summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2016-06-18loplugin:unusedvariablecheckMarkus Mohrhard
Change-Id: I8bd6447915942c1869ec186d8ca01e5ac43b3e8a
2016-06-18move the code for tdf#99410 to the sal init windows codeMarkus Mohrhard
Change-Id: I4ead30fa1736a3a99fb3379e89367934c8df2809 Reviewed-on: https://gerrit.libreoffice.org/26444 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-17LOK: change type of view ids to uintptr_tMiklos Vajna
This fixes the following problem: - createView() = 1 - createView() = 2 - destroyView(1) and then view #2 was renumbered to 1. Instead expose the pointer address of the SfxViewShell as the ID, which is not changing in such a situation. Note that the SfxViewShell <-> ID mapping is an implementation detail of SfxLokHelper, and only pointers are converted to IDs, user-supplied IDs are never converted back to pointers. Change-Id: If79ef8b99ba391011b5d82b219ad13447d44cd5a Reviewed-on: https://gerrit.libreoffice.org/26423 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-17comphelper lok: remove the g_bViewCallback globalMiklos Vajna
Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16comphelper: enable LibreOfficeKit::isViewCallback() by defaultMiklos Vajna
This requires porting the sw/sd/sc_tiledrendering test code to the new internal API, as only the public LOK API is unchanged. Change-Id: Ic6a2f96421da4a16bdee7d0cbb3f6e35bc6ddff9 Reviewed-on: https://gerrit.libreoffice.org/26379 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16sw lok: move filtering of callbacks during paint to desktopMiklos Vajna
This will be important when in the per-view case SwViewShell::libreOfficeKitCallback() won't be called anymore; as pointed out by online.git's TileCacheTests::testSimpleCombine() test. Change-Id: Ie68f8c51facdba127763df660e9220f820805ecc Reviewed-on: https://gerrit.libreoffice.org/26372 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15work around MSVCR2013 bug around AVX, tdf#99410Markus Mohrhard
http://crashreport.libreoffice.org/stats/crash_details/d7bc6c8a-e8c2-4c1f-8291-ccab84ea892c Change-Id: I76f9614bc54988c001c9b252707e4b5d4c588112 Reviewed-on: https://gerrit.libreoffice.org/26339 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15Resolves: tdf#91603 if we cancel/discard recovery dialog, continue as normalCaolán McNamara
Change-Id: Ifd5df74063bcaf2f3a198b090ed2126449d7b8f8
2016-06-15Fix per-view CppunitTest_libreofficekit_tiledrenderingMiklos Vajna
Triggered by: LOK_VIEW_CALLBACK=1 make -sr CppunitTest_libreofficekit_tiledrendering The problem was that on shutdown SfxViewFrame::Current() returns 0 and then SfxLokHelper::getView() should not be called (as documented by an assert() in it). Change-Id: If0475ca591408d5b041c1cbde5b553d0fb8dd056 Reviewed-on: https://gerrit.libreoffice.org/26300 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10Clean up uses of Any::getValue() in desktopStephan Bergmann
Change-Id: I20cc2dba64a07012c7d03ab5d2aca56dd8cfb042
2016-06-10tdf#43157: Clean up OSL_TRACEArnold Dumas
Change-Id: I237c0aad5eefaf7e3dda2f84924c86cd7f82021b Reviewed-on: https://gerrit.libreoffice.org/25970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-09desktop lok: implement per-view CallbackFlushHandlerMiklos Vajna
With this, per-view cursor callbacks work again, as they did after commit 32f419fee5f9df4facb7a9b3ec910471d2a20247 (sw: implement per-view LOK_CALLBACK_CURSOR_VISIBLE, 2015-09-18). Change-Id: Ic589276f99164a1a8d46f7a029d1a59ab6e971f3 Reviewed-on: https://gerrit.libreoffice.org/26102 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09desktop lok: move CallbackFlushHandler impl details out of headerMiklos Vajna
To reduce the amount of rebuilt code when changing something there. Change-Id: I8f3c18c29d5c08d70910ee2b204cafb99d6b4011 Reviewed-on: https://gerrit.libreoffice.org/26088 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-05remove old debug outputMarkus Mohrhard
Change-Id: Icf0e38c6725a129d3afb22b1cc79f72071c8e919 Reviewed-on: https://gerrit.libreoffice.org/25934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04report the crash id back to the userMarkus Mohrhard
Change-Id: I5cc1e698294a5674d691529af8cc14e4cd87a711 Reviewed-on: https://gerrit.libreoffice.org/25865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04don't just silently ignore the return valueMarkus Mohrhard
Change-Id: Ia65c29b61e78de4b908b11cd803d93da4b7e3a2d Reviewed-on: https://gerrit.libreoffice.org/25864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04integrate the minidump upload into the normal LibreOfficeMarkus Mohrhard
Change-Id: Id1808ceebf6c54698f7d1656a0ce96bcaece89ac Reviewed-on: https://gerrit.libreoffice.org/25863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-04extract the minidump uploader code into a static libMarkus Mohrhard
The plan for the near future is to still ship the executable but replace the interal use if possible with using the static library. At some point when it is not needed for debugging anymore and everything works correctly we should only build the uploader executable in dev configurations. The huge disadvantage of the interal solution is that it is nearly impossible for a user to upload a crash report if LibO starts working correctly. Also LibO overwrites the file with the information after the upload whereas the executable does not. Change-Id: Ib9854946be3a34e580964c18e1a9c0cce16221d1 Reviewed-on: https://gerrit.libreoffice.org/25862 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-03add some more error checking to minidump uploaderMarkus Mohrhard
Change-Id: Ia06fec80ea67e88b8c26cdeb5bfc9cee2459ad4a Reviewed-on: https://gerrit.libreoffice.org/25861 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-03A slightly better DbusIpcThreadStephan Bergmann
...that doesn't burn CPU by always directly returning again from a dbus_connection_read_write call with zero timeout. But still doesn't look like it uses DBus the way it's intended to. Help appreciated. Change-Id: I0d130adfb921409a27a847053b0b3646dc566a86
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert ControlType to scoped enumNoel Grandin
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Trivial follow-up fix to 64061d8dd687efa1c78e5284ab01f2f16e5817c3Tor Lillqvist
Change-Id: I322690bba054736a1201b3f4d8f4d5670f7799b7
2016-05-30Move exithelper.h to includeTor Lillqvist
We will want to use EXITHELPER_CRASH_WITH_RESTART in vcl, too. Change-Id: If34244a361b157e0e9c7cca55fc34f0574f39984
2016-05-30use the existing url to path function also in the ini file partMarkus Mohrhard
Change-Id: Ia92261a63cfe1d51f68f312a27d5ba4b42719c47 Reviewed-on: https://gerrit.libreoffice.org/25647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-30generate correct json filesMarkus Mohrhard
Change-Id: I0d39724e550427c7de31ebc4221f1b008a2451c3 Reviewed-on: https://gerrit.libreoffice.org/25648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-30Convert ApplicationEvent::Type to scoped enumNoel Grandin
Change-Id: Ie65951d5fd1e155e3d3b36d4725792fb95fb9a52 Reviewed-on: https://gerrit.libreoffice.org/25608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-29bccu#1781: Impress/Comments - selection not updated on deleteAshod Nakashian
Change-Id: I694d76785fcf6ec9c158c34cbe07f4d1f2c7a41d Reviewed-on: https://gerrit.libreoffice.org/25219 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b95e4e8681c9cefb4e1d4177192164e041baf9d9) Reviewed-on: https://gerrit.libreoffice.org/25428 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: don't filter cursor visibility during paintingAshod Nakashian
Change-Id: Ia44ffe08dc8f46e0d10a73db374a283eb032f771 Reviewed-on: https://gerrit.libreoffice.org/25120 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit f805637353e4463d5b64f1b010bb580e191bd3aa) Reviewed-on: https://gerrit.libreoffice.org/25427 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: improved event handling and fixesAshod Nakashian
During painting, when notifications are disabled, we could still receive notifications that are imporatant and cannot be suppressed. So certain events are let through during painting. A comment describes this better in the code. Some widgets (notably postit/comment control) emits events in relative (local) coordinates instead of absolute. This is patched in many cases but some cases still exist that are rather hard to patch due to the complex interaction with other parts of the code. These supurious local coordinate updates (notably cursor invalidation) are supressed to avoid the bad side-effects they cause in LOOL. Change-Id: Ie22a316d54ea163c6976ed04314d6ced8247824c Reviewed-on: https://gerrit.libreoffice.org/25013 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b5c2a3fdbbf4161b0699ba515f63f98d7607ddf2) Reviewed-on: https://gerrit.libreoffice.org/25424 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28lok: add uno command AssignLayoutHenry Castro
Change-Id: I959d1a57945a3b5aa3f2c273c4b885ed5f628f6e Reviewed-on: https://gerrit.libreoffice.org/25569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-05-27support the json key value data upload for crash report on client sideMarkus Mohrhard
Change-Id: I93f77f9363c016e0cc5a3e3c867de9f426e5bdf0
2016-05-25lok: reset the font list when there are no itemsHenry Castro
In the pre-init stage the devices were initialized with no font list, but later the font list is updated. So those devices were not updated. Change-Id: I157d4c7079f9b1252916eb92b512aadb8e77329f Reviewed-on: https://gerrit.libreoffice.org/25419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-25Silence clang-cl -Werror,-Wmicrosoft-enum-value in external includeStephan Bergmann
Change-Id: Ic08f063efc27e4bd573c684955e69edb7e4f8bc1
2016-05-25Fix mis-mergeStephan Bergmann
Change-Id: Ia16ac2eec2b31aeb12b90e0f3fb2f3a37940c314
2016-05-25Silence clang-cl -Werror,-Wmicrosoft-enum-value in external includeStephan Bergmann
Change-Id: Ied864f8fde22a83ed35b5ce51054f055e84bac78
2016-05-25-Werror,-Wunused-variableStephan Bergmann
Change-Id: I83ef9f123156061ec5befb38dba4f46aec95d96d
2016-05-24add the file extension for minidumps on windowsMarkus Mohrhard
Change-Id: Ib5692ef839c500cac7d2551d0b0ee6faf141132a
2016-05-24use correct URL for crashreportMarkus Mohrhard
Change-Id: Ia7d584685961e8573c1c35f2560a66664632f5f7
2016-05-24copy and paste error in minidump uploaderMarkus Mohrhard
Change-Id: I114325f2de2f2953d158b88f5f0e0a3bac853368
2016-05-24fix previous commitsMarkus Mohrhard
Change-Id: I91e9f1d0f40dd3dd50b03a27ded2f96c71cd1ffd
2016-05-24return paths and not URLsMarkus Mohrhard
Change-Id: I03553a1fe98ac7ac780333b2ec247ed0cd781ffb Reviewed-on: https://gerrit.libreoffice.org/25379 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-24update the minidump location as soon as possibleMarkus Mohrhard
Change-Id: I7525ba7ff48b6df51ce8f7fdccf5ff512cdfec89 Reviewed-on: https://gerrit.libreoffice.org/25378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-24handle std::string vs std::wstring during exportMarkus Mohrhard
Change-Id: I00a32eb465b54e2a2747eebd00605212f14e5384 Reviewed-on: https://gerrit.libreoffice.org/25380 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-23use the TDF server as target for crash reportsMarkus Mohrhard
Change-Id: I0518bbad2f3550f8cac453c98af88a092448b5cd
2016-05-23lok: Subcribe to more uno commands for state changePranav Kant
Change-Id: Id2870b176de4163fbe01e4ac380b4981d3187d90
2016-05-22Convert DragMode to scoped enumNoel Grandin
Change-Id: I68dafefc74bad355047738605defd97f3c6bebcd Reviewed-on: https://gerrit.libreoffice.org/25209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>