summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2016-04-08tdf#94306 replace boost::noncopyable in d...Jochen Nitschke
dbaccess, desktop and drawinglayer. Replace with C++11 delete copy-constructur and copy-assignment. Nothing special, only one unused include in dbaccess/source/filter/xml/xmlfilter.cxx. Change-Id: Iebabbc658215162450d4caf08d4fb2f116c456d9 Reviewed-on: https://gerrit.libreoffice.org/23918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-07refactor pagein, as it still seems to cause rare crashesBjoern Michaelsen
Change-Id: I51e6cdf79c19c3709e00dc10175527ec6583a758 Reviewed-on: https://gerrit.libreoffice.org/23872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-07CppunitTest_desktop_lib: avoid #include "../..." style includeMiklos Vajna
Change-Id: Ib5ce0dee00c9306f89ad4b43af4b34e604147a1c
2016-04-05RequestHandler::Disable(join = false) is problematicStephan Bergmann
...as it causes ~RequestHandler to be called with mIpcThread still running, triggering the assert in ~RequestHandler and keeping the thread potentially still running during exit. The odd SalMainPipeExchangeSignal_impl acting upong just SIGTERM (instead of turning off the IPC thread early for each invocation of LO's signal handler, say) is effectively like that ever since ee3351d78c9b6ffbc4dfe62853e81b84e65879c7 "#89023# splash screen optimization"; just change it to use RequestHandler::SetDowning instead. Change-Id: I238476706c2463130a6ede64a062d46af953ba6f
2016-04-05loplugin:constantparamNoel Grandin
Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18 Reviewed-on: https://gerrit.libreoffice.org/23832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05Consistently use "desktop.app" log area hereStephan Bergmann
Change-Id: Ie31f1ea788cc2b8b0d6c672d93df84adb3326a05
2016-04-05Remove whitespace randomly insertedStephan Bergmann
...with 221144f9c995fe30adf577c02f756b3123fb2550 "tdf#91794 OSL_DEBUG_LEVEL > 1 removed (desktop)" Change-Id: Ief7193bb5cb10e633744b545bca9416ffa37c20e
2016-04-05-Werror,-Wunused-functionStephan Bergmann
Change-Id: I2d0a21b0f38feafa6e3fde0245b1fdb9b5771152
2016-04-05sequence->vector in xmlscriptNoel Grandin
Change-Id: I4f99cd9dc659f54bd4818559dd3e0dbce1e8f5d4 Reviewed-on: https://gerrit.libreoffice.org/23795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04No DBUS_TIMEOUT_INFINITE before D-Bus 1.4.12Stephan Bergmann
Change-Id: Ie53359fb2b6a73fa3611e56314ae2df00457adc0
2016-04-04...and MSVC "warning C4701: potentially uninitialized local variable used"Stephan Bergmann
Change-Id: I4a7eab0cbca2da04b81867158d15c94eda16d3b2
2016-04-04Try silence bogus -Werror,-Wsometimes-uninitializedStephan Bergmann
Change-Id: I85528ab58e6f29464a3b4a78096e5b9575735220
2016-04-04-Werror=shadowStephan Bergmann
Change-Id: I231396660573e395ef7f949687c6e536a8a60b20
2016-04-04Add DBus-based IPC mechanism for xdg-appStephan Bergmann
first cut; triggered on LIBO_XDGAPP env var for now Change-Id: If4586aedb58499e36a5d87cc8d171400ce7e9499
2016-04-04Prepare for using other IPC mechanisms besides an osl::PipeStephan Bergmann
Change-Id: Ie34330508563bef25185216bdc1dc3ae84d084d4
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-04Use std::size_tMiklos Vajna
And include <cstddef> where necessary. Change-Id: Icc1208528d6a8b04375d55ccbf3cd6ef046b454f Reviewed-on: https://gerrit.libreoffice.org/23796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01Remove dead -tofront processingStephan Bergmann
aArguments must adhere to a certain grammar, and if it doesn't (which would be the case if it started with "-tofront"), then the Parser ctor would have thrown an exception and we wouldn't reach this code anyway. Looks like a remnant from Sun webtop times, got originally introduced with c9d844f62c388d463445097f1cc453535491e171 "INTEGRATION: CWS cl03: #109140# -start -> -show", but there appears to be no other mentions of -tofront across the LO code base. Change-Id: I5097bf38753f6cc9184a934da81342b3ccf330b4
2016-04-01Clean upStephan Bergmann
Change-Id: I607108e5ec26992ec4763c4de3e1f53b4fbe886d
2016-04-01Rename ipc_ -> handler_Stephan Bergmann
Change-Id: I9509af144143de9f6ec3fc6ac925be99727c9c68
2016-04-01HAVE_FEATURE_MACOSX_SANDBOX doesn't initiate IPC in RequestHandler::EnableStephan Bergmann
...so cannot return with IPC_STATUS_PIPE_ERROR anyway Change-Id: If98bcc9b7cc1fbcc367e50759be0e8d6003d941b
2016-04-01Unused includeStephan Bergmann
Change-Id: I3541c7a09b203b6a4ee81ffc5e778c017191fe27
2016-04-01No need to #if this codeStephan Bergmann
...it's enough to conditionally set ipc = false in RequestHandler::Enable. Change-Id: Ie64b476d6ad5a5fbedb7542c5dab69daadf17f1e
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: Icff7c0308843d6a7608be24d7fcf11fa079c7b72 Reviewed-on: https://gerrit.libreoffice.org/23672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31Clean upStephan Bergmann
Change-Id: I93efe38ee7148c87d2fabd6f3c77d28b85b6e511
2016-03-31HAVE_FEATURE_MACOSX_SANDBOX doesn't want to launch the PipeReaderThreadStephan Bergmann
Change-Id: I55ca1b91ed3b52e9b2b0f802692cbe45d50826e1
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30Remove undocumented perftune.ini FastPipeCommunicationStephan Bergmann
...originally added to OOo in 2005 with 9277dc7501f70d80ea1302c128c2786c01b69706 and e3eecbfeb639529f3a15c0acfe4697a619d454fb "INTEGRATION: CWS cov2src: #126234# Join MWS COV680 m4 into SRC680". Change-Id: I149686eca8bda5ea7a363cd995447576e217ec13 Reviewed-on: https://gerrit.libreoffice.org/23600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-30Fix Android buildMiklos Vajna
Change-Id: I7247f19b03302b2270e0f6f32c6e6b6e760fd7bd
2016-03-29Remove obsolete commentStephan Bergmann
The code it commented got removed with 77c52217238b6a1b08b74852aa79163306c688a9 "INTEGRATION: CWS sb83". Change-Id: I709db766806a75823e3436a0b3d5a6eba307ecca
2016-03-29Remove undocumented perftune.ini QuickstartPreloadConfigurationStephan Bergmann
...originally added to OOo in 2005 with 8a9d865b32b760804adf53b0d68fd74785890915 "INTEGRATION: CWS cov2src: #126234# Join MWS COV680 m4 into SRC680". Change-Id: I7167c99e28b56c9048de32576e793e2eaa1fc6a6
2016-03-29LOK shouldn't reach this code anymoreStephan Bergmann
...after 79b0d4ba2cbc5a35adaa9628cc18eb0f46d01f9c "Don't launch the PipeReaderThread from LOK" Change-Id: I0a8674cc2df738e723f43e372f622dd5a02c5a7f
2016-03-29Don't launch the PipeReaderThread from LOKStephan Bergmann
ATTENTION: Users of LOK need to ensure somehow that no two processes operate on the same UserInstallation simultanously. Especially the lokdocview widget in gnome-documents is known to be problematic in this regard, cf. the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-March/073839.html> "LibreOfficeKit and the UserInstallation". Change-Id: I7bc2edb281c925e479b8006151d8549441c9e9e8
2016-03-29Rename OfficeIPCThread to RequestHandlerStephan Bergmann
Change-Id: I2076d903e83a0b8eb3aa0ce2413630e2c5415b15
2016-03-29Extract PipeReaderThread from OfficeIPCThread (a misnomer, now)Stephan Bergmann
Change-Id: Ie30cc14bdc772fd898d24a3e3caf41ac9718712f
2016-03-29Simplify codeStephan Bergmann
Change-Id: I793f6ce3297b114ebe79b9937e07291e1b238ab1
2016-03-29The whole block is only relevant for HAVE_FEATURE_OPENGLStephan Bergmann
Change-Id: Iae065ee34c5536843ddba39b72b6fff4836cbf86
2016-03-28don't build/install minidump_upload with ENABLE_BREAKPAD=Rene Engelhard
Change-Id: I0f7d9811d669c2884b0c1704878678b01529e52f
2016-03-25fix headless buildOliver Specht
disables OpenGL and glew usage, lets --without-gui do what --without-x did before and disables X related test Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb Reviewed-on: https://gerrit.libreoffice.org/23474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-23no need for IPC on Android, removes the need for the cache-hackChristian Lohmaier
removing the cache on each launch prevented opening files via intents (i.e. from your mail application) unless the viewer was already running, as it also deleted the temporary file that was created from the intent. Change-Id: I0a4d9432f475e8434902ae11fc2b0c35fd25a71f
2016-03-23loplugin:constantparam in desktopNoel Grandin
Change-Id: I9c7cab31a37214479e3f66d4b8a71de75a50f2e0
2016-03-23Typo in commentStephan Bergmann
Seems most plausible that 5ffdcea247f64e36f56cfbfa3ba2bde0777945d6 "Use OfficeIPCThread::WaitForReady rather than sleeping" meant "ready" instead of "read" here, given it also added a call to OfficeIPCThread::WaitForReady following that comment. Change-Id: I82219d7f1b95798973c2b00cd70219062e97d214
2016-03-22Closing is implicitly done in the osl::Pipe dtor, anywayStephan Bergmann
Change-Id: I6002e42c75d68de9f999b481f41f18f5f765266b
2016-03-22~OfficeIPCThread can only be reached with pGlobalOfficeIPCThread clearedStephan Bergmann
...as only one instance of OfficeIPCThread is ever created (in OfficeIPCThread::EnableOfficeIPCThread), which is then either assigned to pGlobalOfficeIPCThread (if this is the first soffice instance), or pGlobalOfficeIPCThread is left unassigned and the OfficeIPCThread instance goes out of scope at the end of EnableOfficeIPCThread (if another soffice instance is already running). So mpDispatchWatcher also does not need to be cleared here, as it is only ever accessed through pGlobalOfficeIPCThread. And thus, there is no longer a need to lock GetMutex() here, either. Change-Id: I56cffc43361d01d747084153f318b8488519cf9b
2016-03-22Only access pGlobalOfficeIPCThread & mpDispatchWatcher with GetMutex lockedStephan Bergmann
Change-Id: Ia8093525935b02a019bbecd81a087af54471c592
2016-03-22No need for a static Security instance hereStephan Bergmann
Change-Id: I03f0042bd9de07b8d254118d1b4a0a016e217476
2016-03-22tdf#84323: Make osl::Thread::wait more readableGurkaran
It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-08 16:05:27 +0000