summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2019-04-02weld XMLFilterSettingsDialogCaolán McNamara
Change-Id: Ia027fa0b5e99651988f2447bf29f6f5653dd0c48 Reviewed-on: https://gerrit.libreoffice.org/70139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02drop some unneeded includesCaolán McNamara
Change-Id: I78b9682968acea7564554fb589d2759b6c8e67d0 Reviewed-on: https://gerrit.libreoffice.org/70126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-31tdf#120703 PVS: Silence V575 warningsMike Kaganski
V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-29tdf#42949 Fix IWYU warnings in include/sfx2/[n-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia2bea9bd4775f4ed5ef0133971106a6c0bfdd1c0 Reviewed-on: https://gerrit.libreoffice.org/69896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28simplify reset(nullptr) -> reset()Noel Grandin
Change-Id: Iec5e93d9c59dde44571376e46fb98ea854e16b6c Reviewed-on: https://gerrit.libreoffice.org/69784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-26Consolidate declarations of {fire,reap}_glxtest_process in single include fileStephan Bergmann
Change-Id: I7f25cba311d42a7e8751cf3651f684b88d1fb8ac Reviewed-on: https://gerrit.libreoffice.org/69711 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-26loplugin:singlevalfieldsNoel Grandin
Change-Id: I4a56a27ebce927b8e21cf37bb2c527caf1317bcc Reviewed-on: https://gerrit.libreoffice.org/69681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26tdf#124146 support posting of gesture event for LOKitTomaž Vajngerl
Change-Id: I51845f2e41dbcbe1ae6cb0a18cf9f42d5549968b Reviewed-on: https://gerrit.libreoffice.org/69657 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-25new loplugin:unoqueryNoel Grandin
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-22lok: Keep the temporary user profile set during the entire preload.Jan Holesovsky
Otherwise the core likes to crash due to the keyboard accellerators being read, but the configuration is missing. Change-Id: I94193f47462227b5975a49ce11709d7bf415a519 Reviewed-on: https://gerrit.libreoffice.org/69508 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-03-21lok: intercept the UNO command ".uno:ThesaurusDialog"Henry Castro
Change-Id: I085cb646037f260ada4d4d04c2419638dd235048 Reviewed-on: https://gerrit.libreoffice.org/69264 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2019-03-18Added tiled watermark export option for pdfmerttumer
Change-Id: I3f28ad64c13dd4bc1b2862e86d2190e46a0ced46 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/67779 Tested-by: Jenkins
2019-03-15tdf#124042: Add SAL_INFOs for iOS about the CGContext life cycle in LOKitTor Lillqvist
Use the same logging tag as in vcl for uniformity. Helps in tracing the life cycle and usage of CGContexts. Change-Id: I89c33ac63fa26e10a8866c2aacecce89ef9b5f6b
2019-03-15loplugin:stringconstantNoel Grandin
/home/noel/libo/desktop/source/lib/init.cxx:3571:22: error: rewrite call of 'rtl::operator==' with empty string constant argument as call of 'rtl::OUString::isEmpty' [loplugin:stringconstant] if (aHeaders == "") Change-Id: If0d8c411c6dd563622a855e209c0a5692c222abe
2019-03-15Don't return an empty C string, the caller is not prepared for thatTor Lillqvist
If the caller receives a pointer to an empty C string, it will send the message "commandvalues: " to the JavaScript bits. That will cause an exception as it expects JSON after the commandvalues: keyword. Instead return a nullptr. The caller is prepared to handle that. Change-Id: Ia1efa967668ba518993edb7945f064758b660b96
2019-03-12Write HiDPI consistently without a hyphenTor Lillqvist
Hopefully makes it easier to find locations in the code related to HiDPI issues. Change-Id: I2b4e5ff6d66c0ca5792250c3fd0d42eeb59eb3ef
2019-03-11android: Set the program path sensibly when we've got nullptr.Jan Holesovsky
Change-Id: I4415459ca5d758d06d866faeca85e1cf154d0567 Reviewed-on: https://gerrit.libreoffice.org/67877 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-03-11android: Generate liblo-native-code.so so that it can be linked against.Jan Holesovsky
And used for LibreOfficeKit directly, without a JNI wrapper. Change-Id: If4231f53b579417b6c9c90b39541193bf2e8f27c Reviewed-on: https://gerrit.libreoffice.org/67874 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-09loplugin:unusedmethodsNoel Grandin
Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa Reviewed-on: https://gerrit.libreoffice.org/68938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-08Removed duplicated includesAndrea Gelmini
Change-Id: I4b701814e40f1ca3ced81c619696d7c3e18dc765 Reviewed-on: https://gerrit.libreoffice.org/68894 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07log nice exception messages whereever possibleNoel Grandin
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06remove some unnecessary typedef struct... sugarNoel Grandin
Change-Id: I1576282b0a0a3af8ae14c04725d9c4900073f2c4 Reviewed-on: https://gerrit.libreoffice.org/68758 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05improve documentation of soffice --accept parameterMichael Stahl
Change-Id: I8058bad949c973981013d099dba78b3e64cee0aa Reviewed-on: https://gerrit.libreoffice.org/68735 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27weld UpdateDialogCaolán McNamara
Change-Id: Ieca75774925a8766162481713f6e8a6ba0e9feb0 Reviewed-on: https://gerrit.libreoffice.org/68396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27weld LicenseDialogImplCaolán McNamara
Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf Reviewed-on: https://gerrit.libreoffice.org/68389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27lok: sc: clicking on individual chart elements doesn't select objectMarco Cecchetti
Exporting to svg a selected object of a chart does not work. In the chart case the selected object for the current document is always the chart itself, not an internal chart object. Moreover the exporting action cause the exported object to be selected again. So you try to selected the chart legend and you end up with the whole chart selected again. Change-Id: Ib4aa91afd592909ad354ca373dc03298547f9fb5 Reviewed-on: https://gerrit.libreoffice.org/68347 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27Fix typoAndrea Gelmini
Change-Id: Ida6deb31f393d9c7457e41f2047ee364aa95ad2e Reviewed-on: https://gerrit.libreoffice.org/68415 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-25weld UpdateInstallDialogCaolán McNamara
Change-Id: I56f1de2ac91076a35f1f3583d7500e5b2fa4ce54 Reviewed-on: https://gerrit.libreoffice.org/68315 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-23weld ShowLicenseDialogCaolán McNamara
Change-Id: Ia7e158a4f5a4bc629c4ad4aafc71d7c10d453099 Reviewed-on: https://gerrit.libreoffice.org/68234 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-23weld DependencyDialogCaolán McNamara
Change-Id: I2ec86617f17cbee25e6de04c5db944b03204996a Reviewed-on: https://gerrit.libreoffice.org/68235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-23loplugin:unusedfields in desktopNoel Grandin
Change-Id: I72df89e96ea31c684a5255e19796191481bc8be5 Reviewed-on: https://gerrit.libreoffice.org/68231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22LOK: reuse cached json object for ViewId where availableAshod Nakashian
Change-Id: I5e29ec2863e06d3dfcbad95c55e355805f12e259 Reviewed-on: https://gerrit.libreoffice.org/67895 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: always update the payload string via the cacheAshod Nakashian
Change-Id: I090ceb7d214d0809e86b023a8806b6655627918a Reviewed-on: https://gerrit.libreoffice.org/67894 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Validate cached queued callback payloadsAshod Nakashian
And with DBG_UTIL validate and dump LOK queue state. Change-Id: I211ddf89dbcecf17c4f1401e5d96919c4bc966ea Reviewed-on: https://gerrit.libreoffice.org/67893 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Cache JSON payloadsAshod Nakashian
Change-Id: I81f74027363d4b2959c053057851cf01fc94af8b Reviewed-on: https://gerrit.libreoffice.org/67892 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Cache RectangleAndPart payloadsAshod Nakashian
Change-Id: I3a2d98426729ad1b4e43a8f657b512679be82c26 Reviewed-on: https://gerrit.libreoffice.org/67891 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Use a struct instead of std::pair to support cachingAshod Nakashian
Change-Id: I48e8de8709e017f2667c0bf2c850004128c840d1 Reviewed-on: https://gerrit.libreoffice.org/67890 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-22LOK: Move RectangleAndPart to the headerAshod Nakashian
This is in preparation to cache them. Change-Id: Ic511caf5a8798750288e9271f6898ab38fe2055f Reviewed-on: https://gerrit.libreoffice.org/67889 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-02-20Simplify containers iterations in desktop, dtrans, editeng, extensionsArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: Ic5389d123d0a6a32a8bb46b081165e94a7c55292 Reviewed-on: https://gerrit.libreoffice.org/68036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-19pretty up logging of exceptionsNoel Grandin
Add exceptionToString() and getCaughtExceptionAsString() methods in tools. Use the new methods in DbgUnhandledException() Add special-case case code for most of the exceptions that contain extra fields, so all of the relevant data ends up in the log Change-Id: I376f6549b4d7bd480202f8bff17a454657c75ece Reviewed-on: https://gerrit.libreoffice.org/67857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15Mention that temporaryHackToInvokeCallbackHandlers() is for LibreOfficeLightTor Lillqvist
Change-Id: I0b53fea8df48bea17c56678d6d9b7d43c571d0a1
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15tdf#123474: use INetURLObject methods to construct valid URIMike Kaganski
This ensures that no extra slashes are added to the path when it already ends with a slash; for Windows drive root path (e.g. C:\) the trailing slash is always kept to not change the meaning to "current path on the drive", which is different from "root of the drive". Our IsValidFilePath does not allow more than one slash after <drive:>. Change-Id: Ife3cd9e146573a0c278834f795f0d7318c2d303a Reviewed-on: https://gerrit.libreoffice.org/67850 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-12tdf#120703 PVS: remove redundant static castsMike Kaganski
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I5fee1c4bebd1972fbb5e43da37149d4e2ff6ce0d Reviewed-on: https://gerrit.libreoffice.org/67664 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-08loplugin:indentation in dbaccess..drawinglayerNoel Grandin
Change-Id: I05de6c01e827e596c9802c04964f43508dfd4d64 Reviewed-on: https://gerrit.libreoffice.org/67537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-07lok: intercept the UNO command ".uno:EditRegion"Henry Castro
Change-Id: I3a1072e6ededbd0322c4b1dcd0ef4b16ace219d1 Reviewed-on: https://gerrit.libreoffice.org/67478 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 32555d9b5c9ef37276984eaa9d9b84007fd02038) Reviewed-on: https://gerrit.libreoffice.org/67482 Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-06 11:44:26 +0000