summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2022-09-20Only try to convert outdir to system path when it's not emptyMike Kaganski
Avoids a warning on startup of a debug build: > instdir/program/soffice warn:legacy.osl:1528:2140:sal/osl/w32/file_url.cxx:849: osl_getAbsoluteFileURL called with empty base URL and/or invalid relative URL Change-Id: Ic456f08011d099a95894259f31800f12318af223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140230 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-19try harder to remove "OSL_PIPE" pipe on SIGTERMCaolán McNamara
a) When oosplash got SIGTERM it used SIGKILL on soffice.bin, (concealed behind osl_terminateProcess) so soffice.bin has no chance to cleanup. Try SIGTERM, followed by SIGKILL if that doesn't work, to give soffice.bin a chance. b) java intercepts SIGTERM so if JNI_CreateJavaVM was called then our SIGTERM handler doesn't get called. Add -Xrs to jvm args to avoid this. Change-Id: I09f93d8093bc7c094482eda73b4eadc5a6cebb83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140152 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-19Ignore also when a font has been substituted by itself with an empty styleTor Lillqvist
Change-Id: I40fbce716a11b010323ac07e0dacdc114f7d2320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140135 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-15[loplugin:fakebool] in desktopJulien Nabet
/home/julien/lo/libreoffice/desktop/source/migration/migration.cxx:628:5: error: VarDecl, use "bool" instead of '::sal_Bool' (aka 'unsigned char') [loplugin:fakebool] auto const hasCurrent = set->hasByName(currentName); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/julien/lo/libreoffice/desktop/source/migration/migration.cxx:629:5: error: VarDecl, use "bool" instead of '::sal_Bool' (aka 'unsigned char') [loplugin:fakebool] auto const hasMigrated = set->hasByName(migratedName); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/julien/lo/libreoffice/desktop/source/migration/migration.cxx:647:5: error: VarDecl, use "bool" instead of '::sal_Bool' (aka 'unsigned char') [loplugin:fakebool] auto const hasMigrated = set->hasByName(migratedName); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ since 7f04bb393f830a2983e3e26485bbe217c66006ff Clean up color scheme migration Change-Id: I2a06b73cecc4812d2876689f22ba89eba12b308f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140024 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-15Clean up color scheme migrationStephan Bergmann
...avoiding to have code in configmgr that knows about the details of the data stored in the configuration. (See the comments starting at <https://gerrit.libreoffice.org/c/core/+/139690/9#message-44703a2529c07bf1b0202ed3a232aa661784b159> "Migrating product name related color schemes between different versions" for details.) This reverts the dubious changes of 583ea856f2aa227bb04581c5bcdc3a402f5a184f "Migrating product name related color schemes between different versions" in configmgr and offapi. (Also, this moves the computation of sMigratedProductName in MigrationImpl::copyConfig, desktop/source/migration/migration.cxx, to a saner location than in the middle of the "check if the shared registrymodifications.xcu file exists" block where that 583ea856f2aa227bb04581c5bcdc3a402f5a184f had placed it.) Change-Id: I7ab3d57db19065c7c818e697300a2abd9e7f72bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139963 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-14close "OSL_PIPE" pipe on SIGTERMCaolán McNamara
so we don't accumulate ever growing number of stray OSL_PIPE_* in /tmp in crashtesting where timed out instances are killed off with SIGTERM and negate the need for hackery such as https://stackoverflow.com/questions/42515894/open-xchange-java-issues of: ox_kill_readerengine_instances() { ... rm -f /tmp/OSL_PIPE_* } Change-Id: Id5909cba6afc57498adb4ff0677d8a411330e221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-14Fix typoTaichi Haradaguchi
Remove the blank space "Search" and "...". Change-Id: Ide3c6046e7d2c3a22eabb34142dc96d5f407194b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139746 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-09-14move ErrCode to comphelper and improve debug output stringNoel Grandin
need to move it, because modules "below" vcl want to use the debug output method Change-Id: Ibcaf4089a1e0b3fcc0b5189c7ebf1aae90f50b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-14Fix typoAndrea Gelmini
Change-Id: Ibdcc95a3275b4af1b278a5d069c19f47e3e2c8d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139874 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-13Migrating product name related color schemes between different versionsBalazs Varga
Making work to migrate product name related color schemes with different kind of product names. For example from a product named by LibreOffice to a product named by LibreOfficeDev. Change-Id: Iabef982216f126b781df122ed258816af2ae337c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139690 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2022-09-06desktop : use a std::mutex instead of a osl::MutexArnaud VERSINI
Change-Id: I149af335196eaa31cbd11965e1656c3dfe7431ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-05tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macrojsala
Also change some integer by std::size_t Change-Id: Ia51b27bb99b8adda576394f9331345cb11149d6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137274 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-09-05vcl: Rename Gesture event to GesturePanPovilas Kanapickas
We have 5 gesture types: GestureZoom, GestureRotate, Gesture (for panning), Swipe and LongPress. For consistency all of these will use Gesture as a prefix to reduce confusion and for easier grepping throughout the codebase. Change-Id: I8b9e245d011203a19c1172f9833c172f65382ca9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-01Filter out unwanted command URIsStephan Bergmann
Change-Id: I0b7e5329af8cc053d14d5c60ec14fe7f364ef993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139225 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-01Use more idiomatic C++Tor Lillqvist
Change-Id: I0e9460f2500b76bec049c12413fbbee5dcb239c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139149 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-01More handwaving: Assume that it's OK to substitute OpenSymbol for SymbolTor Lillqvist
And that when that happens, there is no reason for a LibreOfficeKit client to optionally warn the user that the Symbol font is missing. (Which it always will be, in that case, on Linux.) Change-Id: I2d60721c826cb3053197a19be8a69b71cbd98e5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139108 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-31Fix typosAndrea Gelmini
Change-Id: I4ed7373afbb4102bbfaf0565c248a5cc84bd3ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139068 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-30Filter out well-known metric-compatible font substitutionsTor Lillqvist
Change-Id: I9da63c173dcc926f577052b704284065b384f960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139038 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-30Add SAL_INFOs for the recorded and pruned font substitutionsTor Lillqvist
Change-Id: Ice7b64c87bff6dbc0eead7bda36f3b0a678986e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139037 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-30Fix typoTor Lillqvist
Change-Id: I857bdb7831bd1e4158f80f09ec232d76d4db794e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139029 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-26Fix typosAndrea Gelmini
Change-Id: I28943475fe35aadab44b8bd2a87f1ea84c49dff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138857 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-25Fix thinkoTor Lillqvist
Change-Id: I0cfd501189275ad5558e6ceeb0fb479b4d2e5835 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138804 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-25Tell LibreOfficeKit clients what fonts in a document are missing on the machineTor Lillqvist
Use the OutputDevice::StartTrackingFontMappingUse() and OutputDevice::FinishTrackingFontMappingUse() functionality that was added last year. Add a new LibreOfficeKit document callback: LOK_CALLBACK_FONTS_MISSING. "Font" here means just the family name. We dont really know what style from the family is missing. Change-Id: Iec4349b5827e7d1dbdde7f8a9f8da92efde429e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138802 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-25lok: make sure flushPendingLOKInvalidateTiles() is calledLuboš Luňák
SwViewShellImp::AddPendingLOKInvalidation() collects invalidations, but this was relying on something eventually calling flushPendingLOKInvalidateTiles(), which wasn't guaranteed. If e.g. a spellchecker caused an invalidation from in idle callback and nothing else changed, then the LOK callback handling code didn't know there was something pending. So add an explicit call to ensure to notify about these pending invalidations. Change-Id: I0a9cb0d5aba2fdbbac126cd8a4a3412bef1cab25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136531 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-08-22Use comphelper::Base64::encode taking OStringBuffer where applicableMike Kaganski
Change-Id: I65c46ad97804827477adba7bbc4eed13cc16b606 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-22lok: Dont render active text edit on slide previewsSzymon Kłos
- extend ITiledRenderable interface to pass active text edit drawing state to the SdXImpressDocument - when painting tiles - allow text edit only for current part - pass new setting also to SdrPaintView where painting happens Change-Id: Ib4ff226961a76129f4f5ff11c90694cd46a83a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137676 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138648 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-18crashreport: __cpuid/__cpuidex are not available on arm64Christian Lohmaier
…and from a quick glance similar features are not exposed to userland applications on arm64: https://docs.kernel.org/arm64/cpu-feature-registers.html "The ARM architecture defines a set of feature registers, which describe the capabilities of the CPU/system. Access to these system registers is restricted from EL0 and there is no reliable way for an application to extract this information to make better decisions at runtime.[…]" Thus the CPU information would have to be gathered from the OS, probably from the Windows registry, at least it should be possible to read the name/model that way… Change-Id: I39e3679a7c4c581d8e3e4f71842d7ea7cdc2ba67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138380 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-08-17Return std::optional instead of using bool* argumentMike Kaganski
Change-Id: I47f03411a6677f22291bea4dc06920ab9052349a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138399 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-16tdf#150427 Gracefully handle potentially unset loggerStephan Bergmann
Change-Id: I237e3b5da042cbfa3fde1a02043ab69cc0711296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138353 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-11some --disable-pdfium fixesCaolán McNamara
Change-Id: I33867397cd5783adb90e9dc2c62b037ced131e26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-11lok: load template documents as regular documentsMert Tumer
otherwise lok cannot save them directly because libreoffice will try to open a save-as dialog For odg, change the draw8_template type draw8 Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I34b0ed03adcac89eaa926f8ae6c57e6f622a90f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132633 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138074 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138098 Tested-by: Jenkins
2022-08-04tdf#150251: clarify macro URL authority in command line helpMike Kaganski
Change-Id: Idaf76365802023204bd2be27d9b4db62cd12f8dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137780 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-02desktop: avoid run graphic tests if ...Henry Castro
DISPLAY=hostname:displaynumber.screennumber has defined a remote display server, otherwise the initialization stuck for long time. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ieb598a023bce3d4298e02fa3ed6ae2bcfc6df015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137366 Tested-by: Jenkins
2022-08-01Fix typo in codeAndrea Gelmini
It passed "make check" on my laptop Change-Id: I2d231c3a8ec40b63026a4b81256b98ee4be0ae1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137660 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-28lok: add dumpState feature for better in-field diagnostics.Michael Meeks
Always suspicious that some un-expected dialog / state can cause strange behavior in a client. An initial cut at an API to make it easier to unwind such problems by exposing the toolkit state. Change-Id: If8f17943fa4837df4f9ca659a111dcdce5c23244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137504 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-28lok: Enable sidebar in MathMike Kaganski
Change-Id: I1554a924eef0bfcaffa893057a37ef45321a0cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137246 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-27sw content controls, plain text: send state changes to LOKMiklos Vajna
This is similar to commit 373f655acbdad88ff5d76324f32650fe3a005e2e (Send state changes of content control UNO commands to LOK, 2022-07-22), but plain text was not a type at that point. Change-Id: Ia317c60411280c07e1e063ee4b23f12e0d9f6dd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137502 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-07-25Send state changes of content control UNO commands to LOKAron Budea
Change-Id: Id6b3f9a35c129078b564f7906e03f6aa9306a5f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137415 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-07-20tdf#127236 vcl: fix missing encryption of PDF images during exportMiklos Vajna
Regression from commit 78e25558e86188314b9b72048b8ddca18697cb86 (tdf#106059 PDF export: create a reference XObject for JPG images with PDF data, 2017-02-23), once a PDF image was inserted to a document, an encrypted PDF export lost those images. The reason for this is that we started to preserve PDF images as vector data with the above commit, but this means we copied over PDF objects from PDF images to the export result as-is, so encryption was not performed for them. Fix this by separating the write of the PDF object headers, stream content and object footer and then calling checkAndEnableStreamEncryption() / disableStreamEncryption() for each object, even if it's not something our PDF export created but comes from a PDF image. Note that when existing PDF files are signed, PDF objects are also copied into a vcl::filter::PDFDocument, but such PDF images are never encrypted, so it's fine to have stub implementations in vcl::filter::PDFDocument. Change-Id: I2f74b9f51cd35b4319221532ca890e197bab9cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137242 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-07-19Replace old png writer in test_desktop_lib.cxxofftkp
Change-Id: I9f73b316521bcacb9042375adef3a3339ab2166f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137115 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-11tools: rename getHeight/Width() to GetOpenHeight/Width()Chris Sherlock
By default Rectangle uses closed interval, if we really want to use half open intervals then we should specifically say as such in the name. Change-Id: Id7a91120ba1a1a4bc330014216b73a692dbf03a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136575 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-06opencl: no need for unhelpful nullptr OUString * case.Michael Meeks
Change-Id: I0b3cad2247706901e1a6b9c3df7fbbc9f23ff987 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136816 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-13Drop obsolete preprocessor directives from UNOIDL filesStephan Bergmann
...which were used by ildc, which is gone since a8485d558fab53291e2530fd9a1be581c1628deb "[API CHANGE] Remove deprecated idlc and regmerge from the SDK", and have always been ignored as legacy by its unoidl-write replacement. This change has been carried out (making use of GNU sed extensions) with > for i in $(git ls-files \*.idl); do sed -i -z -E -e 's/\n\n((#[^\n]*\n)+\n)*(#[^\n]*\n)+\n?/\n\n/g' -e 's/\n(#[^\n]*\n)+/\n/g' "$i"; done && git checkout extensions/source/activex/so_activex.idl odk/examples/OLE/activex/so_activex.idl which apparently happened to do the work. (The final two files are not UNOIDL source files.) Change-Id: Ic9369e05d46e8f7e8a304ab01740b171b92335cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135683 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-13LOK: send state of Protect, UnsetCellsReadOnlyPranam Lashkari
Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I92675ed0033088233fb442138b39a3c8d663c614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135454 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> (cherry picked from commit b8626e85a799fd0807749cab9e712652240f13cd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135389 Tested-by: Jenkins
2022-06-13make VirtualDevice::SetOutputSizePixelScaleOffsetAndBuffer() LOK-onlyLuboš Luňák
Because it's used only for LOK, and SvpSalVirtualDevice::CreateSurface() otherwise wouldn't know whether to apply LOK DPI settings or not (since this might be called for LOK tiled painting, when it should, or it might be called from somewhere else while LOK is active, in which case this should be handled normally). Getting that mismatched can cause things like https://github.com/CollaboraOnline/online/issues/4834 . Change-Id: I1df7b8a169c8ef2e799731a6695a032948536582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135588 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-10loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ica246a12d93f5417ad857b9484575d03c66f761a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-10new loplugin:moveitNoel Grandin
look for local variables that can be std::move'd to parameters off by default, since it doesn't do proper data flow analysis Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-08use recursive mutex for LOK queueLuboš Luňák
Callbacks may be invoked while calling getLOKPayload(), which would try to lock the mutex again. I actually originally expected this possibility, as the comment and moving the data to temporaries in CallbackFlushHandler::enqueueUpdatedTypes() shows, I just didn't realize the used mutex wasn't recursive and so would deadlock. Change-Id: I2b5c4b6b4c1a3933a32ae4641830877e085f2b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135499 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-07Use o3tl::make_unsigned, OString::getLength() is guaranteed to be non-negativeStephan Bergmann
Change-Id: Ibddd4f2b3d8680c94fd0ab45f6ed6204215c6009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135339 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-07 19:23:21 +0000