summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)Author
2014-01-28bool improvementsStephan Bergmann
Change-Id: Ie4c9d7f01fef2604d80d8e465ce30daab7481eed
2014-01-28Introduce com.sun.star.frame.theUICommandDescription singleton.Matúš Kukan
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28Introduce com.sun.star.frame.theAutoRecovery singleton.Matúš Kukan
To replace com.sun.star.frame.AutoRecovery single-instance service, incorrectly converted in 279859fdbc40f68d8f1649fa5b928d9de49e8d9e Unfortunately needs a lot of changes in autorecovery.cxx. Change-Id: Iba5188dffea3e03803236f23e0b3f343746ace90
2014-01-24Introduce com.sun.star.task.theJobExecutor singleton.Matúš Kukan
To replace com.sun.star.task.JobExecutor single-instance service, incorrectly converted in 748aa84e9808ad31c6ff6b71459525c82de10e58 [including changes by Stephan Bergmann <sbergman@redhat.com>] Change-Id: I4cea2c63a20b5b22f6e1f822fb35fcc4d0397687 Reviewed-on: https://gerrit.libreoffice.org/7609 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-23Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23Move defines into settings.hxxChris Sherlock
For some unknown reason, there are a bunch of defines in the middle of Desktop::SystemSettingsChanging() that should really be in include/vcl/settings.hxx. I have now moved DRAG_OPTIONS_ALL into settings.hxx but entirely removed DRAG_OPTIONS_NONE because it is confusing. I also removed it in the one place this combination of options is used in the Desktop class. I have also removed the options DRAG_OPTIONS_OBJECT_* from settings.hxx because they are used nowhere in the code. I have carefully looked through the code and nothing flips bits 0x00000004 or 0x00000008 on the private member of ImplStyleData's mnDragFullOptions in any way. Basically, it is safe to remove. Change-Id: Icf6268f940cfaed271bd43c977473fecfc726949 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-22Improve settings code reabilityChris Sherlock
Application::SetSettings relies on Application::GetSettings to initialize the application's settings if this hasn't happened. This means that GetSettings is being used not to get the app's settings, but to initialize the settings! I have corrected this by introducing a private static function InitSettings(). Note that I assert if it attempts to initialize already initialized settings, because the (Get|Set)Settings does the check for you. Also changed a local variable from nGet to nDragMode in Desktop::SystemSettingsChanging to make it easier to read the code. Whilst this is minor, a variable name of "nGet" seems very sloppy. Change-Id: I04975217c2028b3489179997db4287957578cc93 Reviewed-on: https://gerrit.libreoffice.org/7586 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22bool improvementsStephan Bergmann
Change-Id: Iddc92e42a100a0fb36c77c21d4c176dded8f3391
2014-01-20Remove unused Window parameter from SystemSettingsChangingChris Sherlock
This took a bit of code archaelogy for me to track down. It turns out that as part of an effort to optimize startup, the line of code in this function was commented out, presumably to be rewritten later. This happened in commit ee3351d78c in July 2001 (!). About three years later, in February 2004, the function was rewritten in commit 189c2388d80. As it turns out, the only two functions that used the Window parameter were vcl/source/window/window.cxx (which passed itself in, but of course this did nothing) and vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in the first frame, so it didn't really do anything either. Consequently, the function as it stands *now* only notifies the application that system settings have been changed. It doesn't care which window it tells. Therefore, I have excised this parameter from the function. I don't think it made sense when it was implemented anyway, so there is no net loss. After removing the unneeded parameter, I was also able to remove the Window parameter from winproc.cxx's ImplHandleSalSettings function as it was only ever used to set the top level window, which is now irrelevant. Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1 Reviewed-on: https://gerrit.libreoffice.org/7541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-17fdo#73549 do not attempt to resolve an empty localeEike Rathke
... to match installed UI locales Change-Id: If0ad0fde392bc5ea3cf454f4858330f5e93a6666
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-16Introduce com.sun.star.frame.theGlobalEventBroadcaster singletonStephan Bergmann
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance service. Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-14EndDialog takes long nResult, not boolStephan Bergmann
Change-Id: Ic6283b7a71a5d1c539ae99155f448e34e877080a
2014-01-08Missing XServiceInfoStephan Bergmann
Change-Id: Ifc5454bbcd29730002b0a3261d2c34dee8ffb843
2014-01-08Some ConfigurationProvider -> theDefaultProvider simplificationsStephan Bergmann
Change-Id: I7c25cd94f8a1ca339f7423c26f21f13c7a68906d
2014-01-07remove unnecessary sal_Unicode casts in OUStringBuffer::append callsNoel Grandin
Convert code like: buf.append( static_cast<sal_Unicode>('!') ); to: buf.append( '!' ); Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2013-12-27Some make file fixingZolnai Tamás
Related to d1c74734c8d9026b0f0c03f7382ca60165cec8c6 Change-Id: Ic3a6147f0615e79640ec9f567168f93219d34020
2013-12-27Transex3: NO_LOCALIZE_EXPORTZolnai Tamás
In the past, NO_LOCALIZE_EXPORT macro must be used to skip uneeded parsing of src files which has no localizable content. It is unsued by now and it is more effective to handle this files on gmake level: gb_SrsTarget_add_nonlocalizable_files gb_SrsTarget_add_nonlocalizable_templates Plus remove some empty src file. Change-Id: I8fc9b2db0b5fd7a3379d3c5be970c4fc691f4c53
2013-12-26WaE: unused variable 'ARGUMENT_PREFIX'Tor Lillqvist
Change-Id: I88b8a66ccc4da951e92cce0e4b5d66dcff8bf477
2013-12-26WaE: unused variable 'url'Tor Lillqvist
Change-Id: I6ae6a95bdf9b0f82384dfdcbdefc6a546f81ef0f
2013-12-26WaE: unused variable 'XDG_CONFIG_PART'Tor Lillqvist
Change-Id: I35435dc466478002d065e13f6e31c3c68528d7d5
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-19use proper LanguageTag fallback instead of dumb startsWith(), fdo#68714Eike Rathke
A ca_ES@valencia (=> ca-ES-valencia) locale did not result in 'ca-valencia' UI being selected but 'ca' only instead. Change-Id: Ifa405add2ff7b45e030b02af4338de195b457cb2
2013-12-18resolved fdo#72778 keep setting system locale and LanguageTag in syncEike Rathke
Change-Id: I3547786bf77b8f611bc08d0e52c66ac00e199f13
2013-12-17No need for implbase1.hxx to include XComponentContext.hppStephan Bergmann
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up, of course. Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17Keep using component_getImplementationEnvironment in extensionsStephan Bergmann
...instead of relying on the implicit CPPU_CURRENT_LANGUAGE_BINDING_NAME convention. Keeping that convention an implementation detail makes it easier to do improvements in the future. (Theoretically, the bundled extension in mysqlc could be considered internal code and not adapted, but just be safe.) Change-Id: Iae41a6e072dabc2bf7c1481ba6cfed61680edf37
2013-12-17remove unnecessary double calls to OUString constructorNoel Grandin
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
2013-12-17Remove unnecessary use of OUString constructor in + expressionsNoel Grandin
Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-16Clean-up uno/lbnames.hStephan Bergmann
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-16uiconfig is a l10n-relevant targetBjoern Michaelsen
Change-Id: I8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06
2013-12-16m_bHasActive must be false after last visible entry is removedStephan Bergmann
...otherwise, ExtensionBox_Impl::RecalcAll would crash in CalcActiveHeight(-1). Change-Id: If399825951c79b821ed44ebefa19d1032ab4f850
2013-12-16Re-enable building test-active.oxtStephan Bergmann
Change-Id: I56bd0630f8d238488d9d6598d87acefe1a08fdf0
2013-12-16Missing "boost_headers"Stephan Bergmann
Change-Id: I6ad89134dbecf043fc3e07f035b43cb504a4fafb
2013-12-13Targetted text updates, with seasonable changes before l10n freeze.Michael Meeks
Change-Id: If37ef9f68711da3a0aa9a3ba59b111a8a23421df
2013-12-12Revert "fix windows build"Michael Stahl
This reverts commit 45504f9ba8de2a4372193910b2cb9405f1ea896a. The problem that is apparently fixed here is that link.exe is too dumb to pick the right entry-point if the WinMain definition does not come from an object file but a .lib; in that case it apparently defaults to archaic 8-bit WinMain so tell it to use Unicode one with /ENTRY. Conflicts: desktop/Executable_sbase.mk desktop/Executable_scalc.mk desktop/Executable_sdraw.mk desktop/Executable_simpress.mk desktop/Executable_smath.mk desktop/Executable_sweb.mk desktop/Executable_swriter.mk Change-Id: Ib6239eb0fd3d64fd4a292a0d42d65ef75475c389
2013-12-12use OUString::endsWith where possibleNoel Grandin
Change-Id: Ie2b68f79a7f9a54899f1d727f9a1fc7cfb14d90a
2013-12-12simplify - use OUString::startsWith where possibleNoel Grandin
Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-12Do not use C++-UNO internal static_type functions in client codeStephan Bergmann
...use cppu::UnoType instead. Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-11desktop: document -env cmdline argumentMiklos Vajna
Change-Id: Ic8aa78e4d1bcb02e5d71588ac563c07f371afd41
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
2013-12-06convert accept license dialog to .uiCaolán McNamara
Change-Id: Ib36f42d65ef73446320823775accc94016afb13a
2013-12-06set close as defaultCaolán McNamara
Change-Id: Idb93d99ba68b7f605036071e4c499c0640f42cef
2013-12-06convert show extension licence dialog to .uiCaolán McNamara
Change-Id: I0e34a0ddaee1485184b55788d618288f4e3f69cb
2013-12-05fdo#39956 Delete JABDavid Ostrovsky
JAB has been discontinued in favor of the native IA2 bridge. Change-Id: I88461f73c620507d3e97b077ea2abdd2229322e1 Reviewed-on: https://gerrit.libreoffice.org/6819 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2013-11-30mark non-translatable .ui strings explicitely as suchAndras Timar
so bin/ui-translatable.sh will not find false positives Change-Id: I35e98ba22ba8c0cc9bbf0de40b31be421acc4c15
2013-11-25Resolves: #i123747# allow treating Window's SEH events as C++ exceptionsHerbert Dürr
The crash reporter facility can provide much better details about crashes. But if that facility is disabled then handling SEH events such as div-by-zero as C++ exceptions is a worthwhile alternative. It can provide a few interesting details and it allows a graceful shutdown of the application. (cherry picked from commit c9d10b167b37a9cb0bb310cafc8e80b6cce8ea7a) Conflicts: sal/osl/w32/signal.cxx Change-Id: I25324d6e02ab8acd8fd2b036b77039aac87cf262
2013-11-22remove unnecessary use of OUString constructor in equalsIgnoreAsciiCaseNoel Grandin
Convert code like: sType.equalsIgnoreAsciiCase(OUString("VIEW")); to: sType.equalsIgnoreAsciiCase("VIEW"); Change-Id: I6fb47e6a83b561c7e5a25da76b63606a3174858d
2013-11-21fdo#60698: Unify spl and spl_unxMarcos Paulo de Souza
Change-Id: Ifd328ff3ce12364e95d05405759df6588b3a86bc Reviewed-on: https://gerrit.libreoffice.org/6503 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-07 22:14:46 +0000