Age | Commit message (Collapse) | Author |
|
After 1ae450504cf57457f9702684b1517fda1dd3c481 "drop gtk2 support" removed the
implicit --enable-gtk which removed the implicit --with-system-cairo,
<https://ci.libreoffice.org/job/lo_ubsan/1402/> started to fail with
> [build LNK] Executable/canvasdemo
[...]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libcairo.so.2: undefined reference to `__muloti4'
[...]
> clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
> /home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/LinkTarget.mk:635: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/Executable/canvasdemo' failed
etc. Instead of trying to fix that, just explicitly build --with-system-cairo
again. (Another approach could be to --enable-gtk3, which implicitly sets
--with-system-cairo, too.)
Change-Id: I335b2a694b85a15efae6002d890ce0d67811b2bb
Reviewed-on: https://gerrit.libreoffice.org/79962
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ie838cabfecfef7e3225c1555536d5c9cf3b43f15
Reviewed-on: https://gerrit.libreoffice.org/77405
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id8aae84308f6128351ae2f93c8fbc8941a0c7fc6
Reviewed-on: https://gerrit.libreoffice.org/79085
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Change-Id: Iea7ab7d2aedf33ce7924b2b26f406f69bdffc0eb
Reviewed-on: https://gerrit.libreoffice.org/78848
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
(b4141cade04dac0c9d47293313a4521282975f12)
Change-Id: I3474bdf62d865974bf03682c3201d8dc42993c7a
Reviewed-on: https://gerrit.libreoffice.org/78780
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Just as the gtk3 plugin isn't named GNOME, rename kde5 to kf5, as
it is based on the KDE frameworks 5 libraries.
This also includes:
* a convenience alias to load the kf5 VCL plugin in case someone
requests the kde5 plugin.
* keep convenience kde5 configure switch, but warn about it
* rename detected desktop from kde5 to plasma5
Change-Id: I6764a05b81a5edbf284484c234fee2649aacf735
Reviewed-on: https://gerrit.libreoffice.org/75313
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
No need to reinvent the wheel and hardcode it in configure.ac.
Change-Id: Idb08ea0e5ce228bb0758dbdf023f3aee44da76eb
Reviewed-on: https://gerrit.libreoffice.org/74247
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/74442
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
This list is from online/docker/l10n-docker-nightly.sh
Move it here so that it stays in sync with removed options etc.
Change-Id: I0533c6abe217fc1f904c94c9f8a71d5fb1f9882e
Reviewed-on: https://gerrit.libreoffice.org/73805
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Drop all GStreamer 0.10 support according to
ESC decision of 2019-06-06.
GStreamer 0.10 is obsolete and no longer needed,
superseded by GStreamer 1.0 which is available in
baseline (RHEL 7 or CentOS 7) and all relevant distros.
Change-Id: Ic317eba04d2c17e141acc983f37fbfa4301c9f3f
Reviewed-on: https://gerrit.libreoffice.org/73619
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
This avoids the issue that build breaks when both gtk3
and gstreamer-0.10 are enabled, caused by commit
34bbf192a7753205bb64d14e4eec4ce303317396
("Drop extra define ENABLE_GTKSINK").
gstreamer-0.10 related code will be removed in
a subsequent step according to ESC decision (no longer
needed).
Change-Id: Ief07a797a3e52229da0ff7b23478108aac900841
Reviewed-on: https://gerrit.libreoffice.org/73608
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: Iff70622732792224b3c0a080f95d69f86c167ae6
Reviewed-on: https://gerrit.libreoffice.org/73370
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Enable the gtk3_kde5 and kde5 VCL plugins as discussed
in ESC all of 2019-05-02.
Also drop the "--disable-gtk3" switch so gtk3 is built
as well (which is enabled by default).
Change-Id: I65230255f8db6a7de992c6f5e9f9892a72436349
Reviewed-on: https://gerrit.libreoffice.org/71865
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
|
|
As discussed in ESC call of 2019-02-21, enable kde5
for the Jenkins CI builds to detect build issues *before*
the changes get merged.
Change-Id: I44b0e611348a22b390b6ec89d3ed1d7eb7bddd63
Reviewed-on: https://gerrit.libreoffice.org/68165
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I1d7a261549efa5aad2d86e23d8ee8898c27983e5
|
|
Change-Id: I3a9b2ff1fa24ea4d28b29644d6bf6519fdb1909c
|
|
...for whatever reason. Failure is
> AddressSanitizer:DEADLYSIGNAL
> =================================================================
> ==16438==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x2b6ba8bfe65c bp 0x7ffca100f290 sp 0x7ffca100ba28 T0)
> ==16438==The signal is caused by a READ memory access.
> ==16438==Hint: address points to the zero page.
> #0 0x2b6ba8bfe65b (<unknown module>)
>
> AddressSanitizer can not provide additional info.
> SUMMARY: AddressSanitizer: SEGV (<unknown module>)
> ==16438==ABORTING
> /home/tdf/lode/jenkins/workspace/lo_ubsan/testtools/CustomTarget_uno_test.mk:25: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/CustomTarget/testtools/uno_test.done' failed
(<https://ci.libreoffice.org/job/lo_ubsan/1177/>, but also seen with local ASan+
UBSan builds.)
Started to fail with 98f5f97d4a4206ecfb0754e1901d9c44a3287d82 "make --enable-ld
the default for debug builds, if available". (lld would automatically be
disabled by configure.ac because it doesn't support --dynamic-list-cpp-typeinfo
as needed by UBSan.)
Change-Id: I7bfbfc4c879cbad7748e5855c22698eec5efc94c
|
|
(cf. LO's configure.ac, needed for external/firebird on non-x86[-64]), but
org.freedesktop.Sdk//18.08 apparently doesn't provide it (while
org.freedesktop.Sdk//1.6 apparently did)
(cf. <https://github.com/flathub/org.libreoffice.LibreOffice/pull/67/commits/
b2762523a4678bedd55c11db232868cbaf9c7bdd> "aarch64 and arm need libatomic_ops")
Change-Id: I6eb060251ce85bfd399b72d9c90a93497a3a9029
Reviewed-on: https://gerrit.libreoffice.org/66987
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This reverts commit 81434a0f9afea2185f5e59be09ac73f363baeb92, which is no longer
needed, see 5ae3f1fb1863af109e73f464097bdeda29113d4d "Re-enable --enable-werror
for Jenkins' gerrit_linux_gcc_release job".
|
|
This reverts commit 7990bfd3998508dd3454c408613cf66e53af56eb, which is no longer
needed, see 5ae3f1fb1863af109e73f464097bdeda29113d4d "Re-enable --enable-werror
for Jenkins' gerrit_linux_gcc_release job".
Conflicts:
distro-configs/Jenkins/Linux_rel_master.conf
Change-Id: I90725ecbef0e0cbd908c3d4d9e87ab2336f567c5
|
|
...now that an optimized -Werror build with contemporary GCC should work fine
again after a bunch of recent commits (fed7c3deb3f4ec81f78967c2d7f3c4554398cb9d
"Slience bogus -Werror=maybe-uninitialized" et al)
Change-Id: I912d5dec9eb28b7e2a46cb350dcfed1ede55cb78
Reviewed-on: https://gerrit.libreoffice.org/66666
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
see <https://github.com/flathub/org.libreoffice.LibreOffice/issues/57>
"OpenJDK 11 is available".
Change-Id: Ie24ed7349ca9a4a57c1a8d18d10b29c4a37e259c
Reviewed-on: https://gerrit.libreoffice.org/65830
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
To not increase the size of the main org.libreoffice.LibreOffice app further,
the plan was to realize this as an org.libreoffice.LibreOffice.Help extension.
Ideally, this would be a localized extension, so that, by default, only a
relevant subset of the extension would be downloaded and installed. (But see
below.)
There are multiple technical problems, as discussed at <https://github.com/
flathub/org.libreoffice.LibreOffice/issues/35#issuecomment-447295308> "Add
integrated LibreOffice Help offline":
* LO can't pass a file URL with query part to xdg-open, so uses a temporary
wrapper .html file that redirects to the target URL. But for the flatpak case
this wrapper can't be in /tmp (which isn't visible from outside the flatpak
sandbox), but is instead stored in a new temp dir under $XDG_CACHE_HOME (which
is always set for flatpaks and /is/ visible form the outside) that is
removed on LO exit.
* The file URL stored in the temp file must be rewritten from the internal path
(/app/libreoffice/help/...) to the path as seen outside the flatpak sandbox.
While the path for the org.libreoffice.LibreOffice /app is stored in
/.flatpak-info, the external path for the org.libreoffice.LibreOffice.Help
extension is different and not stored there. So use a hack trying to
construct that path from what information is available in /.flatpak-info.
* But the help content consists of locale-specific and shared files, and those
reference each other with relative links. But a localized flatpak extension
cannot contain shared files, it can only contain per-language sub-dirs. And
if the shared help files were kept out of the extension, as part of the app
itself, the relative paths among these files inside the flatpak sandbox would
differ from those outside of it, so would be broken when viewing the content
in the external browser. A solution would either (a) need to somehow rewrite
the content of all the help files being served from LO to the external
browser, or (b) replicate the shared help files in all the extension's per-
language sub-dirs (and if some localization uses en-US content as a fallback
for only part of its translated content, e.g., in the case of media files,
would need to also replicate that en-US content), or (c) use a non-localized
extension that always contains the content for all localizations.
For now, I chose the third approach. This makes the
org.libreoffice.LibreOffice.Help extension relatively large (the current
/app/libreoffice/help tree has a size of ca. 100MB), so that I decided to not
have it downloaded and installed automatically ("no-autodownload": true in
solenv/flatpak-manifest.in). (I checked with Flatpak 1.0.6 that if the
extension should be changed to a localized one with the same name in the future,
updating from an older version would work. If the old extension was not
installed, just the relevant localizations of the new version will be downloaded
and installed. If the old extension was installed, the full set of
localizations of the new version will be downloaded and installed.)
(As also mentioned at <https://github.com/flathub/org.libreoffice.LibreOffice/
issues/35#issuecomment-447295308>: "A second, minor, nuisance is that, for
security reasons, an `xdg-open file:///...html` call from a flatpak leads to an
intermediate popup dialog letting the user chose which application to use to
open the URI, while e.g. an `xdg-open http:///...html` is allowed to go directly
to the user's preferred browser. So accessing help content from LO flatpak
would present that popup dialog first, forcing the user to select a browser to
proceed.")
Change-Id: I35f5a23947dd551dc1b9bff1dd2abd6710073b5f
Reviewed-on: https://gerrit.libreoffice.org/65451
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I4a4c4ee111d6a22c899ae0d288ae04d760ec996a
Reviewed-on: https://gerrit.libreoffice.org/65272
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
KDE4 is out of maintenance upstream since Nov. 2014, and binaries
provided by TDF have switched to KDE5 as the official backend.
Change-Id: I165465b56d3ba3a18912b203c06ae8fc6111c0c9
Reviewed-on: https://gerrit.libreoffice.org/60014
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I9980f60ebe4cef26348fc26af6b56245260abcca
Reviewed-on: https://gerrit.libreoffice.org/64937
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...similar to d3f2c61e3b9faf577f692ece76cd830f0f74b028 "Make Jenkins
linux_gcc_release_64 pick up Developer Toolset 7":
> /lo/home/tdf/lode/jenkins/workspace/lo_daily_update_gandalf/sal/osl/unx/pipe.cxx: In function ‘oslPipeImpl* osl_psz_createPipe(const sal_Char*, oslPipeOptions, oslSecurity)’:
> /lo/home/tdf/lode/jenkins/workspace/lo_daily_update_gandalf/sal/osl/unx/pipe.cxx:248:12: error: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 107 bytes from a string of length 4096 [-Werror=stringop-truncation]
> strncpy(addr.sun_path, name, sizeof(addr.sun_path) - 1);
> ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(<https://ci.libreoffice.org/job/lo_daily_update_gandalf/558/>).
Change-Id: I443337969dfdcd02a350a171e68d5032b5be22a0
|
|
...now that gandalf (which all of these jobs may run on) has been updated (see
d27d75f86cf8ea4fd87e2cd64b58cc8c0ac0029a "Revert 'Enabling Developer Toolset 7
for Jenkins' lo_tb_random_config_linux'"):
* <https://ci.libreoffice.org/job/lo_daily_update_gandalf/> aka
"lo_daily_update_gandalf", configured with
--distro-config="LibreOfficeLinuxUpdater"
* <https://ci.libreoffice.org/job/lo_tb_ui_testing_linux/> aka
"lo_tb_ui_testing_linux", configued with --distro-config="rel_master"
* <https://ci.libreoffice.org/job/lo_tb_master_linux/> aka "Tinderbox on Master
for Linux", configured with --distro-config="rel_master"
Change-Id: If8afe079cc45e06ea95124e56fa974fd3aca2c78
Reviewed-on: https://gerrit.libreoffice.org/63991
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I4cb2ff5393822c6ec982126b3e0a676374cce033
|
|
...similar to d3f2c61e3b9faf577f692ece76cd830f0f74b028 "Make Jenkins
linux_gcc_release_64 pick up Developer Toolset 7":
> In file included from /opt/rh/devtoolset-7/root/usr/include/c++/7/vector:69:0,
> from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx:39:
> /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/vector.tcc: In function ‘javaPluginError jfw_plugin_startJavaVirtualMachine(const JavaInfo*, const JavaVMOption*, sal_Int32, JavaVM**, JNIEnv**)’:
> /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/vector.tcc:407:15: error: variable ‘__new_finish’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
> pointer __new_finish(__new_start);
> ^~~~~~~~~~~~
> cc1plus: all warnings being treated as errors
(<https://ci.libreoffice.org/job/lo_tb_master_linux/32166/>).
Change-Id: Ifae8705bfafe4caed21713909ff6eeee158f1361
|
|
...aka "Tinderbox on Master for Linux-DbgUtil",
<https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/>. This is similar to
ab8454eb26f72f2d4081d90cb7e60e53e4a5590d "Enabling Developer Toolset 7 for
Jenkins' lo_tb_master_linux_dbg". However, unlike lo_tb_master_linux_dbg, which
is restricted to CentOS-based tb75-lilith, lo_tb_master_linux is restricted to
label TB_Rel, which is currently matched to CentOS-based tb75-lilith,
tb76-maggie, and tb76-pollux, plus non-CentOS based gandalf. The latter thus
doesn't have Developer Toolset 7, so setting CC/CXX this way won't work for
gandalf. I'm thus removing gandalf from
<https://ci.libreoffice.org/label/TB_Rel/>.
Change-Id: Ied305476347d107db4087f710c05300c84ae7e85
Reviewed-on: https://gerrit.libreoffice.org/64444
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This reverts commit 74d6476a045ff2cad36deac51228712d992fb98b. Developer
Toolset 7 has apparently not yet been installed on vm139 (the node exclusively
executing this job), see
<https://ci.libreoffice.org/job/lo_callgrind_linux/6525/console>:
> checking for gcc... /opt/rh/devtoolset-7/root/usr/bin/gcc
> checking whether the C compiler works... no
> configure: error: in `/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux':
> configure: error: C compiler cannot create executables
> See `config.log' for more details
> Error running configure at /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/autogen.sh line 296.
|
|
...aka "Callgrind Linux", <https://ci.libreoffice.org/job/lo_callgrind_linux/>
Change-Id: I518e579ec4ca7b36f700ed412d86feef37c3e203
|
|
This reverts commit 4d72f292cb8adf7529ec1d9ab8fb6728e9717543. Developer
Toolset 7 has apparently not yet been installed on gandalf (the node exclusively
executing this job), see
<https://ci.libreoffice.org/job/lo_tb_random_config_linux/1623/console>:
> checking for gcc... /opt/rh/devtoolset-7/root/usr/bin/gcc
> checking whether the C compiler works... no
> configure: error: in `/lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux':
> configure: error: C compiler cannot create executables
> See `config.log' for more details
> Error running configure at ./autogen.sh line 296.
|
|
...aka "Random Config Linux builder",
<https://ci.libreoffice.org/job/lo_tb_random_config_linux/>
Change-Id: I5a22526b8dcbed8e6fc9cd1fcc7db90774afb0ff
|
|
...aka "Tinderbox on Master for Linux-DbgUtil",
<https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/>
Change-Id: Icf99063e7aaf620cb13dd6ba869f98660f2de82a
Reviewed-on: https://gerrit.libreoffice.org/63982
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Enabling it in the relevant distro-configs/Jenkins/* file is more intuitive than
enabling it in autogen.sh (and avoids issues like
d057e61cb5aae15ea37ce9ac824647cd2060e331 "Restrict Developer Toolset to
Config=linux_gcc_release_64"), and will also be used for other Jenkins jobs like
<https://gerrit.libreoffice.org/#/c/63982/> "Enabling Developer Toolset 7 for
Jenkins' lo_tb_master_linux_dbg".
Change-Id: If633044a90c35a12a73d60335839af0a106aa20f
Reviewed-on: https://gerrit.libreoffice.org/63989
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...as discussed at
<https://lists.freedesktop.org/archives/libreoffice/2018-November/081423.html>
"Re: Compiler baselines".
It doesn't look exactly right to enable the Developer Toolset from autogen.sh.
But the alternative would be to "hide" that in
<https://ci.libreoffice.org/job/gerrit_linux_gcc_release/configure>, which would
probably not be helpful when developers try to track down why a certain Jenkins
build behaves the way it does. So pragmatically stick it in autogen.sh. (Also,
it puts Developer Toolset on the PATH whenever it is found on a system using
LODE_HOME, not just for the specific Config=linux_gcc_release_64 case. Lets see
how that works out in practice.)
However, it turns out that the Developer Toolset 7's GCC 7.3.1 with
--enable-werror (that is implicitly enabled for LODE-driven builds in
configure.ac) and (implicit) --enable-optimized produces many false warnings
(i.e., errors), see below for a sample. (Actually, my experience is that
contemporary GCC hardly ever work with -Werror in optimized builds, due to
analysis being done on already optimized code; it surprised me to find out that
the Jnekins linux_gcc_release_64 builds were apparently successfully done with
--enable-werror with GCC 4.8.5.) So explicitly --disable-werror for these
builds. (Which means that <https://gerrit.libreoffice.org/plugins/gitiles/lode/
+/b82e0a9d26ef4c81046c053ff831dccfc84c56be%5E!> "For linux_gcc_release_64, don't
let ccache strip comments" could probably be reverted again if it has negative
impact on Jenkins' performance.)
Some of the false warnings encountered:
> [CXX] jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
> In file included from /opt/rh/devtoolset-7/root/usr/include/c++/7/vector:69:0,
> from /home/tdf/sberg/core/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx:39:
> /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/vector.tcc: In function ‘javaPluginError jfw_plugin_startJavaVirtualMachine(const JavaInfo*, const JavaVMOption*, sal_Int32, JavaVM**, JNIEnv**)’:
> /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/vector.tcc:407:15: error: variable ‘__new_finish’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
> pointer __new_finish(__new_start);
> ^~~~~~~~~~~~
> cc1plus: all warnings being treated as errors
> [CXX] libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx: In function ‘gboolean gtv_calc_header_bar_draw(GtkWidget*, cairo_t*)’:
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:89:117: error: ‘aRectangle._cairo_rectangle_int::height’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> cairo_move_to(pCairo, rRectangle.x + rRectangle.width / 2 - extents.width / 2, rRectangle.y + rRectangle.height / 2 + extents.height / 2);
> ~~~~~~~~~~~~~~~~~~^~~
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:102:22: note: ‘aRectangle._cairo_rectangle_int::height’ was declared here
> GdkRectangle aRectangle;
> ^~~~~~~~~~
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:89:59: error: ‘aRectangle._cairo_rectangle_int::width’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> cairo_move_to(pCairo, rRectangle.x + rRectangle.width / 2 - extents.width / 2, rRectangle.y + rRectangle.height / 2 + extents.height / 2);
> ~~~~~~~~~~~~~~~~~^~~
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:102:22: note: ‘aRectangle._cairo_rectangle_int::width’ was declared here
> GdkRectangle aRectangle;
> ^~~~~~~~~~
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:89:97: error: ‘aRectangle._cairo_rectangle_int::y’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> cairo_move_to(pCairo, rRectangle.x + rRectangle.width / 2 - extents.width / 2, rRectangle.y + rRectangle.height / 2 + extents.height / 2);
> ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:102:22: note: ‘aRectangle._cairo_rectangle_int::y’ was declared here
> GdkRectangle aRectangle;
> ^~~~~~~~~~
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:89:40: error: ‘aRectangle._cairo_rectangle_int::x’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> cairo_move_to(pCairo, rRectangle.x + rRectangle.width / 2 - extents.width / 2, rRectangle.y + rRectangle.height / 2 + extents.height / 2);
> ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
> /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:102:22: note: ‘aRectangle._cairo_rectangle_int::x’ was declared here
> GdkRectangle aRectangle;
> ^~~~~~~~~~
> cc1plus: all warnings being treated as errors
> [CXX] svl/source/misc/lockfilecommon.cxx
> /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx: In static member function ‘static rtl::OUString svt::LockFileCommon::GetCurrentLocalTime()’:
> /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx:190:10: error: ‘%02d’ directive writing between 2 and 5 bytes into a region of size between 1 and 9 [-Werror=format-overflow=]
> OUString LockFileCommon::GetCurrentLocalTime()
> ^~~~~~~~~~~~~~
> /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx:190:10: note: directive argument in the range [0, 65535]
> /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx:190:10: note: directive argument in the range [0, 65535]
> /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx:204:24: note: ‘sprintf’ output between 17 and 31 bytes into a destination of size 20
> sprintf( pDateTime, "%02d.%02d.%4d %02d:%02d", aDateTime.Day, aDateTime.Month, aDateTime.Year, aDateTime.Hours, aDateTime.Minutes );
> ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1plus: all warnings being treated as errors
Change-Id: I3a851b7591274a8cf8b4729ae036afeb8e82eedc
Reviewed-on: https://gerrit.libreoffice.org/63884
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...to see whether the Coverity issue has solved itself by now (see
0f3b0ec973f06a98c75ef8acfa720a9973e4d2b5 "Avoid C++17 mode for Coverity Scan"
for details)
Change-Id: I1086d6b79217af51a84e347a0d13f323429b37d0
|
|
It doesn't have all the images that dialogs need, for instance the
vcl/res/radio1.png.
Change-Id: If7839fecb2358846b92d46a47cce3b97f7556711
|
|
It belongs in an autogen.input, not in a distro-configs file.
Change-Id: I2e22f94fe9e11986fa40a632e12a272193172bac
|
|
Change-Id: Ia42daaf0dbb8fcd0230c7cee21a0f5d560885c22
|
|
Change-Id: If6149dce7a0467a73720e9ea40e54705518f3316
|
|
Change-Id: Ibbc167ca736012e7585694885370c1505ad48499
Reviewed-on: https://gerrit.libreoffice.org/59939
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* Fix make distro-pack-install.
* Remove Xorg dependency.
* Remove stack protector workaround.
* Update distro-config and enabled features.
Change-Id: I273dc8343ad84bd77b86453cc01ff427b50ea0b5
Reviewed-on: https://gerrit.libreoffice.org/58634
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
...in 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 "Moving mysqlc into connectivity
as a library", apparently without replacement
Change-Id: Ia1d32f98bd90efe2fcd4441dd84cd1862a4daa70
|
|
Change-Id: I60319d22c192b068860b1959350a602edf19aea4
Reviewed-on: https://gerrit.libreoffice.org/58916
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0b6c2d116496da64f91cb5cafb81b69e02366d96
Reviewed-on: https://gerrit.libreoffice.org/58743
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I731e9bcae221d72286f13d5ab8a117e1f1f92052
|
|
...as suggested in comment <https://github.com/flathub/
org.libreoffice.LibreOffice/issues/48#issuecomment-399739393> to "LibreOffice
6.0.5": "Should 'Flatpak version' be just 'Flatpak' to save translation of
'version' in the string for non-English locales?"
Change-Id: I53171a5725f54520ae9e3cbaf294e291d16e1c78
Reviewed-on: https://gerrit.libreoffice.org/56390
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|