summaryrefslogtreecommitdiff
path: root/drawinglayer/source/dumper
AgeCommit message (Collapse)Author
2024-05-08loplugin:ostr in drawinglayerNoel Grandin
Change-Id: I80d424ca042371f4d2e0a1d6be68683c7bad1784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167271 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2022-07-21elide some makeStringAndClear() callsNoel Grandin
Change-Id: Ifd8de0042b843de0766a370fb19b9f7791974612 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-12tdf#145538 - Use range based for loopsdtm
Change-Id: Ib16c742b39af62694ef591dcdaa975b9a720b4a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127203 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-11-23tdf#145538 Use range based for loops in EnhancedShapeDumper.cxxHarjot
Change-Id: I111f6c7ab5ab2033c08683a16adaf388eeabc9ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125577 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2021-10-27Move variable declaration to its use in if() conditionMike Kaganski
Helps understanding the condition more clearly. Change-Id: Ibb2b60283ea650bfac93621feb0333953cac8fcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124188 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-19silence coverity unchecked return value from library on xmlText* functionsCaolán McNamara
Change-Id: I651abb00d8ae1bdbf758a6a0176fd8912531a585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112753 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-13tdf#124176 Use #pragma once in drawinglayerGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I196a60fda0fa88ea2d9ac438d5e9234fde46fb18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102574 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-09Improve loplugin:redundantcast for sal_Int... vs. ::sal_Int...Stephan Bergmann
Change-Id: I1548a76fdc03afee68f1e5c01bc665e616f2edf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86501 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-22tdf#42949 Fix IWYU warnings in drawinglayer/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I0968cfd6a94c20e6b0d324f068ca658d7d5c0296 Reviewed-on: https://gerrit.libreoffice.org/83294 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-20tdf#42949 Fix IWYU warnings in include/drawinglayer/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8daf57df5b8f9c609d4f3ca44bae7366addceb6c Reviewed-on: https://gerrit.libreoffice.org/69151 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-06loplugin:collapseif in dbaccess..lotuswordproNoel Grandin
Change-Id: Ia2a0d25c3833dfde0cd28337361f3cbd2aa29662 Reviewed-on: https://gerrit.libreoffice.org/62934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06clang-tidy performance-unnecessary-value-paramNoel Grandin
Change-Id: I69247498e13331f6ef84afeb242479f8fb1178a8 Reviewed-on: https://gerrit.libreoffice.org/60068 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-18remove use of FillBitmapURL and use FillBitmap as the alternativeTomaž Vajngerl
This is under the ongoing work to get rit of all usage of GraphicObject URLs Change-Id: I900e435ac36a4012ec36a2f0c1d909982c82660a Reviewed-on: https://gerrit.libreoffice.org/49895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-12More loplugin:cstylecast: drawinglayerStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I38baea4d1dd354e48eb90fc2fc385ef60485b5e3
2017-10-23loplugin:includeform: drawinglayerStephan Bergmann
Change-Id: I52693e59a37e36fa0bb21732efe90af84fe6d6c6
2017-05-12remove unused uno::Reference varsNoel Grandin
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-04-11clang-tidy performance-unnecessary-value-param in drawinglayerNoel Grandin
Change-Id: I59d65ba81afab41e781f9dea5339a01d7918c51c
2015-11-17other #includes should be AFTER the include-once #defineNoel Grandin
found with the following script: git ls-files *.hxx | xargs perl -0777 -ne 'if (/include.* .* .* "; close ARGV }' Change-Id: I3afb0e81eb315c34bc0eb6bb4733dd1f0537d5c0
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I3aa15efd12b8c9b20319a1975dbbd541783aea2d
2015-09-12drawinglayer: com::sun::star->cssNoel Grandin
Change-Id: I65706e3e87c1ce287020c90a89f7dc00866bef64 Reviewed-on: https://gerrit.libreoffice.org/18501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-07cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-03Improve loplugin:passstuffbyrefStephan Bergmann
Change-Id: I88ab4c51ff59312127681d3087d22b9c79192b94
2014-11-15drawinglayer: these are expected to be UTF-8Miklos Vajna
Change-Id: Ic2054af851bb9d195be4d550f36b1d7349f90204
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-05-14various loplugin:passsequencebyrefNoel Grandin
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
2014-04-25add way for shape dumper to dump single shapeMarkus Mohrhard
Change-Id: I031921d6869d3bbdef4ed11e4316b6cd977992ca
2014-04-19fixincludeguards.sh: some smaller dirsThomas Arnhold
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-07drawinglayer: sal_Bool->boolNoel Grandin
Change-Id: I893d00a61d314926f84fb3e94743aba2ef5622c4
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-28sd/qa: Remove InteropGrabBag property from XML dumpsJacobo Aragunde Pérez
The InteropGrabBag property adds a lot of noise to this tests and it doesn't actually have any purpose, because we are building their own tests for InteropGrabBag-supported document attributes. We have removed this property by default but we left a flag to enable it when it's convenient for debugging. Change-Id: I97cc7ba171783222a57ab5a96e5755070b949505
2013-12-08fdo#72260: guard against duplicate "name" attributeKorrawit Pruegsanusak
Change-Id: I1ee4b82e04318a50db8bb54bd5c7e00c79177d37 Reviewed-on: https://gerrit.libreoffice.org/6984 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-12-08XShapeDumper: empty name should not be dumpedKorrawit Pruegsanusak
Change-Id: Ic1ab8840c9e543cebf322de922b01739684789ad
2013-12-08add vim modelines for drawinglayer/source/dumper/*Korrawit Pruegsanusak
2013-10-02-Werror,-Wunused-variableStephan Bergmann
Change-Id: Icb19121e39565a3588c0acd14db114a8572b00fa
2013-09-09drawinglayer: added dumping of InteropGrabBag propAndres Gomez
XShapeDumper is now also dumping the InteropGrabBag property as a new empty element. In the future, new "private" properties added to the grab bag could be dumped too. Updated the unit tests accordingly. Change-Id: I7526dbd64bdc08915dc71f1167f05224118f17a6 Reviewed-on: https://gerrit.libreoffice.org/5848 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-05WaE: unused function 'dumpInteropGrabBagAsElement'Tor Lillqvist
Change-Id: I304b8021225c105f068c793ce04a447d4db4f7cf
2013-09-05svx: new InteropGrabBag UNO prop in Shape serviceAndres Gomez
Added the new InteropGrabBag property to the Shape service and modified the JUnit UNO unit tests for it. Added specific implementation in the svx module for the SvxShape class. This new property is intended by now for its usage on preserving OOX's Smart-Art but it could also be used for preserving other attributes for interoperability among document formats. Change-Id: Idc7a8e91592399ff05effd4da6eaa2935f8f4d42 Reviewed-on: https://gerrit.libreoffice.org/5769 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-05-16XShapeDumper: Dump more values, to be able to test n#819614.Jan Holesovsky
Change-Id: I19cbae855996bffb18206b9003e22a2bcc0c75d9
2013-05-15sd unittests: Do not dump the font name, depends on installed fonts.Jan Holesovsky
Change-Id: Id401feed7d629cbc0c24428b0c1273afdb31be89
2013-05-15sd unittests: Update XShapeDumper to dump also (some) font properties.Jan Holesovsky
+ update the expected dumps together with that. This allows testing of the other part (wrong text color and size, commit 55c63ccfd460895af22e91979967cec15d80b72d) of n#758621 too. Change-Id: Ie93feb9d9d05eb4e11106bf9aa1f237947351b4e
2013-04-30Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2012-09-18deprecate oustringostreaminserter.hxxNorbert Thiebaud
the intent of this header has canged over time. now it is already systematically included with ustring.hxx and the operator overload it provide fit nicely there... Just to be safe, since that include as been added to the api during the 3.5 timeframe and therefore is already in 'production' the header remain and simply attempt to include ustring.hxx but a warning is issued indicating that this header should not be used anymore... in a couple of major release we will thenr emove it completely All internal users of that header are converted. Change-Id: I8934c55f089e29d78c0f5649b7c87b2ecf024bad Reviewed-on: https://gerrit.libreoffice.org/634 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-07-19Work around bogus Mac GCC uninitialized warningsStephan Bergmann
Change-Id: I04f64b11b484be8c997e1dbab8de35282fa64289
2012-07-19Work around bogus Mac GCC uninitialized warningsStephan Bergmann
Change-Id: Ia735ee75b75b3e2dafe610cf5cd513dd7d4b7392
generated by cgit (git 2.34.1) at 2025-01-10 22:59:34 +0000