summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2017-08-02remove unnecessary use of 'this->'Noel Grandin
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-01move resmgr to unotoolsCaolán McNamara
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-08-01loplugin:checkunusedparamsNoel Grandin
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31make IntlWrapper arg to GetPresentation non-implicit and non-optionalCaolán McNamara
which requires explicitly adding null in 1) SdrItemBrowserControl::SetAttributes(const SfxItemSet* pSet, const SfxItemSet* p2ndSet) where SdrItemBrowserControl is only used by SdrItemBrowser and the only use of that is within DBG_UTIL in SdrPaintView 2) SwCursorShell::GetContentAtPos( const Point& rPt, within a #ifdef DBG_UTIL block in 3) SvxSearchDialog::BuildAttrText_Impl( OUString& rStr, bool bSrchFlag ) const where the other branch uses SvxResId 4) SfxPoolItem::dumpAsXml(xmlTextWriterPtr pWriter) const 5) XFillStyleItem::dumpAsXml(xmlTextWriterPtr pWriter) const looks very much like all uses (outside the dumpers) are intended to be in the ui locale results in that INetContentTypes::GetPresentation always called with UI Locale Change-Id: I5a110c107838b4db3c355476426d6532f2b6ce52 Reviewed-on: https://gerrit.libreoffice.org/40538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31loplugin:oncevarNoel Grandin
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28loplugin:constparams in editengNoel Grandin
Change-Id: Ice32a16d14d0132a19e8209d311bb799fd7ee0c8 Reviewed-on: https://gerrit.libreoffice.org/40526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28loplugin:checkunusedparams more part2Noel Grandin
Change-Id: Ibb940c2a7098313dfa282734894b1abc1ac40bc2 Reviewed-on: https://gerrit.libreoffice.org/40489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27Ditch use of EditTextObject::Store() in ScGlobal::EETextObjEqual()Eike Rathke
This was the last incarnation of SfxItem binary stream serialization that is to be eliminated after clipboard use is gone. The "full" EditTextObject::operator==() in EditTextObjectImpl::operator==(), and via ContentInfo::operator==() in SfxItemSet::operator==(), also compare the SfxItemPool pointers which gets in the way here (not stored to stream hence didn't matter and maybe the reason for not having switched EETextObjEqual() to use operator==() back in the days). Introduce *::Equals() functions that do not compare pool pointers and let SfxItemSet::Equals() in that case not assume it would be operating on one pool only. Change-Id: Ifff939a92101c7f74695b676a45a7fdbb4f1d7f6 Reviewed-on: https://gerrit.libreoffice.org/40492 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-27replace sal_uLong variables with sal_uInt32 for SvNumberFormatter IDsJochen Nitschke
Replace the stopgap type sal_uLong as SvNumberFormatter format index uses sal_uInt32. SwInsertDBColAutoPilot uses format indices from SvNumberFormatter and from the property "FormatKey" which is stored as sal_Int32 but ctor guards against negative values. Change type of loop variable in SwCaptionDialog to avoid narrowing in GetFormatStr/GetFormatKey. Change-Id: I79980696c07760f7ff026bb1bacf0e069363898c Reviewed-on: https://gerrit.libreoffice.org/40464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26Restore and fix and fix harder the EditTextObject::operator==()Eike Rathke
... chaining down to EditTextObjectImpl::operator==() that compared unique_ptr instead of content with ContentInfo::operator==() that needed to use XEditAttribute::operator==() instead of comparing pointers. That resulted in always false.. Wrong as a chain of commit 5a7a4325eca58c253270d4e9d327042a9ee2c5f0 Date: Tue Nov 10 14:59:05 2015 +0200 editeng: boost::ptr_vector->std::vector<std::unique_ptr> and commit 4ff5a5558472beee85eb1234dcc2aa2ed9000f6c Date: Tue Jan 19 15:17:30 2016 +0200 loplugin:unusedmethods Plus XEditAttribute::operator==() was wrong since commit 71158788efb32ffc3bac5154c38ca5d79525155c Date: Thu May 4 08:11:41 2006 +0000 INTEGRATION: CWS impressc03u3 (1.8.40); FILE MERGED 2006/04/27 12:33:10 cl 1.8.40.1: #i64360# fixed operator== that (to fix a crash comparing items of different types) changed - ( (pItem == rCompare.pItem) || (*pItem == *rCompare.pItem)); + ( (pItem == rCompare.pItem) || + ( pItem->Which() != rCompare.pItem->Which()) || + (*pItem == *rCompare.pItem)); so returning true if Which-IDs differed, instead of + ((pItem == rCompare.pItem) || + ((pItem->Which() == rCompare.pItem->Which()) && + (*pItem == *rCompare.pItem))); Change-Id: I8300c04001e98cb71e520bbe2c180aec0c0a3333 Reviewed-on: https://gerrit.libreoffice.org/40455 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-26loplugin:unusedmethodsNoel Grandin
Change-Id: I7f26ee112ed89ee3e69c56930260565f66ff145b Reviewed-on: https://gerrit.libreoffice.org/40442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26loplugin:unusedfieldsNoel Grandin
Change-Id: I21e538b8e9c7a5f0fb233019efac37a3555e3c93 Reviewed-on: https://gerrit.libreoffice.org/40438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25loplugin:unusedmethodsNoel Grandin
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb Reviewed-on: https://gerrit.libreoffice.org/40391 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-23editeng: remove bogus copy ctorJochen Nitschke
default copy ctor and assignment is deleted because AttribsType (vector<unique_ptr<T>>) can't be copied Change-Id: Ifb95298591c3f0ed5eb04a119efeb065a3eb8705 Reviewed-on: https://gerrit.libreoffice.org/40330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:constparams in editeng,lingucomponentNoel Grandin
Change-Id: I99d9153e3fd1fead34c856ac68a120bb06a003d3 Reviewed-on: https://gerrit.libreoffice.org/40296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in editengNoel Grandin
Change-Id: I61ddd2ce8ded65251fdf1903e6cb67f0d18c9451 Reviewed-on: https://gerrit.libreoffice.org/40293 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21de-hrc various thingsCaolán McNamara
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-21migrate to boost::gettextCaolán McNamara
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-18remove unused CntWallpaperItemCaolán McNamara
Change-Id: I47cf9fc37bb64a80a21ed805bff2bb3ac3eb6da5 Reviewed-on: https://gerrit.libreoffice.org/40148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18Change nonsense non-const Date* GetNullDate() to const Date&Eike Rathke
* first, a non-const Date* may leave the impression that one could change the NullDate through the pointer, which is only partly successful; luckily no one did that * second, there is always a NullDate so checking for nullptr is superfluous * third, the pointer was dereferenced (maybe after a check) everywhere to obtain the NullDate, luckily.. Change-Id: I3c3a788ba0336596ac6bde4c96e77a0cdb7a4a95
2017-07-13use more OUString::operator== in dbaccess..filterNoel Grandin
Change-Id: Ib7b4f2b2403ce766a7db2f6ffc118468e7677776 Reviewed-on: https://gerrit.libreoffice.org/39889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-13loplugin:oncevar: empty strings: editengStephan Bergmann
Change-Id: I3b60b918277b408038a99f2c4801a454e6aa7b4a
2017-07-12EditEngine: Making ODF Format Default for Copy/PasteVarun Dhall
Change-Id: Idfb4dacf4a1595ff974bbca195e419ff6a98418b Reviewed-on: https://gerrit.libreoffice.org/39876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-11EditEngine: Added expwarp for unit testsVarun Dhall
Change-Id: Ice1c8c0ceb7d8fe93f369fb4a05226ba738f7e97 Reviewed-on: https://gerrit.libreoffice.org/39789 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-11EditEngine: Added SvxSimpleUnoModel in import filterVarun Dhall
Change-Id: I65e30853517e1ad7164dd50c290ef3f35c8a61a5 Reviewed-on: https://gerrit.libreoffice.org/39788 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10Remove useless method OCommonAccessibleText::getTextArnaud Versini
Change-Id: I4ee2df05ffceaea9d22ec7e2f78dc6e13061b5ef Reviewed-on: https://gerrit.libreoffice.org/39714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-07loplugin:unnecessaryparen handle parens inside call exprNoel Grandin
stick to single-arg function calls, sometimes parens in multi-arg calls might be there for clarity Change-Id: Ib80190c571ce65b5d219a88056687042de749e74 Reviewed-on: https://gerrit.libreoffice.org/39676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-07EditEngine: Added para break/connect during ODF pasteVarun Dhall
Change-Id: I6ff7fb81425b7788da27ca297d5f08b80b96f795 Reviewed-on: https://gerrit.libreoffice.org/39662 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-07C++11 remove std::binary_function bases from functorsJochen Nitschke
std::binary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::binary_function base class was used by deprecated std::bind2nd, this was solved in individual commits. The members first_argument_type and second_argument_type were used in chart2/source/controller/dialogs/DataBrowserModel.cxx: DataBrowserModel::implColumnLess and are inlined in this commit. Change-Id: I60ded60a8d4afd59e15ac15a58e18d2498c9be5a Reviewed-on: https://gerrit.libreoffice.org/39659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06EditEngine: Added warning for xml export exceptionVarun Dhall
Change-Id: I8709e6656ff753cdd833ee3622a922126161fc2d Reviewed-on: https://gerrit.libreoffice.org/39660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-06EditEngine: Added test for large para copy/pasteVarun Dhall
Change-Id: Ica1e5ae18f71470a3124fd0389213d2fbfc7e521 Reviewed-on: https://gerrit.libreoffice.org/39615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-06make binary functor unary, related tdf#108782dcvb
PropertyValueEqualFunctor was only used as unary functor with std::bind2nd Change-Id: Ic91e49de360e04ec5250f2d63f49163a8e7c7b92 Reviewed-on: https://gerrit.libreoffice.org/39624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06ensure safe GlobalEditData release of xForbiddenCharsTableCaolán McNamara
ensure that when the editeng GlobalEditData dtor is called that the vtable of the xForbiddenCharsTable shared_ptr will point to functions that are callable from editeng. otherwise a shared_ptr created in the sw uwriter cppunit test, but now belonging to GlobalEditData, will have deleter entries pointing to functions in uwriter that have been unloaded and are not available anymore Change-Id: I375a84156c0b1a0f8b24194fc07f0c512f556dbc Reviewed-on: https://gerrit.libreoffice.org/39605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06rework as a shared_ptrCaolán McNamara
mostly to try and track down a crash on exit of sw uwriter under windows Change-Id: Id67e93863056da319dd8225038d60a7f5783b103 Reviewed-on: https://gerrit.libreoffice.org/39604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06teach unnecessaryparen plugin about other kinds of statementsNoel Grandin
i.e. do / while / switch Change-Id: Id0985015cc425557f9984734701d56466f8a6088 Reviewed-on: https://gerrit.libreoffice.org/39601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06loplugin unnecessaryparan improvementsNoel Grandin
Change-Id: I73e945d6ec53537a0da45f6b6291018c7f251a7e Reviewed-on: https://gerrit.libreoffice.org/39587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-05crash on exit of cppunit testsCaolán McNamara
rework EditEngineItemPools own their default items and use a global weak_ptr to share them between instances Change-Id: Ifda3619a175eba3fcad81918c71b16a4d6dd663a Reviewed-on: https://gerrit.libreoffice.org/38885 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-05new loplugin unnecessaryparenNoel Grandin
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec Reviewed-on: https://gerrit.libreoffice.org/39549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfields in editengNoel Grandin
Change-Id: I9806d87028a11a8103c35004c87b5098ca591409 Reviewed-on: https://gerrit.libreoffice.org/39495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03EditEngine: Added test to check multi para start copy/pasteVarun Dhall
Change-Id: Ic253af5ab75783280926f2ed8387f69015014227 Reviewed-on: https://gerrit.libreoffice.org/39488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-02loplugin:casttovoid: editengStephan Bergmann
Change-Id: If389b63fce54a5504d3e25804148038e7c4d4ca9
2017-07-01tdf#108622: use correct type for last check timestamp during autocorrectAron Budea
It's only supposed to check the files once every 2-mins, with mismatching type that happens each time. Change-Id: Ie9243cf928d952e28989dd981508de86cb7dbddb Reviewed-on: https://gerrit.libreoffice.org/39428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-30EditEngine: Changing export selection for copy/pasteVarun Dhall
Change-Id: I6f52f30eff76de5f0d641271ce3ea36ced572cc4 Reviewed-on: https://gerrit.libreoffice.org/39083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-29loplugin:oncevar variousNoel Grandin
Change-Id: I8b82d46d4688b1a59d6fe1b05da7d5c8dfc13ca6 Reviewed-on: https://gerrit.libreoffice.org/38766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-28remove default-able copy ctors and copy operatorsJochen Nitschke
The implicit defined ctors and operators will copy all members (and bases). Since C++11 implicit copy is depreciated if there is a non-default dtor, keep such copies. This commit includes only types that had either copy ctor or copy operator and were found by cppcheck. Change-Id: I93ee687fb3b3c5884f475a2c6054955cdde57ed7 Reviewed-on: https://gerrit.libreoffice.org/39351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-28In ImpEditEngine::ReplaceTextOnly, nLen has always been ignoredStephan Bergmann
...ever since the code's introduction with afb2f41ca982b7e0cbc8a5b4952ea3edfbb2a883 "cws sw33bf08: #i113584#, #i113587# transliteration fixed" Change-Id: I9881ed1585857a95d2d8dd83ebf5d68d989e2c1d
2017-06-28-Werror=ignored-qualifiers (GCC 8)Stephan Bergmann
Change-Id: I2a43ce3ca6af87ac53dd534c0c37150a000e7013
2017-06-26EditEngine: Added test to check MultiPara Copy/Paste with Bold/Italic textVarun Dhall
Change-Id: Ic94338662009a4e0ddbc28e21ac1f5028ddd9126 Reviewed-on: https://gerrit.libreoffice.org/39219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-14 20:03:32 +0000