summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2016-09-01coverity#1372384 Uncaught exceptionCaolán McNamara
Change-Id: I4451623ba950b93e0efba5b3ec755622c2bea2bc
2016-09-01use SfxItemPool::IsWhich instead of custom implementationJochen Nitschke
Change-Id: I56cbdc1ede491486643f73a98117c5cd4ce77c1d Reviewed-on: https://gerrit.libreoffice.org/28564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01use SfxItemPool::IsSlot instead of custom implementationJochen Nitschke
Change-Id: I435fb78f10f361120ee1865465dab93aa4661806 Reviewed-on: https://gerrit.libreoffice.org/28565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (editeng)Stephan Bergmann
Change-Id: If8d2eb5e02a107cc1805e349a70df54160fed02a
2016-08-30loplugin:implicitboolconversionStephan Bergmann
Change-Id: Ia50bd6ecc6a4b5efc2de81282a16203e89087314
2016-08-30Resolves: tdf#96369 don't superscript ordinals for mixed text and numbersCaolán McNamara
e.g. 5th is ok, but foo5th is not this is basically a regression from commit 17e6b8fd05af8fff86847c0ef1e8cc9ad013a1bd Date: Thu Apr 7 13:33:48 2011 +0200 where the older code would only do the conversion if the string before the number was comprised of non-letters, so go back to that logic. Change-Id: I928c365eb11891e78331bbd165dbdb9541ac0361
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26reduce defines to boolJochen Nitschke
nLastAction could be 0, ACTION_INSERTTEXT or ACTION_INSERTPARABRK only later was checked so make this a bool Change-Id: I49287d48ebd12f2fcb4fe71756fe39cf116f588b Reviewed-on: https://gerrit.libreoffice.org/28396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25loplugin:staticaccess: Extend loplugin:staticcall to cover all access...Stephan Bergmann
to static members (data, in addition to function) via class member access syntax. Also covers the (somewhat obscure) access to enumerator members. Change-Id: Iec54b8df2fdb423c0caf21a0dd0f9fe8fdf33897
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-18coverity#1371381 Dereference before null checkCaolán McNamara
this ones in 5-2 also Change-Id: Ia594fdc466d745df141b76ad7d8af3f362287766
2016-08-17convert SvxEscapement to scoped enumNoel Grandin
and fix a potential bug with footnotes and superscripts in writer in ndtxt.cxx, where it was passing bad args to the SvxEscapementItem constructor Change-Id: I0d2de34c056e7824f3b456a86d502e10ac93a1c1
2016-08-17convert SvxTabAdjust to scoped enumNoel Grandin
Change-Id: I29a33b8ea5daaa4b9059d024ffa4a99ca924f7ef
2016-08-17convert SvxLineSpace to scoped enumNoel Grandin
and rename to be more explicit Change-Id: Id06e6b68ef30e1d0d0daf19c37a390060e8bcb01
2016-08-17convert SvxInterLineSpaceRule to scoped enumNoel Grandin
and rename it to be more explicit Change-Id: I3f8bd7928495dba1e94b785cdda06d9819ee66bf
2016-08-17convert SvxSpecialLineSpace to scoped enumNoel Grandin
And move it inside editeng, since it's not really used anywhere else. And fix a bunch of places that were incorrectly calling the constructor with the enum. Change-Id: I74e8ab8bcf315eb5ad0720e74d04a450f0a3e5c9
2016-08-17convert SvxBreak to scoped enumNoel Grandin
Change-Id: If8b79ed617e5662550bd73bd1506d047217f2313
2016-08-17convert SvxCellJustifyMethod to scoped enumNoel Grandin
Change-Id: Ifdb9192f6556477a28af05a74042f216d4e9e8fd
2016-08-16editeng: introduce OutlinerViewShell::NotifyOtherViews()Miklos Vajna
This allows notifying other views about e.g. cursor position changes even if SfxLokHelper::notifyOtherViews() is not accessible from editeng. Change-Id: I921e97344ffe562109a221f241e70b3f68ee9aaf Reviewed-on: https://gerrit.libreoffice.org/28162 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-16loplugin:stringstaticStephan Bergmann
Change-Id: I89cbdf1b831818e7d72b5f9b6334df35a35d4f9f
2016-08-15convert SvxSpellArea to scoped enumNoel Grandin
Change-Id: I91d3caabb667e7d4ff23e603026e072074058712
2016-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6 Reviewed-on: https://gerrit.libreoffice.org/27981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05use std::move in a few placesNoel Grandin
found by git grep -n '.reset.*.release' Change-Id: I498709bd32b21d9dbbaa73603ce21d21c274f8dc Reviewed-on: https://gerrit.libreoffice.org/27863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-02editeng: track view shells in SfxListUndoActionsMiklos Vajna
This is needed for e.g. tracking deletions by backspace in Writer shape text. Change-Id: I6f873872566313096c2c57f4a13ac2f1db67e77d Reviewed-on: https://gerrit.libreoffice.org/27807 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-02editeng: implement SfxUndoAction::GetViewShellId() interface in EditUndoMiklos Vajna
With this, e.g. inserting a character in a Writer shape text remembers its view shell. Change-Id: Ic82a3f45a66cf622496e3131390d365440dffb3b Reviewed-on: https://gerrit.libreoffice.org/27796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-02editeng: make SfxUndoAction::GetViewShellId() interface availableMiklos Vajna
Extend the existing OutlinerViewCallable interface to be able to obtain the view shell ID of a view shell, even from editeng. Change-Id: I13708b0e4f58ee86643b913c7d21de022a685223 Reviewed-on: https://gerrit.libreoffice.org/27788 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-01svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna
Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-27Resolves: tdf#101003 don't give paras in editeng accessible namesCaolán McNamara
change since... commit c23ab5eaed57cc3fb5860e26c591c73c5b22687b Author: Steve Yin <steve_y@apache.org> Date: Tue Nov 26 14:25:22 2013 +0000 Integrate branch of IAccessible2 keep the accessible description, but drop thea accessible name which is reportedly an undesirable change. Change-Id: I8f9c53ef967c4e566fde1829832aa035efce4f23
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-20sd lok: decouple vcl window focus from cursor visibilityMiklos Vajna
The problem was the the blinking cursor was hidden when another vcl window got its focus, so it wasn't possible to edit two shape text in parallel in two windows. The code path is like this: - show cursor, cursor is created: SdrObjEditView::SdrBeginTextEdit() -> OutlinerView::ShowCursor() - show cursor, focus case: sd::FuText::Activate() -> OutlinerView::ShowCursor() - hide cursor, cursor is deleted: SdrObjEditView::SdrEndTextEdit() -> OutlinerView::HideCursor() - hide cursor, focus case: sd::FuText::Deactivate() -> OutlinerView::HideCursor() So add a new optional bool parameter that allows not emitting the LOK_CALLBACK_CURSOR_VISIBLE callback in the focus change case. Also, if we're at it, make sure that painting emits no show/cursor LOK callbacks. Change-Id: I1068a1b1f5cd76fd09b5a79066834bfb0daebc77 Reviewed-on: https://gerrit.libreoffice.org/27335 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-19Resolves: tdf#97404 outline space wrong on second levelCaolán McNamara
Revert "tdf#42788: FORMATTING - Numbering/ordered list" This reverts commit 6517141b6233c5f9667031bc92f66109fddf5b76. https://gerrit.libreoffice.org/#/c/23006/ was apparently intended to revert this, but it never was Then there was https://gerrit.libreoffice.org/#/c/23427/ which was an attempt to improve it but it was abandoned Then there was https://gerrit.libreoffice.org/#/c/23542/ whichw as another attempt to improve it, but it was too abandoned. all of which leaves us worse than when we started with a pile of unhappy abandoned efforts and cruddy indent Change-Id: I8b3666a957339030d5a946a2b387f452e7fb0099
2016-07-15Improve loplugin:unnecessaryoverrideStephan Bergmann
<sberg> thorsten, remember what that "TODO" in SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly, in a909acb7009acadffa53e74ea05ddb88803490f1 ? <thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review me' <sberg> thorsten, OK, thanks (that override will eventually go away with loplugin:unnecessaryoverride, and the TODO comment be lost) Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac Reviewed-on: https://gerrit.libreoffice.org/27232 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-13tdf#100880 editeng spellchecking doesn't work sometimes...Caolán McNamara
believe to be a regression from commit 73f0b3bd5553c5d023d0a1dbfdc00836e2937961 Author: Matteo Casalin <matteo.casalin@yahoo.com> Date: Sat Dec 28 13:37:26 2013 +0100 xub_StrLen to sal_Int32 + some const and lets fix it the same way commit 9705fbc1119da91e73c00a2ec848565929eeb483 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Sun Mar 2 12:19:16 2014 -0600 Fix editeng missing spellchecking redline on load (probably) fixed some other regression caused by that Change-Id: I52775aff50dcc634fd2f08eb685cc4ad9850c82c
2016-07-13Revert "bccu#1781: Impress/Comments - selection not updated on delete"Caolán McNamara
because selection is visually mangled in the editeng. type a word in calc, hit return, double click on the word, then end, hold down the shift key and move to the left, every second letter gets highlighted. The original bug is private so I don't know what problem it wanted to fix to see if there is a better solution. This reverts commit c8a09eb373b78d9936fb00ac98b6876eb8740c4d. Change-Id: Ib1b535aca98daaae210db4e3d62900fbc389e816
2016-07-11Fix typosAndrea Gelmini
Change-Id: I81671c9a8e7e5b878e605ac0ed6c3d8ef5c5b689 Reviewed-on: https://gerrit.libreoffice.org/27088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-07-10Remove redundant SvxGet* wrappers around LinguMgr functionsStephan Bergmann
Change-Id: Ic431ce4880d0c1277ddb411ca59b3c8e8ca36518
2016-07-10ditch the application per-language IsAutoMnemonicEnabled settingCaolán McNamara
Change-Id: I9734ada09edb6544a332893a7c5d31730b0d081d
2016-07-08Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke
... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08SvxGetOrCreatePosDic parameter is unusedStephan Bergmann
...ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", so kill the equally old "TODO: remove argument or provide SvxGetIgnoreAllList with the same one" comment for good now Change-Id: Ie7b64306b8d06fc72d0bb49cc1e5fa3b00f59d6b
2016-07-08loplugin:redundantcast: redundant static_casts in editengStephan Bergmann
Change-Id: Ifc6d62fce28d540d07d95ec06c3a2b95030f1f0c
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I5bb3c63790cb153c0d6f57a681ec6dda71d482be
2016-07-04tdf#100734: Update bullet of paragraph on UNDOMike Kaganski
Change-Id: I1afe0b4ca537eea752d3bced8bbc8944380c3514 Reviewed-on: https://gerrit.libreoffice.org/26874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-07-01don't autocapitalize words that follow a field markCaolán McNamara
Change-Id: Ia8efa88aaf47edba9a590c858d0ea30d7bfe2977
2016-06-29move #includes to top of fileNoel Grandin
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-28Simplify some PutProperties callsStephan Bergmann
Change-Id: Idf91592e6cf34b5591f221c3c5bdc937bbe46014
generated by cgit (git 2.34.1) at 2025-02-01 05:34:34 +0000