summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2016-10-13pass params to Outliner LINK callbacks on stackNoel Grandin
instead of yuck..cough... on itself, which is horribly vulnerable to re- entrancy Change-Id: I8f3d6d39ee50fd36b56b431978cf6c2499c375a6 Reviewed-on: https://gerrit.libreoffice.org/29756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:constantfunctionNoel Grandin
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10reduce indentationNoel Grandin
Change-Id: I9645e083ea61347fa323f84a271937e98d4f8eb3
2016-10-05fix debug buildDavid Tardon
Change-Id: Idbdb3f00faed2a0ae3f58393abf6e345e7d2363c
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03add more dumpAsXml()Noel Grandin
and make it format the output nicely, so I don't have to use 'xmllint --format' before I can read it. Change-Id: I065ee93193f3c6c7bab87212ab96021fb0d7c5ed Reviewed-on: https://gerrit.libreoffice.org/29407 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I8374d6d08f4eb4ae2821e213371c615b92d7e9ab Reviewed-on: https://gerrit.libreoffice.org/29432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-30tdf#101815 editeng SetMustRepaint when InsertTextJustin Luth
Change-Id: Ib66e7d53c231ac40f59593fd45a0706418a9398c Reviewed-on: https://gerrit.libreoffice.org/28717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-09-28variable name and indentation improvementNoel Grandin
Change-Id: Ia3a97b08e1280e3665a56cdbb25ad07687dc7040
2016-09-28extend dumpAsXml to EditDocNoel Grandin
Change-Id: I71464b20c5897a2af3b4069f7f0963ef55dcd8c4
2016-09-25remove unused parameterJochen Nitschke
bTotalRanges is never used. SFX_ITEMSET_NO_DEFAULT_CTOR is no where else used. Change-Id: Ia35ea875f16a8ca04c2173b01074113f1825f565 Reviewed-on: https://gerrit.libreoffice.org/29248 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-24we shouldn't need explicit lt_rtl_OUString, etc things anymoreCaolán McNamara
Change-Id: Ibeec3fcc353e07e61fb2c838b318e0a04081ce2c
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23editeng: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Icccd2db45616de708d83058d76ace312db8af94e
2016-09-22convert C_ constants to typed_flagsNoel Grandin
Change-Id: Ia80cef26edce3e0a664044f3ca65d33998546d0f
2016-09-21Resolves: tdf#83037 <--> corrected into ← → instead of ↔Caolán McNamara
don't use - as a word separator except for breaking up a compound word for the purposes of tdf#55693, e.g. TEst-TEst autocorrected to Test-Test) Change-Id: Ie52a16af0b5838d1ba0de9c5f9c30dcab05c3bc7
2016-09-21convert SfxItemPresentation to scoped enumNoel Grandin
Change-Id: Ibf605706a9f804ab509ac4f92f5f88fcf3daebc1 Reviewed-on: https://gerrit.libreoffice.org/29131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-21loplugin:implicitboolconversionNoel Grandin
Change-Id: Id7dafb926a0eb7fae5e481555eae3d35fe795900
2016-09-21spelling Surregate->SurrogateNoel Grandin
Change-Id: Ic7d79036f4e94a487c9b12edb18d6e4098938585
2016-09-21add dumpAsXml() to more pool itemsNoel Grandin
Change-Id: I276109148bab8180ce2442f5ee69722357362453
2016-09-20Related cid#1371287: Improve code to not depend on missing move assignmentStephan Bergmann
Change-Id: I4c03ad08078e25ea7f7d754e6eaa587da7984c9d
2016-09-15Missing initialization of SvxBorderLine::m_pColorGapFnStephan Bergmann
...since 6dd4905a7ac93a48dc87358da3ba0a8078bbb6cf "loplugin:constantparam in dbaccess..editeng" Change-Id: Ib27615069ac1c7061ad691aada227ebdd70326e5
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-14Revert 8c4dbcef8f and provide a better fixAndras Timar
This reverts commit 8c4dbcef8f92c9bd1c2208e7de7971f184f8a3ff. bccu#1781 bug was in LibreOffice Online. After deletion of the selected editeng text, the selection did not disappear. By making the fix conditional to LibreOfficeKit::isActive(), we can avoid the weird selection problem in desktop editeng. Change-Id: I78c68b5a79db816ea4d0bdf3d75dd1ba4c269106 Reviewed-on: https://gerrit.libreoffice.org/28900 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-13sw draw text: emit LOK_CALLBACK_TEXT_VIEW_SELECTION from registerCallback()Miklos Vajna
With this, in case the first view has an active text edit selection and a new view is created, then the text selection is instantly visible in the second view, even if the first view's text selection does not change later. Change-Id: I3255febd5d65d6576ddbc57cf96836bdf0b06a72
2016-09-13sw draw text: emit LOK_CALLBACK_INVALIDATE_VIEW_CURSOR from registerCallback()Miklos Vajna
With this, in case the first view has an active text edit and a new view is created, then the cursor position is instantly visible in the second view, even if the first view's cursor does not move later. Change-Id: Ia82e7dc1ce9bb58c67a280179ecadc74d3b63026
2016-09-13rename ContentInfo attribs field and methods to charAttribsNoel Grandin
to match naming higher up the call stack Change-Id: I8a89625de5d834b32fd6ea863ebc4152956a21fe
2016-09-13impress: extend dumpAsXml to style information in ContentInfo nodesNoel Grandin
Change-Id: I783f6ad9b71f18c070537e4806381a103960b6eb
2016-09-13fix out of bounds errorJochen Nitschke
there are 22 entries, but Sequence was allocated with 21 fields Change-Id: I6af71e2ece99b643843b4d82e0c6be332be361fa Reviewed-on: https://gerrit.libreoffice.org/28852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13loplugin:constantparam in dbaccess..editengNoel Grandin
Change-Id: I1d0dc3d89933d86cd229e503b350fccc1523dedc Reviewed-on: https://gerrit.libreoffice.org/28833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09use std::unique_ptrDavid Tardon
Change-Id: I8ba37267e8a7058ade54783ea0e117a8f8816c45
2016-09-09loplugin:constantparam in sot..svlNoel Grandin
Change-Id: I08db2db3b90725c556e3ba062da5d62d98f6e882 Reviewed-on: https://gerrit.libreoffice.org/28769 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-08rename CollapsAttribs -> CollapseAttribsNoel Grandin
Change-Id: Ic70f67fb7e0e557a3a726f44aef25931def49835
2016-09-08improve comment grammarNoel Grandin
Change-Id: Ic7da4b4d67bb006290af6c7b9e5d084d13b6ca98
2016-09-05convert Orientation to scoped enumNoel Grandin
Change-Id: Ifbfcf3557ca2a16d21e7a1d613ee54c1c6625f07
2016-09-05convert RasterOp to scoped enumNoel Grandin
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-02editeng: don't let wild-card auto-correct leave current wordMichael Stahl
If a paragraph has e.g. multiple -> in it then auto-correct of the first one will create via the .*->.* rule a new auto-correct entry that has as long-word the word that contains the first -> until the last -> and everything in between. This will be somewhat irritating when it is eventually applied. Avoid it by limiting the wild-card loop to the current word, which is apparently the intent anyway. (regression from a07425892205ff8951027ea20459b97370d01de6) Change-Id: I294bae863c44eb460627b61b4383133131fe4b3a Reviewed-on: https://gerrit.libreoffice.org/28608 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-01coverity#1372384 Uncaught exceptionCaolán McNamara
Change-Id: I4451623ba950b93e0efba5b3ec755622c2bea2bc
2016-09-01use SfxItemPool::IsWhich instead of custom implementationJochen Nitschke
Change-Id: I56cbdc1ede491486643f73a98117c5cd4ce77c1d Reviewed-on: https://gerrit.libreoffice.org/28564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01use SfxItemPool::IsSlot instead of custom implementationJochen Nitschke
Change-Id: I435fb78f10f361120ee1865465dab93aa4661806 Reviewed-on: https://gerrit.libreoffice.org/28565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (editeng)Stephan Bergmann
Change-Id: If8d2eb5e02a107cc1805e349a70df54160fed02a
2016-08-30loplugin:implicitboolconversionStephan Bergmann
Change-Id: Ia50bd6ecc6a4b5efc2de81282a16203e89087314
2016-08-30Resolves: tdf#96369 don't superscript ordinals for mixed text and numbersCaolán McNamara
e.g. 5th is ok, but foo5th is not this is basically a regression from commit 17e6b8fd05af8fff86847c0ef1e8cc9ad013a1bd Date: Thu Apr 7 13:33:48 2011 +0200 where the older code would only do the conversion if the string before the number was comprised of non-letters, so go back to that logic. Change-Id: I928c365eb11891e78331bbd165dbdb9541ac0361
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26reduce defines to boolJochen Nitschke
nLastAction could be 0, ACTION_INSERTTEXT or ACTION_INSERTPARABRK only later was checked so make this a bool Change-Id: I49287d48ebd12f2fcb4fe71756fe39cf116f588b Reviewed-on: https://gerrit.libreoffice.org/28396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25loplugin:staticaccess: Extend loplugin:staticcall to cover all access...Stephan Bergmann
to static members (data, in addition to function) via class member access syntax. Also covers the (somewhat obscure) access to enumerator members. Change-Id: Iec54b8df2fdb423c0caf21a0dd0f9fe8fdf33897
generated by cgit (git 2.34.1) at 2025-02-22 08:05:05 +0000