summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16low hanging xub_StrLen->sal_Int32 in editengCaolán McNamara
Change-Id: I8d9a504a1e7d320b487ee499b5bc0c04b52632e7
2014-01-15Related: #i17171# big xub_Strlen -> sal_Int32 changesCaolán McNamara
Change-Id: I31bce794c95062abfa1171c13cf565498688b5f3
2014-01-14bool improvementsStephan Bergmann
Change-Id: Ic6488ac278cac2d1d7e240abff545f9ea0b8eafe
2014-01-14This shall likely comp. m_eCurrentConversionDirection to HHC::eHangulToHanjaStephan Bergmann
Change-Id: Ib4eba9f6386214d010c880ad15bcacce7665a3af
2014-01-14comment is wrong now with conversion to OUStringCaolán McNamara
Change-Id: Iff26cd2c966fc747895fbde7229a457a99c62f7a
2014-01-14xub_StrLen->sal_Int32Caolán McNamara
Change-Id: I9c4d9b8d18b36dda6609b1976cae13a481943563
2014-01-14longparas: nPartLen always is USHRT_MAX/STRING_LEN to take full stringCaolán McNamara
Change-Id: I55bb0baa8e83948c470ade2fc6fabccb69dea91d
2014-01-13longparas: convert ValidateKashidas to sal_Int32Caolán McNamara
we can use -1 as the failure return code as return value is always checked and isolated from the rest of the code. Change-Id: I87a743de82d681a7e4eabc61a576c4e50f1279a8
2014-01-10SfxPoolItem::operator ==, != should return boolStephan Bergmann
...and SfxEnumItemInterface::HasBoolValue, too. Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-09Consolidate XServiceInfo for classes derived from SvXMLImportStephan Bergmann
Change-Id: I5a269d8b7e95049c67ae14b06a79b417bc91a474
2014-01-08Consolidate XServiceInfo for classes derived from SvXMLExportStephan Bergmann
Change-Id: Ia3e2b5e682a64844bb6c713912c50c7681393d52
2013-12-28Remove unread variableMatteo Casalin
Change-Id: I6271e8f977d5c112223d14744830c8101099613d
2013-12-28Use OUString constructor for constant ASCIIMatteo Casalin
Change-Id: Ifc80743c748c2542055cfe825ad322b83958d976
2013-12-28Use member initialization list in some constructorsMatteo Casalin
Change-Id: Ie0c9720966ca42373bec7a1697b72c5a17f49644
2013-12-28Do not use Getters as SettersMatteo Casalin
Change-Id: Ie465e768f07f6e0ebf10042ca389b4941ba84a2a
2013-12-28xub_StrLen to sal_Int32 + some constMatteo Casalin
Change-Id: Ieae0940d3d072c3214b4fa2280dd0e01dc328cb7
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-12fix OUString simplifyNoel Grandin
In my commit fb847101519ad74c02183672c04ebf1d700aae83 "simplify - use OUString::startsWith where possible" I incorrectly converted if ( !aURL.isEmpty() && ( aURL[ 0 ] != '#' ) ) to if ( aURL.startsWith("#") ) Change-Id: I7fa3a814e13724dc65821e09c03db898b92626ec
2013-12-12simplify - use OUString::startsWith where possibleNoel Grandin
Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-12Don't hold css::uno::Type instances by pointerStephan Bergmann
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-11Revert "Don't hold css::uno::Type instances by pointer"Stephan Bergmann
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now: Ach, old GCC doesn't like plain string literals to initialize members of OUString type... Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11Don't hold css::uno::Type instances by pointerStephan Bergmann
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-10fdo#70278: editeng: fix Time fields in ImpressMichael Stahl
Apparenty an uninitialized SvxTimeField is created instead of the SvxExtTimeField that is needed to preserve the value and format. (regression from ee5fc5d25fe102c30daf7d181b8181d40b85a4f3) Change-Id: I36b16af0c143e8b5451a1925806756492dc2334e
2013-12-10editeng: fix more 32-bit Time breakageMichael Stahl
SfxDateTimeItem and SvxExtTimeField need to use 64-bit integer to store Time as well. These classes also have binary serialization Load()/Save() methods but they are unlikely to be used in a persistent way, just for the clipboard. The problem is easy to reproduce in Impress: Insert->Field->Time(fixed) (regression from 9830fd36dbdb72c79703b0c61efc027fba793c5a) Change-Id: I5946c5b94dd5a509805b6dc40461bbd910caffc4
2013-12-10Resolves: #i123620# IAccessibleHypertext::hyperlinkIndex returns 0...Steve Yin
when editing a cell/object where there is no link (cherry picked from commit 552e71c2482b5911ac485c9331a4f354ba7150b5) Change-Id: I9be20b045d3472f15c98352928d45a1349cec5c4
2013-12-10Drop duplicate #includeTakeshi Abe
Change-Id: Ib8969d5cd4898b81a5dcd90dc313abd28adfe052
2013-11-27IAccessible2: revert some bounds-checking changes againStephan Bergmann
...that were introduced with c23ab5eaed57cc3fb5860e26c591c73c5b22687b "Integrate branch of IAccessible2" but broke JunitTest_sc_unoapi, which expects calls to getCharacterAttributes and getIndexAtPoint to actually fail for out-of-bounds arguments. The above commit does not make it obvious why those changes were actually made. Change-Id: I3492c3e6a49d68885df1206e9368f4483c0dc4f9
2013-11-26WaE: unreachable codeTor Lillqvist
Change-Id: Iee5fa84eb2335efa7d7f7cb28b8efdecf9366592
2013-11-26rewrite new SvxEditSourceHelper::GetAttributeRun replacement in new styleCaolán McNamara
Change-Id: I906e99afb58dcee3e47a545f575aab71b7edc0e9
2013-11-26Integrate branch of IAccessible2Steve Yin
WaE: Reorder initializations to prevent compiler warnings. (cherry picked from commit c05431aa92fa2c7c7258418a6ecd651b5c26d982) WaE: unname unused variable to prevent compiler warnings. (cherry picked from commit 2259256a390c4b6f83cfb5dbe4a65df5032aee47) Conflicts: editeng/source/accessibility/AccessibleEditableTextPara.cxx ad61537527a74670af266feb9e4d26d2d654daf7 66044902b8d94fc15d4c30270e6cc419fb7d3565 Change-Id: I3ec9798f2c7d854824722c0cf44b62128b4f4cb4
2013-11-22replace OUString::reverseCompareTo("xxx") with operator==Noel Grandin
operator== with OUString and literal internally does a reverse-compare (via OUString::equalsAsciiL) anyway, so no need to keep explicit calls to OUString::reverseCompareTo with literal argument Change-Id: I799d9bcd0d5c308a9547ce7cacb2db6042fdb643
2013-11-22remove unnecessary RTL_CONSTASCII_STRINGPARAMNoel Grandin
A final pass through the code, converting code to use the new OUString and OString methods that can detect string literals. Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-20editeng: warning C4805 unsafe mix of type sal_Bool and type boolMichael Stahl
Change-Id: I88fc77ea6c0b6a7c02d0b7eff64d8fdd3db6020e
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OStringBuffer constructorNoel Grandin
Convert code like: OStringBuffer aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OStringBuffer aKeyName("NDX"); which compiles down to the same code Change-Id: If9c96a290bc18cc8285fb733f27be58c6958b63c
2013-11-20fdo#67742 Avoid autocorr of "--" before "-"Laurent Balland-Poirier
LibO 4.1 now uses '-' as word separator for AutoCorrection Then the sequence "---" is detected as word "--" and autocorrect as "–". This avoids autocorrection of "---", as word or as border This commit detects the sequence "---" and report autocorrection. Change-Id: I1342c2ff83dd42683e683b3bb27280d61179b9a2 Reviewed-on: https://gerrit.libreoffice.org/6727 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20sal_Bool to bool in ImpEditEngineRodolfo Ribeiro Gomes
Change-Id: I76dc0343fd735104827b4803c5440570afe86174 Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/6693 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-17bugs.freedesktop.org -> bugs.libreoffice.orgAndras Timar
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
2013-11-14SvxBrushItem: Improve Referer from member to GetGraphic[Object] parameterStephan Bergmann
Change-Id: I034132c315b74d0ea5e03b7d5f7cc225a6c8164e
2013-11-14make l10n buildable separatelyBjoern Michaelsen
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14Fixed for spacing between lines in paragraph.Priyanka Gaikwad
Problem Description: In "w:spacing" value of "w:line" attribute value is not getting preserved. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/6645 Change-Id: Id9da4f9234d14cf4599c6520b4a191ad9af92c25
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14xub_StrLen to sal_Int32 and minor optimizationsMatteo Casalin
Change-Id: Ie8703ee0ff6c428ed00ffb88749540588e608b43
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-11convert STRING_NOTFOUND -> -1 in editengNoel Grandin
And convert some xub_StrLen to sal_Int32 in the same patch of code. Change-Id: I72c92bf9413dbca14688cb8d46a023df49a5d41a
generated by cgit (git 2.34.1) at 2024-07-11 10:02:16 +0000