summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2017-02-21loplugin:subtlezeroinit: editengStephan Bergmann
Change-Id: I2fb3700f00ad76096d048747c8333337d5ffce8f
2017-02-20this can't be nullptrJochen Nitschke
Change-Id: I33a18fe4c03a921e834ac6ea4234ddaf42a390e2 Reviewed-on: https://gerrit.libreoffice.org/34435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-18revert tdf#101815 editeng SetMustRepaint when InsertTextJustin Luth
It wasn't targetted enough at the specific problem, and caused paint problems. This fixes tdf#106056. Change-Id: I2d87bc78627a558c62cb0efc24e49c7656662976 Reviewed-on: https://gerrit.libreoffice.org/34403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-02-17Drop :: prefix from std in [de]*/Tor Lillqvist
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-02-17convert editeng spell menu to .ui formatCaolán McNamara
Change-Id: Iaae8e6d6ee3c9cafad343fefb4f357b080df3a08
2017-02-16convert EESpellState to scoped enumNoel Grandin
and drop unused EE_SPELL_NOLANGUAGE enumerator Change-Id: I74a5f89335883a13d77b39f78b7de55bddb1f107
2017-02-16convert EditEngineAttribs to scoped enumNoel Grandin
and drop unused EditEngineAttribs_HardAndPara enumerator Change-Id: Ic1fcddc6adeb5317f96bcef9b6f715b26d901a8d
2017-02-16remove unused NONE from ScrollRangeCheck enumNoel Grandin
Change-Id: I9d83cc38a9fa477a61ec7e2ec3d9786318187085
2017-02-14convert SvParserState to scoped enumNoel Grandin
and drop unused WAITFORDATA enumerator Change-Id: I658802d88a19dcc2d378456375810454e7426447
2017-02-14editeng: presumed copypasta in 048e30c1f8231e6cd144a9251061f6fa127b353eMichael Stahl
Doesn't make sense to check for RTF twice in a row. Change-Id: I15a384adb4d9e65770d81c414b6f24cc0a2b75e8
2017-02-13convert CharCompressType to scoped enumNoel Grandin
and move it to svl, where it belongs Change-Id: Ic4d846419dfe2dd85de5ade8ed1a041867bbf1dc
2017-02-12Various typos on accessibleJulien Nabet
Change-Id: Id28a4a2cbbcec10a7cc9cb40ad208d575352039b Reviewed-on: https://gerrit.libreoffice.org/34161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-10Remove MinGW supportStephan Bergmann
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-08loplugin:unusedenumconstants read-only constants in vclNoel Grandin
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2 Reviewed-on: https://gerrit.libreoffice.org/34018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07Revert "remove ugly operator* in DynamicErrorInfo"Michael Stahl
This reverts commit b5e3f8a5fa98a249ecd50021c33cf2a5c7a3b4fc. The problem is this: ==24217== Conditional jump or move depends on uninitialised value(s) ==24217== at 0x29A25FCE: SfxObjectShell::SetError(unsigned int, rtl::OUString const&) (objmisc.cxx:220) ==24217== by 0x29A35E6E: SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (objstor.cxx:2300) ==24217== by 0x29A3705C: SfxObjectShell::DoLoad(SfxMedium*) (objstor.cxx:765) ==24217== by 0x29A6BC48: SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (sfxbasemodel.cxx:1802) The commit is bogus because it introduces a DynamicErrorInfo::GetErrorCode(), which overloads ErrorInfo::GetErrorCode(), which is used at least in DynamicErrorInfo_Impl::RegisterEDcr() and used to return a constructor argument of DynamicErrorInfo but now returns pImpl->lErrId, which is what this statement is trying to initialize. Ultimately this causes my clang+ASAN build to fail because the uninitialized error code happens to be detected as a mere Warning: Test name: testMathMalformedXml::Import assertion failed - Expression: !xComponent.is() - loading succeeded: sw/qa/extras/ooxmlimport/data/math-malformed_xml.docx Change-Id: I9141144e0bc356ee54279948f2fce036d1831a86
2017-02-07Clean up some OUString creationStephan Bergmann
Change-Id: I62d312436432939d28aced7cfc4a018adbd94c8c
2017-02-07remove ugly operator* in DynamicErrorInfoNoel Grandin
I can see why you'd want to hide this horrible tunnelling of information with objects registering themselves in a global list. Urrgh. Change-Id: Ib151a0d2d5a4508dc456e52883e488ce56d9a095 Reviewed-on: https://gerrit.libreoffice.org/33984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06Typo: s/dependend/dependent/iTor Lillqvist
Change-Id: If02798894ad6f0e0442ed60aaec6eca40e6dcb61
2017-02-06default ctor is fine hereJochen Nitschke
this was hiding a Wunused-variable warning Change-Id: I32bd853846bc6f56c082541109eedfdab2402c3d Reviewed-on: https://gerrit.libreoffice.org/33942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27tdf#102688: let's purge it here just in case...Kohei Yoshida
In theory it would still leak without this if the map mode is set multiple times. Change-Id: Ie862f4d59e45b92ff75dffb787ef256337f47f84 Reviewed-on: https://gerrit.libreoffice.org/33602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-27tdf#102688: prevent leaking of VirtualDevice instances.Kohei Yoshida
Change-Id: I6fb8e5b7fc5c0cef8f7ab1f93f5096ad588d57c7 Reviewed-on: https://gerrit.libreoffice.org/33601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26tdf#103927: Share single standard VirtualDevice instance.Kohei Yoshida
To avoid creating excessive amounts of VirtualDevice instances. Also, since we now have VclPtr, we shouldn't need this bOwnerOfRefDev flag. Change-Id: I97a6f553a178b32bc173b83a6716185d126f97e1 Reviewed-on: https://gerrit.libreoffice.org/33508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-24teach unusedvariablecheck plugin about SfxPoolItem subclassesNoel Grandin
which can all be treated as SAL_WARN_UNUSED The eehtml.cxx change probably fixes some CJK/CTL bug somewhere Change-Id: I6852129540f316075aee907971ac19418d71dd9a
2017-01-24loplugin: unnecessary destructor cppcanvas..filterNoel Grandin
Change-Id: I009cdd60869a67d210edf879ddb451663a7b8676 Reviewed-on: https://gerrit.libreoffice.org/33491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23cppcheck: memleak (false positive)Jochen Nitschke
but manage ownership from start Change-Id: Ia9d29cc0e0676173c231c8b68b7681cc1b3dff86 Reviewed-on: https://gerrit.libreoffice.org/33392 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, editengStephan Bergmann
Change-Id: I4d93bf348b7b6a91aa37f8ce79b0b52a1a7d41ee
2017-01-18use rtl::Reference in AccessibleStaticTextBase_ImplNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I03da766787c3ac0273db50b7a79fd7a1d1d7bcbd
2017-01-18manage pField with tools::SvRefNoel Grandin
since it is a SvRefBase subclass Change-Id: Ib7d1e22336d673405d7455d40464df29f547d351
2017-01-17Change Idle to be a Timer subclassJan-Marek Glogowski
Drops a lot of duplicated code, as Idle is just a convenience class for instant, mostly low priority timers. Change-Id: I847592e92e86d15ab1cab168bf0e667322e48048
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-13coverity#1371287 don't need to copy and then overwriteCaolán McNamara
Change-Id: Ica30e4bed463e8e42cbf54f4b81491149a8de8ab
2017-01-13new loplugin: useuniqueptr: editengNoel Grandin
Change-Id: I6df65eab882780d996ee996b5fef8020186b6d98 Reviewed-on: https://gerrit.libreoffice.org/32958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-09New loplugin:externvar: editengStephan Bergmann
Change-Id: I1668a58f478c63b981c57e68795413f2aab87967
2017-01-09tdf#101828 handle rtf/richtext correctlyOliver Specht
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-05editeng: convert more DBG_ASSERT to assertMichael Stahl
Change-Id: I55aa17c9c900f927735d530550d5a660b6c2148a
2017-01-05editeng: convert some DBG_ASSERT to assertMichael Stahl
Change-Id: Iec89de279adf1c1cea3ecf84380d4b8b820714a4
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-26use std::vector instead of naked array in SfxItemPoolNoel Grandin
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4 Reviewed-on: https://gerrit.libreoffice.org/32384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-21convert VclButtonsType to scoped enumNoel Grandin
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-19no need to wrap calls to SAL_INFO in #ifdef DBG_UTILNoel Grandin
Change-Id: Ic373a8f145f3f78c3f109e36a9c1dd9156f0dd75 Reviewed-on: https://gerrit.libreoffice.org/32034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-16loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I24a0e495b64a1db8b7c45f3c68e06ad3301bd9c4
2016-12-16tdf#104488 editeng,svx: throw less Accessible exceptionsMichael Stahl
For some of these functions it doesn't make sense to throw DisposedException as they can return a sensible default value. Particularly AccessibleShape::getAccessibleChildCount() was throwing an exception that was never caught. Change-Id: I000149cf9bb0fd13f69650ad8224a8daf26f7bee
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-11 13:24:06 +0000