summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2015-11-10EditUndoRemoveChars::GetStr must return a referenceStephan Bergmann
...as ImpEditEngine::ImpRemoveChars (editeng/source/editeng/impedit2.cxx) calls pCurUndo->GetStr() += aStr; Regression introduced with d5e11f5ffb741aabe7e43be78ef764a1f3cafd8e "convert editeng/source/editeng/editundo.hxx from String to OUString." Change-Id: Iab3dd3b861bca715a90e89e3a63a6f298657367d (cherry picked from commit e31205f3ec1f941ab5a188bfde6329edf2acc55b) Reviewed-on: https://gerrit.libreoffice.org/19858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-28don't write SvxBackgroundColorItem via inherited SvxColorItem::StoreCaolán McNamara
SvxBackgroundColorItem inherits from SvxColorItem and for backwards compatibility with the StarOffice 5 binary file format (yes, really) writes/reads only rgb and not the transparency value, so copying and pasting text from a sidebar comment in writer to itself or another one results in a black character background as the default COL_AUTO turns into black (cherry picked from commit 3bc69b1d0d8620afd89a993b5f6bc46a2ff5267f) Change-Id: I18b5105dd8e060b9e49dda6026e26d3a0f00d8f5 Reviewed-on: https://gerrit.libreoffice.org/18074 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-18tdf#88295: Don't export transparent background colour as whiteKatarina Behrens
The fix is twofold: 1. retrieve transparency from colour in SvxBackgroundColorItem (add QueryValue, PutValue methods, use additional memberID to retrieve alpha channel as a bool property) 2. add CharBackTransparent bool property to Draw [text] shapes, xmloff needs it to be able to output 'transparent' string instead of '#XXYYZZ' colour code in ODF format Conflicts: include/editeng/colritem.hxx Change-Id: I6e14b81cc82f6b4d7fdd4756ff2e4f75e9270361 Reviewed-on: https://gerrit.libreoffice.org/16243 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-05-27tdf#88056: Implement ODF import/export of page title fieldKatarina Behrens
to/from loext namespace, since new tag's needed for the new field and it isn't approved by ODF-TC yet Change-Id: I70ceb4e16e1199663520dbdf3beae31423bc81d0 Reviewed-on: https://gerrit.libreoffice.org/15485 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-05-08rhbz#1215443 avoid null pointer dereferenceDavid Tardon
Change-Id: I0a7986703a6997c756d583d0e46907691f807b16 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-04-03tdf#85496: editeng: suppress all duplicate attributes during exportMichael Stahl
Since commit 0d57434180db6c8eda8c5b9b704f8a1c18b371df multiple 0-length attributes will be exported by the ODF filter as duplicate attributes. 846b56b6b99e334dfa44f1a24640aa3158509854 was apparently not the only bug that could cause this; unfortunately nobody is able to reproduce the editing operations that result in the newly reported issue, so just take the safe approach and check for duplicates, as is already done in the libreoffice-4-3 and libreoffice-4-2 branches. Change-Id: I1de10a99f6b84a0f4ea793ad55aaf6953b8307d5 (cherry picked from commit 5ece3e3525b0ef62e1b0e59ac5446aec0538d0d3) Reviewed-on: https://gerrit.libreoffice.org/15117 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-23tdf#89437 Ordinal suffix should never be superscript in some languagesNiklas Johansson
Printing ordinal suffixes as superscript is just not done in Swedish and likely a few other languages but this change only cares for Swedish at the moment. Change-Id: Ib7600ceb0534793d900f13b2740e63c1f7f34ba9 Reviewed-on: https://gerrit.libreoffice.org/14913 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 307c25fe460857c52f0b9c2078e83f6d12f8bdc9) Reviewed-on: https://gerrit.libreoffice.org/14956
2015-03-19tdf#89867: editeng: fix crash on shutdown after changing AutoCorrect optionsMichael Stahl
Since commit 5bff4b016c4b44f4123e0e6a4fd4c0c4dc0cfa2d the SvxAutoCorrCfg::pAutoCorrect is cleared by one terminate() listener but then another terminate() listener calls Commit() on all modified utl::ConfigItem and these two have a Commit() that does not clear the modified flag so they are always modified. Sadly there's no non-virtual Commit() wrapper that calls ClearModified() on the base class... Change-Id: I9ae220d78bb109c7bf0fdc544754a0686b357115 (cherry picked from commit d1698027e9f1c4a88b17da7357f257be3cfb7c1a) Reviewed-on: https://gerrit.libreoffice.org/14828 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-26tdf#78148 Ordinal numbers should not be auto-capitalizedNiklas Johansson
FnChgOrdinalNumber should return true if it changes the ordinal number. This seems to be accentually removed when the function was internationalized and has always returned false since. Change-Id: I633058a99ec033e0c33f807776364a52e22e9c64 Reviewed-on: https://gerrit.libreoffice.org/14535 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 42ec6448f9acd474d8ec1a92d9362e1b38e13758) Reviewed-on: https://gerrit.libreoffice.org/14578 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-12fdo#82719 EDITING: String with hyperlink not pastedHenry Castro
Fixed. It is impossible to copy / paste a string with hyperlink what is part of a longer string in cell. Change-Id: Id97ef7d742ab8ca17e2cafdc449d04d5839e93d4 Reviewed-on: https://gerrit.libreoffice.org/14412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5a646f04cc40fb13f39b16ab452237e5cf324684) Reviewed-on: https://gerrit.libreoffice.org/14441
2015-01-14fdo#85451 classic draw rectangles "fit to contour" utterly brokenCaolán McNamara
regression from commit 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 Date: Sun Feb 2 22:16:48 2014 -0600 xub_StrLen and tools/string.hxx final straw There is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases (cherry picked from commit 9977cbba8a36d3e6365cf886630d213ec7c1240c) Change-Id: I82bdcb6951c42fdcaa68808a251f9b2f76f8ed0b Reviewed-on: https://gerrit.libreoffice.org/13903 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-01-05Resolves fdo#87968 : Assertion failed: false rtl_uString_newFromSubStringJulien Nabet
aNewText already contains the good string so calling copy method is wrong (same pb for i18n::TransliterationModulesExtra::TITLE_CASE and i18n::TransliterationModulesExtra::SENTENCE_CASE) Change-Id: Ifce92f33e98af3a58a70d25da9c60cf3d584a001 Reviewed-on: https://gerrit.libreoffice.org/13724 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 31de7888660f551597263413bfdf467aade36680) Reviewed-on: https://gerrit.libreoffice.org/13753
2014-12-10Resolves: fdo#87141 Remove deletes the node, release doesn'tCaolán McNamara
regression from introduction of boost::ptr_vector originally one had to Remove and delete the return to delete it, while now the Remove automatically delete it. This bare Remove to just "release" it seems to have been overlooked Change-Id: I175f7c95862ce47402993e5e3b8feaa93af43e75 (cherry picked from commit efcbb12a27a380a442292f17c7f508555a66d4af)
2014-12-08Resolves: fdo#86931 wrong offsets used to set languageCaolán McNamara
after Chinese conversion. the _aOldSel is the one that has the start and end index set to the end of the replacement text and so the calculation only makes sense on that selection Change-Id: I152067550d7741579bfc6ca026072b16ac7c2dd6 (cherry picked from commit 6d10a42d5b1690b3b1ed81d99a3a1bc9b65c30d9)
2014-12-02Adapt to int/sal_Int32 mismatch on 32-bit buildTor Lillqvist
Change-Id: I9c5cb458ea7595c1b623ce14ed58fd3d5b3d961e (cherry picked from commit f1e7489d98a1d1fd9e261e4a7e83fff03e5daf63)
2014-12-02Adapt to int/sal_Int32 mismatch on 32-bit buildTor Lillqvist
Change-Id: Ifef81d53bee4241be3c0dd6b7ddb2c1bbf419b5e (cherry picked from commit 9bdde8b420265c7e77f4b310fb4c1214b715aa72)
2014-12-01fdo#85496: add some asserts to detect this sort of problemMichael Stahl
Change-Id: Iff787c8d2a71bc3082192cc98e3d916badee65dd (cherry picked from commit 7a242b463132d67a4a2d6e69319e0da367145cc0)
2014-12-01fdo#85496: editeng: do not add multiple 0-length attributes...Michael Stahl
... at the same position. Since commit 0d57434180db6c8eda8c5b9b704f8a1c18b371df these will be exported by the ODF filter as duplicate attributes. Change-Id: I8befe55f61c59ab968409fa03359540c300f9198 (cherry picked from commit 846b56b6b99e334dfa44f1a24640aa3158509854)
2014-11-23Resolves: fdo#86392 the assert seems to just want the attrs to be sortedCaolán McNamara
i.e. two at the same position is ok assert added in commit 8220b70fe2dc270188751950ac6d872320db1aa2 Date: Sun Jul 27 00:21:50 2014 -0400 bnc#467459 - fix editeng text search with expanded fields. Change-Id: Ifc65f3301a7d505a7d2d13e5914f53cbe263fc1f (cherry picked from commit e37e8f38d1f5c6bc427965dc535f1a64f0c8649c) Reviewed-on: https://gerrit.libreoffice.org/13024 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17editeng: Avoid calling expensive getLineBreak() if possibleMatúš Kukan
ImpEditEngine::ImpBreakLine: if nMinBreakPos == nMaxBreakPos just set nBreakPos to the same value directly. Change-Id: I4544cb6c56f68071cba739260161bb24ef5a3f7f
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14coverity#1242632 Untrusted loop boundCaolán McNamara
Change-Id: Ib821adfbca149091d4fbe52d05837e232c3caf55
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13sw: delete global SwAutoCorrect instance to avoid crash...Michael Stahl
... in exit handlers because VCL and the SolarMutex is gone. (regression from 4404b718bdb547cb9b7b17c73a53574724cdeeb7) Change-Id: I9f33b2cb8c87f7137e3ba0ae033879861f9fe11b
2014-11-12rename variables in makefileDaniel Sikeler
Change-Id: Ie1a7a8d83cc9c1ae4b6d015b77713f446fdd871e Reviewed-on: https://gerrit.libreoffice.org/12388 Reviewed-by: Matúš Kukan <matus.kukan@collabora.com> Tested-by: Matúš Kukan <matus.kukan@collabora.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12Guard against wrap-around in SvxFontHeightItemStephan Bergmann
...though the whole design there looks broken Change-Id: I6c3a53d606ea835d34729fcfb661fad0f1897716
2014-11-11Copy the original prop/prop unitStephan Bergmann
...instead of scaling the translated nNewHeight once more by the original prop Change-Id: Iadb53361a79f0b37b3c7c50066e4cfb7d24ed5e8
2014-11-11Revert "Some SvxFontHeightItem clean-up"Stephan Bergmann
This reverts commit d5f93eb47ec4c27e93ad908b0199790c702491a0, SvxFontHeightItem::SetProp was used to override "dummy" 100% nProp/ePropUnit values that did not match the computed nHeight value with nProp/ePropUnit values that are supposed to match the computed nHeight value. Yuck. Change-Id: Ic12e824054b3c5da7aca766b9b3eb076d1837d9a
2014-11-11Some SvxFontHeightItem clean-upStephan Bergmann
...and operator= shall probably copy rSize.ePropUnit... Change-Id: I112c02b3a3b2ce23f3d03f03881136e05be29017
2014-11-11callcatcher: dropping SwChapterNumRules binary Load/Store has knock-on effectCaolán McNamara
Change-Id: I2567026af23dd5fc42812b90bd6098c4c74a4f92
2014-11-11WaE: 'register' storage class specifier is deprecatedTor Lillqvist
Silly gperf generates 'register' storage class specifiers. So ignore those warnings from the generated tokens.cxx file. Change-Id: Ia80139f904f949bd2ae0267b6790d17b7f0e93d0
2014-11-11fdo#80403: TokenHandler impl. FastTokenHandlerBaseDaniel Sikeler
getTokenFromUTF8: calls getTokenDirect getTokenDirect: uses perfect hash New makefile creates perfect hash table with perl-script gentoken.pl. I found the script on https://wiki.openoffice.org/wiki/XFastTokenHandler and made some changes. XMLTokens are defined in tokens.txt Change-Id: Id04134a896ee082e2d0ba55a715fede19ff04928 Reviewed-on: https://gerrit.libreoffice.org/12335 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05coverity#1242632 Untrusted loop boundCaolán McNamara
Change-Id: I4ec2e1a21a6a27c31c3308a5f72dbdcb33a62f39
2014-11-05changed some timer to idleJennifer Liebel
Change-Id: Ifd5e2d87732d3e537c7754e52be24ef768ecb8d9
2014-11-05editeng: SvxRTFParser sal_Bool to boolMichael Stahl
Change-Id: I2159f5c45ec6e6df965836705792cf2d71abbc42
2014-11-05fdo#79761: parse BlockList.xml only onceDaniel Sikeler
Change-Id: I3cfc5b66ee73b0e4d07a84c8255c5a006e4fbb25 Reviewed-on: https://gerrit.libreoffice.org/12210 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-03coverity#982161 unchecked return valueDavid Tardon
Change-Id: I3c8370915898e322f40812b52929132e192b3a2c
2014-11-03coverity#982160 unchecked return valueDavid Tardon
Change-Id: I94117e9f53f1929906b88b2a31d0fcfdf2e40c8d
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31missing SAL_CALLMatúš Kukan
Change-Id: Ifa9034f12f42c0ddc5aa5e363fbcc04bab36492b
2014-10-31fdo#80403: AutoCorrect uses XFastParserDaniel Sikeler
depends on c0a5d390e519603dbc19a38c610d0a114b80cfa1 ContextClasses implement fast methods. ImportClasses implement fast methods. New TokenHandler for AutoCorrectTokens. Change-Id: I41ef7266da2068da3ab5f047280b13e57ee2e763
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28coverity#735305 Unchecked return valueCaolán McNamara
Change-Id: I0f03b67a5df3427e78f70f2b86aba26024ea575f
2014-10-27cid#1209201 Logically dead codeNoel Grandin
Change-Id: I8a7a9e23ad33f0c62813ae4ebd84cece3fe75283
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-10 13:58:47 +0000