summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2015-05-15tdf#62475: partial handmade fixesAndrea Gelmini
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15conver MENU_FLAG_ constants to scoped enumNoel Grandin
Change-Id: I969d99fa8881cc89601696a2d8621905a82b147b
2015-05-15convert POPUPMENU_ constants to scoped enumNoel Grandin
Change-Id: I4cdaf36581d1e1daa39929e621070d18a9996852
2015-05-14convert INPUTCONTEXT_ constants to scoped enumNoel Grandin
Change-Id: I5b99e42a3e85527b27d515c468d2ed66386fc9df
2015-05-14convert QUICKHELP constants to scoped enumNoel Grandin
Change-Id: Ie7302c909feb2e83b8b5e62a5e6a1f901783fb49
2015-05-14convert GRFILTER_I_FLAGS to scoped enumNoel Grandin
Change-Id: Ic1cb9b32fe252706cd607abb2ae1fd5a00999901
2015-05-14convert KERNING_ constants to scoped enumNoel Grandin
Change-Id: I58031485aaa9ebdeb986a3ee0376f36a9f667947
2015-05-12convert CURSOR_DIRECTION constants to scoped enumNoel Grandin
Change-Id: I444c61d0073b12740b55e316b2bb6e34f59dfe21 Reviewed-on: https://gerrit.libreoffice.org/15675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann
Change-Id: I94230f5d0838f26173eb17401f7bf22ab126e7ef
2015-05-11cppcheck: unreadVariableCaolán McNamara
Change-Id: I7af3807a4390e3b2f1bd9373feb937b6ff3dea7a
2015-05-10Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann
Change-Id: I9aca53ea7c957524a4ade0f20ef47954ddcbf5de
2015-05-07Remove unnecessary includes of sot/storage.hxx from include/Stephan Bergmann
Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
2015-05-07Unwind SotStorageStreamRef typedefStephan Bergmann
Change-Id: If7652a7c0251b741660365848a717c06954ca419
2015-05-07Unwind SotStorageRef typedefStephan Bergmann
Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
2015-05-07Remove SvStorage aliasStephan Bergmann
Change-Id: Id07ace147ff4fd4a17d05ba3cce6408def05c9c7
2015-05-07Remove SvStorageStreamRef aliasStephan Bergmann
Change-Id: Ic25c39adf8796bb433fa7746f53a68e3e2bfd228
2015-05-07SotStorage ctor takes as 3rd param a StorageMode (aka short)Stephan Bergmann
The code in editeng, passing sal_True (= 1) into StorageMode, has been like that ever since cd7096b4260149eb6fdd117ea0ba26b8116a41b2 "INTEGRATION: CWS mav09: #i27773#: remove so3; new storage API" where SfxMedium ctor calls were replaced with SotStorage ctor calls, keeping the argument lists intact. And at least way-back 5a9184d9e270e0ec0fe4b378c5cfde54ede095fa "INTEGRATION: CWS hedaburemove01: #72503# get rid of hedabu procedure: Moving headers to sfx2/inc/sfx2 and correspondent necessary changes" had a SfxMedium ctor that took as 3rd param a sal_Bool bDirect. That is, it looks like cd7096b4260149eb6fdd117ea0ba26b8116a41b2 inadvertently carried the SfxMedium bDirect arguments over as SotStorage StorageMode arguments. Given further that even way-back e1e019fed3970b916b046e2d7be48ea786026fce "INTEGRATION: CWS hedaburemove01: #72503# get rid of hedabu procedure: Moving headers to sot/inc/sot and correspondent necessary changes" only defines STORAGE_* values with values >= 0x02 (so sal_True would never have had any effect), the best bet appears to just use the implicit default = 0 instead. Change-Id: I3c19831433173657d3a3225c28398de7481fe036
2015-05-06VclPtr: one ref too manyCaolán McNamara
Change-Id: I0efce31e0f7cc5aa4895b6e5e35432d3f0c6fb70
2015-05-06convert DEFAULTFONT_ constants to scoped enumNoel Grandin
Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
2015-05-06convert FONTTOSUBSFONT constants to scoped enumNoel Grandin
Change-Id: I994bfc76d709d01406404991dbfbd49b15bd03f4
2015-05-05vcl::Window::Scroll takes a sal_uInt16 nFlags, not a sal_BoolStephan Bergmann
This passing of sal_True instead of some SCROLL_* flags has been there ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import," and the signature of vcl::Window::Scroll has been like that at least since f59676fe09175725ee0a75a1678dd1581decc20b "INTEGRATION: CWS hedaburemove01: #72503# get rid of hedabu procedure: Moving headers to vcl/inc/vcl and correspondent necessary changes," so lets arbitrarily assume that this wants to pass SCROLL_CLIP (which has the same numeric value as Change-Id: I8da6536404aa220611a7df96605c7a4a9efc7f7c
2015-05-05Use typed Idle::SetIdleHdl LinkStephan Bergmann
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-03drop useless temp debugging stringsCaolán McNamara
Change-Id: I9adc765654cf15633a53576e620c13eddcdc3b82
2015-05-03drop useless temp debugging stringsCaolán McNamara
Change-Id: I8a11a3d20fc5bde984586cb7046b174568315620
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Get rid of initial :: for the svx namespaceTor Lillqvist
Change-Id: I03e428a749bca409ebac9c142acaddafcbfeca23
2015-04-29Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann
...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28SvxRTFParser::ReadBorder/BackgroundAttr bTableDef param wants to be boolStephan Bergmann
Change-Id: I78c34a539a62ed129309305ce6e37a8feb19b1fd
2015-04-28Outliner::RemovingPagesHdl return type wants to be boolStephan Bergmann
Change-Id: I7d57d560f28683a840022cf766ef22cc50683349
2015-04-28operator == return type wants to be boolStephan Bergmann
Change-Id: I7ef0a09b718ca701ed2b6f4a50593f8ef1421dd3
2015-04-27rhbz#1215443 avoid null pointer dereferenceDavid Tardon
Change-Id: I0a7986703a6997c756d583d0e46907691f807b16
2015-04-27More loplugin:simplifyboolStephan Bergmann
Change-Id: I4d4df3a845d7a3af7d18dc58d35ebf5cd967b7eb
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: I0d41417b964f7f43b413a7b29fb1cf930f363427
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23ImpEditView::SetEditSelection: fix missing tiled rendering selection callbacksMiklos Vajna
Commit 2f31ac76be64953d19a72e3d8eae42b1ac5c5473 (editeng tiled rendering: allow resetting selection with a single click, 2015-03-16) changed ImpEditView::DrawSelection() so that the selection is only emitted when the view is in selection mode. However, this way selections set by ImpEditEngine::Search() were lost, as it only set the selection, but not the selection mode. So when in tiled rendering, always adjust selection mode depending on if the selection is empty or not, that makes the search result selections show up. Change-Id: I00b0739c5263a98a437e38d01b73c5004e50957b
2015-04-22convert BorderWidth flags to scoped enumNoel Grandin
Change-Id: I99214dc2056122158df9d861e3fb3e44bf0b16f6
2015-04-22convert SFX_STYLESHEET_ constants to scoped enumNoel Grandin
Change-Id: Iceba35cb058afa55374cf3cac70ed2207b7bc8b4
2015-04-21No more need for PartialWeakComponentImplHelper hereStephan Bergmann
...since 70626249cd247d9acdad417b8eaf252bae22c059 "API CHANGE a11y unpublishing and add/removeListener rename." Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
2015-04-21Related tdf#88056: this guy's better off in presentation namespaceKatarina Behrens
no use for it outside Impress really ... Change-Id: I419ce252ec1b32a7ef225fefc02ec5dd87ba402a
2015-04-17loplugin:implicitboolconversion clean-upStephan Bergmann
Change-Id: I248a35364e7bc24ec2d62f70ac9a9e91f07ddf68
2015-04-17SvStream: WriteUChar -> WriteBoolStephan Bergmann
Change-Id: I89aa0e22c31d368ab36fe46917db6aacb11c7b14
2015-04-17Related tdf#88056: prep UNO stuff for ODF export/importKatarina Behrens
Change-Id: I13c95b3e96db96634a3247154d28eddb3ae6c80d
2015-04-17convert SCRIPTTYPE_ constants to scoped enumNoel Grandin
Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433 Reviewed-on: https://gerrit.libreoffice.org/15344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-16drawinglayer, editeng, forms, fpicker: convert new to ::Create.Michael Meeks
Change-Id: I5144ac74a09a3ac5679abca89e7d87386f2484fd
2015-04-15convert SFX_ITEM constants to scoped enumNoel Grandin
Change-Id: Ief8c30c356ba947727c5ab70092042816a0db99e Reviewed-on: https://gerrit.libreoffice.org/15302 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd