summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2017-10-24loplugin:implicitboolconversionStephan Bergmann
("explicit conversion (NoOp) from 'const bool' to 'bool' implicitly cast back to 'const bool'", seen now with a recent trunk Clang 6, and with experimentally enabling -std=gnu++17 for the LO build; not sure what caused this to be triggered only now for me) Change-Id: I5310961b1d50870d3ae06554e4cb37e12ac68151
2017-10-23loplugin:includeform: editengStephan Bergmann
Change-Id: If2aa2cbbfabe164ccf0f68522fa18fa3bae2225d
2017-10-23tscp: advanced classification dialog for impressTomaž Vajngerl
Change-Id: I76c81e6f84de8160c20f1614d7676f2f2c3fb155 Reviewed-on: https://gerrit.libreoffice.org/43361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-19use std::unique_ptr in TrieNodeNoel Grandin
Change-Id: I1482f846370e0b8e6f76d46fc5020e2dcb152223 Reviewed-on: https://gerrit.libreoffice.org/43495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17EditEngine: Enhance visualization of URLsArmin Le Grand
When URLs get layouted Multi-Lined from the EditEngine, a rough 'guess' how many chars per line should be used was in place up to now. This could lead to lines being too short or being longer than the available space, also looked ugly. Layouting now using the needed space properly. Also adapted vertical (for horizontal text) space usage, with multiple lines the space was 'compressed' and wrong calculated. Change-Id: I7255e3e65c85a3a50497b771ed2ca1ef5d97c0dd Reviewed-on: https://gerrit.libreoffice.org/43464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-10-16Move editeng/source/editeng include files to common include directoryStephan Bergmann
...that are included from various source directories. Change done in preparation of loplugin:includeform. Change-Id: I4c2160d1c682b37e93e1161796c67097866bf659
2017-10-16editeng: add function to insert parargaph break to the EditViewTomaž Vajngerl
Change-Id: I06ab56967f25e6f9170cfbeb391110b55ddb18f6 Reviewed-on: https://gerrit.libreoffice.org/43359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-14sd lok: fix spell checking languages in ImpressHenry Castro
Change-Id: I133c9b91521fa7f2b5f7e3a47396f7efa31e1a86 Reviewed-on: https://gerrit.libreoffice.org/43382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-10-05editeng: fix assert about wrong EE_PARA_OUTLLEVEL itemMichael Stahl
It's a SfxInt16Item in DefItems::DefItems(). Change-Id: I01644b0b9d689d4d8756c52f1c2868f03b3037a5
2017-10-05tdf#112817 editeng,svx: fix SvxUnderlineItem/SvxOverlineItem SDIMichael Stahl
This was asserting because the superclass SvxTextLineItem was instantiated instead of the specific subclasses. Change-Id: If26847b8fa96dbf00062ba8372fe58e58c786782
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-29rename SvxTabStop::IsEqual to operator==Noel Grandin
Change-Id: I98f8db6e80d6a5dc30826ec755deb9432f809e92 Reviewed-on: https://gerrit.libreoffice.org/42907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-29convert IsEqual/etc methods on ESelection to operatorsNoel Grandin
Change-Id: Ia8424e701b6f22d0536ee7f3bdb0ecaaed94a3b9 Reviewed-on: https://gerrit.libreoffice.org/42904 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22lok: Don't freeze the LibreOfficeKit via the spell-checking popup menu.Jan Holesovsky
Change-Id: I045ed919daeefca612d7908dd7de50c36536c9a0 Reviewed-on: https://gerrit.libreoffice.org/42608 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42627 Tested-by: Jenkins <ci@libreoffice.org>
2017-09-22ofz: don't leak in face of exceptionsCaolán McNamara
Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2 Reviewed-on: https://gerrit.libreoffice.org/42587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21loplugin:flatten in editeng..extensionsNoel Grandin
Change-Id: I2b68f5640471ea827c09af1b5a319fb526a53b4b Reviewed-on: https://gerrit.libreoffice.org/42579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-19unused xForbiddenCharsTable in ImpEditEngineNoel Grandin
since as far back as I can see Change-Id: I828d527e91479f40d0186b09043de4841d735e84
2017-09-18unused m_xAccInfo in AccessibleEditableTextParaNoel Grandin
since commit c23ab5eaed57cc3fb5860e26c591c73c5b22687b Date: Tue Nov 26 14:25:22 2013 +0000 Integrate branch of IAccessible2 Change-Id: Id068fb0a49f5a1e79ca17fe66885cda558abe275
2017-09-18remove unused aLocale from SvxNumRuleNoel Grandin
and fix usage site, regression from commit 41956321ceefb5836feb2c119b66de7bb557740f Date: Sat Nov 24 18:54:09 2012 +0100 get rid of Svx...Locale...() double conversion nonsense Change-Id: Ic70abf5f52dce1db9cffd9c819e57f1a6c2a3df3
2017-09-18convert SvxDateFormat to scoped enumNoel Grandin
And simplify the code in sd/headerfooterdlg, no need for the complex encoding of date and time when we can just index into a static array. Change-Id: I677400bf1f956c81eba665b71dbda9183b63f55c Reviewed-on: https://gerrit.libreoffice.org/42346 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeFormat to scoped enumNoel Grandin
and make the numerators look more like our internal formatting codes Change-Id: I3b3d448cec913e72c7ffb6cc3e7754241af36d93 Reviewed-on: https://gerrit.libreoffice.org/42345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeType to scoped enumNoel Grandin
Change-Id: Ic5ca8c50ccd74837cd0521a13e1f5eaa8e326ff3 Reviewed-on: https://gerrit.libreoffice.org/42344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxURLFormat to scoped enumNoel Grandin
Change-Id: Ie2199cf0bcfb6d649f8aa33325ab645b18e7c000 Reviewed-on: https://gerrit.libreoffice.org/42343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxFileType to scoped enumNoel Grandin
Change-Id: Iec1c67f7f0f9b2244b1d6ef52921ddd09f944fbb Reviewed-on: https://gerrit.libreoffice.org/42314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxFileFormat to scoped enumNoel Grandin
Change-Id: Ia75c86a89c89bb22759e1d588ce603701cb7fad5 Reviewed-on: https://gerrit.libreoffice.org/42313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxAuthorType to scoped enumNoel Grandin
Change-Id: I990eb35c883ddd417751487435556f584e956374 Reviewed-on: https://gerrit.libreoffice.org/42312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxAuthorFormat to scoped enumNoel Grandin
Change-Id: I5553ea640a4483c98ec5f5240594e30a72c968f8 Reviewed-on: https://gerrit.libreoffice.org/42311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SdrMeasureFieldKind to scoped enumNoel Grandin
Change-Id: I8896d46623843d3fe341c057d7ee0376a99f4741 Reviewed-on: https://gerrit.libreoffice.org/42310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxCellVerJustify to scoped enumNoel Grandin
Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4 Reviewed-on: https://gerrit.libreoffice.org/42276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14improve redundantcast lopluginNoel Grandin
to find c-style casts where the expression is a templated method Change-Id: Ifbd1e2cdc72d906fc95a7ec0f9408c3f6d2a836b Reviewed-on: https://gerrit.libreoffice.org/42275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11clang-tidy modernize-use-emplace in editeng..frameworkNoel Grandin
Change-Id: I7739c4f77c856d34f8484754244df13d8fef840e Reviewed-on: https://gerrit.libreoffice.org/42151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08loplugin:constantparamNoel Grandin
Change-Id: Ic87f0cc863490858b7cc7e74a7f90ec31992dd53 Reviewed-on: https://gerrit.libreoffice.org/42089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-27OUString: reduce temporaries and constifyMatteo Casalin
Change-Id: Ic4d5e26b16414625dfb507ecf37d87efe171ceab
2017-08-25loplugin:unusedfieldsNoel Grandin
Change-Id: I81bcf4f56599146536ba8d66cc86fa5a08737298 Reviewed-on: https://gerrit.libreoffice.org/41556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-25loplugin:unusedmethodsNoel Grandin
Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f Reviewed-on: https://gerrit.libreoffice.org/41539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24Related: tdf#108795 never use an unresolved LANGUAGE_SYSTEM in SvxAutoCorrectEike Rathke
Substitute with the current work locale, using MsLangId::getSystemLanguage() instead was also wrong. Change-Id: I55db3bc1f76329320afc1f366d7426a8c2f66fb2 Reviewed-on: https://gerrit.libreoffice.org/41476 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-24Related: tdf#108795 a shared SvxAutoCorrect instance can not be statefulEike Rathke
An SvxAutoCorrect instance is shared via SvxAutoCorrCfg::Get().GetAutoCorrect(). Since commit 284eb106767d094fc5c547efd6c11cc390e3538a and following the SvxAutoCorrect::bRunNext/HasRunNext() introduced a state whether a previously inserted NO-BREAK SPACE should be removed again, depending on the next character input. That does not work, for example, if SvxAutoCorrect::DoAutoCorrect() is called from two different EditEngine instances, like it is the case in the Calc input line and cell which are synchronized; or any other two or more instances for that matter. The caller has to pass and remember a flag that is maintained by SvxAutoCorrect. Change-Id: I79a26d2ba44cc40771979a78b686c89f0c80b412 Reviewed-on: https://gerrit.libreoffice.org/41475 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-22editeng: warning C4701 potentially uninitialized local varMichael Stahl
Change-Id: I611f0b5652722f0de38dfb82440823b832a6029c
2017-08-22editeng: avoid infinite loop in SvxBoxItem::CreateMichael Stahl
Apparently a sw unit test randomly read a partially written autotbl.fmt and the stream has m_isEof = true. Change-Id: Iacfbc42e83be6320d4aa695a5df4264f1db0b021
2017-08-22drop unused SvxScriptTypeItemJochen Nitschke
apparently there was never a user for this item since initial commit in the year 2000. SvxScriptSetItem gets the ScriptType by parameter see GetItemOfScript and PutItemForScriptType. remove SID_ATTR_CHAR_SCRIPTTYPE and don't put the item in any set. keep the gap in the ID range because it's not part of any range and there are already other gaps. Change-Id: Iee24f13b329593af2dc5548d8b6bc2282c2dc5b3 Reviewed-on: https://gerrit.libreoffice.org/41423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-20drop unused SfxSpellCheckItemJochen Nitschke
last getter went with commit 215207f480258b37864a88e1b831055e148adf65 Date: Thu Mar 6 16:42:24 2014 +0000 coverity#708784 Unused pointer value don't put the item in any item sets anymore. delete SID_ATTR_SPELL and adjust SfxItemSet ranges. narrow ranges in OfaTreeOptionsDialog::CreateItemSet to actually used items. Change-Id: Ia5cc91fc62a0fccf87b2fd380e6bb2bef1f6f3e7 Reviewed-on: https://gerrit.libreoffice.org/41335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18loplugin:unnecessaryparenNoel Grandin
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-19 19:04:27 +0000