summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-25coverity#1266493 Use of untrusted scalar valueCaolán McNamara
Change-Id: Iba051da07f5ffafcab559fe03a4e93f21a2d4f8a
2015-01-25coverity#1266455 Explicit null dereferencedCaolán McNamara
Change-Id: If772142b776d2365cbd2b7f0927975c2739c1316
2015-01-25coverity#1266454 Explicit null dereferencedCaolán McNamara
Change-Id: Ic8f13e9bd3755c9ccb59d173ac0a36be1d06a2f4
2015-01-25coverity#1266453 Explicit null dereferencedCaolán McNamara
Change-Id: Ia03fdd3d854574ba19b028334e2397ad544fe20a
2015-01-25coverity#1266506 Useless callCaolán McNamara
Change-Id: I0d2f493ddf410aa4980dbeeaf8976c052ea139e3
2015-01-25coverity#1266515 Useless callCaolán McNamara
Change-Id: I554ca2a961a9ba6009bef23067febe8611ba1f80
2015-01-23fix 64-bit build after OUStringBuffer changeMichael Stahl
Change-Id: I6c5295110292ae48ff0cb3472e4dbea287645d2a
2015-01-20textranges are always in pairsCaolán McNamara
Change-Id: I3d98c26c7902bc89ab6701dd02e266fd466c6907
2015-01-20Factor out SvxShadowItem::dumpAsXml() from swMiklos Vajna
Change-Id: Id25a050a9840d83cff4b390faec7478f17336524
2015-01-20Some more loplugin:cstylecast: editengStephan Bergmann
Change-Id: I047212dfd7ae330d6cd8149e3c7110d67b9e79e9
2015-01-17Factor out SvxULSpaceItem::dumpAsXml() from swMiklos Vajna
Change-Id: I52d7a7aaf304b7d698705cda7d3e70e723811fb2
2015-01-16loplugin:implicitboolconversionStephan Bergmann
Change-Id: I31e3753c722f98cd7b6ffbf87839bbea8de4b740
2015-01-16Factor out SvxLRSpaceItem::dumpAsXml() from swMiklos Vajna
Change-Id: Id28c3e1617f2e73c36f13b506488d401a22b00a8
2015-01-16remove unnecessary parenthesesNoel Grandin
left over from "SVStream operator>> to Write method" conversion Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
2015-01-15loplugin:implicitboolconversionStephan Bergmann
Change-Id: Idbee7d8c96082a88c9653556ec7f88f4e7ced973
2015-01-15remove unnecessary castsNoel Grandin
leftovers from conversion of SvStream operator>> to Write methods Change-Id: Id1d1e60ae42afb689910845a3c6ec75e3388fb56
2015-01-14classic draw rectangles "fit to contour" utterly brokenCaolán McNamara
regression from commit 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 Date: Sun Feb 2 22:16:48 2014 -0600 xub_StrLen and tools/string.hxx final straw There is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases Change-Id: I82bdcb6951c42fdcaa68808a251f9b2f76f8ed0b
2015-01-13simplify Date/Time/DateTime conversion codeNoel Grandin
add constructors to Date/DateTime/Time, that take the css::util counterparts, to simplify code converting between these type Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7 Reviewed-on: https://gerrit.libreoffice.org/13855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2015-01-13debugging assert about unsorted properties on loading ooo59216-14.odsCaolán McNamara
Change-Id: I30e7dcddcce188edef0d2affb148a3dba6f62c1d
2015-01-12Factor out SvxProtectItem::dumpAsXml() from swMiklos Vajna
Change-Id: I780afa7c5faa0f594257200c5c2c132cc49388b6
2015-01-12no need for DeletedNodeInfo class to be type unsafeNoel Grandin
Change-Id: Idab8eacf8fa06d902c9186995b249e871bc54067 Reviewed-on: https://gerrit.libreoffice.org/13860 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fdo#84938: convert COMPRESSMODE_ #defines to 'enum class'Noel Grandin
Change-Id: Ica501fc73e7e5f9dbd30dd9da3f337b2dc7e6f02
2015-01-07fix windows buildNoel Grandin
and a handful of other currently uncompiled spots, after my commit 7f8f277b94704a289fbbd1b836e4e5d66311580d "fdo#84938: convert STREAM_ #defines to 'enum class'" Change-Id: I550f6fb850e1d71a6f08767eeb222a18071b89d5
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07fdo#84938: convert VCL_INPUT_ #defines to 'enum class'Noel Grandin
Change-Id: I155e45f58974a2b946c4a7703b350bcbfbad342e
2015-01-07fdo#84938: convert INDICATOR_ #defines to 'enum class'Noel Grandin
and replace SalIndicatorState, it serves the same purpose Change-Id: I618b8946b8e2527883eecb13060b2256abc505b6
2015-01-07fdo#39440 reduce scope of local variablesŁukasz Hryniuk
Beside scope changes, it fixes lack of initialization in a few places. Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2 Reviewed-on: https://gerrit.libreoffice.org/13755 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-06fdo#84938: convert EXPORT_ #defines to 'enum class'Noel Grandin
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-05Resolves fdo#87968 : Assertion failed: false rtl_uString_newFromSubStringJulien Nabet
aNewText already contains the good string so calling copy method is wrong (same pb for i18n::TransliterationModulesExtra::TITLE_CASE and i18n::TransliterationModulesExtra::SENTENCE_CASE) Change-Id: Ifce92f33e98af3a58a70d25da9c60cf3d584a001 Reviewed-on: https://gerrit.libreoffice.org/13724 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03Typo: translitaration->transliterationJulien Nabet
Change-Id: If722e7d025db65b72419499f1443d5f0cda609dd
2015-01-02Fix simple typos.Andrea Gelmini
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599 Reviewed-on: https://gerrit.libreoffice.org/13719 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-18editeng: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Iab879390c18a3ce2c5bfc49548ca273ce0b907da
2014-12-18Factor out SvxFontHeightItem::dumpAsXml() from swMiklos Vajna
Change-Id: I8dc3a0ed7bfce62b0d20c6bff143d77c0f26963f
2014-12-17Factor out SvxBrushItem::dumpAsXml() from swMiklos Vajna
Change-Id: I5421cf5a7d1a2ff4db81d028f44a490c234b9ccf
2014-12-16Factor out SvxFontItem::dumpAsXml() from swMiklos Vajna
Change-Id: I8283ddd868639e6535e27798d91a7273d77f048c
2014-12-12fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: Ifbc5a7a562e714f48dcfd51a75e9a4e0bfcde81c Reviewed-on: https://gerrit.libreoffice.org/13443 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11coverity#705150 Missing break in switchCaolán McNamara
Change-Id: I5df9dff9ef6940b15c899d13f1a358e47dbd8b2b
2014-12-11Factor out SvxCharRotateItem::dumpAsXml() from swMiklos Vajna
Change-Id: I52bca77e8ff0d4fccf8423f01dac9b6a7498f8d1
2014-12-10Typo: postion(s)=>position(s)Julien Nabet
Change-Id: Id2957f1cb68fc4b2fef9966abeb6745b548bcb75
2014-12-10Resolves: fdo#87141 Remove deletes the node, release doesn'tCaolán McNamara
regression from introduction of boost::ptr_vector originally one had to Remove and delete the return to delete it, while now the Remove automatically delete it. This bare Remove to just "release" it seems to have been overlooked Change-Id: I175f7c95862ce47402993e5e3b8feaa93af43e75
2014-12-10fdo#76776 crashes after paste a table from WriterCaolán McNamara
Change-Id: If859352a7d8d409e5c3c651e0ffea0b3687007db
2014-12-09changed inherited timers to idleTobias Madl
Change-Id: I1d70d4d2fe8573d0f120f2a1ece83f504d5efde5
2014-12-09changed timers to idleJennifer Liebel
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-09changed timers to idlesJennifer Liebel
Change-Id: Iebde351b3bfca907a7730b7af379efb040cbeae2
2014-12-09Factor out SvxRsidItem::dumpAsXml() from swMiklos Vajna
Change-Id: I60c57fa6a9f3619de717e7b2383dc420706b2886