summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2013-12-10fdo#70278: editeng: fix Time fields in ImpressMichael Stahl
Apparenty an uninitialized SvxTimeField is created instead of the SvxExtTimeField that is needed to preserve the value and format. (regression from ee5fc5d25fe102c30daf7d181b8181d40b85a4f3) Change-Id: I36b16af0c143e8b5451a1925806756492dc2334e
2013-12-10editeng: fix more 32-bit Time breakageMichael Stahl
SfxDateTimeItem and SvxExtTimeField need to use 64-bit integer to store Time as well. These classes also have binary serialization Load()/Save() methods but they are unlikely to be used in a persistent way, just for the clipboard. The problem is easy to reproduce in Impress: Insert->Field->Time(fixed) (regression from 9830fd36dbdb72c79703b0c61efc027fba793c5a) Change-Id: I5946c5b94dd5a509805b6dc40461bbd910caffc4
2013-12-10Resolves: #i123620# IAccessibleHypertext::hyperlinkIndex returns 0...Steve Yin
when editing a cell/object where there is no link (cherry picked from commit 552e71c2482b5911ac485c9331a4f354ba7150b5) Change-Id: I9be20b045d3472f15c98352928d45a1349cec5c4
2013-12-10Drop duplicate #includeTakeshi Abe
Change-Id: Ib8969d5cd4898b81a5dcd90dc313abd28adfe052
2013-11-27IAccessible2: revert some bounds-checking changes againStephan Bergmann
...that were introduced with c23ab5eaed57cc3fb5860e26c591c73c5b22687b "Integrate branch of IAccessible2" but broke JunitTest_sc_unoapi, which expects calls to getCharacterAttributes and getIndexAtPoint to actually fail for out-of-bounds arguments. The above commit does not make it obvious why those changes were actually made. Change-Id: I3492c3e6a49d68885df1206e9368f4483c0dc4f9
2013-11-26WaE: unreachable codeTor Lillqvist
Change-Id: Iee5fa84eb2335efa7d7f7cb28b8efdecf9366592
2013-11-26rewrite new SvxEditSourceHelper::GetAttributeRun replacement in new styleCaolán McNamara
Change-Id: I906e99afb58dcee3e47a545f575aab71b7edc0e9
2013-11-26Integrate branch of IAccessible2Steve Yin
WaE: Reorder initializations to prevent compiler warnings. (cherry picked from commit c05431aa92fa2c7c7258418a6ecd651b5c26d982) WaE: unname unused variable to prevent compiler warnings. (cherry picked from commit 2259256a390c4b6f83cfb5dbe4a65df5032aee47) Conflicts: editeng/source/accessibility/AccessibleEditableTextPara.cxx ad61537527a74670af266feb9e4d26d2d654daf7 66044902b8d94fc15d4c30270e6cc419fb7d3565 Change-Id: I3ec9798f2c7d854824722c0cf44b62128b4f4cb4
2013-11-22replace OUString::reverseCompareTo("xxx") with operator==Noel Grandin
operator== with OUString and literal internally does a reverse-compare (via OUString::equalsAsciiL) anyway, so no need to keep explicit calls to OUString::reverseCompareTo with literal argument Change-Id: I799d9bcd0d5c308a9547ce7cacb2db6042fdb643
2013-11-22remove unnecessary RTL_CONSTASCII_STRINGPARAMNoel Grandin
A final pass through the code, converting code to use the new OUString and OString methods that can detect string literals. Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-20editeng: warning C4805 unsafe mix of type sal_Bool and type boolMichael Stahl
Change-Id: I88fc77ea6c0b6a7c02d0b7eff64d8fdd3db6020e
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OStringBuffer constructorNoel Grandin
Convert code like: OStringBuffer aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OStringBuffer aKeyName("NDX"); which compiles down to the same code Change-Id: If9c96a290bc18cc8285fb733f27be58c6958b63c
2013-11-20fdo#67742 Avoid autocorr of "--" before "-"Laurent Balland-Poirier
LibO 4.1 now uses '-' as word separator for AutoCorrection Then the sequence "---" is detected as word "--" and autocorrect as "–". This avoids autocorrection of "---", as word or as border This commit detects the sequence "---" and report autocorrection. Change-Id: I1342c2ff83dd42683e683b3bb27280d61179b9a2 Reviewed-on: https://gerrit.libreoffice.org/6727 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20sal_Bool to bool in ImpEditEngineRodolfo Ribeiro Gomes
Change-Id: I76dc0343fd735104827b4803c5440570afe86174 Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/6693 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-17bugs.freedesktop.org -> bugs.libreoffice.orgAndras Timar
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
2013-11-14SvxBrushItem: Improve Referer from member to GetGraphic[Object] parameterStephan Bergmann
Change-Id: I034132c315b74d0ea5e03b7d5f7cc225a6c8164e
2013-11-14make l10n buildable separatelyBjoern Michaelsen
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14Fixed for spacing between lines in paragraph.Priyanka Gaikwad
Problem Description: In "w:spacing" value of "w:line" attribute value is not getting preserved. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/6645 Change-Id: Id9da4f9234d14cf4599c6520b4a191ad9af92c25
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14xub_StrLen to sal_Int32 and minor optimizationsMatteo Casalin
Change-Id: Ie8703ee0ff6c428ed00ffb88749540588e608b43
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-11convert STRING_NOTFOUND -> -1 in editengNoel Grandin
And convert some xub_StrLen to sal_Int32 in the same patch of code. Change-Id: I72c92bf9413dbca14688cb8d46a023df49a5d41a
2013-11-11remove unnecessary use of OUString constructorNoel Grandin
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-08longparas: same variable used for two different loops of different typesCaolán McNamara
Change-Id: I1efdeb3f9bbda47d8f465a04fb36164e7ffc347b
2013-11-08n is immediately overwrittenCaolán McNamara
Change-Id: I51c511efcfaf2d97cefa42abea1d3e42c023fbbd
2013-11-06convert xub_StrLen to sal_Int32Noel Grandin
convert various module-local functions Change-Id: I89f3eb40b107e2617958e474ffe86bd73e01cf33
2013-11-06convert xub_StrLen to sal_Int32Noel Grandin
convert for loops using xub_StrLen to use sal_Int32 Change-Id: I5f635ca078966fefe938dbc7e8dea7c8d0d0b554
2013-11-05convert xub_StrLen to sal_Int32Noel Grandin
Convert code like: xub_StrLen nLen = aStr.getLength(); into sal_Int32 nLen = aStr.getLength(); Change-Id: Ib0af6b747068257478918fd1cc93e4925f32ac47
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03fdo#69762 Scientific number AutoCorrect as ordinalLaurent Balland-Poirier
In French, ordinal number autocorrection transforms 2e-3 in 2^e-3 which is annoying in Calc. This patch avoids autocorrection with [digit][e|E]- Change-Id: Iaaff4f8d6e667fc84a68d7c11e1a96da13594a18 Reviewed-on: https://gerrit.libreoffice.org/6204 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-10-28fixincludeguards.sh: editengThomas Arnhold
Change-Id: I022e690c1f50f7f5ae872889e21aaedb5c60085d
2013-10-28windows: warning 4706 is disabled globally in com_MSC_defs.mkThomas Arnhold
So there is no need to do this locally, too. Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
2013-10-23Some clean-upStephan Bergmann
Change-Id: I87cc4a6840090076007d268ae19eb2cfd3408e7c
2013-10-23fdo#54938: Kill ServiceInfoHelper::supportsService and use cppu's instead.Marcos Paulo de Souza
Change-Id: I1c2d95e4c3fb6242dcb4cdb88cf9733471a3412b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-23remove comment that is irrelevant after the death of String classAndras Timar
Change-Id: I791b007b68247a041f33d779276d1bb0d7e06e78
2013-10-23convert code to use OUString::endsWithNoel Grandin
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22Resolves: fdo#38838 remove UniStringCaolán McNamara
hammer silver nails into coffin and bury in concrete Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-20drop unnecessary tools/string includesCaolán McNamara
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20fdo#52622 - Reduce copy and paste codeJosé Guilherme Vanz
This commit removes copy and paste code, creating a constructor for it Change-Id: I7a66cfda7fc7c11308d155a7a890352fdacfaacc Reviewed-on: https://gerrit.libreoffice.org/6356 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-19Make copy and pasting non-ascii text from editengine work againCaolán McNamara
regression since 80df5277585d69be5c3d5f32184db94831113f95 Change-Id: Ifcd8f97fdeb078be1884cfbd7175ab15ac30b23d
2013-10-19CID#1038307 Negative loop boundCaolán McNamara
fix of coverity#1038307 Negative loop bound d9ac156b2d651c1305135938a1e828144aa5742b wasn't complete, it assigned possible -1 int32 to unsigned value before comparison, so -1 not detected. Change-Id: I6c2805acae8e776902d74c641e01c036193ce3d8
2013-10-18disambiguate GetScriptType that return different value typesCaolán McNamara
Change-Id: I694d81d17fac5fbd964937dc654ebd764af90842
2013-10-18Resolves: rhbz#1020712 return all the selected scriptsCaolán McNamara
What we want here is *all* the scripts in the range, that's the whole point of using SCRIPTTYPE. We use this to determine the font to show in the fontbox. If it's an exclusive script then we can show the font that that script, and if there are multiple scripts we know to set it empty. With the other intermediate bugs out of the way, this now appears to work correctly. Change-Id: I58426123602d70c151bd878e96fa5cbab7d3fd3e
2013-10-18Related: rhbz#1020712 more i18n::ScriptType being compared against SCRIPTTYPECaolán McNamara
Change-Id: I5da9114a3fd8330df2b63dc9187323765d305791
2013-10-18Related: rhbz#1020712 wrong default font shown in editengineCaolán McNamara
Only in editengine could we have this fiasco. There are two ImpEditEngine::GetScriptType's a) sal_uInt16 ImpEditEngine::GetScriptType(const EditPaM& rPaM, sal_uInt16* pEndPos) const this one returns i18n::ScriptType b) sal_uInt16 ImpEditEngine::GetScriptType(const EditSelection& rSel) const this one returns SCRIPTTYPE Could there be a better way to ensure that mistakes will be made. Anyway, within variant b, with an empty edit engine ImpEditEngine::GetScriptType calls GetI18NScriptTypeOfLanguage but *that* returns i18n::ScriptType's not SCRIPTTYPEs but when there is content then a SCRIPTTYPE is truly returned. Change-Id: I3a4a7c8746728e0fdfb25d961004c8339a24c93d
generated by cgit (git 2.34.1) at 2025-01-08 20:56:57 +0000