summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2014-04-04Resolves: coverity#705447 Self assignmentCaolán McNamara
in every other !bAbsorb branch we set the StartPara to the EndPara Change-Id: I4fc877e9d63f823679acf9c4b1550d5e877819be
2014-04-04svl/eitem.hxx: sal_Bool->boolNoel Grandin
Change-Id: I45dfd2429a490af3cc80f51340e0c05a91425668
2014-04-04cleanup up the EditEngine::GetAttribs callNoel Grandin
It was using a bool parameter, but passing various constants through it. Make the constants into an enum, and use the enum in the GetAttribs call. Change-Id: I3010397dfe83b24db3946b9dea2fb37f4393abdd
2014-04-03svl: sal_Bool->boolNoel Grandin
Change-Id: I6938314a08d061d2b07d9129742d74a989bd1385
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-31use SAL_N_ELEMENTSCaolán McNamara
Change-Id: I533ce52828ae08a6ab111bcbeaaa6b44c62a6ab9
2014-03-31Presentation string for recently-added border typesLuke Deller
LibreOffice will show a textual description of a style in some contexts eg in the Organizer tab of the dialog for modifying a style. This change updates the description of border line types to support recently-added types: FINE_DASHED, DOUBLE_THIN, DASH_DOT, DASH_DOT_DOT Also this fixes an out-of-bounds array access in SvxBorderLine::GetValueString Change-Id: Ia354a05ab1455eb8bcc079c6e51419a0cc6429d6 Reviewed-on: https://gerrit.libreoffice.org/8781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-31.doc support for recently-added border line typesLuke Deller
Some new border line types have been added recently to LibreOffice (FINE_DASHED, DASH_DOT, DASH_DOT_DOT) This change updates .doc import/export to support these. (Import of FINE_DASHED was already working, but not export). Change-Id: Id3bcb1d4e6e9ceb97b492f0c578fd5b885ab16ff Reviewed-on: https://gerrit.libreoffice.org/8780 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-31xmloff: sal_Bool->boolNoel Grandin
Change-Id: I64c33ae4c157e270acac9a1f820d3e6272ba0bea
2014-03-30Avoid possible resource leaks by boost::scoped_arrayTakeshi Abe
Change-Id: Iffc9d1ca971610bad9b3dd2bd9a6cd00f02ff39b
2014-03-29typo: selektion -> selectionThomas Arnhold
2014-03-28Merge back branch alg_writerframes to trunkArmin Le Grand
(cherry picked from commit b635b4fa4e42053d30ab639643d2236a20243f62) Conflicts: comphelper/inc/comphelper/TypeGeneration.hxx comphelper/source/property/TypeGeneration.cxx cui/source/factory/dlgfact.hxx cui/source/inc/cuitabarea.hxx cui/source/tabpages/tabarea.cxx cui/source/tabpages/tabarea.hrc cui/source/tabpages/tabarea.src cui/source/tabpages/tparea.cxx drawinglayer/source/primitive2d/polypolygonprimitive2d.cxx drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx drawinglayer/source/texture/texture.cxx editeng/inc/editeng/unotext.hxx editeng/source/items/frmitems.cxx include/drawinglayer/texture/texture.hxx include/editeng/brushitem.hxx include/svx/sdr/primitive2d/sdrdecompositiontools.hxx include/svx/svxids.hrc include/xmloff/xmltypes.hxx reportdesign/source/ui/misc/UITools.cxx sc/source/ui/drawfunc/drawsh.cxx sfx2/source/dialog/tabdlg.cxx svl/source/undo/undo.cxx svx/inc/svx/unoshprp.hxx sw/Library_sw.mk sw/inc/doc.hxx sw/inc/format.hxx sw/inc/frmfmt.hxx sw/inc/swatrset.hxx sw/inc/unomap.hxx sw/inc/unoprnms.hxx sw/source/core/access/accpara.cxx sw/source/core/attr/format.cxx sw/source/core/attr/swatrset.cxx sw/source/core/doc/docdraw.cxx sw/source/core/doc/docfly.cxx sw/source/core/doc/notxtfrm.cxx sw/source/core/inc/frame.hxx sw/source/core/inc/frmtool.hxx sw/source/core/layout/atrfrm.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/text/inftxt.cxx sw/source/core/text/porfld.cxx sw/source/core/text/txtfly.cxx sw/source/core/txtnode/fntcache.cxx sw/source/core/uibase/app/docst.cxx sw/source/core/uibase/app/docstyle.cxx sw/source/core/uibase/shells/drawdlg.cxx sw/source/core/uibase/shells/frmsh.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unomap.cxx sw/source/core/unocore/unoprnms.cxx sw/source/core/unocore/unostyle.cxx sw/source/ui/fmtui/tmpdlg.cxx sw/source/ui/fmtui/tmpdlg.src sw/source/ui/frmdlg/frmdlg.cxx sw/source/ui/frmdlg/frmpage.src sw/source/ui/inc/frmsh.hxx xmloff/source/text/txtprhdl.cxx xmloff/source/text/txtprmap.cxx Change-Id: Id3ffaa83bb5594d287f1ac8f2c1c9cf55c70946d
2014-03-28Avoid possible resource leaks by boost::scoped_arrayTakeshi Abe
Change-Id: Ie20fc857f19f74aaccb546f9bfa11a7a657d3e8a
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-24editeng: clean up unneeded bForceCursorMiklos Vajna
Change-Id: Idb12f1c388e14dc833fd7d153c4099639f11ea11
2014-03-22coverity#736772 Dereference before null checkCaolán McNamara
Change-Id: Idf973cb888c7ac7a3e33aa2fdec0e25515b1feca
2014-03-19convert OUString::match to OUString::endsWithNoel Grandin
Convert code like: rTxt.match( "---", rTxt.getLength()-3 ) to: rTxt.endsWith( "---" ) Change-Id: Iada74c5e714f7234f25b326526843a36255d5599
2014-03-19Add dash-dot and dash-dot-dot line styles.Kohei Yoshida
We need these for Excel interop. Change-Id: I91450c1d205f28636edfb4392aa6ae5091b1d7b7
2014-03-18Disable unit tests which use library objects from libmerged on Windows.Matúš Kukan
For some reason on Windows the linking fails with 'one or more multiply defined symbols found' error. Change-Id: If2af0822a837665e8f0a31d04cd42bf4d1f054f0
2014-03-17Make this non-inline.Kohei Yoshida
Change-Id: I2002f7278b63b7678a5274e4213ab9dfb50e525e
2014-03-17codemaker,editeng: prefer passing OUString by referenceNoel Grandin
Change-Id: If3e2dd3905cc33f1e7fc9fbfbb9f2bb49a756a34
2014-03-15fdo#63154 Remove some solar.h referencesAlexandre Vicenzi
Remove some solar.h from tools. Replace sal_uLong by size_t, sal_uInt32 and sal_Int32. Change-Id: I38961db046337a3ea4ef75d64afa424d81391f34 Reviewed-on: https://gerrit.libreoffice.org/8582 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-14fdo#68779: RTF import: set borders without explicit widthMichael Stahl
Word reportedly uses 0.75pt as a default if \brdrw is missing. Change-Id: I263c56f756c65ff6bb30870aa70806564d5826a6
2014-03-11oox export: associate editeng CharInteropGrabBag with sw via SIDTomaž Vajngerl
Change-Id: If25356aa88f435e53b6014773e23d18723507053
2014-03-11editeng: sal_Bool->boolNoel Grandin
Change-Id: I7a7b5e9ae1762cace1f87b379b32398b231745fd
2014-03-10editeng: register GrabBag as a Char attributeTomaž Vajngerl
and hopefully this fixes the tests.. Change-Id: Ib736ee1c0bfcebb2515009ddad7e3c76cb58a095
2014-03-10editeng: simplify deprecated XTypeProvider.getImplementationIdStephan Bergmann
Change-Id: I4135695eccb486e5df180f98a247755ba85a9454
2014-03-10editeng: Add CharInteropGrabBag to editeng.Tomaž Vajngerl
Change-Id: I91c816499f463febc536d79e4a9fd9804f74df00
2014-03-10RTF writing now uses SfxStyleSheetIterator to iterate over style sheetsTobias Lippert
Change-Id: I9d5e86eecf1849d8ae7f9e7052c434844e27ddfd Reviewed-on: https://gerrit.libreoffice.org/8481 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-07coverity#735418 Logically dead codeCaolán McNamara
Change-Id: Iad5d984cd923758daee8d5d6d76694586a34b9e0
2014-03-07coverity#982456 Dereference after null checkCaolán McNamara
Change-Id: I7222d394c47b73b8a84cd069fed3eb268090a70b
2014-03-06coverity#1190356 Dereference null return valueCaolán McNamara
Change-Id: I9a857423cd190b2da9f535e8897a9c9baba40b73
2014-03-05Simplify DrawWaveKeith Curtis
This patch simplifies the DrawWave logic. Callers of that code would try to figure out what size wave to draw and pass down a style integer to DrawWaveLine, but DrawWaveLine already has logic which trims the height of the wave so it doesn't need the hint. This doesn't change the UNO API (::com::sun::star::awt::FontUnderline::SMALLWAVE), but it does get rid of internal usages and maps those small waves to normal. Note that changing the zoom in Calc right now causes spelling underlines to disappear. That bug is not related to these changes. Conflicts: editeng/source/editeng/impedit3.cxx Change-Id: I3caa2a74a0f5228b924d4e1b0a77f96eaef5fa00 Reviewed-on: https://gerrit.libreoffice.org/8168 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-03-05made ListBox handle more than 64k elements, fdo#61520 relatedEike Rathke
ListBox and related now handle up to sal_Int32 elements correctly. sal_Int32 instead of sal_Size or size_t because of UNO and a11y API. Also disentangled some of the mess of SvTreeList and other containers regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures. Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a Reviewed-on: https://gerrit.libreoffice.org/8460 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05remove unused code SvxNumRule::Create(SvStream&)Noel Grandin
Change-Id: I82205010e613a07df24f22071eec74f53578671d
2014-03-05remove unused code SvxNumberFormat::Create(SvStream&)Noel Grandin
Change-Id: If8cfea11552bf008ab4381ecec50aadf58a98a45
2014-03-05remove unused code accessibility::AccessibleParaManager::Release(int)Noel Grandin
Change-Id: I1f3bbd1baf16c27fb5c01055295ccabb3d6eb3d7
2014-03-05remove unused code editeng::MisspellRange::MisspellRange()Noel Grandin
Change-Id: Id137b4789652ca54290106a33d2c230723834a52
2014-03-05remove unused code editeng::Section::Section()Noel Grandin
Change-Id: I1201ebf5f97f95690835d343be8d1b6f5382dbe6
2014-03-04fdo#75260: Correctly draw double lines for both Writer and Calc.Kohei Yoshida
Fix all sorts of incorrect double line handling in drawinglayer in order to draw thick-thin double line types correctly. Also change handling of border lines in writer tables. There are still some outstanding issues but it's much better than how it was before. Also realized that Word and Excel handle simple thin double lines differently; Word varies widths of all of the lines and the gap whereas Excel only has one fixed size for its double line. For this reason I decided to add a separate double line type (DOUBLE_THIN) to handle Excel's double line. Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4
2014-03-04fdo#54938: Convert some places to use cppu::supportsServiceMarcos Paulo de Souza
The last cases are non obvious, so it's pratically done Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547 Reviewed-on: https://gerrit.libreoffice.org/8445 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-03editeng: sal_Bool->boolNoel Grandin
Change-Id: I51b4ae54c2c440d38879439f74d4fea39d243004
2014-03-03editeng: sal_Bool->boolNoel Grandin
Change-Id: Icfda5e8e774b9b5a6c3d99b636e4ce772b93139d
2014-03-03editeng: sal_Bool->boolNoel Grandin
Change-Id: I767aa3d25f6d18e8a6e23b4d3f8d038d581ac292
2014-03-03editeng: sal_Bool->boolNoel Grandin
Change-Id: I4fc276e320294d57eb667b6db8e5eff078bc28b3
2014-03-03editeng: sal_Bool->boolNoel Grandin
Change-Id: I26b1fe14023737b85bcf23628e4881c8be79f071
2014-03-03editeng: sal_Bool->boolNoel Grandin
Change-Id: I0aa375d35c796cfa1929f9c0e735eaaa05561ee4
2014-03-03editeng: sal_Bool->boolNoel Grandin
this had to be done in conjunction with changing include/svx/unoshtxt.hxx because there are two virtual methods "bool IsValid" in two different base classes and some subclasses are overriding both base-class methods at once. Change-Id: Ib43fc5000b443057caaa513b4efeaa6fd16e4260
2014-03-02WaE sign/unsigned compNorbert Thiebaud
Change-Id: I12cb5aa89caa3670101f4632701e33851885c1db
2014-03-02Fix editeng missing spellchecking redline on loadNorbert Thiebaud
Change-Id: I16bfbff85978702c93932d723180a7f9166bd39e
generated by cgit (git 2.34.1) at 2024-07-11 16:17:44 +0000